Commit graph

43125 commits

Author SHA1 Message Date
Paul Berry dea023d345 Upgrade "path" package to 1.4.1 and eliminate analyzer test workaround.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569043002 .
2016-12-12 14:08:59 -08:00
John McCutchan 8b6f610206 Fix hot reload test mode in simdbc by supporting forced slow paths on simdbc
- [x] Add new SIM DBC byte code: CheckStackAlwaysExit.
- [x] Emit CheckStackAlwaysExit instead of CheckStack when requested.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2569013002 .
2016-12-12 14:07:22 -08:00
Brian Wilkerson 223513c81a Fix bug when packages file changes in new driver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2570623002 .
2016-12-12 14:03:00 -08:00
Florian Schneider 1ca079a472 Reduce flakiness of http_client_stays_alive_test.
Give it more time before failing.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566263002 .
2016-12-12 13:50:33 -08:00
Ryan Macnak 6051488ad9 Cleanup dead compiler and runtime aliases from the test framework.
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2570633002 .
2016-12-12 13:42:35 -08:00
Konstantin Shcheglov a5b2e62bda Fix for completion after the closing quote in a directive.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2572513003 .
2016-12-12 13:38:38 -08:00
Ben Konyi 0d16859d87 Updated SimpleManyTasksWithZones test to not use PrintJSONForVM
Fixed test to not use PrintJSONForVM to get isolate information since it only returns @Isolates. Also removed some unnecessary comments and checks for isolate ids.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2567153002 .
2016-12-12 13:35:43 -08:00
Konstantin Shcheglov c4ed99acc9 Support for overlay only files in Analysis Server with the new driver.
Do we need this at all?

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2571593002 .
2016-12-12 13:16:04 -08:00
Zachary Anderson b873e2b8e3 Revert "Make list_files.py and list_dart_files.py return absolute paths"
This reverts commit a858542c89.

mac gyp build fails.

Review-Url: https://codereview.chromium.org/2574523002 .
2016-12-12 13:14:53 -08:00
Zachary Anderson a858542c89 Make list_files.py and list_dart_files.py return absolute paths
This makes doing an SDK build in the Fuchsia tree easier

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2564413004 .
2016-12-12 13:09:26 -08:00
John McCutchan cd116d861b Fix service tests
BUG=

Review-Url: https://codereview.chromium.org/2568963002 .
2016-12-12 12:43:01 -08:00
Konstantin Shcheglov d564b0aaab Send errors notification without delay.
Update 'analysis.updateContent' integration test.

This might be OK from performance POV - errors are cheaper to send than
for example navigation. And this satisfies the goal of 'analyzing'
notification - that new errors are to be expected.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2567113003 .
2016-12-12 11:39:47 -08:00
Ben Konyi fa25fdd72d Fixed tests breaking build.
Merge branch 'master' of github.com:dart-lang/sdk into fix

Updated format string to reflect actual type.

BUG=

Review-Url: https://codereview.chromium.org/2562243003 .
2016-12-12 11:36:55 -08:00
Paul Berry 3a24020c23 Fix test of incorrect SDK path.
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2568253002 .
2016-12-12 11:30:57 -08:00
Ben Konyi 21192e0227 Updated format string to reflect actual type.
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2566283002 .
2016-12-12 11:13:22 -08:00
Paul Berry 0c81fbc411 Fix "unused import" warnings and sort declarations.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2562643006 .
2016-12-12 11:02:22 -08:00
Paul Berry d70184abd8 Create a default error handler to avoid the need for null checks.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2568583002 .
2016-12-12 10:54:38 -08:00
Konstantin Shcheglov f43db9ccfa Update the integration test to make the file with subscription a priority one.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566243002 .
2016-12-12 10:51:13 -08:00
Ben Konyi 69be515447 Fixed build issue introduced with last commit.
BUG=
R=johnmccutchan@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2573483004 .
2016-12-12 10:32:01 -08:00
Paul Berry 02fe40c6f7 Simplify how patch files are specified to analyzer.
After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like.  This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.

Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.

Note that we no longer include the patch configuration in
encodeCrossContextOptions.  This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2560323002 .
2016-12-12 10:15:18 -08:00
Ben Konyi d217b21ca6 Added conversion from thread id to intptr that fixes breaking build.
BUG=
R=johnmccutchan@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2570583002 .
2016-12-12 10:13:44 -08:00
Konstantin Shcheglov 2a7612f103 Implement 'analysis.occurrences' for the new analysis driver.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566223002 .
2016-12-12 10:07:19 -08:00
Ben Konyi 35a49bc1ff Created methods to surface zone memory information for each isolate and thread in JSON.
BUG=
R=asiva@google.com, johnmccutchan@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2554983002 .
2016-12-12 09:56:49 -08:00
Paul Berry fb2dbfce21 Fix analyzer's SDK detection so that during integration tests, we use the built SDK.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2568743003 .
2016-12-12 09:49:50 -08:00
Konstantin Shcheglov a7222ac09d Implement 'analysis.outline' for the new analysis driver.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2571513002 .
2016-12-12 09:09:45 -08:00
Brian Wilkerson a2713a8be5 Disable a test that times out on the bots
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2568183002 .
2016-12-12 08:51:11 -08:00
Konstantin Shcheglov 1e59cc0b9f Remove making added files as changed.
This is not done (in a way) during removing files.
We just forget everything about all files.

So, we don't need an additional complication here.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566913002 .
2016-12-12 08:36:40 -08:00
Florian Loitsch cc2eba8c2a Implement FutureOr<T> for dart2js.
In dart2js, FutureOr<T> should simply be treated as `dynamic`.

Fixes #28011
BUG= http://dartbug.com/28011
R=johnniwinther@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2559523006 .
2016-12-12 15:21:03 +01:00
Florian Loitsch 0c3deba6df Add tests for FutureOr<T>.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2564563003 .
2016-12-12 14:54:57 +01:00
Florian Loitsch 6a966d2914 Add FutureOr<T> class to dart:async.
`FutureOr<T>` is a magical class, but having a concrete implementation
makes it easier for many tools (like dartdoc, code navigation, ...) to
deal with it.

Fixes #28029
BUG= http://dartbug.com/28029
R=lrn@google.com

Review URL: https://codereview.chromium.org/2562703002 .
2016-12-12 14:05:48 +01:00
Johnni Winther e00732643f Remove CodegenEnqueuer.compiler
R=het@google.com

Review-Url: https://codereview.chromium.org/2564823002 .
2016-12-12 10:59:48 +01:00
Johnni Winther 7953afaee6 Remove Compiler.inferenceWorld
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2559373004 .
2016-12-12 10:48:18 +01:00
Johnni Winther 415ba7948c Reduce use of Compiler.closedWorld
- in preparation for passing ClosedWorld directly between phases.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2563443007 .
2016-12-12 10:35:23 +01:00
Brian Wilkerson 756cfc963d Fix warnings
Review-Url: https://codereview.chromium.org/2564323002 .
2016-12-11 16:53:13 -08:00
Brian Wilkerson b7f1a96ae5 Change the way tasks are registered
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2566893002 .
2016-12-11 15:59:46 -08:00
Konstantin Shcheglov 0728e4ee70 Implement 'analysis.getErrors' for the new driver.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566013002 .
2016-12-11 15:27:57 -08:00
Konstantin Shcheglov 80e30c4c4e Implement 'analysis.getNavigation' for the new analysis driver.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566883002 .
2016-12-11 15:23:03 -08:00
Konstantin Shcheglov 662ba0908f When a file is removed from the driver, reschedule full analysis.
Removing files happens rarely, so it should be OK to keep it simple
and just reset the file state and let analysis to happen from scratch.

It look in profiler that the most expensive operation is recomputing
content hash (16%) and unlinked bundle key hash (14%). Reading content
itself is somewhat expensive (11%) on SSD. Might be higher on NFS.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566003002 .
2016-12-11 11:38:09 -08:00
Brian Wilkerson 718a17db85 Revert "Change the way tasks are registered" (TBD)
Review-Url: https://codereview.chromium.org/2564303002 .
2016-12-11 11:32:12 -08:00
Brian Wilkerson 84577c55bb Change the way tasks are registered
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2568723002 .
2016-12-11 11:25:40 -08:00
Brian Wilkerson 86c62a6bad Remove the command-line plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2565993002 .
2016-12-11 10:59:19 -08:00
Konstantin Shcheglov 4fa3413596 Renames and comment tweaks for files.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2569623002 .
2016-12-11 10:11:07 -08:00
Brian Wilkerson 9f308faa71 Add file missed in last commit (TBR)
Review-Url: https://codereview.chromium.org/2562223002 .
2016-12-11 08:42:40 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
2016-12-11 08:38:29 -08:00
Brian Wilkerson ebf5fbcd0e Remove references to the linter plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2567863002 .
2016-12-10 10:00:20 -08:00
Konstantin Shcheglov 9fcaf42df4 Remove filtering by known files in search.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2562173002 .
2016-12-10 09:43:28 -08:00
Brian Wilkerson c6c8259ca4 Add an alternate mechanism for registering default lints
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2568463004 .
2016-12-10 09:22:09 -08:00
Konstantin Shcheglov c3d404a23c addFile() must refresh the file.
This covers for example the 'git revert' case.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2569553002 .
2016-12-10 09:08:12 -08:00
Konstantin Shcheglov 42aa2a6d25 Fix race condition with 'knownFiles'.
A temporary solution for now, not the most efficient.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2550093011 .
2016-12-09 22:49:32 -08:00
Zachary Anderson a0f4b3616c Mark io/socket_test Pass, Timeout on macos.
related #27453

Review-Url: https://codereview.chromium.org/2565133002 .
2016-12-09 22:27:48 -08:00