languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:45:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
48217 commits 11 branches 6011 tags 1.4 GiB
Commit graph

48217 commits

This branch
This branch
All branches
Author SHA1 Message Date
Brian Wilkerson 3c1c22a3a1 Add a quick fix for missing new (issue 30077) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2965063002 .
 2017-07-05 10:59:34 -07:00
Konstantin Shcheglov 7ea7324747 Remove CompilationUnitElement.getElementAt(). 
It is not used by any package we use internally.
It was added for search, but is not used anymore.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2967203002 .
 2017-07-05 10:52:02 -07:00
Konstantin Shcheglov cfbf85c340 Remove unused PubVerifier. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2973683002 .
 2017-07-05 10:33:21 -07:00
Konstantin Shcheglov e93566189f Fix for types of function-typed parameters in reified type of MethodElement. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2965053002 .
 2017-07-05 10:32:31 -07:00
Vijay Menon 7b766556a1 Update test status 
See #30075

TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2967193002 .
 2017-07-05 10:16:25 -07:00
Konstantin Shcheglov cf66612116 Change UnusedLocalElementsVerifier to AST visitor. 
We are moving to excluding local elements from the element model,
so we cannot use element visitor to visit and report local elements.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2967183002 .
 2017-07-05 10:12:05 -07:00
Ryan Macnak 6eacc4b7f8 [gen_snapshot] Escape spaces when generating depfiles. 
Fixes https://github.com/dart-lang/sdk/issues/30059

R=jakobr@google.com

Review-Url: https://codereview.chromium.org/2966903003 .
 2017-07-05 10:00:18 -07:00
Bob Nystrom 1bd907dc2e Run dartdevc tests on drt instead of Chrome on the bots. 
Also, do another triage pass on the tests.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2964043004 .
 2017-07-05 09:45:16 -07:00
Ryan Macnak daa38a2ea2 [profiler, linux/android] Check whether a sample is ARM or Thumb code to decide which FP register to load. 
Android and Linux use R11 as the FP register in ARM code and R7 in Thumb code. We've been assuming all code in our process is ARM and reading R11 as FP. This made our stack walks fail if they started in Thumb code.

This issue does not arise on iOS, because its ABI uses R7 as the FP register for both ARM and Thumb code.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2965823002 .
 2017-07-05 09:43:12 -07:00
Konstantin Shcheglov ec621a67c1 Remove HintGenerator. 
It is not used neither by tasks, nor by the driver.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2971843002 .
 2017-07-05 09:38:25 -07:00
Vijay Menon 9cbd5bdc2e Output errors for tests that fail to compile 
This makes it easier to fix strong mode errors in tests.

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2971443002 .
 2017-07-05 09:37:14 -07:00
Brian Wilkerson 62f43f663b Fix a bug in inline method refactoring 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2973673002 .
 2017-07-05 09:35:48 -07:00
Brian Wilkerson 895f898b9b Make analyzer respect exclusions from the analysis options file 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2967883002 .
 2017-07-05 07:52:48 -07:00
Erik Ernst c2afa4146b Updated various gardening data, and ignoring gardening/temp. 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2973653002 .
 2017-07-05 16:20:40 +02:00
Florian Loitsch 304665a5b8 Fix status file line. 
Review-Url: https://codereview.chromium.org/2970073002 .
 2017-07-05 16:04:00 +02:00
Peter von der Ahé f1f884011f Improve warnings related to incorrect 'part of' declarations. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2967143002 .
 2017-07-05 15:22:57 +02:00
Paul Berry 6c769b39c9 Fix inference test expectations for generic function types. 
The analyzer-based test code was incorrectly using typeArguments when
it should have been using typeFormals.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2965023002 .
 2017-07-05 06:13:30 -07:00
Peter von der Ahé 5999f45148 Implement type variables on old style function-typed formal parameters. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2969053002 .
 2017-07-05 14:54:21 +02:00
William Hesse cd8fc9aa6b Add commit queue status links to Gerrit CLs 
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=735039
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2965003002 .
 2017-07-05 13:15:20 +02:00
Peter von der Ahé 6bb89e4fbf Use type variables on Typedef correctly. 
R=johnniwinther@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2967923002 .
 2017-07-05 13:12:27 +02:00
Brian Wilkerson a3406c38e2 Update server version after adding experimental API 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2972673002 .
 2017-07-04 16:14:57 -07:00
Florian Loitsch 89365d4d9a Mark max-device-aspect-ratio_t01 as flaky. 
Review-Url: https://codereview.chromium.org/2972663002 .
 2017-07-04 16:12:15 +02:00
Peter von der Ahé fdd1073173 Add names to nested declaration to ease debugging. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2967903003 .
 2017-07-04 15:33:40 +02:00
Peter von der Ahé 3fe6e76939 Implement toString on ModifierBuilder. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2972543003 .
 2017-07-04 15:32:21 +02:00
Peter von der Ahé 83eede8ad4 Import message codes by prefix. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2964933002 .
 2017-07-04 13:37:04 +02:00
Peter von der Ahé 3fd7bd1bdc Implement type variables on generalized function types. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2964013002 .
 2017-07-04 13:29:23 +02:00
Florian Loitsch 97a458adf7 Update status files. 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2972613003 .
 2017-07-04 12:54:36 +02:00
Florian Loitsch 3df3725f27 Mark type_object tests as co19 issues. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2964913002 .
 2017-07-04 12:14:18 +02:00
Florian Loitsch 6a9337ee82 Mark mouseOverEvent test as flaky. 
Review-Url: https://codereview.chromium.org/2970813002 .
 2017-07-04 10:09:58 +02:00
Jens Johansen e20fd66f93 [kernel] Fix skipping library typedefs. 
Fixes #30064.

BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2973483002 .
 2017-07-04 10:02:10 +02:00
William Hesse b6d67828b3 Remove both rietveld config and review_lgtm setting from cq config 
BUG=735039
R=agable@chromium.org, tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2970543002 .
 2017-07-03 22:24:26 +02:00
Brian Wilkerson 6a7b9f441b Convert DartChangeBuilder to use AnalysisSession 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2969833002 .
 2017-07-03 08:41:40 -07:00
Brian Wilkerson 2f28f5713c Fix a test so that it passes 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968883002 .
 2017-07-03 08:39:31 -07:00
Vyacheslav Egorov f167ad18da test.py: temporarily disable background optimizer in vm-dartk-debug config. 
It is causing flakiness on bots.

Unmark tests marked as flaky by 45e4d848d2

See https://github.com/dart-lang/sdk/issues/30016.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2970733002 .
 2017-07-03 17:05:12 +02:00
Peter von der Ahé e3939aa96c Fix status file expression. 
Review-Url: https://codereview.chromium.org/2969843003 .
 2017-07-03 15:43:01 +02:00
Peter von der Ahé 45e4d848d2 [gardening] Update status files for kernel debug mode. 
Review-Url: https://codereview.chromium.org/2969883002 .
 2017-07-03 15:37:16 +02:00
Lasse R.H. Nielsen 03491d6ed7 Don't use file-based part-of when part files are shared. 
Review-Url: https://codereview.chromium.org/2967833002 .
 2017-07-03 13:48:21 +02:00
Johnni Winther 8ce912063e Split implementation of KernelToElementMapImpl 
- to enable testing of pure implementations of the frontend/backend KernelToElementMap interfaces

This introduces Indexed* entities to enable sharing envs/data between K and J elements.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2964683003 .
 2017-07-03 10:06:33 +02:00
Lasse R.H. Nielsen 62bc61b367 Use relative URIs for core library part-of statements. 
Reapply "Change some platform libraries to use `part of URI`."
Change to used relative URIs in the part-of declarations.

R=brianwilkerson@google.com, floitsch@google.com

Review-Url: https://codereview.chromium.org/2911903002 .
 2017-07-03 10:04:06 +02:00
Johnni Winther 3433c71c2e Add equivalence testing on JS nodes to support different label names 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2963193003 .
 2017-07-03 10:00:31 +02:00
Erik Corry 1ef0ec401a VM-codegen: Restrict widening class ranges in method dispatch 
We widen the range of class-ids that we dispatch to if the
neighbouring classes dispatch to the same methods.  With this
change we don't widen the range to encompass abstract classes
unless we also catch more concrete classes in that way.

This improves the Megamorhphic benchmark suite scores by about
10% on average.

This is split off from https://codereview.chromium.org/2955073005/

R=vegorov@google.com
BUG=

Review-Url: https://codereview.chromium.org/2962333002 .
 2017-07-03 09:27:08 +02:00
Erik Corry 955a4b6e71 VM: Reland Inline instance object hash code into object header on 64bit. 
Inline instance object hash code into object header on 64 bit.

64 bit objects have 32 bits of free space in the header word.
This is used for the hash code in string objects. We take it
for the default hash code on all objects that don't override
the hashCode getter.

This is both faster and a memory reduction. Eg it makes the
MegaHashCode part of the Megamorphic benchmark 6 times faster.

This is a reland of https://codereview.chromium.org/2954453002/
which fixes an issue that made script snapshots generated on
64 bit platforms incompatible with 32 bit VMs.

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2965723002 .
 2017-07-03 09:26:46 +02:00
Jens Johansen 6873d96db3 [kernel] Update status file 
Removed no-longer-current status-file entry.

See issue #28790.

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2962303002 .
 2017-07-03 08:17:17 +02:00
Brian Wilkerson 0ee29eadf1 Run the generator after updates to spec 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972473002 .
 2017-07-02 07:49:05 -07:00
Brian Wilkerson 8c8a177f3c Fix failing test (TBR) 
Review-Url: https://codereview.chromium.org/2964343002 .
 2017-07-01 12:55:17 -07:00
Brian Wilkerson f6a2fb0050 Clean up AstProvider hierarchy 
Review-Url: https://codereview.chromium.org/2969793002 .
 2017-07-01 12:06:33 -07:00
Brian Wilkerson aadafd1bd5 Use DartEditBuilder to write types and remove dead code 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972463003 .
 2017-07-01 12:03:44 -07:00
Brian Wilkerson d31ed8690e Capture imports on copy; update imports on paste 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939593002 .
 2017-07-01 12:02:30 -07:00
Emily Fortuna b6671a0e3f Revert "Added for-loop variable tracking and regular closures/initializers captured variable tracking." 
I think I had a bad merge. Reverting to figure out the issue.

This reverts commit d40f84fbf8.

BUG=

Review-Url: https://codereview.chromium.org/2964113004 .
 2017-07-01 07:33:53 -07:00
Emily Fortuna d40f84fbf8 Added for-loop variable tracking and regular closures/initializers captured variable tracking. 
This whole thing is hanging together by a thread. A BUNCH of tests and more implementation coming next once the KernelClosureClass is truly functional.

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2961253005 .
 2017-07-01 07:12:37 -07:00