languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:49:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make analyzer respect exclusions from the analysis options file

Browse source 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2967883002 .
This commit is contained in:
Brian Wilkerson 2017-07-05 07:52:47 -07:00
parent c2afa4146b
commit 895f898b9b
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
pkg/analyzer_cli/lib/src/driver.dart
View file

@ -211,7 +211,8 @@ class Driver implements CommandLineStarter {
// Note that these files will all be analyzed in the same context.
// This should be updated when the ContextManager re-work is complete
// (See: https://github.com/dart-lang/sdk/issues/24133)
Iterable<io.File> files = _collectFiles(sourcePath);
Iterable<io.File> files =
_collectFiles(sourcePath, context.analysisOptions);
if (files.isEmpty) {
errorSink.writeln('No dart files found at: $sourcePath');
io.exitCode = ErrorSeverity.ERROR.ordinal;
@ -446,11 +447,24 @@ class Driver implements CommandLineStarter {
/// Collect all analyzable files at [filePath], recursively if it's a
/// directory, ignoring links.
Iterable<io.File> _collectFiles(String filePath) {
// TODO(devoncarew): This needs to respect analysis_options excludes.
Iterable<io.File> _collectFiles(String filePath, AnalysisOptions options) {
List<String> excludedPaths = options.excludePatterns;
/**
* Returns `true` if the given [path] is excluded by [excludedPaths].
*/
bool _isExcluded(String path) {
return excludedPaths.any((excludedPath) {
if (resourceProvider.absolutePathContext.isWithin(excludedPath, path)) {
return true;
}
return path == excludedPath;
});
}
List<io.File> files = <io.File>[];
io.File file = new io.File(filePath);
if (file.existsSync()) {
if (file.existsSync() && !_isExcluded(filePath)) {
files.add(file);
} else {
io.Directory directory = new io.Directory(filePath);
@ -459,6 +473,7 @@ class Driver implements CommandLineStarter {
in directory.listSync(recursive: true, followLinks: false)) {
String relative = path.relative(entry.path, from: directory.path);
if (AnalysisEngine.isDartFileName(entry.path) &&
!_isExcluded(relative) &&
!_isInHiddenDir(relative)) {
files.add(entry);
}