languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 20:29:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
36340 commits 11 branches 6011 tags 1.4 GiB
Commit graph

36340 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Berry cd94acd7e2 Clear up confusion between type arguments and type parameters in summary tests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1688683003 .
 2016-02-10 14:14:10 -08:00
Paul Berry 9edfb4ad1a Refactor one more use of serializeUnlinkedReference 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1687963003 .
 2016-02-10 14:12:20 -08:00
Paul Berry b18cdd3f77 Ensure that element handles never refer to Member objects. 
This is necessary in order for "is" checks (e.g. `element is
ConstructorMember`) to function properly in the presence of element
handles.

To make this possible, it was necessary to lazify the `type` getter in
ExecutableMember, so that attempting to wrap an element handle inside
an ExecutableMember doesn't force the actual element to be
resynthesized.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1686283002 .
 2016-02-10 14:11:13 -08:00
Todd Turnidge 0de97fbaba Trace compilation during developer_extension_test. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1684283002 .
 2016-02-10 13:46:59 -08:00
Paul Berry 6b492b06a4 Test references from resynthesized const ASTs to ConstructorMembers. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1686253002 .
 2016-02-10 13:29:47 -08:00
Todd Turnidge d3397f64c1 Add debugging output to full_coverage_test to help diagnose timeouts. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1688933002 .
 2016-02-10 13:23:51 -08:00
John McCutchan d78ebae9af "fix" standalone/io/sleep_test.dart on Windows 
BUG=

Review URL: https://codereview.chromium.org/1682873004 .
 2016-02-10 13:03:50 -08:00
Konstantin Shcheglov e71080901f Remove only local variables/functions from the cache. 
This is a temporary measure to restore incremental resolution in most
cases. In the future we should avoid putting constant variables into
cache at all and enforce this on the cache.put() level.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1682333003 .
 2016-02-10 12:58:30 -08:00
Paul Berry 1f4d5390b9 Fix summarization of generic redirecting constructors (again). 
In the previous fix (4b5d30abba) I
neglected to account for the fact that
ConstructorElement.redirectedConstructor is sometimes a
ConstructorMember, not a ConstructorElementImpl.

Fixing this required properly storing the redirected constructor's
type arguments in the summary.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1683813005 .
 2016-02-10 12:55:10 -08:00
Srdjan Mitrovic d26980f6fc Pass field to mutator thread so that it can be marked as boxed and all dependent code deoptimized (background compilation only). 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1685963002 .
 2016-02-10 12:33:47 -08:00
Alan Knight 90b6ffece5 Add issue number for Dartium 45 suppressions 
BUG=

Review URL: https://codereview.chromium.org/1691553002 .
 2016-02-10 12:13:04 -08:00
Konstantin Shcheglov da0a022962 Incrementally update incompletely resolved units. 
When the context A uses unit U from the context B, we don't resolve U
in A to RESOLVED_UNIT, we usually stop somewhere before. But we still
want to update U in A incrementally. We don't put RESOLVED_UNITx
results into cache, so we don't write a less resolved unit as a more
resolved result.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1680403003 .
 2016-02-10 11:35:00 -08:00
Alan Knight 1fe4654d6b Suppressions for Dartium 45 roll 
BUG=

Review URL: https://codereview.chromium.org/1688883002 .
 2016-02-10 11:31:40 -08:00
Todd Turnidge be3acab294 Use Stopwatch instead of DateTime to measure elapsed time in tests. 
Improve timer_repeat_test.dart to not totally punt on testing the timing.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1683233003 .
 2016-02-10 11:21:40 -08:00
Siva Annamalai e4813b0e0a Fix for issue 27094147 (Null pointer deref in IsScriptSnapshot). 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1683243002 .
 2016-02-10 11:08:31 -08:00
Regis Crelier 21cad16fac A type should be a subtype of Function if its class declares a call function, 
even if call is abstract (fixes #25550).
Add regression test.

R=hausner@google.com

Review URL: https://codereview.chromium.org/1683113003 .
 2016-02-10 10:54:00 -08:00
Brian Wilkerson bcaedf2b7f The exception occurs because the type can be set to null if the element is either a parameter or local variable element. This might be a change since the time this code was originally written. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1688493002 .
 2016-02-10 10:49:47 -08:00
John McCutchan a5390e8588 Sleep for more than 1 millisecond in timeline tests 
This is an attempt to fix flaky Windows timeline tests.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1687043003 .
 2016-02-10 10:20:53 -08:00
Todd Turnidge f501f9d8f2 Add timestamps to --trace-service output to help debug test timeouts. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1673383004 .
 2016-02-10 09:54:47 -08:00
Vyacheslav Egorov 03d2a819e4 Make --abort_on_assertion_errors more selective. 
Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=http://dartbug.com/25753
R=srdjan@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/1691443002 .
 2016-02-10 18:49:10 +01:00
danrubel 3fc06a4aa7 abort completion request - fixes #24271 
This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.

In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1685653002 .
 2016-02-10 12:45:53 -05:00
Alan Knight 4feb92938b Fix status file for Dartium tests which pass in Chrome 45 
BUG=

Review URL: https://codereview.chromium.org/1687063002 .
 2016-02-10 09:41:13 -08:00
Paul Berry 8d130d1e09 Consolidate strings in summary output. 
This reduces the size of the SDK summary by about 15.5%.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1687053002 .
 2016-02-10 09:25:43 -08:00
Brian Wilkerson ec04f012f7 Move Token into the public API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1690523002 .
 2016-02-10 09:12:26 -08:00
Paul Berry f2fa7e85e5 Create a tool for collecting statistics about summary files. 
In addition to exploring how the summary format is used, it should be a
nice micro-benchmark for FlatBuffer deserialization efficiency.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1686753005 .
 2016-02-10 09:03:11 -08:00
John McCutchan b9b0649b9c dart:developer service extension fixes 
Fixes #25724
Fixes Florian Loitsch's emailed request (get rid of k prefix on constants).

- Rename ServiceExtensionResponse constants to not have a 'k' prefix.
- Provide more explanation on how to invoke service extensions (they require an 'isolateId' parameter).
- Require extension method names to begin with "ext." and recommend the template: "ext.package.command" to avoid conflicts with other packages.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1680593004 .
 2016-02-10 08:54:51 -08:00
Konstantin Shcheglov 6be32fee2d Fix for recording 'null' as a defined element. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1681493005 .
 2016-02-10 08:50:10 -08:00
John McCutchan 9b2de983e6 Fix compiler error encountered by Flutter 
../../dart/runtime/vm/compiler.cc: In member function 'bool dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*)':
../../dart/runtime/vm/compiler.cc:577:8: error: variable 'done' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
  bool done = false;
       ^
cc1plus: all warnings being treated as errors
[2/10/16, 8:41 AM] Ian Hickson (ianh@google.com): building android debug

Review URL: https://codereview.chromium.org/1682223005 .
 2016-02-10 08:49:36 -08:00
Paul Berry 9717305de4 Remove irrelevant TODOs from summary code. 
Also remove the annotation `private` from idl.dart (it was never used).

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1687793003 .
 2016-02-10 08:34:05 -08:00
Paul Berry 4b5d30abba Fix summarization of generic redirecting constructors. 
This should allow the SDK to be summarized again.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1687513003 .
 2016-02-10 08:31:54 -08:00
Florian Schneider 29b6c0b5d7 VM: Remove dead code from flow graph optimizer. 
BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1682803005 .
 2016-02-10 16:24:59 +01:00
Kevin Millikin 35839c7840 Dart2js CPS: Implement 'await for'. 
The implementation strategy is in terms of a loop over a StreamIterator,
similar to what is done in the dart2js SSA backend and in the Dart VM.

BUG=https://github.com/dart-lang/sdk/issues/24984
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1686973002 .
 2016-02-10 15:28:03 +01:00
William Hesse b42443bd26 Add abort-on-assertion flag to dart2js unit test runner. 
BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1682343003 .
 2016-02-10 13:42:00 +01:00
Asger Feldthaus aeb36c9314 dart2js cps: Set the return type on adapters. 
The return type of an adapter function was not set, preventing
further inlining of methods whose receiver depends on the return value.

CLOSES #25725.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1685643002 .
 2016-02-10 11:47:35 +01:00
Asger Feldthaus b487d020ef dart2js cps: Avoid overlapping status lines. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1688693002 .
 2016-02-10 11:38:22 +01:00
Asger Feldthaus 3f8fdc2434 dart2js cps: Update status files. 
BUG=

Review URL: https://codereview.chromium.org/1686733003 .
 2016-02-10 11:21:11 +01:00
Johnni Winther fcad7b6b5b Introduce getPrefixEndToken to avoid too big context in messages. 
R=ahe@google.com

Review URL: https://codereview.chromium.org/1661853005.
 2016-02-10 09:27:30 +01:00
Konstantin Shcheglov 135be23107 Issue dev_compiler@443. Clone beginToken. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/dev_compiler/issues/443

Review URL: https://codereview.chromium.org/1686653003 .
 2016-02-09 19:24:14 -08:00
Regis Crelier fb2dab5f43 Resolve correct noSuchMethod (fixes #25671, #25737). 
R=hausner@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1684913002 .
 2016-02-09 16:08:09 -08:00
Alan Knight cca5bee27e Update DEPS 
BUG=

Review URL: https://codereview.chromium.org/1680393002 .
 2016-02-09 15:19:45 -08:00
Devon Carew ef95541628 Tweak to the service protocol doc; move the location of an array type indicator. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1684863003 .
 2016-02-09 15:11:26 -08:00
Paul Berry c5b3141564 Deprecate PrefixElement.importedLibraries. 
It has never worked.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1686863002 .
 2016-02-09 14:59:57 -08:00
Paul Berry d3caa1342a Refactor code that populates the references table. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1681353002 .
 2016-02-09 14:45:51 -08:00
John McCutchan 7fc337d6f7 Silence observatory tool again 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/1683903002 .
 2016-02-09 14:17:00 -08:00
Paul Berry e3f246c696 Add support for redirectedConstructor to summaries. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1686713002 .
 2016-02-09 14:07:41 -08:00
Chinmay Garde 63e836ceae Fix the snapshotter to generate valid precompilation snapshots 
R=asiva@google.com

Review URL: https://codereview.chromium.org/1673423004 .
 2016-02-09 13:46:32 -08:00
Siva Annamalai 14417a7851 Add missing Dart_ExitScope calls in some of the VM unit tests. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1683553003 .
 2016-02-09 13:40:10 -08:00
pq 6f29b0ae2d Exclude packages from analyzer source in build. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1685763002 .
 2016-02-09 13:35:25 -08:00
pq 961f8d9f68 Linter DEP bump. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1681343002 .
 2016-02-09 13:34:43 -08:00
Konstantin Shcheglov 85512a85f5 Use spec.sum SDK summary and CONSTANT_EXPRESSION_RESOLVED. 
This lets us pass most of the shared tests even if we enable using
SDK summary.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1684773002 .
 2016-02-09 13:25:25 -08:00