With set literal support enabled, there are many new cases in Flutter hit by this lint.
Change-Id: Ife1e4f9ac5205bdfb74b89ab18a6c36dd9ebcea1
Reviewed-on: https://dart-review.googlesource.com/c/93460
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Once the roll happens flutter team should see the errors and fix it.
Change-Id: I7ab5cfc67a3bb749cfe69ad4075b0c90998c15e9
Reviewed-on: https://dart-review.googlesource.com/c/93420
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
This reverts commit 5d6bab4ed2.
Reason for revert: this change is API incompatible when rolling into mono-repo.
Original change's description:
> Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
>
> Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
> Reviewed-on: https://dart-review.googlesource.com/c/93141
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
TBR=scheglov@google.com,brianwilkerson@google.com
Change-Id: I98d478f56e8aea037cbcc8b6cb940c36edb732fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/93440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Makes it explicit that the functions do not accept `null` as a string.
Change-Id: If60361a678f3a88c2d67423cc1f5cfa8976424e0
Reviewed-on: https://dart-review.googlesource.com/c/93171
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Change-Id: I82416e5b34c0b63dc3106f88c437c488be0ffbbc
Reviewed-on: https://dart-review.googlesource.com/c/93406
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
This change makes named configurations central in test.dart. Previously
test.dart would attempt to emulate the steps taken by a builder. Instead it
now runs a single named configuration as a single step and invokes test.py
directly without any other arguments from the test steps. This better
matches the behavior of test.py and what the developers expect.
Either a named configuration or a builder must be specified. If both are
provided, then the results for that builder is downloaded and used to
compare with when running the named configuration. Otherwise if the only the
named configuration is provided, then it downloads results from all the
builders using the named configuration. Finally if only the builder is
provided, then the named configuration defaults to the one tested by the
builder. If the builder has multiple named configuration, the user is
asked to clarify which one should be tested.
This change adds support for branches to the test matrix. test.dart needs to
know which builders are on which branch, so it can download the relevant
results, and not look on builders that won't be building the right commit.
Fixes https://github.com/dart-lang/sdk/issues/35873
Change-Id: Ie7b75445b954250493528299a0b45eca4e0bb2e5
Reviewed-on: https://dart-review.googlesource.com/c/92780
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I0c8a05cf8715962ab6ebe787dafd14fe611a8a0e
Reviewed-on: https://dart-review.googlesource.com/c/93172
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Change-Id: I1518b916433746f75514f27fdc1456ac535a6dcb
Reviewed-on: https://dart-review.googlesource.com/c/93300
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Internal builds in Google are catching this as an error.
I'm guarding it because I assume we might support building using other
compilers.
Change-Id: I665099cace9c6a40d737c471dd1b0fdb326fea39
Reviewed-on: https://dart-review.googlesource.com/c/91162
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
I was not able to create a test that triggers it, but I saw this
exception sometimes while using it myself.
R=brianwilkerson@google.com
Change-Id: Ia8773a9914b03e73622d5e59f570006723426d42
Reviewed-on: https://dart-review.googlesource.com/c/93281
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Must have forgotten to save this before uploading the new patch
yesterday.
Change-Id: I17967886c5138d609171030350c2b329f17b4650
Reviewed-on: https://dart-review.googlesource.com/c/93282
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
The detachable file system manager feature is now a feature of the Dart Analysis Server, when starter.detachableFileSystemManager has been set.
Support originally added in https://dart-review.googlesource.com/c/sdk/+/73689/ under the --ux-experiment-2 flag.
Change-Id: I26e82e44891d31bf1a1b7399ef5d79e98bc62e7c
Reviewed-on: https://dart-review.googlesource.com/c/93283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Change-Id: I6ec0556c0ec42971dee67a784c7c5f884862ac03
Reviewed-on: https://dart-review.googlesource.com/c/93284
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This is a re-land of "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)."
The native extension test was failing in hot-reload: this has been fixed.
Change-Id: Ic18da8cfbc6a3dba8aac09d654dce616487a67d7
Reviewed-on: https://dart-review.googlesource.com/c/92800
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Change-Id: I7d22c7fdff780ad6c1f302ae041865849be2f011
Reviewed-on: https://dart-review.googlesource.com/c/93170
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Change-Id: I61d860ac4b11b056545dc2ec4f5fe80bc055e49d
Reviewed-on: https://dart-review.googlesource.com/c/93166
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Each function and method starts in unconditional control flow. This
should allow more assertions to be recognized as demonstrating
non-null intent.
Change-Id: I5f6437a3009ebf6c91972e267c8a136a2b2fa77f
Reviewed-on: https://dart-review.googlesource.com/c/93129
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
When the migration tool is run in permissive mode, its visitors try to
catch exceptions and continue running. This means that when the
visitors make temporary state changes before recursive calls, they
have to restore the state inside `finally` blocks.
This should hopefully result in slightly saner behavior when running
the migration tool in permissive mode.
Change-Id: I46e07684526314befad860c4e065ec2c7f6d8b11
Reviewed-on: https://dart-review.googlesource.com/c/93127
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
