languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
38620 commits 11 branches 6011 tags 1.4 GiB
Commit graph

38620 commits

This branch
This branch
All branches
Author SHA1 Message Date
Harry Terkelsen 1fa0ccf869 fix tests for dart2js-mac10.11-chrome-be 
BUG=

Review URL: https://codereview.chromium.org/2038153002 .
 2016-06-03 13:57:58 -07:00
Konstantin Shcheglov dbfce10aae Remove _DeferredClassElement because ClassElementImpl is now lazy. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2042473002 .
 2016-06-03 13:44:52 -07:00
Sigmund Cherem 63a8582514 Fix again linux#3: it was passing in jsshell, moved the entry to the chrome section. 
TBR=het@google.com

Review URL: https://codereview.chromium.org/2034003003 .
 2016-06-03 13:44:24 -07:00
Sigmund Cherem 6740e339c6 Fix co19 status file for dart2js-linux-chromeff-4-4-be 
R=het@google.com

Review URL: https://codereview.chromium.org/2031313003 .
 2016-06-03 13:26:34 -07:00
Konstantin Shcheglov 7af5b1c531 Resynthesize ClassElementImpl fields and property accessors lazily. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2039573002 .
 2016-06-03 13:10:24 -07:00
Sigmund Cherem bc0fe505b9 fix status of co19 for dart2js-linux-chromeff-3-4-be 
R=het@google.com

Review URL: https://codereview.chromium.org/2038923002 .
 2016-06-03 13:03:44 -07:00
Harry Terkelsen 31895ea4e1 triage more dart2js-linux tests 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2033893005 .
 2016-06-03 10:43:39 -07:00
Todd Turnidge c6fbc89f43 Allow double-slash in uris. This is needed for data uri parsing. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2035123002 .
 2016-06-03 09:42:25 -07:00
Konstantin Shcheglov 98553a4917 Resynthesize constructors lazily. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2030403002 .
 2016-06-03 09:38:22 -07:00
Konstantin Shcheglov 17adc3ccd1 Compute ConstructorElement.returnType/type dynamically. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2033293003 .
 2016-06-03 09:24:21 -07:00
Paul Berry af8c6342bf Cleanup: remove package "analyzer2dart". 
This was an experimental effort to merge the front ends of analyzer and
dart2js, and to my knowledge it has not received significant attention
in over a year.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2037123002 .
 2016-06-03 09:23:30 -07:00
Paul Berry 86046f795b Fix resynthesis tests after dead code detection improvements. 
Commit 38e8d9702b improved analyzer's
detection of dead code, causing some of the test cases in
resynthesize_test.dart to have dead code hints.  This CL adds
"allowErrors: true" to those tests so that they won't fail.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2037973003 .
 2016-06-03 09:19:57 -07:00
pq 5a6c934a0a Fix @protected access check from within defining class (#26614). 
Fixes: https://github.com/dart-lang/sdk/issues/26614.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2032363003 .
 2016-06-03 09:09:46 -07:00
Zachary Anderson de78ddbc55 DBC: Collect type feedback for fastpath smi ops 
R=turnidge@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2015113002 .
 2016-06-03 09:09:13 -07:00
Zachary Anderson 7cd20ac709 Fix status file for asan test no longer crashing 
related #26487

Review URL: https://codereview.chromium.org/2037753003 .
 2016-06-03 08:50:53 -07:00
Zach Anderson 44796ed02d Move Windows build output from //build to //out 
This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.

R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2027063003 .
 2016-06-03 08:28:48 -07:00
Lasse R.H. Nielsen 2d8e63e985 Revert "Add package-config tests where test is running in Isolate.spawn-isolates." 
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Committed: 151d1b6796

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2038033002.
 2016-06-03 17:12:17 +02:00
Lasse R.H. Nielsen 0bd6b7e924 Add package-config tests where test is running in Isolate.spawn-isolates. 
R=floitsch@google.com

Committed: f3f6d1e00d

Committed: eda2a81c0c

Review URL: https://codereview.chromium.org/2020653002.
 2016-06-03 16:48:21 +02:00
Lasse R.H. Nielsen eda2a81c0c Add package-config tests where test is running in Isolate.spawn-isolates. 
R=floitsch@google.com

Committed: f3f6d1e00d

Review URL: https://codereview.chromium.org/2020653002.
 2016-06-03 16:35:27 +02:00
Lasse R.H. Nielsen 151d1b6796 Revert "Add package-config tests where test is running in Isolate.spawn-isolates." 
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Review URL: https://codereview.chromium.org/2038033002 .
 2016-06-03 15:34:52 +02:00
Lasse R.H. Nielsen f3f6d1e00d Add package-config tests where test is running in Isolate.spawn-isolates. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2020653002 .
 2016-06-03 13:53:50 +02:00
Ryan Macnak 6b6d363900 Add missing tree shaking root for draining the microtask queue after running a service extension. 
R=asiva@google.com

Review URL: https://codereview.chromium.org/2033983002 .
 2016-06-02 17:21:41 -07:00
Harry Terkelsen 6b721d5145 add resolver dart2js script 
can resolve helloworld

BUG=

Review URL: https://codereview.chromium.org/2024473002 .
 2016-06-02 17:21:06 -07:00
pq bfd06cbd77 Extend @protected to include implemented interfaces. 
Fixes: https://github.com/dart-lang/linter/issues/252.
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2031053002 .
 2016-06-02 16:13:03 -07:00
Sam Rawlins 38e8d9702b Revert "Revert "If an if or do statement always exits, following statements are dead."" 
This reverts commit c0b0c7be81.

BUG=https://github.com/dart-lang/sdk/issues/16420
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2007933002 .
 2016-06-02 15:25:08 -07:00
Konstantin Shcheglov 0ec31b24ba Resynthesize ConstructorElement.redirectedConstructor lazily. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2031093002 .
 2016-06-02 14:53:04 -07:00
John McCutchan d47866964c Fix canonicalization of --url_mapping URIs in gen_snapshot 
When gen_snapshot encounters a url that has been remapped with the --url_mapping command line argument it rewrites the library's url to be the mapped url before canonicalization. The new C++ API only does canonicalization with respect to the library's url (as returned by Dart_LibraryUrl) which is insufficient for gen_snapshot. The correct long-term fix is to alter the new C++ API to allow for the base url to be passed in directly rather than indirectly via Dart_LibraryUrl.

This CL just restores some deleted code and has gen_snapshot work like it did before. The standalone embedder still uses the C++ API during loading.

Review URL: https://codereview.chromium.org/2031103002 .
 2016-06-02 14:52:42 -07:00
Harry Terkelsen 88dd7c8f37 use const Link so that empty Link is always identical 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2033873002 .
 2016-06-02 14:25:09 -07:00
Sam Rawlins c2f04d2dc2 ExitDetector: Do not special case enums, since null exists 
BUG=https://github.com/dart-lang/sdk/issues/26606
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2033693003 .
 2016-06-02 14:15:36 -07:00
Konstantin Shcheglov 6e4095affe Resynthesize constructor initializers lazily. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2030853003 .
 2016-06-02 13:50:39 -07:00
Todd Turnidge 825cc4957f Make ResolveUri return the correct target_uri for relative base uris. 
BUG=

Review URL: https://codereview.chromium.org/2037823003 .
 2016-06-02 13:31:59 -07:00
Todd Turnidge 29ec16c91f Fix non-mac builds by adding "const". 
BUG=

Review URL: https://codereview.chromium.org/2037823002 .
 2016-06-02 13:17:01 -07:00
Todd Turnidge a7d46eb5a6 Canonicalize uris in C++ instead of Dart for the standalone embedder. 
Adds Dart_DefaultCanonicalizeUrl() to the dart embedding api.

Motivation:

As we try to get source reloading working for the standalone embedder, things get simpler if an isolate doesn't run Dart code while it is loading Dart code.  We intend to solve this by moving the embedder tag handler calls to the service isolate.  But making a blocking rpc into the service isolate whenever a url needs to be canonicalized during parsing seems like it would slow things down and make things complicated.  By moving canonicalization into C++, we avoid this.

R=ahe@google.com, fschneider@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2011543002 .
 2016-06-02 12:29:57 -07:00
Konstantin Shcheglov f91de5fef1 Fix for SDK summary result provider. 
Unfortunately the problem was uncovered only in the check mode.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2037523003 .
 2016-06-02 12:24:27 -07:00
Paul Berry f5a9c029b7 Update status file for issue #26592 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2027393002 .
 2016-06-02 12:19:09 -07:00
Konstantin Shcheglov ddfffc6984 Only ClassElementImpl has TypeParameterizedElementMixin. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2033853002 .
 2016-06-02 11:28:21 -07:00
Konstantin Shcheglov 106d70ec1f Use ResynthesizerResultProvider for both SDK and packages. 
I would need to use something like this for serving external packages,
and it might be also useful for serving the Flutter bundle.

R=brianwilkerson@google.com, paulberry@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/2035833002 .
 2016-06-02 11:24:04 -07:00
Ryan Macnak 3f8c0bb0a9 Don't overload FreeListElement for become. 
R=asiva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2026643004 .
 2016-06-02 10:57:34 -07:00
Ryan Macnak 2e9c5f9a91 Reapply "VM: Add result cid information for recognized methods." 
- _HashVMBase._index is nullable
 - _HashVMBase._data is a regular Array
 - DBC fixes from Zach.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2033553002 .
 2016-06-02 09:59:48 -07:00
Konstantin Shcheglov f2baca7192 One more fix for SummaryTypeProvider - nullType is lazy. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2023353004 .
 2016-06-02 09:51:27 -07:00
pq 551eee30e5 DEPS bump to pull in linter 0.1.18 (#26596). 
Fixes: https://github.com/dart-lang/sdk/issues/26596.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2033543004 .
 2016-06-02 09:50:59 -07:00
Konstantin Shcheglov d64b2b9299 Resynthesize class methods lazily. 
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2032053002 .
 2016-06-02 09:11:14 -07:00
Matthias Hausner 1859ce46c3 Fix finally clause inlining for forward jumps 
In switch statements, ‘continue L’ jumps can refer to a label
that the compiler hasn’t seen yet. The label is tentatively
to be in the innermost switch statement, but may later
be moved to an outer switch statement. The compiler must
make sure that the correct finally blocks are inlined in front
of these jumps.

BUG=26577, 25310
R=regis@google.com

Review URL: https://codereview.chromium.org/2030763002 .
 2016-06-02 09:03:49 -07:00
Konstantin Shcheglov d45453d2a2 Make SummaryTypeProvider lazy. 
Mostly because this fixes a serious performance regression in DDC
compilation, introduced as a during making ClassElement.supertype lazy.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2037693002 .
 2016-06-02 08:51:46 -07:00
Konstantin Shcheglov f1bc40923a Report HintCode.UNUSED_FIELD for fields which are referenced in constructor field initializers. 
This adds two not false positives in dart2js, and zero to DDC.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2029193003 .
 2016-06-02 08:00:22 -07:00
Florian Loitsch 2820f231c6 Don't toString messages in native Js sendports. 
Fixes #26595
BUG= http://dartbug.com/26595
R=lrn@google.com

Review URL: https://codereview.chromium.org/2033063002 .
 2016-06-02 14:39:25 +02:00
Johnni Winther 6384fc0c77 Fix poi test. 
BUG=

Review URL: https://codereview.chromium.org/2030043002 .
 2016-06-02 14:20:55 +02:00
Johnni Winther bb9fab0065 Fix code-size regression 
This reinserts the native spec-string interpretation.

The CL https://codereview.chromium.org/2004833003/ changed the interpretation of `List` from `List<E>` to `List<dynamic>` causing these native classes to be added through subtyping:

NativeUint8List <: List
NativeUint8ClampedList <: List
NativeUint32List <: List
NativeUint16List <: List
NativeInt8List <: List
NativeInt32List <: List
NativeInt16List <: List
NativeFloat64List <: List
NativeFloat32List <: List
NativeTypedArrayOfInt <: List
NativeTypedArrayOfDouble <: List

R=sra@google.com

Committed: 565b30123c

Reverted: fa5b98126c

Review URL: https://codereview.chromium.org/2021723003 .
 2016-06-02 13:56:51 +02:00
Florian Loitsch d3579131c8 Avoid runtime type errors in checked mode for ChunkedConverters. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2035473003 .
 2016-06-02 13:41:29 +02:00
Erik Ernst c59d37032e Added missing status entries. 
A fix for c35caf253e and
https://codereview.chromium.org/2029003002.

Review URL: https://codereview.chromium.org/2029343003 .
 2016-06-02 12:37:47 +02:00