Brian Wilkerson
e3e72aeb01
Rework the parser to improve performance
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2041723008 .
2016-06-07 13:58:29 -07:00
Florian Schneider
c88a8a648c
Remove unused code from aot optimizer.
...
FLAG_polymophic_with_deopt is always false when generating precompiled code,
so this function is not needed.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2047433005 .
2016-06-07 13:30:46 -07:00
Harry Terkelsen
74abdfe09e
typecheck erroneous members as dynamic
...
Fixes #26582
R=sra@google.com
Review URL: https://codereview.chromium.org/2046053002 .
2016-06-07 13:18:45 -07:00
John McCutchan
bf4b3b3733
Activate the service isolate for all precompiled tests.
...
- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2041113003 .
2016-06-07 12:47:44 -07:00
Konstantin Shcheglov
1390dbd36a
Fix for writing structures of imported libraries.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2047573003 .
2016-06-07 12:00:44 -07:00
Paul Berry
f5ef3232ea
Remove unnecessary overrides of PropertyAccessorElementImpl.operator== and hashCode
...
It turns out that these overrides aren't necessary, since the
element's location contains enough information to distinguish between
getters and setters. Removing the overrides makes
PropertyAccessorElementImpl's behavior match that of
PropertyAccessorElementHandle, which is important when summaries are
in use.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2042393002 .
2016-06-07 11:26:53 -07:00
Konstantin Shcheglov
676a9f7d60
Compute IGNORE_INFO and filter DART_ERRORS.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2048713002 .
2016-06-07 09:56:14 -07:00
Konstantin Shcheglov
c2f3076450
Allow analyzer to be used with crypto 2.x.x
...
R=brianwilkerson@google.com , kevmoo@google.com
BUG=
Review URL: https://codereview.chromium.org/2047023002 .
2016-06-07 09:49:27 -07:00
Konstantin Shcheglov
5c70d41832
Upgrade SDK to crypto 1.1.1
...
R=kevmoo@google.com , nweiz@google.com
BUG=
Review URL: https://codereview.chromium.org/2045533003 .
2016-06-07 09:40:17 -07:00
Ryan Macnak
1bd4586961
Fix product build.
...
Review URL: https://codereview.chromium.org/2041383002 .
2016-06-07 09:36:34 -07:00
Terry Lucas
dd481e9d15
Updated to lated Chromium and WebKit changes for aggregate support.
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2040093003 .
2016-06-07 07:41:58 -07:00
Johnni Winther
40108f661d
Update Windows build output path in .bat files
...
R=asiva@google.com , whesse@google.com
Review URL: https://codereview.chromium.org/2035313004 .
2016-06-07 10:43:13 +02:00
Konstantin Shcheglov
1074d44c65
Serve DART_ERRORS from incremental cache.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2045793003 .
2016-06-06 20:25:33 -07:00
Siva Annamalai
53c20930d1
Add --packages option to gen_snapshot in order to accept package map files (see https://github.com/dart-lang/sdk/issues/26362 )
...
BUG=26362
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2044673002 .
2016-06-06 17:12:20 -07:00
Florian Schneider
9ee5dfb245
Fix speculative inlining in precompilation.
...
When optimistically inlining is-checks and as-casts, we have to guard
again repeated speculative attempts.
Also, add result cid information for recognized factories.
BUG=#26607
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2035073002 .
2016-06-06 16:37:39 -07:00
Stephen Adams
50a25aebf0
Use intl 0.13.0
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2047573002 .
2016-06-06 16:31:19 -07:00
John McCutchan
c5dd06f7c7
Attempt to fix entrypoints list in main.cc
...
BUG=
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2043953002 .
2016-06-06 16:21:46 -07:00
Konstantin Shcheglov
a42317f2de
Serve INCLUDED_PARTS from incremental cache.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2044513003 .
2016-06-06 16:00:37 -07:00
John McCutchan
154a659b5e
Fix Dart2js, analyzer bots
...
- Re-add support for loading from a script snapshot
BUG=
Review URL: https://codereview.chromium.org/2041173002 .
2016-06-06 15:30:33 -07:00
pq
63b00419b1
Supertype checking cleanup.
...
Following up from: https://codereview.chromium.org/2045693002/ .
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2047523002 .
2016-06-06 15:13:16 -07:00
John McCutchan
1020392647
Add missing locking around loaders list
...
BUG=
Review URL: https://codereview.chromium.org/2039383002 .
2016-06-06 14:51:24 -07:00
William Hesse
e9b92b73fe
Start working on version 1.18 of Dart
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2039093004 .
2016-06-06 23:31:00 +02:00
John McCutchan
45e277a2cb
Fix MacOS build
...
BUG=
Review URL: https://codereview.chromium.org/2035383004 .
2016-06-06 14:20:39 -07:00
John McCutchan
6fd8fd7987
Rework standalone to use a synchronous loader that does not invoke Dart code
...
- [x] The first caller of the tag handler blocks, recursive callers queue work and exit.
- [x] Use a NativeMessageHandler to receive I/O results from the service isolate.
- [x] Preserve load error message format.
- [x] Move packages map into service isolate.
- [x] Wire up Todd's native URI code.
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1998963003 .
2016-06-06 14:15:01 -07:00
Konstantin Shcheglov
ed8154a53c
Add put/getSourceErrorsInLibrary to IncrementalCache.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2042883002 .
2016-06-06 13:27:25 -07:00
William Hesse
49dec47c97
Update status for failing vm precompilation test.
...
BUG=https://github.com/dart-lang/sdk/issues/26607
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2044613002 .
2016-06-06 13:15:33 -07:00
pq
8b1440fd2b
Fix @protected checks to play nice with generic supers (linter#257).
...
Fixes: https://github.com/dart-lang/linter/issues/257 .
(Pardon the member-sorting churn in `hint_code_test`.)
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2045693002 .
2016-06-06 13:14:13 -07:00
pq
8b779f33c0
Fix @protected to include closure references (linter#255).
...
Generalizes the check for invalid protected access.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2041873003 .
Fixes: https://github.com/dart-lang/linter/issues/255 .
2016-06-06 11:43:30 -07:00
Konstantin Shcheglov
e6d2b37065
Start using crypto 1.1.1 and tweak MD5 computation.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2041963002 .
2016-06-06 11:37:08 -07:00
Konstantin Shcheglov
e87a9c955c
Start adding experimental incremental analysis mode into CLI analyzer.
...
At the moment it is not very useful, because it does not use or store
errors from incremental cache yet. But I hope to implement this soon.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2039773004 .
2016-06-06 11:35:55 -07:00
Todd Turnidge
424ca27a15
Fix various nefarious problems with the script table used in source reports.
...
Before we could get duplicate or spurious script table entries.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2038203002 .
2016-06-06 11:22:46 -07:00
Konstantin Shcheglov
2ef55609fc
Resynthesize enums lazily.
...
Now everything is resynthesized lazily, so we can remove 'unitHolder'.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2043783002 .
2016-06-06 08:55:29 -07:00
Konstantin Shcheglov
df61e8d64a
Resynthesize enum fields lazily.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2040673002 .
2016-06-06 08:32:07 -07:00
Erik Ernst
6d56db592b
Revert "New tests for initializing formal access."
...
This reverts commit 543a51ff3e
because several status file updates are needed.
Review URL: https://codereview.chromium.org/2039243002 .
2016-06-06 16:07:03 +02:00
Erik Ernst
543a51ff3e
New tests for initializing formal access.
...
This CL adds tests for previously uncovered elements of the semantics
and includes fixes such that the desired behavior is obtained. In
particular, an `isInitializingFormal` element may now occur in contexts
where it wasn't expected until now, and changes were made to handle it.
It is also checked that a capture of an initializing formal (in a
function literal) captures the parameter, not the field.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org/2039833002 .
2016-06-06 15:55:44 +02:00
danrubel
2d310f1e67
improve completions in closures and switch statements
...
This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2034713004 .
2016-06-06 08:09:44 -04:00
Johnni Winther
e97c1c673f
Align semantics of getDefaultConstructor()
...
The modelx implementation of getDefaultConstructor() (surprisingly)
returned constructors with only optional arguments. This CL aligns the
modelz implementation with this, adding a TODO to figure out what the
best behavior is.
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2033893004 .
2016-06-06 11:23:22 +02:00
Johnni Winther
153c36ce39
Don't crash when tree shaking is disabled
...
When tree shaking is disabled, type checking crashed on member lookup into serialized classes.
Also classes are now ensured to be resolved when computing lookup.
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2031293002 .
2016-06-06 11:08:01 +02:00
Johnni Winther
b11a92f2ed
Handle use of fromEnvironment from serialized data.
...
This CL removes the [intEnvironment], [boolEnvironment] and [stringEnvironment]
from [Compiler] and instead determine .fromEnvironment directly from the
constructor element itself.
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2033383002 .
2016-06-06 10:52:41 +02:00
Johnni Winther
0b926d64a4
Handle deferred access of unserialized code.
...
This CL fixes crashes in deferred_load when using serialized dart:core:
- resolution impacts are cached in [Resolution] for both serialized and unserialized elements.
- type variable constants (for mirrors) are computed using [ConstantExpression]s.
- LibraryElementZ.getImportsFor returns the empty list; thus still not valid for deferred access in serialized code.
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2034973003 .
2016-06-06 10:26:37 +02:00
Lasse R.H. Nielsen
c7e601c90d
Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
...
This reverts commit f3f6d1e00d
.
Running a new process doesn't correctly pass empty command line parameters on Windows.
Committed: 151d1b6796
R=floitsch@google.com
Committed: 2d8e63e985
Review URL: https://codereview.chromium.org/2038033002 .
2016-06-06 08:46:58 +02:00
Harry Terkelsen
417b36a942
mark newly failing html test in safari
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2034283002 .
2016-06-03 16:17:33 -07:00
Sigmund Cherem
99792d9a79
fix remaining windows issues
...
TBR=het@google.com
Review URL: https://codereview.chromium.org/2035113004 .
2016-06-03 15:55:35 -07:00
Stephen Adams
b37747934e
Specialize Symbol.hashCode
...
Patch internal.Symbol.hashCode and specialize JS version to avoid
recomputing String.hashCode
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2038853003 .
2016-06-03 15:10:51 -07:00
Sigmund Cherem
5e9f7a8882
Fix IE status
...
Review URL: https://codereview.chromium.org/2040593002 .
2016-06-03 14:49:05 -07:00
Konstantin Shcheglov
b473d6f451
Resynthesize CompilationUnitElement.types lazily.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2036203005 .
2016-06-03 14:42:37 -07:00
Regis Crelier
4524d15d52
Fix sed expression to substitute recalculated fingerprints after format change.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2031153002 .
2016-06-03 14:38:16 -07:00
Konstantin Shcheglov
674fc7829b
Create ClassElement.type lazily in ClassElementImpl and EnumElementImpl.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2038153003 .
2016-06-03 14:35:16 -07:00
Harry Terkelsen
c59d264131
fix dart2js-mac10.11-safari tests
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2038173002 .
2016-06-03 14:29:02 -07:00
William Hesse
fbf301c0ad
Run dartium buildbot tests under xvfb on linux
...
Previously, the entire builder run was under xvfb, now only the tests are.
R=het@google.com
BUG=
Review URL: https://codereview.chromium.org/2038903002 .
2016-06-03 14:14:13 -07:00