Commit graph

42199 commits

Author SHA1 Message Date
Zachary Anderson c4e1b1c641 GN: Don't strip binary with clang on x64
Review URL: https://codereview.chromium.org/2494563002 .
2016-11-09 15:00:44 -08:00
Brian Wilkerson 37890f995f Add a new annotation
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2420653002 .
2016-11-09 14:19:27 -08:00
Zachary Anderson da81562dc8 Fix mac build
Review URL: https://codereview.chromium.org/2490003002 .
2016-11-09 12:51:21 -08:00
Zachary Anderson 630d24bec8 clang-formats remaining files and adds a presubmit check.
R=asiva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2483363002 .
2016-11-09 12:43:57 -08:00
Konstantin Shcheglov 050e16d221 Evict using size in bytes in MemoryCachingByteStore.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2487313002 .
2016-11-09 12:22:32 -08:00
Konstantin Shcheglov b6c02291b8 Notify all drivers about all changed files.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2489063002 .
2016-11-09 11:32:02 -08:00
Regis Crelier 80f289e54d Remove getter p on double in the VM to control fractional precision.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2489713002 .
2016-11-09 10:56:55 -08:00
Konstantin Shcheglov 221ff0beae Don't ovewrite method types of a resynthesized library in TypeResolverVisitor.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2491533002 .
2016-11-09 10:24:00 -08:00
Zach Anderson eba3743adb Adjust line endings setting in .gitattributes
When checking out code on Windows, we have git set up to automagically
convert LF line-endings to CRLF line-endings. This confuses the canned
formatting presubmit check, which fails because the line endings are not
what it wants.

This CL turns off the automagic line-ending conversion for C/C++ source
files, so that clang-format doesn't get confused by them on Windows.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2490993002 .
2016-11-09 09:23:21 -08:00
Paul Berry 1dfa5685ce Update cross-context options encoding to account for patchPlatform.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2486973004 .
2016-11-09 09:12:09 -08:00
Brian Wilkerson 6ce2f220e3 Add an error when a type parameter from a generic function is used in an is test
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2479293004 .
2016-11-09 07:47:54 -08:00
Vyacheslav Egorov 6dce6e87f8 Reduce amount of boilerplate associated with bootstrap libraries.
R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org/2493473002 .
2016-11-09 16:38:50 +01:00
Sigmund Cherem 053fa1c500 dart2js: move type-mask intermediate data from tree-elements into the global
inference engine.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2468303003 .
2016-11-09 07:26:13 -08:00
Johnni Winther 26f61fe1d4 Change IR encoding of redirecting factory invocations.
- redirecting factory constructors are not included in the program
- invocations of redirecting factory constructor point to the effective target

R=het@google.com

Review URL: https://codereview.chromium.org/2486703002 .
2016-11-09 16:22:27 +01:00
Konstantin Shcheglov 4e4f8a9c73 Support for parts.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2483443002 .
2016-11-09 07:13:01 -08:00
Lasse R.H. Nielsen 2e56c7b8fa Spec: Make fontenc understand that greater than is not an inverse question mark.
No longer using a 7-bit font. Welcome to the 21th century.

R=eernst@google.com

Review URL: https://codereview.chromium.org/2487193002 .
2016-11-09 14:31:28 +01:00
Lasse R.H. Nielsen f3288982de Spec: Rewrite lambdas to simpler semantics instead.
This is instead of introducing a let-construct.

R=eernst@google.com

Review URL: https://codereview.chromium.org/2433943002 .
2016-11-09 13:21:39 +01:00
Erik Ernst 5bf3c1fa4d Fixed erroneously commented-out \end{itemize}
Commit 4cb61407a8, CL
https://codereview.chromium.org/2476613002 introduced a spurious `%`
which causes `latex dartLangSpec.tex` to fail. This CL fixes it.

Review URL: https://codereview.chromium.org/2487113003 .
2016-11-09 12:30:34 +01:00
Konstantin Shcheglov e7350d171e Don't serialize elements of top-level function/constructor/method bodies.
Instead in DeclarationResolver build these local elements in the bodies.

As you can see, the summary_common tests are quite ugly now, we decided
that we still have to serialize everything in variable initialiers,
including local functions. So, this requires repurposing the tests to
using initializers, and also keep buildLabelElements() in
DeclarationResolver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2485043004 .
2016-11-08 19:19:46 -08:00
Konstantin Shcheglov ceda6a038b Provide LINE_INFO using just UnlinkedUnit even though the full info is not available.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2486573002 .
2016-11-08 18:11:43 -08:00
Konstantin Shcheglov b22ac9c93d Use AnalysisDriverScheduler to schedule work across multiple AnalysisDriver(s).
I don't like that it lives in the same file, but I'd not like to
expose internals of AnalysisDriver or AnalysisDriverScheduler outside :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2487003002 .
2016-11-08 18:05:16 -08:00
Konstantin Shcheglov 0f52c15f1c Include 'enableGenericMethods' into salt.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2485853003 .
2016-11-08 17:24:04 -08:00
Ryan Macnak ab26422df0 Check that Dart_CreateIsolate is given a correct kind of snapshot.
R=zra@google.com

Review URL: https://codereview.chromium.org/2481013006 .
2016-11-08 16:49:59 -08:00
Paul Berry 7493d120a4 Remove front_end's dependency override on analyzer.
The override had no effect anyway, because it was identical to
front_end's dependency on analyzer.

This is necessary in order to publish front_end.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2487603004 .
2016-11-08 16:19:34 -08:00
Florian Schneider 368409d3e4 DBC: Fix bugs with array allocation
Guard against negative length in the fast path.

Add missing PC descriptors for correct exceptions.

BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2490803002 .
2016-11-08 15:45:31 -08:00
Zachary Anderson 5f8580a673 Add BUILD.gn for pkg/front_end to fix the Fuchsia build
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2483353002 .
2016-11-08 15:15:07 -08:00
Jacob Richman 3356f82eb3 Fix crashing bug for closures of the form () { return; }
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2484913004 .
2016-11-08 15:14:10 -08:00
Zachary Anderson 076ff10c3c Fuchsia: fix Debug build
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2488813002 .
2016-11-08 14:35:00 -08:00
Paul Berry 0c3fade7f7 Fix front_end version number in preparation for publishing.
Analyzer needs to depend on a published version of front_end in order to
pass buildbot tests (it may be an alpha version).  This CL sets the
version to "0.1.0-alpha.0" (I will publish this version once the CL
lands).  Note that the previous version of front_end was "0.1.0", so we
appear to be moving the version backwards.  This is ok because version
"0.1.0" was never published.

Note that during this transitional period where code is being moved from
analyzer to front_end, we have circular imports between analyzer and
front_end, so from now until the transitional period ends, we will need
to publish front_end whenever we publish analyzer.

Update copyright notices in front_end package

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2485993003 .
2016-11-08 14:28:40 -08:00
Paul Berry e790b44c63 Update copyright notices in front_end package.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2483313003 .
2016-11-08 14:23:58 -08:00
Paul Berry 5eb3636ae3 Add patch file support to the analyzer task model.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2483343002 .
2016-11-08 14:00:45 -08:00
Zachary Anderson a1bcf051d8 clang-format runtime/vm
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 13:54:47 -08:00
Paul Berry 0a1fb8d248 Move scanner into pkg/front_end/lib/src/scanner.
Several support classes also had to move to front_end along with the
scanner.  Some of these support classes arguably don't belong to the
scanner itself, since they have other uses (e.g. SyntacticEntity,
ErrorCode, ErrorSeverity, ErrorType, and StringUtilities).  They will
be reorganized into a more appropriate location in future CLs, at the
time that they become needed by other components of the front end.

In order to avoid dragging in a lot of dependencies, the following
changes were made:

1. Scanner no longer reports errors through Source and
AnalysisErrorListener objects passed to the constructor.  Instead, it
provides an abstract reportError() method which clients may override
to perform error reporting in any way they wish.  Analyzer contains an
override of Scanner that mimics the old behavior in order to maintain
compatibility.

2. Static members of ErrorCode (`values` and `byUniqueName`) have been
moved to top level, and remain in analyzer.  To maintain
compatibility, these static members remain in ErrorCode (as deprecated
members that simply wrap the implementations in analyzer).  This means
we have a reverse dependency (front_end depends on analyzer), but this
dependency will go away as soon as we publish the next breaking change
release of analyzer.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2486873003 .
2016-11-08 13:47:17 -08:00
Sigmund Cherem ce758e7e0a dart2js: depend directly on kernel/ast to avoid indirect dependency on dart:io
BUG= https://github.com/dart-lang/sdk/issues/27744
R=het@google.com

Review URL: https://codereview.chromium.org/2485093003 .
2016-11-08 13:13:10 -08:00
Florian Schneider a77d860806 Fix static field initialization in optimzed DBC code.
Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

Fixes #27787.

R=zra@google.com

Review URL: https://codereview.chromium.org/2486863002 .
2016-11-08 11:21:47 -08:00
Brian Wilkerson 562c2be184 Convert generic method errors to hints
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2487583002 .
2016-11-08 11:06:42 -08:00
Paul Berry 72fc9805d9 Add analysis options for front end, and fix a bug discovered by strong mode.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2489573002 .
2016-11-08 10:39:48 -08:00
Jennifer Messerly 8f04f902df fix #27771, create directory if needed
R=vsm@google.com

Review URL: https://codereview.chromium.org/2483753004 .
2016-11-08 10:21:31 -08:00
Jennifer Messerly 3995146b55 fix #27775, enum declaration where "name" is a property
R=vsm@google.com

Review URL: https://codereview.chromium.org/2488543002 .
2016-11-08 10:18:55 -08:00
Ryan Macnak f7ed0eb832 GN: Run a small portion of the test suite for dart2js and the analyzer.
R=zra@google.com

Review URL: https://codereview.chromium.org/2484083002 .
2016-11-08 10:04:45 -08:00
Florian Schneider d53f26e395 Remove references to non-existing tests from status files.
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2481223003 .
2016-11-08 09:21:21 -08:00
Ryan Macnak 888a8793a3 Mark sample_extension_app_snapshot_test as failing on IA32 Windows.
Issue #27786

Review URL: https://codereview.chromium.org/2482193002 .
2016-11-08 09:07:23 -08:00
Martin Kustermann 4ae06af529 VM: [Kernel] Set types on [LocalVariable] if they were introduced by [VariableDeclaration]s
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2477563003 .
2016-11-08 09:56:23 +01:00
Johnni Winther 8ea13999de Handle dart:html in kernel_impact
R=het@google.com

Review URL: https://codereview.chromium.org/2481113003 .
2016-11-08 09:31:53 +01:00
Ryan Macnak 0d830711bf Fix Windows build.
Review URL: https://codereview.chromium.org/2481013005 .
2016-11-07 16:38:30 -08:00
Ryan Macnak 987165f022 Reload native extensions when starting from a snapshot.
Fixes #21180
Fixes #27574

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2475523002 .
2016-11-07 16:17:47 -08:00
Harry Terkelsen 4b2751a80e don't rely on identical for comparing empty linked lists
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2476333003 .
2016-11-07 15:48:45 -08:00
John McCutchan 14297ee480 Add an environment variable toggle to control new service protocol auth token
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2486443002 .
2016-11-07 14:45:52 -08:00
Harry Terkelsen a9d4575788 add missing semicolon in profile_many script
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2482773003 .
2016-11-07 13:17:43 -08:00
Zachary Anderson 861f0be47e Fix build
Review URL: https://codereview.chromium.org/2487473002 .
2016-11-07 13:13:58 -08:00