languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 21:21:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
42891 commits 11 branches 6011 tags 1.4 GiB
Commit graph

7767 commits

Author SHA1 Message Date
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium." 
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
 2016-07-19 13:56:36 +02:00
Keerti Parthasarathy 69a8b11f67 Fix for uri replace whene uri has fragment. Was adding a second '#'. 
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2158933003 .
 2016-07-18 16:31:43 -07:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
Alan Knight e610d803b1 Update test status for webgl extension tests, fix one typo in extension name 
BUG=

Review URL: https://codereview.chromium.org/2152393002 .
 2016-07-15 15:00:15 -07:00
Alan Knight b9316f9882 Recognize WEBGL extensions on Firefox (copy with regenerated files) 
Both of the following objects need to map to Dart type 'AngleInstancedArrays'

    [object ANGLEInstancedArrays]
    [object ANGLE_instanced_arrays]

Fixes https://github.com/dart-lang/sdk/issues/26850

BUG=

patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1)

R=sra@google.com

Review URL: https://codereview.chromium.org/2150003002 .
 2016-07-15 12:48:22 -07:00
Stephen Adams 1eee3c7dc7 dart2js js_runtime: faster code for floor() & ceil() 
Within the [-2^31, 2^31) range it is faster to truncate and correct at boundaries than call Math.ceil/Math.floor.

Each call to toInt() has been specialized to the calling operator (ceil, floor, ~/ etc).

This makes the conversion faster (values are already integral) and lets us put the name of the operation and original operands in conversion errors, e.g

(a / b).floor();  // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Infinity.floor()

a ~/ b;   // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Result of truncating division is Infinity: 132 ~/ 0

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1405113003 .

Downside: an extra 400 bytes
 2016-07-15 12:27:59 -07:00
Todd Turnidge 3a51fceaba First cut at _spawnUri rpc in the vm service. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2072543002 .
 2016-07-11 14:25:27 -07:00
Florian Loitsch badabcc53a Don't use => on void functions. 
Fixes #26740
BUG= http://dartbug.com/26740
R=sra@google.com

Review URL: https://codereview.chromium.org/2118633002 .
 2016-07-11 14:20:12 +02:00
Florian Loitsch 9413d62bf6 More documentation for zones. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2082553003 .
 2016-07-11 13:21:08 +02:00
Florian Loitsch 9a851032c9 Copy Dart-configuration detection from dart script to pub. 
Fixes #26621.
BUG= http://dartbug.com/26621
R=whesse@google.com

Review URL: https://codereview.chromium.org/2134733002 .
 2016-07-08 16:23:10 +02:00
Lasse R.H. Nielsen bb96f28921 Update documentation for Stream.listen. 
Addresses issue #25967
BUG= http://dartbug.com/25967
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2119153002.
 2016-07-06 09:17:18 +02:00
Florian Loitsch bf8eeef6a0 Don't call _ensureRequestAnimationFrame in Dartium. 
Review URL: https://codereview.chromium.org/2117103004 .
 2016-07-05 19:50:49 +02:00
Florian Loitsch 3daaf3849f Fix animationFrameRequest for dartium. 
Review URL: https://codereview.chromium.org/2124863002 .
 2016-07-05 19:22:27 +02:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: f746f8f77e

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: dae3922915
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Lasse R.H. Nielsen a11ad27723 Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key. 
Most URI strings are short, but this still gives a 10%-20% improvement on doing repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbug.com/18162
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2119833002 .
 2016-07-04 10:19:41 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch b40cfcb57f Add zone task support to http-requests. 
R=alanknight@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2042033002 .
 2016-07-01 19:44:19 -07:00
Florian Loitsch 726b9f8dc7 Add zone task support for request-anim. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2039963003 .
 2016-07-01 19:43:36 -07:00
Florian Loitsch 6d1f6b2af6 Make Dom events run through zone tasks. 
R=jacobr@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2022263002 .
 2016-07-01 19:43:06 -07:00
Florian Loitsch 85cccde717 Add tasks to zones. 
R=lrn@google.com, misko@google.com

Review URL: https://codereview.chromium.org/1848933002 .
 2016-07-01 19:42:22 -07:00
Todd Turnidge f7242f2137 Reimplement devfs in dart. Implementation now writes to disk. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2120473004 .
 2016-07-01 14:57:32 -07:00
Brian Wilkerson cacabb3085 Fix typos in docs 
Review URL: https://codereview.chromium.org/2119483002 .
 2016-06-30 10:08:54 -07:00
Lasse R.H. Nielsen b39e048c4b Fix regression for the one case where we deliberately don't follow the RFC. 
The new code didn't have that exception.

Also optimize some string operations when it's possible.

R=eernst@google.com

Review URL: https://codereview.chromium.org/2117453002 .
 2016-06-30 14:52:23 +02:00
Lasse R.H. Nielsen 00090a0c72 Add fast-mode Uri class. 
Optimize parser and make it recognize a class of URIs that don't need extra
handling: no escapes, no funny characters, already (nearly or completely)
normalized.
Have a class specifically for those URIs which retains the original
input string without having allocate any further strings.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2086613003.
 2016-06-30 12:20:15 +02:00
Jacob Richman dead24a756 Make allowInterop a generic method. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2102893002 .
 2016-06-29 14:23:37 -07:00
Florian Loitsch d28687f1f7 Add documentation to List.filled to warn of common mistake. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2100943003 .
 2016-06-28 17:30:38 -07:00
Lasse R.H. Nielsen ddf35f2d56 Fix bug in BytesBuilder. Add tests. 
Fixes issue #26772

BUG= http://dartbug.com/26772
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2100103002 .
 2016-06-28 14:34:53 +02:00
Stephen Adams 716898c227 Shorter encoding for zero optional arguments. 
R=het@google.com

Review URL: https://codereview.chromium.org/2092243002 .

Addresses: https://github.com/dart-lang/sdk/issues/26754
 2016-06-27 13:23:43 -07:00
Stephen Adams 909ec27b10 Code changes to avoid Firefox debug 'error' lint warnings. 
Firefox produces many SyntaxErrors and TypeErrors for what are really
linter issues.

Improve compile-time and run-time codegen to avoid these warnings.

BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2072883004 .
 2016-06-17 13:05:28 -07:00
Zach Anderson 22e449ba09 Fix Windows time zone name extraction. Update API docs 
On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085

R=asiva@google.com

Review URL: https://codereview.chromium.org/2069783002 .
 2016-06-14 13:51:19 -07:00
Zachary Anderson 678cb048ed Adds blocking file locks. 
Fixes #26665

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2050413002 .
 2016-06-13 07:58:09 -07:00
John McCutchan 1a4c2005cc DevFS initial implementation. 
This cl implements an experimental filesystem maintained in the vm, called dart-devfs.  This will allow service protocol users to read and write source files while the vm is running.  This is needed for the reload support for flutter.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/2059883003 .
 2016-06-10 12:33:50 -07:00
Johnni Winther 40108f661d Update Windows build output path in .bat files 
R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2035313004 .
 2016-06-07 10:43:13 +02:00
John McCutchan 6fd8fd7987 Rework standalone to use a synchronous loader that does not invoke Dart code 
- [x] The first caller of the tag handler blocks, recursive callers queue work and exit.
- [x] Use a NativeMessageHandler to receive I/O results from the service isolate.
- [x] Preserve load error message format.
- [x] Move packages map into service isolate.
- [x] Wire up Todd's native URI code.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1998963003 .
 2016-06-06 14:15:01 -07:00
Stephen Adams b37747934e Specialize Symbol.hashCode 
Patch internal.Symbol.hashCode and specialize JS version to avoid
recomputing String.hashCode

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2038853003 .
 2016-06-03 15:10:51 -07:00
Florian Loitsch 2820f231c6 Don't toString messages in native Js sendports. 
Fixes #26595
BUG= http://dartbug.com/26595
R=lrn@google.com

Review URL: https://codereview.chromium.org/2033063002 .
 2016-06-02 14:39:25 +02:00
Florian Loitsch d3579131c8 Avoid runtime type errors in checked mode for ChunkedConverters. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2035473003 .
 2016-06-02 13:41:29 +02:00
Florian Loitsch e1bf3506d1 Make linked-list non-circular. 
This bug was introduced when making the collection library strong-mode clean.

Fixes #26522
BUG= http://dartbug.com/26522
R=lrn@google.com

Review URL: https://codereview.chromium.org/2015513006 .
 2016-06-01 14:19:37 +02:00
Alexandre Ardhuin 1e356e1881 Update http.dart (#26524) 
Fix #26518 (part 2)
 2016-05-30 14:18:36 +02:00
Jacob Richman 6cb121f847 Make sort method generic. This eliminates a large number of dynamic calls that slow down sorting under ddc. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/2008373002 .
 2016-05-25 12:33:41 -07:00
Alan Knight 088dd409fc Add types on internal DateTime accessors 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2008163002 .
 2016-05-24 17:36:33 -07:00
Alexandre Ardhuin 9b9e97d5ba Update http.dart (#26520) 
Fix #26518
 2016-05-24 19:53:23 +02:00
Lasse R.H. Nielsen fbf64bb7a5 Make Iterable.toList more efficient if the length is known. 
Add more tests. Fix (some) bugs found by tests.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1999793002.
 2016-05-23 10:00:19 +02:00
Terry Lucas 94456a2433 Optimization for patch file generation 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1999803002 .
 2016-05-20 07:48:08 -07:00
Florian Loitsch 2203c54cbb Fix documentation for LinkedHashSet. 
Fixes #26496
BUG= http://dartbug.com/26496

Review URL: https://codereview.chromium.org/1999783002 .
 2016-05-20 14:36:38 +02:00
Florian Loitsch ac0a5ef431 Fix documentation for identity sets/maps. 
Fixes #26503
BUG= http://dartbug.com/26503
R=lrn@google.com

Review URL: https://codereview.chromium.org/2002593002 .
 2016-05-20 14:29:14 +02:00
Lasse R.H. Nielsen 3a1a7c3968 Make Uri.parse("data:...") go through UriData.parse. 
It's safer to not try to do part normalization on data: URI content,
and it's likely to be faster to parse it only once.

This should also reduce the work done when parsing data: URIs using
Uri.parse.

BUG= https://github.com/dart-lang/sdk/issues/26280
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1994623002.
 2016-05-19 11:27:05 +02:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00
Lasse R.H. Nielsen 5d6e8bcda1 Make Iterable.generate use ListIterable as base implementation. 
This makes it work the same as a List like the documentation claims.

Update documentation of Future.doWhile, and a few other documentation fixes.

BUG= http://dartbug.com/26358
BUG= http://dartbug.com/26462
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1992713002.
 2016-05-18 13:52:10 +02:00
John McCutchan 84e1fe5cb5 Add an intrinsified early out path for Dart timeline calls 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1985813002 .
 2016-05-17 09:45:28 -07:00
Florian Loitsch 1be2f87236 Fix Iterable.where documentation by updating its signature. 
Fixes #26459
BUG= http://dartbug.com/26459

Review URL: https://codereview.chromium.org/1986243002 .
 2016-05-17 17:57:12 +02:00
Florian Loitsch 38bd7d586d Fix typo in doc. 
Fixes #26457
BUG= http://dartbug.com/26457

Review URL: https://codereview.chromium.org/1983103002 .
 2016-05-17 17:18:09 +02:00
Florian Loitsch 86fd2b62d1 Fix remaining strong-mode warnings and errors in dart:io. 
R=lrn@google.com

Committed: 493c70d2b0

Reverted: 49fe254ea2

Review URL: https://codereview.chromium.org/1971643003 .
 2016-05-17 12:55:11 +02:00
Florian Loitsch 1e3b98278a Make DoubleLinkedQueueEntry subclassable again. 
Also, add back the `remove` function that was accidentally removed.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1973903005 .
 2016-05-17 12:54:12 +02:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the" 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
 2016-05-13 12:38:25 -07:00
Greg Littlefield cd8124cdcf JS: Use direct function invocation when possible for calls with 4 or 5 args (#26268) 
* Use direct function invocation when possible for calls with 4 or 5 args

* Add test for Function.apply called with 0-5 arguments
 2016-05-13 10:13:46 -07:00
Harry Terkelsen 75797c0fef make linked_hash_map strong mode clean 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1965893008 .
 2016-05-12 13:27:41 -07:00
Florian Loitsch 49fe254ea2 Revert "Fix remaining strong-mode warnings and errors in dart:io." 
This reverts commit 493c70d2b0.

Review URL: https://codereview.chromium.org/1974043002 .
 2016-05-12 18:17:08 +02:00
Florian Loitsch ef6eaee42f Make DateTime comparable only to DateTime. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1972533003 .
 2016-05-12 18:06:22 +02:00
Alexandre Ardhuin 5f2c5b94ca Fix bad link (#26446) 2016-05-12 16:54:23 +02:00
Florian Loitsch 493c70d2b0 Fix remaining strong-mode warnings and errors in dart:io. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/1971643003 .
 2016-05-12 16:50:20 +02:00
Florian Loitsch e3c3f099ea Fix strong mode errors in dart:io. 
Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed: 5216f1d67d

Reverted: 7503ecc8fd

Review URL: https://codereview.chromium.org/1904553006 .
 2016-05-12 13:17:31 +02:00
Florian Loitsch 7503ecc8fd Revert "Fix strong mode errors in dart:io." 
This reverts commit 5216f1d67d.

BUG=

Review URL: https://codereview.chromium.org/1966373002 .
 2016-05-11 21:44:09 +02:00
Florian Loitsch e19addf23e Make dart:collection strong-mode clean. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1937103002 .
 2016-05-11 16:28:43 +02:00
Florian Loitsch fe1fda0766 Make dart:convert strong mode clean. 
Also removes the ChunkedConverter.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1964953003 .
 2016-05-11 16:15:31 +02:00
Florian Loitsch b828752fd7 Make dart:math strong mode clean. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1961993002 .
 2016-05-11 16:00:58 +02:00
Florian Loitsch 5216f1d67d Fix strong mode errors in dart:io. 
Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org/1904553006 .
 2016-05-11 14:30:32 +02:00
Florian Loitsch 5612898e23 Fix return-type for error-handlers in streams. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/1958143002 .
 2016-05-11 14:27:16 +02:00
Lasse R.H. Nielsen 63b71b4c24 Make _Future._chainForeignFuture not cause an assert. 
If the foreign future completes with a future, the following call to
_Future._completeWithValue would hit an assert in checked mode
(value is! Future). This change makes the _Future._completeWithValue flatten
incoming nesting futures before completing the _Future, ensuring that a
_Future never has a Future as value.

An alternative is to throw if the value of a future is another future.
That's what the assert does in checked mode, but we shouldn't be able to hit
an assert.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1966523003 .
 2016-05-11 13:10:46 +02:00
Stephen Adams 73c236a3a4 Revert "Library changes to align with DDC." 
TBR=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org/1970653002 .
 2016-05-10 19:42:51 -07:00
Stephen Adams 260eb5534a Library changes to align with DDC. 
Mostly adding a few types and formatting changes since DDC uses dartfmt.

R=floitsch@google.com, vsm@google.com

Committed: 308cb34a7c

Reverted: facb3eb9dc

Review URL: https://codereview.chromium.org/1952183002 .
 2016-05-10 18:38:19 -07:00
Stephen Adams facb3eb9dc Revert "Library changes to align with DDC." 
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1969643002 .
 2016-05-10 17:42:02 -07:00
Stephen Adams 308cb34a7c Library changes to align with DDC. 
Mostly adding a few types and formatting changes since DDC uses dartfmt.

R=floitsch@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/1952183002 .
 2016-05-10 17:36:16 -07:00
John McCutchan 4c97892885 Fix dart2js build 
BUG=

Review URL: https://codereview.chromium.org/1965053003 .
 2016-05-10 15:11:04 -07:00
John McCutchan 11f4a36e84 Fix dart2js build 
BUG=

Review URL: https://codereview.chromium.org/1968733002 .
 2016-05-10 14:59:28 -07:00
John McCutchan 62f9135490 Dart Timeline improvements 
- [x] Add _getThreadCpuClock to dart:developer.
- [x] Report CPU usage for Dart synchronous timeline blocks.
- [x] GetEnvironmentValue for 'dart.vm.product' will return "true" or "false" depending on whether or not we are running in product mode.
- [x] Early out of Dart timeline calls if we are running in product mode.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1966833002 .
 2016-05-10 14:31:33 -07:00
Florian Loitsch c67133d3ab Fix typo in Map.values getter. 
Fixes #26424.
BUG= http://dartbug.com/26424

Review URL: https://codereview.chromium.org/1960123002 .
 2016-05-09 14:57:37 +02:00
John C. Bland II 02651a9949 Thank you :) 
Thank you :)
 2016-05-07 21:51:19 +02:00
Stephen Adams 2266452244 Remove unused imports. 
BUG=

Review URL: https://codereview.chromium.org/1955193002 .
 2016-05-06 16:43:39 -07:00
Natalie Weizenbaum e41fb4cafd Fix some WebSocket strong-mode errors and warnings. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1952103002 .
 2016-05-05 10:19:57 -07:00
Florian Loitsch 2d8aac23bc Make Future.catchError return a typed Future. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1936343002 .
 2016-05-03 12:13:46 +02:00
Leaf Petersen bd323f27cd Fix async test failures. Remove test accidentally duplicated into the 
non-error path.

TBR=floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org/1936313003 .
 2016-05-02 11:59:50 -07:00
Leaf Petersen 47b0be761d Hide strong mode casts in dart:async, factor out try/catch blocks into helpers, and hide some reified generic type information. This brings AsyncStressTest back to parity as measured on my machine. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1914373003 .
 2016-05-02 11:02:46 -07:00
John McDole 8720ec869d Fix windows + gitbash (#25712) 
* work with gitbash

* gitbash

* gitbash

* gitbash

* gitbash
 2016-05-02 12:47:48 +02:00
Florian Loitsch c9397d0493 Fix BASE64URL documentation. 
Fixes issue #26353
BUG= http://dartbug.com/26353

Review URL: https://codereview.chromium.org/1928313002 .
 2016-04-29 11:52:14 +02:00
Alan Knight c5acca2ff0 Check for the case where previousNode fails in sanitization. Can happen with object tags 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1825373004 .
 2016-04-28 12:51:40 -07:00
Florian Loitsch b19e00c2d4 Fix Set.from which still had a generic type on the incoming Iterable. 
Follow-up fix for http://dartbug.com/21731
Also see https://codereview.chromium.org/838463002/

R=lrn@google.com

Review URL: https://codereview.chromium.org/1887883006 .
 2016-04-28 15:01:04 +02:00
Florian Loitsch e29ee5e0f6 Fix Iterable.empty documentation. 
Fixes #26357.
BUG= http://dartbug.com/26357

Review URL: https://codereview.chromium.org/1931633003 .
 2016-04-28 11:31:34 +02:00
Jacob Richman 09c607abfa Fix StackTrace performance issue that blocks using the new version of the stack_trace package that depends on StackTrace.current. The problem is the previous entry wasn't lazy about evaluating error.stack which destroys performance for cases where most of the time you don't end up caring about the stack trace. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1925453004 .
 2016-04-27 17:04:03 -07:00
Kevin Moore 27e8e1d1d8 make a field in _ConverterStreamEventSink final 
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1930593002 .
 2016-04-27 11:19:11 -07:00
Florian Loitsch 0253879a60 Make dart:async strong-mode clean. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1850273002 .
 2016-04-27 20:07:58 +02:00
Florian Loitsch 3874fc46c6 Revert "Don't include controller in the subscription linked list." 
This reverts commit 800228f823.

BUG=

Review URL: https://codereview.chromium.org/1931573002 .
 2016-04-27 20:06:54 +02:00
Florian Loitsch 800228f823 Don't include controller in the subscription linked list. 
R=leafp@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/1908963003 .
 2016-04-27 20:03:29 +02:00
Jacob Richman 6ef4eae35f Remove as checks bloating sample dart apps by 4K 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1923143002 .
 2016-04-27 08:53:48 -07:00
Florian Loitsch a96120243a Merge pull request #26330 from sethladd/library-level-import-docs 
add library-level docs to help with importing
 2016-04-27 14:01:01 +02:00
Zachary Anderson ba550f1c43 Fixes NetworkInterface.list crash on Android 
Previously, Socket::ListInterfaces failed to set the os_error out
parameter causing a crash in the caller. This change sets an error here.

I've also added NetworkInterface.listSupported, which returns false on
Android, and true everywhere else. ifaddrs.h continues not to exist in
the NDK, so in order to support NetworkInterface.list, we'd have to
reimplement it, or find a suitable reimplementation somewhere.

related #26329

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1916223003 .
 2016-04-26 07:48:58 -07:00
Florian Loitsch 516c09cb1f Fix documentation for identity collections. 
BUG= http://dartbug.com/26326

Review URL: https://codereview.chromium.org/1922083002 .
 2016-04-26 11:35:30 +02:00
Alan Knight dad1a74d2e Oops, movementX/Y are private. Fix template 
BUG=

Review URL: https://codereview.chromium.org/1916203002 .
 2016-04-25 13:26:14 -07:00
Seth Ladd a875749e82 add library-level docs to help with importing 2016-04-25 12:41:24 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix 
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
 2016-04-25 12:35:03 -07:00
Alan Knight 290a250be3 Move annotation_Creates_SerializedScriptValue into dart2js-specific code 
BUG=

Review URL: https://codereview.chromium.org/1918963002 .
 2016-04-25 10:52:02 -07:00
Florian Loitsch 80d0cac6a3 Fix Iterable.first documentation. 
Fixes #26319.
BUG= http://dartbug.com/26319

Review URL: https://codereview.chromium.org/1919863002 .
 2016-04-25 16:36:20 +02:00
Florian Loitsch 111a794141 Fix documentation for identity hashmap. 
Fixes 26326.
BUG= http://dartbug.com/26326

Review URL: https://codereview.chromium.org/1921663002 .
 2016-04-25 15:56:32 +02:00
Terry Lucas 8f7b8a9d87 Update to new Webkit additions for custom elements 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
 2016-04-22 12:53:36 -07:00
Jacob Richman 7fdce7a2f0 Use _downcast and _cast instead of "as" to reduce dart2js output size. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1914583002 .
 2016-04-22 11:09:01 -07:00
Jacob Richman 819ed4bb60 Fix strong mode errors in SVG 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903893003 .
 2016-04-21 12:45:08 -07:00
Florian Loitsch 1e574a1ffc Fix void foo(..) => ... to use { } instead. 
Fixes issue 26292.
BUG= http://dartbug.com/26292
R=lrn@google.com

Review URL: https://codereview.chromium.org/1908943004 .
 2016-04-21 21:35:17 +02:00
Jacob Richman 25b88eabe5 Fix indexed_db strong mode warnings. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903973002 .
 2016-04-21 10:03:53 -07:00
Jacob Richman 9ffe1c2450 Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input"); 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1904903003 .
 2016-04-21 09:54:18 -07:00
Zachary Anderson ccfd19bfd7 Fixes memory leak of async directory lister 
R=iposva@google.com

Review URL: https://codereview.chromium.org/1893033002 .
 2016-04-21 07:57:02 -07:00
Florian Loitsch 84ec63e9fc Make dart:core strong-mode clean. 
R=leafp@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/1895473004 .
 2016-04-21 14:01:48 +02:00
Florian Loitsch 4be9d36961 Make dart:internal strong-mode clean. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1890323002 .
 2016-04-21 13:53:51 +02:00
Jacob Richman 777e1a386e Revert "Remove the generics from _FrozenElementList: causes checked mode failures" 
This reverts commit 7824ac771b.

BUG=

Review URL: https://codereview.chromium.org/1909613003 .
 2016-04-20 18:50:11 -07:00
Zachary Anderson 943c69f408 Fix file fuzz test failure 
R=iposva@google.com

Review URL: https://codereview.chromium.org/1903733006 .
 2016-04-20 14:05:27 -07:00
Jacob Richman b546d05362 TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent. 
BUG=

Review URL: https://codereview.chromium.org/1908603002 .
 2016-04-20 10:41:56 -07:00
Zachary Anderson 218545ba10 Fixes leak of native File objects. 
Also employs the same reference counting technique as secure sockets to
avoid the IO Service touching dangling pointers.

R=iposva@google.com

Review URL: https://codereview.chromium.org/1892623002 .
 2016-04-20 10:08:37 -07:00
Jacob Richman 068252e721 Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart 
BUG=

Review URL: https://codereview.chromium.org/1903033002 .
 2016-04-19 16:42:16 -07:00
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
John McCutchan 6c33c4b1be Avoid an empty Map allocation in the dart:developer Timelnie API 
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1888813002 .
 2016-04-19 12:29:43 -07:00
Terry Lucas e8fd9f5c1f The patch file cached_patches.dart generated from C++ with special dartium switch --enable-blink-features=dartGenCachedPatches 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1898163002 .
 2016-04-19 08:32:50 -07:00
Alan Knight 810faa31b9 Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) 
BUG=

Review URL: https://codereview.chromium.org/1885943002 .
 2016-04-16 16:26:14 -07:00
Alan Knight 7824ac771b Remove the generics from _FrozenElementList: causes checked mode failures 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1891543005 .
 2016-04-14 15:14:40 -07:00
Terry Lucas 74ddf84ffd Remove MutationEvent bad entries in both removed list and renamed list 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1890983002 .
 2016-04-14 13:49:42 -07:00
Alan Knight 48d73a66e0 Fix MutationEvent class name 
BUG=

Review URL: https://codereview.chromium.org/1888693004 .
 2016-04-14 09:56:07 -07:00
Alan Knight a790d5ac12 Regenerate libraries after CL 1876363006 
BUG=

Review URL: https://codereview.chromium.org/1879233006 .
 2016-04-13 15:18:03 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Committed: 65fe0a5383

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
Stephen Adams a05620f5b5 dart2js: Improve performance of nested yield* 
Avoid O(n^2) behaviour in the following code by tracking the innermost sync* iterator rather than the outermost.

from(n) sync* {
  yield n;
  yield* from(n + 1);
}

main() {
  print(from(0).take(1000));
}

R=floitsch@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org/1873413002 .
 2016-04-13 14:24:02 -07:00
Zach Anderson 522ce88fe6 Implements remaining SecurityContext calls for iOS 
BUG=
R=asiva@google.com, iposva@google.com

Review URL: https://codereview.chromium.org/1852783003 .
 2016-04-13 10:27:39 -07:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."" 
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
 2016-04-12 17:16:06 -07:00
Florian Loitsch 50bdab3841 Steps towards making the convert library strong-mode compliant. 
This version has a few deprecated methods. In a future release they will be removed.

See https://codereview.chromium.org/1827803002 for the final patch (once the deprecated methods have been removed).

R=leafp@google.com, lrn@google.com

Committed: 4ab1219bf9
Reverted: 045a375366

Review URL: https://codereview.chromium.org/1847843002 .
 2016-04-12 20:59:21 +02:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects." 
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
 2016-04-12 11:28:05 -07:00
Terry Lucas 7146915ea8 Breaking Change: Support @JS at library level 
R=jacobr@google.com
TBR=asiva@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/1871573002 .
 2016-04-12 10:29:49 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
 2016-04-12 10:23:32 -07:00
Sam Rawlins ad194b7dc1 Fixing JSON comments. In particular: 
* Link to ECMA 404 here: https://api.dartlang.org/stable/1.15.0/dart-convert/JsonUtf8Encoder/JsonUtf8Encoder.html
* Fix codeblock syntax: https://api.dartlang.org/stable/1.15.0/dart-convert/JSON-constant.html
* Fix Søren's final comment from https://codereview.chromium.org/195203002/

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/1868073005 .
 2016-04-11 10:59:06 -07:00
Florian Loitsch 045a375366 Revert "Steps towards making the convert library strong-mode compliant." 
This reverts commit 4ab1219bf9.

Review URL: https://codereview.chromium.org/1881553002 .
 2016-04-11 19:52:57 +02:00
Florian Loitsch 4ab1219bf9 Steps towards making the convert library strong-mode compliant. 
This version has a few deprecated methods. In a future release they will be removed.

See https://codereview.chromium.org/1827803002 for the final patch (once the deprecated methods have been removed).

R=leafp@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/1847843002 .
 2016-04-11 19:16:04 +02:00
Jacob Richman 1536c671f5 Add support for switching library from the chrome devtools console. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1865803004 .
 2016-04-07 11:14:47 -07:00
Lasse R.H. Nielsen 3f0ad9d4f2 Add "url-safe" encoding to base64 in dart:convert. 
Fixes issue #24813.
Doesn't add a second codec. The codec is unimportant,
only the BASE64 and BASE64URL constants need to be public anyway.

BUG= http://dartbug.com/24813
R=floitsch@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org/1858113003.
 2016-04-07 16:36:14 +02:00
Terry Lucas c95b9875ef Fix registerElement for HTMLElement prototype should not change it's m_type 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1857343002 .
 2016-04-05 11:59:28 -07:00
Florian Loitsch 71fe450dbf Fix sample code in dartdoc. 
Thanks to gsathya.

Fixes #26185.

Review URL: https://codereview.chromium.org/1865473003 .
 2016-04-05 20:47:29 +02:00
Zach Anderson b0475caa7f Allows adding trusted certs on iOS. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1845273004 .
 2016-03-31 15:51:14 -07:00
Zach Anderson 08450dc432 Begin work on ios secure sockets 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1839123003 .
 2016-03-31 12:55:31 -07:00
Alan Knight 0f5c249f22 Fix webgl methods, properly this time 
BUG=

Review URL: https://codereview.chromium.org/1846803002 .
 2016-03-31 09:45:32 -07:00
Jacob Richman 3cb280c5e1 Fast path Location.hash as some apps call it 10000+ times a frame. 
BUG=

Review URL: https://codereview.chromium.org/1847543003 .
 2016-03-31 09:04:10 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Zach Anderson 5cee7ff634 Fixes handling of short reads/writes for Mac SSL 
The SecureTransport API is a bit finicky about the return code
and length from SSL{Read,Write}Callback. I think I've got it
right now, but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104

R=iposva@google.com

Review URL: https://codereview.chromium.org/1842703003 .
 2016-03-29 10:30:09 -07:00