This reverts commit 0b10bfcde9.
Reason for revert: testing the branch alignment process
Original change's description:
> [infra] "Bad" commit to test the branch alignment process
>
> This is an empty commit that is labled "Bad" to test the branch
> alignment process when there are roll blockers, it will be reverted on
> the beta branch.
>
> Change-Id: Id12a64e0c1d0f900f95f3bb1a477c13e141e65c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338920
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Ilya Yanok <yanok@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I45b99d2b122cc40baa9b0cda44ae2199ab4dba96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339120
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
I left the mixin structure because Danny and I plan to use the same
structure to start adding LSP-specific test coverage.
Change-Id: I2eefc05c01eadb67f2c95fcaed3e5a963df7d69b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This may seem to be a silly change, adding these lists only for the
error fix status file, but I claim this is a very pragmatic solution:
* It is important and beneficial to correctly track error fix
statuses; I was recently confused about these fix statuses because
the text in the fix status file was a lie.
* When fixes are added for more errors, you cannot forget to update
the codesWithFixes list because the fix won't apply (and no test
asserting the fix works would pass).
* Overhauling these FixGenerators to use maps like the others is maybe
a good change in the long run, but at this point might be
over-engineering; we only have fixes for 2-3 codes for each file
type.
Change-Id: Iaa902acf2401f97ff722e222910f5d6fcd00a5ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
I'm not crazy about the re-constitution of `File`s (see the TODO) but I'm not sure this is a yak we want to shave now (especially since this handler is not yet in use).
Larger context: https://github.com/dart-lang/sdk/issues/53876
Change-Id: I4b9814842525ed4440aa39a7d14baa75f526f72a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Allows FFI to reuse FlowGraphCompiler::EmitMove in contexts where the delta between SP and FP isn't accurately described by StackSize.
TEST=dart2js codesize unchanged
Change-Id: Idf0643af3debfc77564672d6d16491990b87611c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339040
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
The analyzer currently resolves constructor comment references in the
formal parameter scope which doesn't include field or super
formal parameters, so super parameters referenced in comments
weren't resolved.
To fix this, this CL instead resolves constructor comment references
in the initializer scope which includes all parameters.
Fixes https://github.com/dart-lang/sdk/issues/51578
Bug: https://github.com/dart-lang/sdk/issues/51578
Change-Id: Idb80957b54ee9d57c36d37142188e7c833ce77f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338741
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Conditional constant propagation doesn't update environments and may
also replace redefinition instructions with constants
without updating environment uses of their original definitions.
This causes discrepancy between arguments of a call and its environment.
It is harmless and corresponding check in the flow graph checker can be
relaxed.
TEST=runtime/tests/vm/dart/regress_54128_test.dart
Fixes https://github.com/dart-lang/sdk/issues/54128
Change-Id: I6e68e0525b7f110400435ac071934dd9a02eebd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338941
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
Was failing to compile because `array` was a List<A> so indexSet on line 32 was invalid.
Change-Id: I555a2c341e0d9dec5e85d92ecc855d073f134694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339060
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
- Use YamlNode to access spans and offsets instead of casting.
- Add logic to merge conflicting edits when removing multiple entries
from dev_dependencies.
Change-Id: I1f20b5a4691c37e9f56293acbaf870a489380b9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338592
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
This allows me to use IntelliJ's built in testing support when working on the analyzer.
Change-Id: Ie7c072b06d0eeaf2be10433604519714fe79a01e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339020
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
This tells the formatter to parse files at language version 3.3 so that
extension types can be parsed correctly.
Change-Id: I0f937802c38c5542407a33192ad71fcbe7ceec89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339041
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
These tests are flaky and don't add much useful test coverage to the
Observatory service test suite. Equivalent, non-flaky versions of these
tests are under the pkg/vm_service test suite.
Fixes https://github.com/dart-lang/sdk/issues/53373
TEST=Removing tests
Change-Id: Iadb5f296387bff687cb06fbdfb3379eba05b9afa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338981
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
Change-Id: Ibbcc36c72d40fd466f735ec098eaf1365cf5fb96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338980
Auto-Submit: Nate Biggs <natebiggs@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
The locally available libraries will usually be a different versions than the libraries on the bots.
Change-Id: Ic1f954346e2ca7b5563b2a9f20f4c466d1f4f16a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338425
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This is an empty commit that is labled "Bad" to test the branch
alignment process when there are roll blockers, it will be reverted on
the beta branch.
Change-Id: Id12a64e0c1d0f900f95f3bb1a477c13e141e65c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338920
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Ilya Yanok <yanok@google.com>
Reviewed-by: William Hesse <whesse@google.com>
It was ignoring NNBD mode for the loaded component and
transforming sound NNDB code in the unsound mode.
TEST=manually tested that it fixes internal problem
R=kustermann@google.com
Change-Id: I17986d2e12bf19c12e28032dc042932ffd40470d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
This change prevents `TODO` comments in pkg/kernel from showing up in
Visual Studio Code's "problems" view, which makes it much easier to
see errors, warnings, and lints in that view.
With this change, Visual Studio Code now treats `TODO` comments the
same in `pkg/kernel` as they are treated in `pkg/_fe_analyzer_shared`,
`pkg/front_end`, and `pkg/analyzer`.
Change-Id: Ifeff026b9cf5ef13c8b1a4382a82441175165374
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338589
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
E.g.
```
final bool foo = (1+1==2) ? true : false;
if (foo) {
if (foo) {
print("always true");
}
if (!foo) {
print("always false");
}
}
```
Inside the first if we know `foo` to be true, so there's no reason to do
more if's on it.
Change-Id: I87d0827c47ce0e7277d951c0ec28f19dff09767a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338780
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Implementation of stores and their inlinings had some
stuff left over their since Dart 1:
* No need to insert null-checks (in sound null-safety mode).
* Since Dart 2 there is no need to insert (speculative)
cid checks. Inputs are guaranteed to be a value of a
supported implementation type. Inserting narrow speculative
checks for Smis is actually leads to worse code in JIT.
* There is no need to convert incomming integer values to
smaller representation - the store will take care of it. This was
left over from Dart 1 times when incomming integer could be _Bigint.
TEST=existing tests
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-release-simarm_x64-try,vm-aot-linux-release-arm64-try,vm-aot-linux-release-x64-try,vm-aot-mac-product-arm64-try,vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-android-release-arm_x64-try,vm-aot-android-release-arm64c-try
Change-Id: I72cdaaecc524f1dccc63825df4f7b71241ab47a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338600
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Avoid copying JS string to Dart.
The test co19/LibTest/convert/Latin1Codec_A01_t01 throws a lot of
exceptions. Before this patch it runs in d8 in 4.1s, after it runs in
1.5s.
Change-Id: I1b9bf06876d63e92c93a03cdbf14587e369978ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338400
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Includes a cleanup of the errors reported for duplicate instance field.
Previously, in addition to reporting the duplicate, we would report that
the field cannot be used because it is a duplicate and that the
duplicate field hasn't been initialized.
Closes#53467Closes#53320
Change-Id: Ifd94223500809f3be36a1345d9d0c409778eed8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336885
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Also fix for Windows.
Change-Id: I22133cebdc57de5c63248f4e547212d6c8ddaaef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338647
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
