Commit graph

5 commits

Author SHA1 Message Date
Devon Carew 58392c017a [pkg/status_file] analyze using package:lints
Change-Id: Iac4401d92f21fc1edd49e3abd9fc6c5474337cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250769
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2022-07-06 22:48:35 +00:00
Robert Nystrom 9e4cbbbe78 Migrate pkg/status_file to null safety.
Change-Id: Ic6627a64a3ee72a6f14aadf59ee87e21e64e3664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209781
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-08-12 20:33:30 +00:00
Kevin Moore 94abf948c4 pkg:status_file misc cleanup
Clarify in the pubspec that it's not published
Cleaned up hints/lints in source files

Change-Id: Ifbf59ab0fb219dcdf5de99eced0a0129e6e191cb
Reviewed-on: https://dart-review.googlesource.com/61909
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-06-22 16:42:27 +00:00
Morten Krogh-Jespersen 39c399ca98 Add normalizer to normalize status files.
The test in this CL will test if the transformation of a status file produce an
equivalent status file. It does this by checking the number of entries and
making sure to find ONE entry in the produced status file.

As an invariant it needs that no duplicate entries exists in sections.

Bug:
Change-Id: I6aec3b20ef1bca89d6a7cf72d85487a95c3d1f0a
Reviewed-on: https://dart-review.googlesource.com/21341
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-01 09:10:51 +00:00
Morten Krogh-Jespersen 14ae756623 Linting for status files.
This both works as a tester for correct canonicalization of status files and can
be used later to check if changes to status files follow the guide lines.

It checks that:
- Comments only exists before a section or after a test path entry.
- That there are no disjunctions in headers.
- That variables and clauses are correctly ordered in section headers.
- That paths are alphabetically ordered in sections.
- That sections are lexicographically ordered with respect to negation.

Bug:
Change-Id: I0f5e2cc16f20bb48ee53a9a55a22aaab710e32ff
Reviewed-on: https://dart-review.googlesource.com/17786
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-09 01:48:03 +00:00