Commit graph

39548 commits

Author SHA1 Message Date
Jacob Richman
b779679721 Switch to @patch annotation from patch.
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2233633002 .
2016-08-10 09:31:06 -07:00
Brian Wilkerson
38689cd848 Fix errors introduced by recent strong-mode changes
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2233913003 .
2016-08-10 09:12:49 -07:00
William Hesse
9d2ab4d016 Change location of sysroot download so bot doesn't erase it.
BUG=https://github.com/dart-lang/sdk/issues/27048
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org/2230333002 .
2016-08-10 18:06:05 +02:00
William Hesse
ab74e91c51 Fix error in SDK build script
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2233923002 .
2016-08-10 17:34:19 +02:00
William Hesse
81f2226225 Change SDK builder bot to use sysroots when compiling
BUG=https://github.com/dart-lang/sdk/issues/27048
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2231073002 .
2016-08-10 17:28:21 +02:00
William Hesse
ae7b38799c Add tools to build Dart with Chromium's sysroot.
This downloads and uses the Debian Wheezy sysroot used by chromium,
when building Dart.  The resulting dart runtime requires libc version
2.14, and building without the sysroot requires libc version 2.16

BUG=https://github.com/dart-lang/sdk/issues/27048
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2230083005 .
2016-08-10 16:04:03 +02:00
Brian Wilkerson
07850a6562 Remove false positive from override hint
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2228233003 .
2016-08-10 06:12:41 -07:00
Johnni Winther
32bcf1e3b2 Fix string_interpolation tests.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2230823002 .
2016-08-10 11:39:25 +02:00
Johnni Winther
5af09978e7 Fix Resolution.getResolvedAst for serialization in production mode
- and split analysis_test into 4 subtests.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2220333007 .
2016-08-10 10:30:05 +02:00
Konstantin Shcheglov
de837749a2 Basic linking in PubSummaryManager.
Many features are not implemented yet, but I'd like to show to you and
if it a step in the correct directlion, land it.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2226973005 .
2016-08-09 18:03:13 -07:00
Florian Schneider
eb600a9af6 VM: Add more array intrinsics.
Make building array intrinsics a little easier for future additions.

For now I added a few that are frequently used in Flutter.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2235433002 .
2016-08-09 17:38:53 -07:00
John Messerly
1c7aca0d6d fix #25944, improve Future.then inference
also fixes #25322, return values of async functions are T | F<T>

R=leafp@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2208953002 .
2016-08-09 16:04:26 -07:00
Zachary Anderson
bf085120f6 Revert: Fixes leak of duplicate command line environment strings
For bot crashes on Mac

Review URL: https://codereview.chromium.org/2229973002 .
2016-08-09 15:36:57 -07:00
Zachary Anderson
92abe83b26 Fixes memory leaks in the eventhandler
These probably only happen when the VM is going down after an unhandled
exception, but I want to fix them anyway.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2228503007 .
2016-08-09 15:20:50 -07:00
Carlo Bernaschina
9ce171ac33 Converted Observatory cpu-profile element
Fixes https://github.com/dart-lang/sdk/issues/26043

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2204563003 .
2016-08-09 14:34:00 -07:00
Terry Lucas
f19bbb0ea5 Updated to WebKit, Dart_Initiaize change
BUG=asiva@google.com,vra@google.com

Review URL: https://codereview.chromium.org/2229953002 .
2016-08-09 14:21:11 -07:00
Ryan Macnak
a0df7275d6 Use log prints for simulation tracing and fix --disassemble-stubs.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2229553005 .
2016-08-09 14:03:29 -07:00
Carlo Bernaschina
a5443086a0 Converted Observatory isolate-summary element
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2217723004 .
2016-08-09 13:15:21 -07:00
Matthias Hausner
f56654e882 Put patch syntax warning behind a flag
Fixes Dartium tests, which choke on the additional output introduced
by the warning.

TBR=vegorov

Review URL: https://codereview.chromium.org/2233493002 .
2016-08-09 13:01:12 -07:00
Adam Barth
fac99f35b3 Switch Dart_Initialize to use a struct
The number of NULL parameters was getting out of hand.

R=zra@google.com

Review URL: https://codereview.chromium.org/2223463003
2016-08-09 12:25:39 -07:00
Adam Barth
bd41127c7f Revert "Switch Dart_Initialize to use a struct"
I landed the wrong version of my patch.

This reverts commit bdc25d5695.
2016-08-09 12:24:13 -07:00
Adam Barth
bdc25d5695 Switch Dart_Initialize to use a struct
The number of NULL parameters was getting out of hand.

R=zra@google.com

Review URL: https://codereview.chromium.org/2223463003 .
2016-08-09 12:20:16 -07:00
Brian Wilkerson
b29c6bf330 Suppress follow-on errors when a file is imported with either a prefix or a show clause
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2226613004 .
2016-08-09 11:11:39 -07:00
Paul Berry
1229cb7ee9 Make API signature based only on unlinked data.
Note that this is safe because linked data can be fully derived from
unlinked data.

This should make it more useful for the PubSummaryManager, which only
stores unlinked data at the moment.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2228083002 .
2016-08-09 10:18:38 -07:00
John Messerly
eafe459b0e fix #26896, mark all @proxy ops as dynamic
This was already working for calls/methods because we fail to get a FunctionType. But it wasn't working for other cases like operators.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2223343002 .
2016-08-09 10:15:03 -07:00
Konstantin Shcheglov
6df5ea27a5 Revert 6ad38498c8 (PARSED_UNIT).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2231473002 .
2016-08-09 10:14:18 -07:00
Matthias Hausner
e11ca24053 Use metadata annotation @patch for patch classes
Annotate patch classes and top-level patch functions with @patch
instead of the pseudo-keyword patch. This allows the analyzer
to read patch files, and matches the syntax that dart2js uses.

The deprecated syntax is still supported, but a warning is printed when detected.

BUG=

Review URL: https://codereview.chromium.org/2220883004 .
2016-08-09 09:48:03 -07:00
Paul Berry
902ce5e739 Record information about a summary's dependencies in the summary itself.
The idea is that we can use this information to help discover related
summary files, and determine when summaries need to be re-linked.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2226093002 .
2016-08-09 09:31:04 -07:00
Konstantin Shcheglov
43fef756ae Provide LINE_INFO from ResynthesizerResultProvider.
Also, to guarantee that LINE_INFO is computed, we need to replace
context.getLineInfo() with context.computeLineInfo() in the server.
This should be equivalently fast in both summary (from provider) and
non-summary cases (the source should have been scanned and parsed in
order to resolve references to its elements).

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2225893003 .
2016-08-09 09:12:24 -07:00
John Messerly
8e9b77dd42 fix #26155 - optional param passed to positional was not inferred
R=vsm@google.com

Review URL: https://codereview.chromium.org/2230513002 .
2016-08-09 09:10:44 -07:00
John Messerly
cdcc426f82 fix #26139, allow inferring a more precise return type
we were losing a lot of information on statement lambdas

R=vsm@google.com

Review URL: https://codereview.chromium.org/2225413002 .
2016-08-09 08:49:24 -07:00
William Hesse
1077b24c31 Restart bots after master restart
TBR=scheglov@google.com
BUG=

Review URL: https://codereview.chromium.org/2218413005 .
2016-08-09 17:12:58 +02:00
Konstantin Shcheglov
c35fb3c79d Initial implementation of pub summary manager.
For now we just generate unlinked, spec summaries.
We don't use them.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2220703002 .
2016-08-09 07:18:52 -07:00
Lasse R.H. Nielsen
3502fd5fd7 Revert "Reapply fast-URI patch."
Seems to trigger VM bug.

Review URL: https://codereview.chromium.org/2225243003 .
2016-08-09 12:51:58 +02:00
Aleksei Semenov
c9081ea4df initial support for running tests against dart analyzer in strong mode (#27033) 2016-08-09 10:58:15 +02:00
Lasse R.H. Nielsen
99e94db85b Reapply fast-URI patch.
R=whesse@google.com

Review URL: https://codereview.chromium.org/2220373002 .
2016-08-09 09:38:47 +02:00
Kevin Moore
3c2fcdd3c3 pkg/compiler: clean up imports
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2223133003 .
2016-08-08 19:28:01 -07:00
Sigmund Cherem
b995d06a12 dart2js: fix bot failures - I made this private without realizing it was accessed for testing
TBR=het@google.com

Review URL: https://codereview.chromium.org/2226173002 .
2016-08-08 18:19:35 -07:00
Kevin Moore
f33edeafe1 pkg/compiler: remove samples
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2221243002 .
2016-08-08 17:10:44 -07:00
Sigmund Cherem
eac954b3dc Introduce a bazel provider
R=het@google.com

Review URL: https://codereview.chromium.org/2204593010 .
2016-08-08 16:57:19 -07:00
Konstantin Shcheglov
6ad38498c8 Extract unresolved AST parsing (PARSED_UNIT1) from full parsing, which includes UriBasedDirective(s) resolution.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2229603003 .
2016-08-08 14:45:27 -07:00
Kevin Moore
406d5e0c48 pkg/compiler: fix imports
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2221893003 .
2016-08-08 14:41:50 -07:00
John Messerly
ed416bb6cb fix #26393, treat tear offs as definite functions
R=vsm@google.com

Review URL: https://codereview.chromium.org/2212233003 .
2016-08-08 14:29:20 -07:00
Stephen Adams
101a83f2f4 dart2js: Reduce overhead of --verbose measurements
ZoneSpecification and zoneValues are now per-task, rather than per measurement.
This reduces total LinkedHashMap allocations by 30%

In the large compile I am using to measure these things, there are still
~3M zones created via Zone.fork and 10M _ZoneFunction objects allocated, and the Zone.fork copies the (now cached) LinkedHashMap.
So cross-task measurements are still quite expensive.

R=ahe@google.com
BUG=

Review URL: https://codereview.chromium.org/2133913002 .
2016-08-08 14:18:21 -07:00
Paul Berry
281322870e Rework linker tests to use SummaryDataStore.
Also add a test to make sure that things work properly when one
summary has a dependency on another.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2225163002 .
2016-08-08 13:58:33 -07:00
Sigmund Cherem
be28b088d6 Split js_backend into multiple libraries.
R=sra@google.com

Review URL: https://codereview.chromium.org/2220993005 .
2016-08-08 13:33:06 -07:00
Carlo Bernaschina
4329f962b2 Converted Observatory isolate-reconnect element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2202973002 .
2016-08-08 13:07:08 -07:00
Zachary Anderson
82cb63e70f Fixes leak of duplicate command line environment strings
R=asiva@google.com

Review URL: https://codereview.chromium.org/2222013002 .
2016-08-08 12:53:26 -07:00
Zachary Anderson
1c6d8fd4ec Fuchsia: Fix arm64 build
R=asiva@google.com

Review URL: https://codereview.chromium.org/2226843002 .
2016-08-08 12:43:13 -07:00
John McCutchan
5a2193ecc4 Fix Windows build
BUG=

Review URL: https://codereview.chromium.org/2223863003 .
2016-08-08 12:30:37 -07:00