Passing an empty map signals that the environment is empty and constants should
be evaluated.
Change-Id: I5611a2be81786aa7d42e24022198d52c60558cc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110748
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
In retrospect I probably should have made this three separate CLs, and
I'm happy to go back and do so if you'd prefer.
Change-Id: I816bbbc16794c86129c9b6501db4a5dce2a8e199
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110480
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
I'll add unit tests when the check is implemented. Note that there are
both co19 and language tests for this case.
Change-Id: Iad8499a32a6f21a58739b3179167ccce384afc86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
The identifier `in` is a reserved word and hence cannot be used as a variable name.
Change-Id: I557430e1f87573d19bfb22d7c09120139baa3731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110581
Reviewed-by: Leaf Petersen <leafp@google.com>
Supports markers like `cfe|analyzer.` to annotated that the expected
result is for both `cfe` and `analyzer`.
Change-Id: Ie69809db5f63a9ee9b87ff1513b819fe85ce0bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110500
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
The many different entrypoints to the CFE have repeatedly shown problems
with targets that do not support unevaluated constants being used
without providing an environment.
Making the targets opt-in to supporting unevaluated constants will
give the users of CFE early notice that CFE is used inconsistently
(as opposed to the backends failing when they happen to see an
UnevaluatedConstant node that they don't support).
Change-Id: I98c80df3a551823598e413e2895f5649f22f7c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110561
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
This avoids the recomputation of constant node indices on every
constant reference.
Closes#37611
Change-Id: I376a8cdb55da75e9050c544dc60d20eb7685c0c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110563
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
When creating a dynamic invocation forwarder, the VM clones the original
function object and then modifies the clone to create the forwarder.
Previously, the is_native flag was left untouched, but now it is
properly cleared.
Change-Id: I133ffdc0d0d3d727f7b7e47af22944e6b0574ee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110721
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Instead of hand-writing S-expression output in the methods used by the
serializer, just create an appropriate S-expression data structure (with
handling of extra info maps) that handles serialization.
Bug: https://github.com/dart-lang/sdk/issues/36882
Change-Id: I9b56827d7452271de4b32c0c01cc2e4c4bcc0367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109706
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
ABI compatibility was broken by this change:
https://dart-review.googlesource.com/c/sdk/+/108723
The change is backwards incompatible, so we can't support any versions
older than this. We should have bumped the version when the CL was
submitted, but the bot failure was misidentified as a timeout.
Bug: https://github.com/dart-lang/sdk/issues/37630
Change-Id: I3b5563ab27f40b0876b5b7682e15e2b7d7408c2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110541
Auto-Submit: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
The test infrastructure only runs tests whose name ends in "_test.dart".
Change-Id: I42bde31cf49318b87c270b4df9cc71fd9b89999c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110460
Reviewed-by: Leaf Petersen <leafp@google.com>
Revert this change once fixes have landed for DDK.
Issue: #37523
Change-Id: I2855c647ceb5b9831466d8da458e6e7bcd810ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110543
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Changes from original CL:
* Removed service_undocumented.md
* Removed generation of wrappers for undocumented RPCs
* Cleaned up generation code which was used for generating wrappers for undocumented RPCs
* Removed JARs from pkg/vm_service/java/third_party
This reverts commit 477a3c4748.
Change-Id: I8d36733c8b2602e4935c3f23698d3f7c97a20187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110135
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Local test run after running `gclient sync`:
ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!
Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Bug: https://github.com/dart-lang/sdk/issues/37631
These tests cause the dart2js batch mode compiler process
to resist termination somehow on Windows, which locks the dart.exe executable
and prevents sharding task cleanup.
Change-Id: Ica19e9d262f0b5b97c263205ba6fac030a3bedb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110444
Reviewed-by: Ryan Macnak <rmacnak@google.com>
