languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 15:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
52806 commits 11 branches 6011 tags 1.4 GiB
Commit graph

1505 commits

Author SHA1 Message Date
Terry Lucas bfea069823 Test possible keyevent fix. 
Change-Id: I3f90979fad2681775cae56d499f3ff5968ea6485
Reviewed-on: https://dart-review.googlesource.com/29545
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-14 21:22:39 +00:00
Terry Lucas 642b768e87 Fixed default parameter messagePorts for MessageEvent factory. 
R=vsm@google.com

Change-Id: Ic94ccbe4c29302e44c58791658ce75dff86d9ac2
Reviewed-on: https://dart-review.googlesource.com/29544
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-14 18:21:25 +00:00
Terry Lucas 529add3834 DDC fix to expose classes which are only created inside of the browser. 
R=vsm@google.com

Change-Id: I27ede73ac84a72ee9b5e8b3b0a706ade82b2aa59
Reviewed-on: https://dart-review.googlesource.com/25500
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-13 03:03:09 +00:00
Vijay Menon b8cd835bb9 Workaround CFE instantiate-to-bounds bug 
This avoids #31566 for now.

Change-Id: I5f2ea0cf0ad15a534c1c62182bdca36fc3b0b103
Reviewed-on: https://dart-review.googlesource.com/26760
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-06 21:34:11 +00:00
Leaf Petersen 8f199377fa Remove generic method comment syntax from dart:html. 
This removes the last uses of the generic method comment syntax from
the SDK.  There are no additional explicit casts or reified generics
(other than those implied by reifying generic methods) in this CL.

Bug:
Change-Id: Icae23cac60869243cb3ba441f86d70422f68178f
Reviewed-on: https://dart-review.googlesource.com/26081
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2017-12-06 21:26:04 +00:00
Paul Berry 316f2b429f Strong mode fixes to DDC SDK 
Change-Id: I40508c686014f28772109fdfd10c68b986b40be6
Reviewed-on: https://dart-review.googlesource.com/25140
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-12-01 19:58:07 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Stephen Adams 7686dce346 Replace _downcast and _cast with local downcasts (dart:html) 
Change-Id: I4282b20aac07da125805a2654da072742dbbdd0b
Reviewed-on: https://dart-review.googlesource.com/20300
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-11 00:09:38 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Terry Lucas 352f9fd859 Fixed bad indent not flushing emitted files. 
Removed Dartium code emission.

TBR: alanknight@google.com,vsm@google.com
Change-Id: Ib027f542b238c90311f6838e67b4b8d27815374c
Reviewed-on: https://dart-review.googlesource.com/3280
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-05 14:43:08 +00:00
Florian Loitsch ee46026671 Don't use LinkedList in the core libraries anymore. 
R=lrn@google.com

Committed: fe17b5b2bc
Reverted: 5d4a786f44
Review-Url: https://codereview.chromium.org/2975443002 .
 2017-07-28 21:14:11 +02:00
Bob Nystrom 012774c78e Remove Dartium support from test.dart. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2981223002 .
 2017-07-20 12:46:50 -07:00
Vijay Menon 12e32e230d Add hook to register global object 
DDC will use this in a later CL.

R=alanknight@google.com, sra@google.com

Stephen: I assume this will get compiled out be dart2js.
Review-Url: https://codereview.chromium.org/2983813002 .
 2017-07-19 05:46:07 -07:00
Alan Knight 0700adc633 Fix the go.sh script for a completely new repo. 
BUG=

Review-Url: https://codereview.chromium.org/2981193002 .
 2017-07-18 13:44:08 -07:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium) 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
 2017-07-18 11:02:02 -07:00
Terry Lucas 657daa96a8 First step in removing dartium from IDL generation in TIP of master. 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2982143002 .
 2017-07-18 08:40:39 -07:00
Alan Knight 789de57cdf Allow setting unknown CSS properties, e.g. CSS variables 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2976213002 .
 2017-07-17 14:56:31 -07:00
Stephen Adams 8623950864 Change imports to clean up irritating warning 
This gets rid of the following messages in the build:

patched_dart2js_sdk/lib/_internal/js_runtime/lib/native_typed_data.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/svg/dart2js/svg_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_audio/dart2js/web_audio_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_gl/dart2js/web_gl_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_sql/dart2js/web_sql_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.

BUG=
R=ahe@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2982503002 .
 2017-07-12 14:37:40 -07:00
Terry Lucas 1265b4c674 Fixed readPixels not working in Dartium. 
BUG=11614
R=alanknight@google.com, jacobr@google.com

Review-Url: https://codereview.chromium.org/2975953002 .
 2017-07-11 13:12:51 -07:00
Stephen Adams b0803e1dd7 _ChildrenElementList implements removeRange 
This is to avoid inheriting an implementation that works incorrectly for the underlying NodeList.

TBR=lrn@google.com

BUG=

Review-Url: https://codereview.chromium.org/2977453002 .
 2017-07-07 15:55:19 -07:00
Stephen Adams fc7d880c60 Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError 
_ChildNodeListLazy.removeRange used to throw UnsupportedError because ListMixin.removeRange calls setRange.
Make throwing UnsupportedError explicit to avoid relying on the implementation of ListMixin.removeRange
This will unblock the '_closeGap' change.

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2955103003 .
 2017-06-28 09:42:55 -07:00
Florian Loitsch 978213d427 Revert "Make Zone API strong mode clean." 
This reverts commit 0b35711d48.

BUG=

Review-Url: https://codereview.chromium.org/2963743002 .
 2017-06-28 13:31:32 +02:00
Florian Loitsch 0b35711d48 Make Zone API strong mode clean. 
Review-Url: https://codereview.chromium.org/2959163002 .
 2017-06-28 13:16:39 +02:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Terry Lucas 8ab1a87aba Typedefs and IDL file order between platforms could generated different files. 
TBR=alanknight@google.com,vsm@google.com

Review-Url: https://codereview.chromium.org/2948493002 .
 2017-06-18 11:54:29 -07:00
Alan Knight 6042ae4bd8 Get the name and message from DOMException correctly 
BUG=
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2931903003 .
 2017-06-13 08:59:33 -07:00
Terry Lucas b3a90540f1 Fix sound not playing in Dartium checked mode. 
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.

https://github.com/dart-lang/sdk/issues/29810

TBR=alanknight@google.com,kevmoo@google.com

Review-Url: https://codereview.chromium.org/2940543002 .
 2017-06-12 22:50:12 -07:00
Terry Lucas 3cbacefbe3 Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation. 
R=alanknight@google.com,sigmund@google.com

Review-Url: https://codereview.chromium.org/2932793002 .
 2017-06-08 20:44:30 -07:00
Alan Knight 75a1eaef7e Fix dataTransfer getter 
BUG=

Review-Url: https://codereview.chromium.org/2907273003 .
 2017-05-30 15:14:40 -07:00
Alan Knight d21cc80a54 Add a dataTransfer member to MouseEvent 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2899393004 .
 2017-05-25 14:05:10 -07:00
Terry Lucas 20dc749844 Suppress Scale interface - unused. 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2901213006 .
 2017-05-25 12:54:38 -07:00
Alan Knight 6f71f9c80b Revert "[Experiment] Stop suppressing DragEvent" 
This reverts commit fbbb974670.

Also updates the cached_patches.dart file.

BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2907563003 .
 2017-05-25 11:16:10 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version 
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
 2017-05-24 12:49:13 -07:00
Alan Knight e6c38ea30f Remove JS_CONST from CssStyleDeclaration, causes DDC problems 
BUG=
R=sra@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2896393002 .
 2017-05-23 14:48:08 -07:00
Alan Knight fbbb974670 [Experiment] Stop suppressing DragEvent 
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2898673003 .
 2017-05-22 14:10:05 -07:00
Alan Knight 9e0297f49e Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIEvent 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2896653003 .
 2017-05-22 10:29:24 -07:00
Sigmund Cherem cd2ebf70a2 Add dart:html and friends to patched_dart2js_sdk/platform.dill, also fix up 
warnings on these libraries.

R=sra@google.com

Review-Url: https://codereview.chromium.org/2885103005 .
 2017-05-17 10:58:30 -07:00
Stephen Adams 9c3d439b1e dart2js + html: getBoundingClientRect() returns a ClientRect 
Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2879403002 .
 2017-05-16 13:48:04 -07:00
Stephen Adams 89b9c7c8dd html: AudoTrackList is a List 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2884813002 .
 2017-05-15 14:44:35 -07:00
Stephen Adams 35979c3205 Add keyLocation to KeyboardEvent constructor for backwards compatibility 
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2884713002 .
 2017-05-15 10:58:24 -07:00
Stephen Adams 01ba5f8d74 fix KeyEvent and KeyboardEvent 
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent.  We has done work to hide them on UIEvent; this needed
to be updated.

TBR=terry@google.com

BUG=

Review-Url: https://codereview.chromium.org/2883623004 .
 2017-05-12 16:03:01 -07:00
Stephen Adams ca3d90c4cd Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking 
We can't have the [data] and [source] getters typed as Object.
This causes it to appear that all DOM types are instantiated.

I have modelled the annotations after the same getters from
MessageEvent.

TBR=jacobr@google.com

BUG=

Review-Url: https://codereview.chromium.org/2879763002 .
 2017-05-11 19:31:20 -07:00
Stephen Adams 0879884d80 web_audio: rename OfflineAudioContext.suspend 
Rename member to avoid warning due to incompatible signature of base class method of same name.

TBR=terry@google.com

BUG=

Review-Url: https://codereview.chromium.org/2872023006 .
 2017-05-11 18:05:09 -07:00
Stephen Adams 91f9ce3f71 Better type for _match argument in AttributeMatch 
This fixes two warnings in analyze_api_test:

R=jacobr@google.com

sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == null;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == _namespace;
                              ^^^^^^^^^^^^^^^^^^
Review-Url: https://codereview.chromium.org/2875183002 .
 2017-05-11 16:59:17 -07:00
Stephen Adams f3734a9fc5 dom: Recognize __getter__ indexers 
BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2879663002 .
 2017-05-11 13:59:41 -07:00
Terry Lucas f27144d7b5 Roll 50: Updated for push to origin/master. 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
 2017-05-10 18:16:51 -07:00
Alan Knight 95930806c9 Add dynamic declaration to CssRectangle width/height setters 
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2868483002 .
 2017-05-05 13:34:23 -07:00
Nate Bosch bbc65073fa Clarify units for timeout 
This is indicated in the linked MDN doc, but we should not make readers
go looking.

Also fix a typo.

BUG=https://github.com/dart-lang/sdk/issues/29428
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2832353003 .
 2017-05-05 10:11:03 -07:00