Commit graph

1088 commits

Author SHA1 Message Date
nweiz@google.com 46e1783cae Really fix Dartdoc.
Review URL: https://codereview.chromium.org//13882002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21131 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-09 02:11:18 +00:00
nweiz@google.com 8db0ca07f4 Fix the dartdoc build.
Review URL: https://codereview.chromium.org//13878002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21128 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-09 01:14:25 +00:00
ahe@google.com da25a12caf Only build apidoc in release mode.
Review URL: https://codereview.chromium.org//13784002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21068 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 12:43:25 +00:00
ajohnsen@google.com 1bae12223b Fix recursive directory-deletion of top-level files/links.
BUG=

Review URL: https://codereview.chromium.org//13771010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21060 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 11:30:33 +00:00
ahe@google.com 0f111680af Fix dependencies of apidoc.
Review URL: https://codereview.chromium.org//13722007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21058 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 10:49:04 +00:00
kevmoo@j832.com f2059edd6e pub/validator/lib_test: use group instead of integration
All tests are now registered before the test system starts.

Review URL: https://codereview.chromium.org//13694002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21005 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 22:56:40 +00:00
floitsch@google.com c93132625d Fix for pub.
Review URL: https://codereview.chromium.org//13598017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20987 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 17:16:54 +00:00
floitsch@google.com bef8ebb5f6 Add Iterable.fold (and Stream.fold) which replace reduce.
For now this is just a copy. In a next step we will change the behavior of
`reduce`.

BUG= http://dartbug.com/9536

Review URL: https://codereview.chromium.org//13548002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20978 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 16:12:40 +00:00
sgjesse@google.com e10bc2d3e0 Reapply "Add a sleep function to dart:io"
This reapplies r20952, r20953, r20954 together with hiding sleep from
dart:io in a number of tests.

R=ager@google.com

Review URL: https://codereview.chromium.org//13704003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20964 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 13:04:26 +00:00
ahe@google.com 43d9cdb340 Ensure apidoc exits with non-zero exit code when dart2js crashes.
Also, print the stack trace when dart2js crashes.

Review URL: https://codereview.chromium.org//13471015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20912 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-04 10:32:18 +00:00
nweiz@google.com 5e5d82725c Split apart several asynchronous tests to reduce timeouts.
Review URL: https://codereview.chromium.org//13472016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20827 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-02 22:39:43 +00:00
amouravski@google.com 8a8de00b90 Changed pkg option to package-root.
pkg will remain in a deprecated state for the time being.

Review URL: https://codereview.chromium.org//13421002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20808 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-02 19:32:51 +00:00
nweiz@google.com 59a85239a7 Split up some slow pub tests and mark some scheduled_test tests as slow.
BUG=9231

Review URL: https://codereview.chromium.org//13375022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20758 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-01 23:20:11 +00:00
nweiz@google.com 2510e91be2 Fix a few bugs breaking the pub tests.
Review URL: https://codereview.chromium.org//13370003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20709 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:39:31 +00:00
nweiz@google.com 57bf732773 Always enable the friendly pub unittest config locally.
Review URL: https://codereview.chromium.org//13366002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20706 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:31:47 +00:00
nweiz@google.com 3569854b56 Rename the includeHiddenFiles parameter of listDir.
Review URL: https://codereview.chromium.org//13367002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20705 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:31:12 +00:00
nweiz@google.com 16367f141e Work around issue 4928.
Review URL: https://codereview.chromium.org//13293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20704 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:10:48 +00:00
nweiz@google.com 1049bd30dc Replace defer() with Future.of in pub.
Review URL: https://codereview.chromium.org//13196007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20703 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:08:47 +00:00
nweiz@google.com 0c20674dbd Make pub warning-clean.
This also works around issue 9535 in scheduled_test.

Review URL: https://codereview.chromium.org//13348002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20702 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:07:27 +00:00
nweiz@google.com 5750ce8d71 Make listDir and createSymlink synchronous in pub.
Review URL: https://codereview.chromium.org//13332009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20698 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-29 22:20:22 +00:00
nweiz@google.com f5534bdb3f Increase the default test timeout for scheduled tests on Windows.
Review URL: https://codereview.chromium.org//13327009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20695 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-29 21:47:35 +00:00
rnystrom@google.com aa3fdc3659 Mark flaky test as flaky.
Review URL: https://codereview.chromium.org//13314007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20675 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-29 17:45:57 +00:00
devoncarew@google.com 972ec0b7b0 Minor tweak to the pubspec.lock output to remove the leading whitespace from the file.
"        # Generated by pub. See: http://pub.dartlang.org/doc/glossary.html#lockfile"
"         {"packages":{}}"
        
becomes:

# Generated by pub.
# see http://pub.dartlang.org/doc/glossary.html#lockfile

{"packages":{}}
Review URL: https://codereview.chromium.org//13200003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20655 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-28 23:10:35 +00:00
nweiz@google.com 70f8c7ab6e Work around issue 9499.
Review URL: https://codereview.chromium.org//13236002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20648 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-28 21:31:49 +00:00
nweiz@google.com c590e8ae0c Switch pkg packages, pub, and dartdoc to use package: imports.
This also changes the SDK layout by replacing the "pkg" directory, which
contained the full source of all the packages needed by pub and dartdoc, with a
"packages" directory that contains only their lib directories. This directory is
used as the package root for pub and dartdoc when run from the SDK.

BUG=6745

Review URL: https://codereview.chromium.org//12782016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20640 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-28 20:27:28 +00:00
nweiz@google.com 3697a04750 Add a library for manipulating stack traces.
Review URL: https://codereview.chromium.org//13102003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20582 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 21:15:55 +00:00
nweiz@google.com ac18c8ced8 Work around issue 9278.
Review URL: https://codereview.chromium.org//12907030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20577 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 20:53:25 +00:00
nweiz@google.com d80616fdce Clean up the semantics of io.dart operations w.r.t. symlinks.
fileExists and dirExists will now both return true for symlinks only if those
symlinks are unbroken and point to entries of the appropriate type. entryExists
will return true for any symlink as well, broken or unbroken.

deleteDir and deleteFile have been replaced with a single function, deleteEntry.
This will delete whatever filesystem entry exists at the path specified, whether
it's a file, directory, or symlink (broken or unbroken).

BUG=9454

Review URL: https://codereview.chromium.org//13116020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20575 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 20:37:55 +00:00
rnystrom@google.com 616ab7e943 Handle deleting broken symlinks on Windows.
BUG=https://code.google.com/p/dart/issues/detail?id=9192

Review URL: https://codereview.chromium.org//12716024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20501 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-26 00:50:23 +00:00
nweiz@google.com 5f052a9796 Work around issue 9360.
BUG=8687

Review URL: https://codereview.chromium.org//12995008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20406 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:49:14 +00:00
nweiz@google.com 8783e780e9 Stop working around issue 6764.
Review URL: https://codereview.chromium.org//12902031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20404 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:34:55 +00:00
rnystrom@google.com 7aafe74407 Mark right test as flaky.
BUG=

Review URL: https://codereview.chromium.org//12872006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20398 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:29:59 +00:00
nweiz@google.com c9724a390f Ignore lockfile entries where the source is wrong.
BUG=7262

Review URL: https://codereview.chromium.org//12995013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20395 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:12:14 +00:00
nweiz@google.com 5d68e6b5fc Mark pub_update_test as flaky.
BUG=9357

Review URL: https://codereview.chromium.org//12995004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20357 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-21 22:03:51 +00:00
nweiz@google.com 30afbfd9c0 Provisionally un-flake pub tests.
Now that pub is using scheduled_test, it should at least be clearer what's going
on if these tests start flaking again.

BUG=8511,8868

Review URL: https://codereview.chromium.org//12422015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20291 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 21:21:06 +00:00
nweiz@google.com cc340dc736 Increase the scheduled_test timeout for Git tests on Windows.
Review URL: https://codereview.chromium.org//12668014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20289 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 21:09:17 +00:00
nweiz@google.com 6cd9cee512 Provisionally stop working around issues 9252 and 9253.
We're removing these workarounds in the hopes that the pub tests won't resume
flaking. If they do, this CL should be rolled back.

Review URL: https://codereview.chromium.org//12879015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20286 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 19:49:05 +00:00
nweiz@google.com 84dd8a51e0 "new Map()" -> "new Map.from()" in pub.
BUG=8511

Review URL: https://codereview.chromium.org//12580008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20265 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 01:03:23 +00:00
nweiz@google.com db9ff1e404 Use scheduled_test for Pub tests.
This was originally committed as r20250. Due to issue 9294, this failed on
Windows. This commit works around that issue.

BUG=8511

Review URL: https://codereview.chromium.org//12437022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20264 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 00:50:58 +00:00
nweiz@google.com 32db9c0cf6 Revert "Use scheduled_test for Pub tests."
This reverts r20250, which was failing on Windows.

BUG=8511

Review URL: https://codereview.chromium.org//12782005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20253 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 22:22:55 +00:00
nweiz@google.com 82cbc2db3a Use scheduled_test for Pub tests.
BUG=8511

Review URL: https://codereview.chromium.org//12794007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20250 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 21:58:53 +00:00
nweiz@google.com 83d896d80b Fix a couple broken tests in pub/validator_test.
These tests were marked as test() rather than integration() and so their
schedules weren't getting run at all.

Review URL: https://codereview.chromium.org//12659008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20238 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:37:03 +00:00
nweiz@google.com 8f7295dce7 Work around issue 9252 in scheduled_test and pkg/http.
Review URL: https://codereview.chromium.org//12540010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20187 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 00:25:05 +00:00
sgjesse@google.com 49dec76806 Change all File APIs to make the mode and encoding arguments named
R=ager@google.com, ajohnsen@google.com, whesse@google.com, floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org//12609004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20153 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 12:10:32 +00:00
rnystrom@google.com 78a4088f03 Actually make status file do something.
Review URL: https://codereview.chromium.org//12712013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20123 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:17:27 +00:00
rnystrom@google.com 5def0d4962 Disable failing test on Windows until I can fix it.
BUG=https://code.google.com/p/dart/issues/detail?id=9192

Review URL: https://codereview.chromium.org//12422010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20118 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:51:16 +00:00
rnystrom@google.com 2f2b30eb0e Handle broken symlinks when creating package dirs.
BUG=https://code.google.com/p/dart/issues/detail?id=8343

Review URL: https://codereview.chromium.org//12772005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20116 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:07:18 +00:00
rnystrom@google.com 4a465ef855 Remove support for SDK dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=6354

Review URL: https://codereview.chromium.org//12790006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20098 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 18:33:05 +00:00
floitsch@google.com e57443e0b5 Make argument to StringSink.writeln optional.
BUG= http://dartbug.com/9102

Review URL: https://codereview.chromium.org//12870003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20081 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 13:59:39 +00:00
floitsch@google.com f85fa4feff Make argument to StringSink.writeln optional.
BUG= http://dartbug.com/9102

Review URL: https://codereview.chromium.org//12870003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20074 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 12:45:40 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
nweiz@google.com f12902dfaf Fix some analyzer warnings in pub.
Review URL: https://codereview.chromium.org//12820009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20057 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:39:14 +00:00
nweiz@google.com a9a8d42063 Add a SafeHttpServer shim to work around issue 9140.
Review URL: https://codereview.chromium.org//12633015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20054 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:12:19 +00:00
keertip@google.com a455e0d9cd add cache list command to pub
Review URL: https://codereview.chromium.org//12755024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19977 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 22:29:00 +00:00
scheglov@google.com 139e02c68e Rename analyzer-experimental to analyzer_experimental.
https://code.google.com/p/dart/issues/detail?id=9071

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12838003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19973 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 21:42:01 +00:00
nweiz@google.com 0e32e0327f Fix pub_lish_test.
This fixes a consistent breakage, not the flakiness.

Review URL: https://codereview.chromium.org//12847002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19970 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 20:45:59 +00:00
rnystrom@google.com 0122b2954e Dev dependencies.
BUG=dartbug.com/5358

Review URL: https://codereview.chromium.org//12433014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19966 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 19:40:25 +00:00
floitsch@google.com 482b2f34e8 Move Options to dart:io.
Review URL: https://codereview.chromium.org//12794002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19927 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:12:00 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
nweiz@google.com f29ae528f7 Use default-port-aware URI comparisons in pub.
This fixes a usability issue where error messages from
pub.dartlang.org were getting reported as generic HTTP errors.

Review URL: https://codereview.chromium.org//12667016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19826 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 23:07:17 +00:00
amouravski@google.com 6e056b8044 Lots of little changes for dartdoc/apidoc.
* Alphabetized imports.
* Added TODOs.
* Removed some prefixes.
* Cleaned up a LOT of async code to make it work better.
* Much, much, much friendlier status messages for dartdoc/apidoc. More to do...
* Prevented many, many bad warnings from showing up... by fixing them.
* Smarter finding of packages directories.
* Started using pathos all over the place.
* Added indexed_db to html_diff.

Review URL: https://codereview.chromium.org//12448006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19817 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:27:53 +00:00
nweiz@google.com 15762df9f4 Stop working around issue 8512.
Review URL: https://codereview.chromium.org//12452008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19743 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:04:09 +00:00
nweiz@google.com 845e550cbb Properly handle errors from the OAuth2 token endpoint in pub.
This also adds more detailed HTTP logging to pub.

BUG=8849

Review URL: https://codereview.chromium.org//12428012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19734 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:57:27 +00:00
nweiz@google.com c71bb58877 Update pub to use the latest dart:io stream APIs.
Review URL: https://codereview.chromium.org//12613010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19729 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:46:08 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode.
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com cd9bcfe956 Remove references to capital-D-Dynamic.
Review URL: https://codereview.chromium.org//12615002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19687 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:57:28 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError.
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:06:28 +00:00
johnniwinther@google.com 44b1941b88 Revert "Remove pkg from apidoc."
This reverts commit r19636.

Review URL: https://codereview.chromium.org//12614006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19637 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 15:19:14 +00:00
johnniwinther@google.com 4f40f1d3aa Remove pkg from apidoc.
Review URL: https://codereview.chromium.org//12613008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19636 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 15:01:35 +00:00
rnystrom@google.com b3e5168249 Add a failing test for handling broken symlinks.
BUG=8343

Review URL: https://codereview.chromium.org//12500005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19580 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 20:55:53 +00:00
johnniwinther@google.com 43d6b6a84b Support full dart2js output for dartdoc/apidoc.
Review URL: https://codereview.chromium.org//12446003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19537 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 08:43:33 +00:00
rnystrom@google.com 50d1fc7a99 Delete files synchronously.
BUG=8868

Review URL: https://codereview.chromium.org//12481003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19517 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-05 21:32:35 +00:00
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
devoncarew@google.com 1600f30a14 Cleanup two warning messages when running apidoc, and update the apidoc.gyp file to rerun the tool
when any of its dart source changes.
Review URL: https://codereview.chromium.org//12388048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19336 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 20:01:03 +00:00
ricow@google.com 85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
gram@google.com 621650b0e8 Disable breaking tests while I investigate the issue. I don't really want to revert;
I want to understand this as it may indicate some other problem.
Review URL: https://codereview.chromium.org//12387033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19271 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 01:38:57 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 2a0c74a18d Make pub warning-clean.
Review URL: https://codereview.chromium.org//12382031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19265 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:21:58 +00:00
nweiz@google.com 3ce4e71a92 Make use of Completer.isComplete in pub and pkg/scheduled_test.
Review URL: https://codereview.chromium.org//12385027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19264 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:18:27 +00:00
floitsch@google.com cc8cefc004 Timer callbacks don't take arguments anymore.
Review URL: https://codereview.chromium.org//12379013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19231 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 14:22:49 +00:00
floitsch@google.com ff006ed05b Timer callback doesn't take an argument anymore.
Review URL: https://codereview.chromium.org//12380019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19221 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 13:36:22 +00:00
gram@google.com 017d21bdc0 Unit test changes:
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
whesse@google.com 6ef35edef1 dart:io | Rename File.name to File.path.
BUG=dartbug.com/8790

Review URL: https://codereview.chromium.org//12314153

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 15:26:11 +00:00
lrn@google.com fa78a93635 Make arg parser return growable list of rest arguments.
This allows the user to remove them when he's done, which is what
is currently being done.

Review URL: https://codereview.chromium.org//12316155

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19119 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 09:48:17 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list.
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
amouravski@google.com edee0d7e8e Updated an error message to inform users that their packages were not installed
when their SDK version does not match.

Review URL: https://codereview.chromium.org//12315059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19026 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 03:12:02 +00:00
rnystrom@google.com 1d62e0a077 Disable test on Windows for now.
Review URL: https://codereview.chromium.org//12313114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19016 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:20:47 +00:00
rnystrom@google.com b88ebea7c3 Handle shared path dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=8775

Review URL: https://codereview.chromium.org//12335076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19012 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:00:16 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
nweiz@google.com c8f6014ae7 Move pkg/path to pkg/pathos.
Review URL: https://codereview.chromium.org//12316056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
rnystrom@google.com df8647c43f Allow whitespace in version constraints.
BUG=http://code.google.com/p/dart/issues/detail?id=7140

Review URL: https://codereview.chromium.org//12310029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18851 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 19:47:44 +00:00
rnystrom@google.com e3e5d46f32 Make sure package names are URL encoded.
If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Review URL: https://codereview.chromium.org//12328021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18849 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 18:59:48 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
rnystrom@google.com 8b37852e8a Use relative symlinks for self links and secondary "packages" dirs.
This lets you move a package directory without breaking all of those links.
BUG=http://code.google.com/p/dart/issues/detail?id=8342

Review URL: https://codereview.chromium.org//12321020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18785 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:17:16 +00:00
rnystrom@google.com e28a669679 Make some name validation errors warnings.
BUG=http://code.google.com/p/dart/issues/detail?id=8632

Review URL: https://codereview.chromium.org//12313014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18783 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:11:47 +00:00
nweiz@google.com d64b7d392a Use the correct set of reserved identifiers in pub validations.
We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but
apparently those are the built-in identifiers that are valid for user use. Now
we're using the set listed in the spec as "reserved words".

BUG=8628

Review URL: https://codereview.chromium.org//12301032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18716 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:55:40 +00:00
rnystrom@google.com a1702c3578 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010


Review URL: https://codereview.chromium.org//12294039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18715 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:49:46 +00:00
floitsch@google.com ecce8a6293 Remove deprecated Strings class.
Review URL: https://codereview.chromium.org//12295014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 13:57:03 +00:00
lrn@google.com bbfe7b02dc Reapply "Make Comparable generic."
Avoid concurrent modification in dart2js.
Avoid crash in VM by not using self-referential type bound.

Review URL: https://codereview.chromium.org//12288040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18667 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 10:29:44 +00:00
kasperl@google.com d4feeb4910 Revert "Make Comparable generic."
This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//12298027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18657 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 08:06:03 +00:00
lrn@google.com a0f22b77be Make Comparable generic.
It's now allowed to write "class X implements Comparable<X>" to make
X comparable only to X's. The argument type of Comparable<T>.compareTo
is now T.

Review URL: https://codereview.chromium.org//12255055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18655 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 07:52:24 +00:00
lrn@google.com 03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com 5ed85458d1 Revert "Support relative paths in path dependencies."
This reverts commit 0b0da0d44dde213647e7281bf0914c59fc552b27.

BUG=

Review URL: https://codereview.chromium.org//12280019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18606 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 02:00:45 +00:00
rnystrom@google.com 8514e448b7 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 01:45:39 +00:00
rnystrom@google.com 0e0473d33a Unbreak pub:
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Review URL: https://codereview.chromium.org//12286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
floitsch@google.com 0672317bec Remove deprecated mappedBy.
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy."
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy.
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
lrn@google.com ecbf4478c2 Reapply "New implementation of {,Linked}Hash{Set,Map}."
Review URL: https://codereview.chromium.org//12212211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18573 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:07:22 +00:00
rnystrom@google.com db82ff139f Fix pub on windows.
Review URL: https://codereview.chromium.org//12261050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18553 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:33:23 +00:00
rnystrom@google.com b12e27a4d2 Get rid of join() and encapsulate File and Directory in io.dart.
Review URL: https://codereview.chromium.org//12253054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18551 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:13:07 +00:00
rnystrom@google.com 10f7ad94ae Clean up some warnings and deprecated calls.
Review URL: https://codereview.chromium.org//12262056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18550 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:10:07 +00:00
rnystrom@google.com ba326cd770 Get rid of old redundant methods in io.dart.
Now that we have pkg/path, we can ditch the old methods in io.dart
that do the same thing.

Review URL: https://codereview.chromium.org//12255016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18500 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 01:14:31 +00:00
jacobr@google.com c83eac0511 Add mdn docs to json, tag which classes are throwable, and provide additional information about parameter elements, and store FunctionTypeElements.
Review URL: https://codereview.chromium.org//12217161

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18496 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 00:00:46 +00:00
rnystrom@google.com 96697d6ecc Fix path tests on windows.
Review URL: https://codereview.chromium.org//12263018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18488 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 22:18:55 +00:00
rnystrom@google.com 76ec804170 Auto-reinstall broken packages in the system cache.
BUG=http://code.google.com/p/dart/issues/detail?id=5939

Review URL: https://codereview.chromium.org//12225149

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18480 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 21:11:12 +00:00
rnystrom@google.com bd0d874a53 Take Sam Elkhateeb's path for "path" dependencies and clean it up some.
BUG=http://code.google.com/p/dart/issues/detail?id=3732

Review URL: https://codereview.chromium.org//12208138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18465 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 18:47:19 +00:00
whesse@google.com acd03abf83 dart:io: Use PathBuffer class for Directory.list on Windows platform.
BUG=https://code.google.com/p/dart/issues/detail?id=7505

Review URL: https://codereview.chromium.org//12252006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18448 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 15:00:55 +00:00
jacobr@google.com 71cace784b Generate separate json files for each library and include the version #.
BUG=

Review URL: https://codereview.chromium.org//12217077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18432 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 06:01:27 +00:00
nweiz@google.com 83eec7051a Work around issue 8512 in pub.
Review URL: https://codereview.chromium.org//12225157

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18427 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:23:17 +00:00
rnystrom@google.com 7c2e379f89 Add --force to pub lish.
BUG=http://code.google.com/p/dart/issues/detail?id=8487

Review URL: https://codereview.chromium.org//12217156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18423 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:06:29 +00:00
rnystrom@google.com 1b15bef29f Mark oauth2 and pub_uploader as flaky. :(
Review URL: https://codereview.chromium.org//12251008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18416 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:46:56 +00:00
keertip@google.com ea861b9bdd add --preview flag to publish command
Review URL: https://codereview.chromium.org//12226077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18397 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 19:52:01 +00:00
floitsch@google.com 3f7146707d Rework Timer interface.
Review URL: https://codereview.chromium.org//12213092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18326 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 19:22:16 +00:00
amouravski@google.com 03aecdbbae Delete unused file.
Review URL: https://codereview.chromium.org//12210039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18291 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 00:22:58 +00:00
amouravski@google.com c6e2418c89 Added support for 'description' in pubspec.yaml.
Also standardized the way of validating a url.

Also, one test was working, but was not actually testing what it was supposed to be testing.

Review URL: https://codereview.chromium.org//12211097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18290 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 00:16:15 +00:00
nweiz@google.com 8f3ec6b6d3 Add a scheduled test library.
Review URL: https://codereview.chromium.org//12209073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18285 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-08 23:07:57 +00:00
pquitslund@google.com 90fd9e9c78 Call init test config for generating human-friendly test results.
Review URL: https://codereview.chromium.org//12218062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18234 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 22:11:34 +00:00
rnystrom@google.com 9f21b5324b Make createTempDir() synchronous.
Review URL: https://codereview.chromium.org//12225085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18231 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 20:46:45 +00:00
rnystrom@google.com ec020bbd99 Handle circular dependencies on the root package when checking SDK constraints.
BUG=dartbug.com/8364

Review URL: https://codereview.chromium.org//12211061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18198 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 00:40:09 +00:00
rnystrom@google.com fd3cfd264e Don't allow pub to run on XP.
BUG=dartbug.com/5480

Review URL: https://codereview.chromium.org//12221049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18188 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 21:33:13 +00:00
rnystrom@google.com 12dd25f65b Drain HTTP request input streams before responding.
Review URL: https://codereview.chromium.org//12211052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18185 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 20:50:53 +00:00
amouravski@google.com cd51673fce Removed some cruft from ApiDoc.
Review URL: https://codereview.chromium.org//12208017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18151 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 19:00:21 +00:00
floitsch@google.com cb10990e5a Remove Sink and move CollectionSink to async.
Committed: https://code.google.com/p/dart/source/detail?r=18063
Reverted: https://code.google.com/p/dart/source/detail?r=18067

Review URL: https://codereview.chromium.org//12154006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 15:32:18 +00:00
rnystrom@google.com fcab5f5adb Fix hosted tests on Windows.
BUG=http://dartbug.com/8264

Review URL: https://codereview.chromium.org//12208006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18113 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:32:40 +00:00
rnystrom@google.com cf697141d9 Get most pub IO tests passing on Windows.
The remaining issue now is a hang in dart:io.

BUG=

Review URL: https://codereview.chromium.org//12211004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:18:34 +00:00
nweiz@google.com 193eac0d3c Un-mark {pub_{uploader,lish},oauth2}_test as flaky.
We need to see when these go red so they stop bit rotting.

Review URL: https://codereview.chromium.org//12195006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18105 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 01:09:57 +00:00
nweiz@google.com dbb72ee35d Get the pub oauth2 test passing locally.
Review URL: https://codereview.chromium.org//12191008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18103 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 00:57:25 +00:00
rnystrom@google.com 57c9b64975 Wait until file list is available before printing it.
Review URL: https://codereview.chromium.org//12193014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18081 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 22:18:08 +00:00
nweiz@google.com dfb2a2f23d Mark pub hosted tests as flaky on Windows.
BUG=8264

Review URL: https://codereview.chromium.org//12184019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18077 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 20:52:31 +00:00
rnystrom@google.com b3606c9047 Tweak SDK constraint checking a bit.
Review URL: https://codereview.chromium.org//12171002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18020 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:47:26 +00:00
rnystrom@google.com b6d5dc7f5a Make a bunch of stuff in pub synchronous.
Review URL: https://codereview.chromium.org//12079112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18019 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:30:16 +00:00
nweiz@google.com 31c93eeceb Fix a few breakages with Pub's oauth2 test.
Review URL: https://codereview.chromium.org//12150006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18017 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:11:56 +00:00
rnystrom@google.com 4a9cc0f619 Validate packages against their SDK constraints.
After running pub install or update, it will look at all of the
selected packages and see if their SDK constraints match the
current SDK. If not, it will show a (hopefully) helpful error
message.
BUG=dartbug.com/6285

Review URL: https://codereview.chromium.org//12092080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18014 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 23:45:26 +00:00
nweiz@google.com 342e7a4c1a Don't mark the few passing hosted pub tests as failing.
Review URL: https://codereview.chromium.org//12082127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18008 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:43:23 +00:00
nweiz@google.com 6565bb80ef Stop using cURL in Pub.
BUG=7395

Review URL: https://codereview.chromium.org//12090104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18007 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:35:33 +00:00
nweiz@google.com 6c3535dceb Fix the Pub status file.
Review URL: https://codereview.chromium.org//12149006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18006 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 21:55:44 +00:00
nweiz@google.com aac9fcda5a Mark pub hosted tests as failing.
Review URL: https://codereview.chromium.org//12082124

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17997 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:55:11 +00:00
nweiz@google.com 18d274df07 Use the dart:async Stream API thoroughly in Pub.
This was originally submitted as r17822, and rolled back in r17867. There are no
changes, but in preparation for the dart:io Stream changes we're applying this
with the intent to mark Windows tests as failing.

BUG=7807

Review URL: https://codereview.chromium.org//12086110

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17996 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:42:09 +00:00
nweiz@google.com 474994a5b7 Add a validator that tests the size of pub packages.
BUG=7045

Review URL: https://codereview.chromium.org//12094093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17961 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 02:09:37 +00:00
keertip@google.com 796a9f601a add a comment to the generated lock file
Review URL: https://codereview.chromium.org//12133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17951 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 23:03:11 +00:00
nweiz@google.com f181fdc8a8 Add a Pub validator for READMEs that are invalid utf-8.
BUG=7045

Review URL: https://codereview.chromium.org//12090081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17948 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 22:39:53 +00:00
nweiz@google.com dd763be6af Add a pub validator for compiled dartdoc output.
BUG=7045

Review URL: https://codereview.chromium.org//12089076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17943 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 21:02:46 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html'
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
johnniwinther@google.com 74d03a2aeb Fix small bugs in dartdoc/apidoc.
Changed client implementation to use import instead of parts.
Fixed explicit package-root bug in apidoc.

BUG=http://dartbug.com/8162

Review URL: https://codereview.chromium.org//12094076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17895 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 10:11:17 +00:00
ricow@google.com b410b64719 Mark pub/oauth2_test as timeout as well as pass,fail
Review URL: https://codereview.chromium.org//12086078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17885 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 07:26:23 +00:00
rnystrom@google.com b0779d1453 Remove invalid sanity check.
In the presence of setUp() it is possible for stuff to be scheduled
by the time integration() is called.

Review URL: https://codereview.chromium.org//12090075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17870 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:47:16 +00:00
nweiz@google.com 8be520740e Roll back Pub stream changes.
These changes are still breaking the Windows bots, so I'm rolling them back
until we figure out what's going on.

TBR

Review URL: https://codereview.chromium.org//12095050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17867 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:26:03 +00:00
rnystrom@google.com f73ee270b7 Fix issue where failing pub tests confused unittest.
Review URL: https://codereview.chromium.org//12086052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17861 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 17:45:50 +00:00
nweiz@google.com 5552aff98b Fix a use of a StreamController as a Stream.
TBR

Review URL: https://codereview.chromium.org//12086055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17822 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 01:54:52 +00:00
nweiz@google.com d56994eb18 Use the dart:async Stream API thoroughly in Pub.
Review URL: https://codereview.chromium.org//12021008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 01:06:39 +00:00
sigmund@google.com aeca565ae9 Fix build for throwsStateError: remove duplicate definitions in other tests.
Review URL: https://codereview.chromium.org//12088056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17812 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 21:47:05 +00:00
rnystrom@google.com 63eac3fe8b Handle parsing the "version" file better.
Review URL: https://codereview.chromium.org//12087008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17740 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 00:56:07 +00:00
asiva@google.com d313a1243f 1. Change option --use_script_snapshot to --use-script-snapshot (easier to type).
2. Use dart binary with the --generate-script-snapshot option to generate dart2js snapshot
Review URL: https://codereview.chromium.org//12084010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17686 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 05:47:56 +00:00
jmesserly@google.com 61c97e7325 Restructure YAML package suitable for pub lish
After this I can use tools/publish_pkg.py upload script to fix dartbug.com/4126

Review URL: https://codereview.chromium.org//11622011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17685 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 02:25:43 +00:00
rnystrom@google.com 079402c3ae Get rid of RootSource.
This was a sort of hackish source only used internally during
version solving. But it causes a couple of subtle bugs because it
never gets registered with the SourceRegistry. That in turn makes
toString() fail on any PackageId with that source since it relies
on the Source being registered.

The simplest fix is to just remove the hacked source and have a
null source in PackageId/Ref mean "root" and handle it specially.

Review URL: https://codereview.chromium.org//12047096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17646 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 18:22:29 +00:00
amouravski@google.com e9e57f1209 Removed Disqus comments.
https://code.google.com/p/dart/issues/detail?id=6334

Review URL: https://codereview.chromium.org//12038081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17620 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 00:01:21 +00:00
amouravski@google.com d2a79c9bdd First half of the new HTML json docs.
This half produces the JSON file by going through each of the HTML libraries
and pulling out the @DomName annotations as keys for the map.
This means that even though member names may change, the map still works.

Currently creates a blank json file because I have not hooked up the other half
that puts the docs into the libraries to begin with.

Review URL: https://codereview.chromium.org//12035057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17610 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 22:53:00 +00:00
lrn@google.com 1f05296600 Change singleSubscription/multiSubscription to normal/broadcast.
Also make StreamController not a Stream.

Review URL: https://codereview.chromium.org//12049013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17563 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:30:27 +00:00
floitsch@google.com ed938af868 Rename new Uri.fromString to Uri.parse.
Review URL: https://codereview.chromium.org//12052038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17562 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:26:18 +00:00
floitsch@google.com fb7b9e3c5c Rename Date to DateTime.
BUG=http://dartbug.com/1424

Review URL: https://codereview.chromium.org//11770004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17549 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 12:16:37 +00:00
rnystrom@google.com 344249b02f Get rid of unneeded Future.immediate() calls.
Future.then() will now implicitly wrap the callback result in a
future if it isn't one, so this manual wrapping can be removed.

Also take advantage of the fact that Future.immediate() is always
async now and remove some workarounds.

Finally, noticed there were two copies of the git-related code
floating around so killed the old one.

Review URL: https://codereview.chromium.org//12042053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17519 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 01:13:36 +00:00
rnystrom@google.com 7ec5b82507 Make pub use the SDK's "version" file for its version.
This includes pub's own version and the implied version of SDK
packages. I also added a little test that verifies that pub can
parse the actual version file generated with the SDK.
BUG=5906,6173,7837

Review URL: https://codereview.chromium.org//12036065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17512 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 23:20:09 +00:00
rnystrom@google.com edf7ca2927 Add support for specifying SDK version constraints in pubspecs.
These constraints don't currently do anything, but these patch
gets them being parsed by pub.

Review URL: https://codereview.chromium.org//12038038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17477 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:41:40 +00:00
rnystrom@google.com f053f356ee Clean up code that locates SDK and SDK version.
This is prep work for SDK constraints. It moves the SDK
version-related code out of SdkSource (which will go away at some
point) into its own library.

I also removed the need for the DART_SDK env variable. It will
still be used if set (which the tests need), but if not set, Pub
will locate the SDK.
Clean up a few static warnings.

Review URL: https://codereview.chromium.org//11871028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17433 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 23:52:37 +00:00
hausner@google.com a885f8638b Fix map literals from change 17410
Remove any type arguments from map literals
that had one type argument before change 17410.
Review URL: https://codereview.chromium.org//12045024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17412 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 17:31:29 +00:00
hausner@google.com dc3bf6646a Stop supporting map literals with 1 type argument
To be checked in next week Tue (Jan 22)

Review URL: https://codereview.chromium.org//12021022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17410 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 16:48:00 +00:00
floitsch@google.com 1febeb689a Move some core classes to collection library.
Review URL: https://codereview.chromium.org//11867024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17352 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 13:34:02 +00:00
rnystrom@google.com d160b37a92 Clean up a few static warnings.
Review URL: https://codereview.chromium.org//11867029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17331 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 23:54:38 +00:00
rnystrom@google.com 4573dcd11d Create a unit test config for the pub tests that's prettier.
In particular, it:

- Shows test results incrementally.
- Cleans up the stack traces.
- Doesn't show the failures and their stack traces twice.

Right now, it's opt in. You need to:
- Add initConfig() to the top of a test suite.
- Pass "--human" when you run the test.

At some point, I can add the initConfig() calls to every test suite but I figured we could just add them manually for now.

Review URL: https://codereview.chromium.org//11867012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17313 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 21:11:43 +00:00
rnystrom@google.com 97af32b4d3 Make integration tests a bit cleaner.
Review URL: https://codereview.chromium.org//11943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17300 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 18:06:22 +00:00
ager@google.com 842a06c4cb Remove utils/archive. It is not used at this point.
R=nweiz@google.com,sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12016011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17248 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 07:15:27 +00:00
amouravski@google.com bd8be55838 Remove the old hand-written HTML doc format, which has not worked for months.
Personal TODO has been made to extract the useful bits of documentation from
this CL into the new hand-written HTML doc format.

Review URL: https://codereview.chromium.org//11961047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17231 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 18:54:18 +00:00
amouravski@google.com af3428430c Remove CommentMap from all DartDoc code.
Review URL: https://codereview.chromium.org//11958023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17224 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 16:55:14 +00:00
nweiz@google.com 03244ffee1 Stop treating StreamController as a Stream.
Apparently StreamController will soon stop extending Stream, so this gets rid of
all uses of it as a Stream in pkg/http and pub.

Review URL: https://codereview.chromium.org//11975017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17163 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 21:35:45 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation.
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
nweiz@google.com e0867a91d1 Mark pub tests as flaky.
BUG=7905,7920

Review URL: https://codereview.chromium.org//11944003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17107 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 00:15:29 +00:00
nweiz@google.com 013b0104f5 Add an ErrorGroup class to Pub.
Review URL: https://codereview.chromium.org//11941003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17106 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 00:12:30 +00:00
lrn@google.com ef13a0822b Make StreamController's unnamed constructor create a single-sub stream.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//11887016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17049 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 09:09:47 +00:00
nweiz@google.com 59cbc77eaf Increase the step timeout in scheduled pub tests.
Also un-mark the uploaders test as flaky.

BUG=7879

Review URL: https://codereview.chromium.org//11881033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17039 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 00:44:31 +00:00
nweiz@google.com 30d2e78687 Stop working around issue 7781 in Pub.
Review URL: https://codereview.chromium.org//11881032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17038 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 00:15:23 +00:00
nweiz@google.com 0109fd9664 No longer work around issue 7761.
This also moves Pub's modified _OutputStreamConsumer class into pkg/http.

Review URL: https://codereview.chromium.org//11881030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17034 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 23:30:00 +00:00
whesse@google.com 3696154a8e Default constructor for dart:io Path now handles native Windows paths. Path() now does the same as Path.fromNative(). Path.fromNative() is removed, and all uses of it replaced by Path().
BUG=https://code.google.com/p/dart/issues/detail?id=7872

Review URL: https://codereview.chromium.org//11878015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17026 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 19:46:13 +00:00
ricow@google.com e5b51f0196 Mark pub/pub_uploader_test as flaky.
Filed http://dartbug.com/7879
Review URL: https://codereview.chromium.org//11881016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17010 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 07:07:29 +00:00
lrn@google.com 4868ee2110 Remove Futures class, move methods to Future.
Optimize Future.forEach, Future.delay.

Review URL: https://codereview.chromium.org//11865005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16954 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 09:46:45 +00:00
nweiz@google.com 4774c5b7cf Un-mark pub_lish_test as flaky now that socket issues are resolved.
BUG=7819

Review URL: https://codereview.chromium.org//11826067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16944 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 00:06:25 +00:00
nweiz@google.com 9c8eb660d5 Don't die because we write empty arrays to cURL.
Review URL: https://codereview.chromium.org//11821062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16941 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 23:21:41 +00:00
nweiz@google.com 31ff3b949e Stop working around issue 7790 in pub.
Review URL: https://codereview.chromium.org//11778108

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16935 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 21:54:46 +00:00
lrn@google.com fd8f8fefe6 Fix pub tests.
Small tweaks to code.

Review URL: https://codereview.chromium.org//11833032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16910 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 10:42:37 +00:00
ricow@google.com 2f128089e7 Mark pub/pub_lish_test as flaky on linux.
This has been flaking a lot recently.

Filed high priority bug 7819
Review URL: https://codereview.chromium.org//11778090

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16902 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 08:23:57 +00:00
sigmund@google.com 7259a9df79 This change does a couple fixes to configurations:
- it renames '_postMessage' so that it can be overriden by configurations that don't need it.
- it splits the onDone callback in two: onSummary - a callback with all the results, and onDone - a callback with just the end result. The idea is that onSummary is mostly dedicated to reporting results, while onDone is about notifying that unittest is done. This split is very useful for subclasses that only want to override onSummary or onDone.

Review URL: https://codereview.chromium.org//11829045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 03:42:08 +00:00
nweiz@google.com fcff2fb2d9 Fix ALL the pub tests.
Review URL: https://codereview.chromium.org//11830017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16888 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 21:37:40 +00:00
ager@google.com 75c8f427cc Update remaining usages of Completer.completeException.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11827017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16840 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 09:29:39 +00:00
rnystrom@google.com 907f515718 Fix chainToCompleter.
Review URL: https://codereview.chromium.org//11783052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16833 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 02:26:49 +00:00
rnystrom@google.com b60575a0fb Get more pub tests working.
Review URL: https://codereview.chromium.org//11821012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16830 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 01:32:55 +00:00
rnystrom@google.com 8c2cbb8c53 Unwrap AsyncErrors to find real error.
Review URL: https://codereview.chromium.org//11821006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16825 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 23:07:35 +00:00
rnystrom@google.com 50bdaac949 Create an explicit lambda for onExit.
This is needed because completer.complete() now takes an optional
argument. A function with an optional argument isn't a subtype of
the same function without the argument being optional.

Review URL: https://codereview.chromium.org//11794051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16817 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 19:34:25 +00:00
rnystrom@google.com c324f5f050 Get validator tests working on lib_v2.
Review URL: https://codereview.chromium.org//11784031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16776 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 01:39:25 +00:00
rnystrom@google.com 021b6438c5 Commit Martin's patch for pub + lib_v2.
Pub is still all kinds of broken with this, but it's slightly
less broken. Some tests pass, and at least the code *parses*
after this.

Review URL: https://codereview.chromium.org//11785028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16763 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 23:11:55 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
rnystrom@google.com 0f99a4b070 Convert pub tests to line doc comments.
Review URL: https://codereview.chromium.org//11785008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16667 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-05 01:19:42 +00:00
nweiz@google.com cab2a027ce Add a validator for top-level directory names.
BUG=7045

Review URL: https://codereview.chromium.org//11741026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16621 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 00:25:22 +00:00
rnystrom@google.com ac04fc6c18 Convert pkg/http to use "package:" imports.
Review URL: https://codereview.chromium.org//11746009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16620 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 00:10:47 +00:00
nweiz@google.com 09afa8f485 Validate that a package doesn't depend on itself.
BUG=7045

Review URL: https://codereview.chromium.org//11737013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16614 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-03 22:18:46 +00:00
efortuna@google.com 9cbe127651 Fix new path of html lib docs in apidoc.
BUG=

Review URL: https://codereview.chromium.org//11706002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16559 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:54:57 +00:00
sgjesse@google.com 7e293aa077 Reapply "Fix URI encoding/decoding of + and space""
Updated test expectations for some tests for pkg/http, pkg/oauth2 and
pub to match the change.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org//11659009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16426 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:50:05 +00:00
floitsch@google.com f020a7d270 Add 'timeout' for io_test.
This reintroduces the change from https://codereview.chromium.org/11648033/
which was reverted in https://codereview.chromium.org/11570065/.

Review URL: https://codereview.chromium.org//11660003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16425 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:48:33 +00:00
floitsch@google.com 5271b558c2 Close receivePort when tests are failing.
Review URL: https://codereview.chromium.org//11570065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16422 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:37:48 +00:00
nweiz@google.com 5168d9bafd Add a validator for dependency version constraints.
BUG=7045

Review URL: https://codereview.chromium.org//11635060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16415 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:59:58 +00:00
nweiz@google.com 88af0578b6 Add a timeout to scheduled pub tests.
This ensures that at least we'll know which test is timing out.

Review URL: https://codereview.chromium.org//11649047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16410 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 00:24:44 +00:00
nweiz@google.com 2ae5ab640e Add a small note to a TODO.
Review URL: https://codereview.chromium.org//11644058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16409 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 23:51:44 +00:00
floitsch@google.com bef5bcf8b4 Update status file.
Review URL: https://codereview.chromium.org//11648033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16395 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 20:09:26 +00:00
rnystrom@google.com 12b11b4cc0 Convert /** comments to /// in pub.
Previously, it was a mix of both styles. Now it's consistent. :)

Review URL: https://codereview.chromium.org//11638010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16354 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 02:04:28 +00:00
ager@google.com 87a38c4546 Fix pub suppression
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11648008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16310 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 10:24:14 +00:00
ricow@google.com e652efe397 Suppress flake for pub/io_test on windows
Review URL: https://codereview.chromium.org//11637013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16307 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 08:49:10 +00:00
nweiz@google.com 71e2fc2bf4 Fix analyzer errors/warnings for Pub.
Review URL: https://codereview.chromium.org//11609005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16299 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 01:08:42 +00:00
rnystrom@google.com 747a3f83f5 Move path ("pathos") to pkg/.
Review URL: https://codereview.chromium.org//11647003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16297 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 00:04:37 +00:00
rnystrom@google.com c302b07858 Fix interpolation in warning message. :(
Review URL: https://codereview.chromium.org//11616019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16279 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:24:42 +00:00
nweiz@google.com 14c52ba5f1 Make listDir always emit paths within the given directory.
BUG=7346

Review URL: https://codereview.chromium.org//11553043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16275 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:00:12 +00:00
nweiz@google.com bc356f6840 Add the http library to pub.
TBR

Review URL: https://codereview.chromium.org//11593016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16231 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 22:00:05 +00:00
nweiz@google.com e2036dea9c Add a pub command for managing uploaders for packages.
BUG=7363

Review URL: https://codereview.chromium.org//11569046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16230 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 21:47:37 +00:00
amouravski@google.com 849f34cdbd Fixed package: imports breaking apidoc.
Review URL: https://codereview.chromium.org//11598012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16218 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 18:33:27 +00:00
nweiz@google.com 59fcc7a8cf Don't log a user's credentials.
Review URL: https://codereview.chromium.org//11565046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16184 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 22:30:09 +00:00
nweiz@google.com 3ea1942248 Validate that a single library has the same name as the package.
BUG=7045

Review URL: https://codereview.chromium.org//11519049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16139 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 20:57:30 +00:00
rnystrom@google.com 4edb7f8630 Exclude .gitignored files from published package.
Review URL: https://codereview.chromium.org//11567015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16134 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 18:39:16 +00:00
nweiz@google.com 899b1a7d1f A few small changes to the "pub lish" confirmation UI.
* Don't collapse the root directory of a directory tree, since this is usually
  going to be a very heterogeneous set of files and directories.

* Indent "(N more...)" two fewer spaces. This makes it clearer at what level
  things are collapsed when it comes immediately after a directory. E.g.

      |-- dir
      |   '-- file
      | (6 more...)
      |-- other-dir

  vs

      |-- dir
      |   '-- file
      |   (6 more...)
      |-- other-dir

Review URL: https://codereview.chromium.org//11442068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16085 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:11:47 +00:00
rnystrom@google.com 617d0970cd Don't try to put symlinked files in archive.
Review URL: https://codereview.chromium.org//11558036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16079 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 23:55:20 +00:00
rnystrom@google.com 0f9bed70a5 Make pub publish more user friendly:
- Show the contents of their package.
- Let the confirm the upload even if there are no warnings.
- Make the error/warning text less scary.
- Validate that the pubspec has a version client-side.

Addresses #7175 and #7219.

Review URL: https://codereview.chromium.org//11557008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16068 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 22:22:38 +00:00
nweiz@google.com 7a2155fd65 Move path-manipulation code from io.dart into path.dart.
Review URL: https://codereview.chromium.org//11553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16063 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 21:24:09 +00:00
rnystrom@google.com f0154d3b5a Fix #7330.
Review URL: https://codereview.chromium.org//11558022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16056 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 19:49:26 +00:00
nweiz@google.com 8c3148b8b8 Mark the Pub validator test as failing on mac.
Review URL: https://codereview.chromium.org//11552004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16013 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 01:47:38 +00:00
nweiz@google.com 6e4bb05e59 Add a validator that checks that the lib directory is not empty.
BUG=7045

Review URL: https://codereview.chromium.org//11543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16010 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 00:54:17 +00:00
nweiz@google.com 4f782ecd56 Fix issue 7215 by relativising a path before checking its components.
This includes a couple more miscellaneous fixes.

BUG=7215

Review URL: https://codereview.chromium.org//11528020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16002 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 21:18:11 +00:00
rnystrom@google.com ff428417ed Workaround #6986.
This avoids trying to read a non-existent lockfile. On some
non-English locales, this fails when trying to parse the error
message coming from Windows.
BUG=6986

Review URL: https://codereview.chromium.org//11477012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15992 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 19:01:47 +00:00
sgjesse@google.com 93514a3b28 Reapply "Stop working around issue 6984."
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 10:03:21 +00:00
rnystrom@google.com 67367bf7df Handle relative paths where the trailing directory has an extension.
Review URL: https://codereview.chromium.org//11512011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15946 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 03:22:15 +00:00