Ben Konyi
86fdbde70a
Added timeout parameter to RawSocket and Socket connect, which allows for the specification of a maximum time to wait for a valid connection to be established.
...
fixes #19120
R=zra@google.com
Review-Url: https://codereview.chromium.org/2946333002 .
2017-06-21 14:31:52 -07:00
Jens Johansen
be9a3043aa
[kernel] Make fasta call a new constructor on FallThroughError
...
On a switch fall through error, Fasta currently generates
```
throw new core::FallThroughError::•();
```
which generates the error-message via the VM:
```
'null': Switch case fall-through at line null.
```
This introduces a new constructor taking a url and a linenumber,
which then can give a better error message.
BUG=
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2951453002 .
2017-06-21 08:40:59 +02:00
Siva Chandra
b9bf4fcc48
Remove vmservice_patch.dart.
...
The code in the patch is now inlined into the vmservice library.
This is being done because, the vmservice related libraries are
now compiled directly from source instead of from the "patched_sdk".
So, what is being compiled now does not have the vmservice_patch
applied. By removing the patch, we are removing the need to
artificially patch the vmservice library and making the
vmservice_io.dill complete.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2946773002 .
2017-06-20 12:24:16 -07:00
Alan Knight
6042ae4bd8
Get the name and message from DOMException correctly
...
BUG=
R=jacobr@google.com , terry@google.com
Review-Url: https://codereview.chromium.org/2931903003 .
2017-06-13 08:59:33 -07:00
Peter von der Ahé
14e9d0bd89
Prepare for improved error recovery from compile-time errors.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2931423002 .
2017-06-13 15:59:18 +02:00
Terry Lucas
b3a90540f1
Fix sound not playing in Dartium checked mode.
...
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.
https://github.com/dart-lang/sdk/issues/29810
TBR=alanknight@google.com ,kevmoo@google.com
Review-Url: https://codereview.chromium.org/2940543002 .
2017-06-12 22:50:12 -07:00
Peter von der Ahé
1f294cbed0
Fix problem introduced with 043c0096ad
.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2931383002 .
2017-06-12 11:22:13 +02:00
Peter von der Ahé
043c0096ad
Complain about use before declaration.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2924423003 .
2017-06-10 10:12:18 +02:00
Terry Lucas
3cbacefbe3
Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation.
...
R=alanknight@google.com ,sigmund@google.com
Review-Url: https://codereview.chromium.org/2932793002 .
2017-06-08 20:44:30 -07:00
Ben Konyi
4a15b0b602
Updated HttpServer documentation to specify that only IPv6 connections can be made when specifying InternetAddress.LOOPBACK_IP_V6 as the address for a HttpServer. Refer to buganizer issue 38306174 for context.
...
BUG=
R=zra@google.com
Review-Url: https://codereview.chromium.org/2931623003 .
2017-06-08 15:53:07 -07:00
Ben Konyi
033c18472d
Revert "Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHANGELOG.md to announce its removal."
...
This reverts commit 4b6fa0d5fb
.
BUG=
R=kevmoo@google.com
Review-Url: https://codereview.chromium.org/2928013002 .
2017-06-08 14:32:41 -07:00
Ben Konyi
4b6fa0d5fb
Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHANGELOG.md to announce its removal.
...
BUG=
R=zra@google.com
Review-Url: https://codereview.chromium.org/2926153004 .
2017-06-07 15:15:58 -07:00
Lasse Reichstein Holst Nielsen
2a14e68d78
Clean-up of Future documentation and small fix-ups.
...
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2917683002 .
2017-06-02 07:53:47 +02:00
Florian Loitsch
33f360cc38
Revert "Add groupBy to Stream."
...
This reverts commit 3e8bfb1adb
and 3f90b06836
.
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2921663002 .
2017-06-01 16:11:39 +02:00
Kevin Moore
46110c331b
fix doc comments in dart:io and collection types
...
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2905013003 .
2017-05-31 09:08:12 -07:00
Alan Knight
75a1eaef7e
Fix dataTransfer getter
...
BUG=
Review-Url: https://codereview.chromium.org/2907273003 .
2017-05-30 15:14:40 -07:00
Lasse Reichstein Holst Nielsen
fbe98e6bfc
Update stream documentation.
...
Fixes #29694
BUG= http://dartbug.com/29694
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2899273003 .
2017-05-29 09:14:40 +02:00
Sigmund Cherem
dd70d8b655
Remove factory body in *.fromEnvironment, and implement this same behavior
...
directly inside dart2js.
A few notes:
* I ended up adding support for this feature also in dart2js with --use-kernel, it was not implemented correctly before. This is why more tests are passing.
* I played with two other ideas:
(a) making this a compile-time error instead
(b) making it a warning if the arguments were constant and implement it as a constant, treat it as an error if they were not.
Unfortunately both are a breaking changes, so I backed out from them. IMO (a) is the cleanest thing to do long term, and we should raise this with the language team.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2896393003 .
2017-05-26 14:49:19 -07:00
Alan Knight
d21cc80a54
Add a dataTransfer member to MouseEvent
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2899393004 .
2017-05-25 14:05:10 -07:00
Terry Lucas
20dc749844
Suppress Scale interface - unused.
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2901213006 .
2017-05-25 12:54:38 -07:00
Alan Knight
6f71f9c80b
Revert "[Experiment] Stop suppressing DragEvent"
...
This reverts commit fbbb974670
.
Also updates the cached_patches.dart file.
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2907563003 .
2017-05-25 11:16:10 -07:00
Sigmund Cherem
80942f15cf
add _CompileTimeError error to dart2js patch
...
See https://github.com/dart-lang/sdk/issues/29661 for context
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2901323002 .
2017-05-24 13:52:32 -07:00
Alan Knight
b4b02daade
Include DDC fixes to dart:html in the main version
...
BUG=
R=jacobr@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
Terry Lucas
03688818fa
Need to regen cached_patches; new class exposed.
...
TBR=alanknight@google.com ,keerti@google.com
Review-Url: https://codereview.chromium.org/2899233004 .
2017-05-24 09:22:52 -07:00
Vijay Menon
991315ae87
Reapply convert fixes for dart2js
...
BUG=
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2906443002 .
2017-05-24 08:34:19 -07:00
Peter von der Ahé
b6a78795e4
Fix various semantic nits that Fasta will detect.
...
R=johnniwinther@google.com , paulberry@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2897003003 .
2017-05-24 11:43:18 +02:00
Alan Knight
e6c38ea30f
Remove JS_CONST from CssStyleDeclaration, causes DDC problems
...
BUG=
R=sra@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2896393002 .
2017-05-23 14:48:08 -07:00
Alan Knight
fbbb974670
[Experiment] Stop suppressing DragEvent
...
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2898673003 .
2017-05-22 14:10:05 -07:00
Alan Knight
9e0297f49e
Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIEvent
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2896653003 .
2017-05-22 10:29:24 -07:00
Stephen Adams
7983454299
js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts
...
Pre-filtering hunks to initialized ended up calling some initializations multiple times. This happened for empty parts, so was harmless after 4af03b1a65
Simplify logic to reduce use of corelib functions. There is no real need to be creating closures and calling all of List.generate, where, and map.
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2893653005 .
2017-05-18 14:16:41 -07:00
Lasse Reichstein Holst Nielsen
25a770fc97
Fix Stream.distinct.
...
Due to incorrectly shared state, a broadcast distinct stream listened to
more than once would give incorrect results.
Also update docs.
Fixes #29638 , #29627 .
BUG= http://dartbug.com/29638 , http://dartbug.com/29627
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2885993005 .
2017-05-18 16:53:23 +02:00
Sigmund Cherem
cd2ebf70a2
Add dart:html and friends to patched_dart2js_sdk/platform.dill, also fix up
...
warnings on these libraries.
R=sra@google.com
Review-Url: https://codereview.chromium.org/2885103005 .
2017-05-17 10:58:30 -07:00
Stephen Adams
750de777cf
js_array tweaks
...
- uniform quotes
- uniform naming of methods in _checkGrowable
- use .slice(0), it is slightly faster than .slice()
- avoid bounds and type checks in removeWhere/retainWhere
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2880643005 .
2017-05-16 16:38:13 -07:00
Stephen Adams
9c3d439b1e
dart2js + html: getBoundingClientRect() returns a ClientRect
...
Gives better code since the general Rectangle requires getInterceptor
dispatch.
BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com , terry@google.com
Review-Url: https://codereview.chromium.org/2879403002 .
2017-05-16 13:48:04 -07:00
Stephen Adams
89b9c7c8dd
html: AudoTrackList is a List
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2884813002 .
2017-05-15 14:44:35 -07:00
Stephen Adams
35979c3205
Add keyLocation to KeyboardEvent constructor for backwards compatibility
...
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2884713002 .
2017-05-15 10:58:24 -07:00
Stephen Adams
01ba5f8d74
fix KeyEvent and KeyboardEvent
...
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent. We has done work to hide them on UIEvent; this needed
to be updated.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883623004 .
2017-05-12 16:03:01 -07:00
Stephen Adams
ca3d90c4cd
Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking
...
We can't have the [data] and [source] getters typed as Object.
This causes it to appear that all DOM types are instantiated.
I have modelled the annotations after the same getters from
MessageEvent.
TBR=jacobr@google.com
BUG=
Review-Url: https://codereview.chromium.org/2879763002 .
2017-05-11 19:31:20 -07:00
Stephen Adams
0879884d80
web_audio: rename OfflineAudioContext.suspend
...
Rename member to avoid warning due to incompatible signature of base class method of same name.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2872023006 .
2017-05-11 18:05:09 -07:00
Leaf Petersen
8cdcfb98e2
Use Null argument for callback arity check in async_error.
...
Avoid relying on fuzzy arrow semantics by using Null for the callback type
parameter to be checked against. Any function of the right arity will pass the "is"
check.
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2878553003 .
2017-05-11 17:36:47 -07:00
Leaf Petersen
ccbaabad8d
Adjust types in SplayTree implementation and some strong tests to
...
avoid relying on fuzzy arrows.
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2877683002 .
2017-05-11 17:27:32 -07:00
Stephen Adams
91f9ce3f71
Better type for _match argument in AttributeMatch
...
This fixes two warnings in analyze_api_test:
R=jacobr@google.com
sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
bool _matches(Node node) => node._namespaceUri == null;
^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
bool _matches(Node node) => node._namespaceUri == _namespace;
^^^^^^^^^^^^^^^^^^
Review-Url: https://codereview.chromium.org/2875183002 .
2017-05-11 16:59:17 -07:00
Stephen Adams
f3734a9fc5
dom: Recognize __getter__ indexers
...
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2879663002 .
2017-05-11 13:59:41 -07:00
Lasse R.H. Nielsen
953f78d6dd
Revert "Change some platform libraries to use part of URI
."
...
This makes the analyzer generate a variety of odd errors.
Best guess is that it somehow fails to recognize Object as the Object class
(stack overflow while traversing superclasses, cannot assign Foo<T> to
Foo<Object> and similar errors can be explained by that).
Review-Url: https://codereview.chromium.org/2880543002 .
2017-05-11 11:42:21 +02:00
Lasse R.H. Nielsen
540bb7a0ec
Change some platform libraries to use part of URI
.
...
Use new dart-style. Now needs an SDK built with this checked in as well.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2871123004 .
2017-05-11 10:56:02 +02:00
Lasse R.H. Nielsen
3f90b06836
Rename StreamGroup to GroupedEvents.
...
Avoids clash with StreamGroup from package:async.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2872263003 .
2017-05-11 10:53:21 +02:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Stephen Adams
d9e094b906
Add more arguments to JS pseudo-function
...
TBR=sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869333003 .
2017-05-10 14:03:46 -07:00
Terry Lucas
88a226b58b
New sdk/lib generated from Chrome 50 IDLs
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2871193002 .
2017-05-10 05:26:37 -07:00
Lasse R.H. Nielsen
7157b6aef2
Make Future._nullFuture be initialized synchronously.
...
Also type it as Future<Null> now that it makes sense.
Because there is no reason not to.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2867763003 .
2017-05-10 09:21:08 +02:00