Commit graph

34329 commits

Author SHA1 Message Date
Regis Crelier a604838e22 Update CHANGELOG.md with Random.secure for 1.14.
R=sethladd@google.com

Review URL: https://codereview.chromium.org/1416683002 .
2015-10-19 13:03:05 -07:00
Konstantin Shcheglov d5830fb6a3 Publish analyzer and use it to fix completion in 'for (Type item in^)'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1417613002 .
2015-10-19 12:36:16 -07:00
Konstantin Shcheglov ea947094ae Fix for suggesting methods as a *name* of a local variable declaration.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1417603002 .
2015-10-19 12:29:22 -07:00
Konstantin Shcheglov 4249335a0e Improve incomplete for-each parsing.
Othewise a bizzare structure is returned with identifier in place of a semicolon.
It is easier for client to work with a more correct AST.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1413953003 .
2015-10-19 12:16:26 -07:00
Konstantin Shcheglov efc1d4b224 Ignore contexts in folders named 'packages' or starting with dot.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24614

Review URL: https://codereview.chromium.org/1415713002 .
2015-10-19 11:59:11 -07:00
Alan Knight a9362610ee Hide internal methods like wrap_jso from the dart:html public interface
Issue https://github.com/dart-lang/sdk/issues/24602

R=terry@google.com

Review URL: https://codereview.chromium.org/1409743003 .
2015-10-19 11:28:53 -07:00
pq 568484d106 Bump analyzer_cli DEP.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1417483005 .
2015-10-19 11:19:19 -07:00
pq 186bbfc929 Analyzer version bump.
R=keertip@google.com

Review URL: https://codereview.chromium.org/1412213004 .
2015-10-19 10:57:50 -07:00
Srdjan Mitrovic 465cf10a7c Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current thread
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/1414493003 .
2015-10-19 10:27:36 -07:00
Konstantin Shcheglov 78c7cde132 Improve recovery for local variable declarations.
We need this to improve code completion, and to *not* suggest method/keywords/etc
in cases like "main() {String s^}". Currently it is parsed as "main() {String; s^;}",
so completion cannot distinguish the variable name "s" from a of start a new expression.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1413773003 .
2015-10-19 10:24:21 -07:00
Konstantin Shcheglov e0636b183c Make IndexableObjectKind parameterized.
LMK if this is a bad change.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1413563004 .
2015-10-19 10:13:43 -07:00
Paul Berry 365ea71f78 Fix task model grapher to use package root.
This should avoid errors on the buildbots, which don't run "pub get"
inside pkg/analyzer, and thus don't have a folder pkg/analyzer/packages.

TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/1414763002 .
2015-10-19 10:08:16 -07:00
Konstantin Shcheglov f80bd4203d Index Dart CompilationUnit(s) with the correct context.
We should use the context that they belong to, not the context that we got them through.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410983003 .
2015-10-19 09:59:58 -07:00
pq 140a4f5891 Register .analysis_options files for analysis.
Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/).

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1412213003 .
2015-10-19 09:46:54 -07:00
Paul Berry 6da5bb4ee4 Fix test_hasKnownValue_list_invalid
This test wasn't actually testing anything about lists, and was
redundant with test_hasKnownValue_dynamic.  Correcting the test to match
the probable intention.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413123002 .
2015-10-19 09:40:24 -07:00
Paul Berry c5f4af4df6 Rework task model graphing to work on buildbots.
This CL reworks the task model grapher (formerly at
pkg/analyzer/tool/task_dependency_graph.dart, now at
pkg/analyzer/tool/task_dependency_graph/generate.dart) so that it
works similarly to the code generation in the analysis server.
Namely, the output file is stored in source control
(pkg/analyzer/tool/task_dependency_graph/tasks.dot), and a test run by
the buildbots verifies that it is up to date.  If it is not, the test
outputs the command necessary to update it.

This carries the benefit that:

- Anyone with access to an installation of graphviz can generate the
  task model graph easily from its .dot file.

- Any time a change occurs that affects task model dependencies, a
  test failure will prompt us that we need to generate a new .dot
  file.

- If a change ever occurs that breaks the ability of the task
  dependency grapher to produce the graph, a test failure will prompt
  us.

The downside is that when making a change that affects task model
dependencies, it is now necessary to re-run the script
pkg/analyzer/tool/task_dependency_graph/generate.dart to avoid a test
failure.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1408743006 .
2015-10-19 09:24:18 -07:00
danrubel 948b21a8cf (TBR) update test to run with new task model
Review URL: https://codereview.chromium.org/1413963002 .
2015-10-19 12:04:51 -04:00
Florian Schneider 33eed24b57 VM: Always inline typed data list factories, clean up inliner.
They just redirect to the native typed data list constructor. Inlining
them makes type propagation more precise.  There is no size cost with always
inlining these since they just contain a constructor call.

Also, remove dead code from the inliner: Unoptimized code is not accessed during
optimized compilation anymore.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1416603002 .
2015-10-19 18:03:32 +02:00
Brian Wilkerson 27eb09033f Clean up wording of client usage expectations
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
Brian Wilkerson 8eb408914d Fix library name
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1411523007 .
2015-10-19 07:46:32 -07:00
Brian Wilkerson 3a62346925 Resolve some todos in the graph tool
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1411083002 .
2015-10-19 07:46:05 -07:00
Paul Berry 2d3fe73b36 Fix tests of DartObject.hasKnownValue.
The tests were exercising the semantics of the old (deprecated) method
hasExactValue, and thus they were failing.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1411083004 .
2015-10-19 07:32:54 -07:00
Johnni Winther c3d8f392c5 Extract WorldImpactBuilder from _ResolutionWorldImpact.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1413543004.
2015-10-19 14:31:49 +02:00
Konstantin Shcheglov 3b198ed6ae Disable completion of formal parameter names as *types*.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1414653002 .
2015-10-18 13:28:12 -07:00
Konstantin Shcheglov af4fbdd952 Index library/part file references from import/export/part containing files.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1407863004 .
2015-10-18 10:24:53 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition.
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
Brian Wilkerson b49a389fbf Add missed override
Review URL: https://codereview.chromium.org/1413823002 .
2015-10-17 08:36:54 -07:00
Brian Wilkerson 873d46cbbb Remove MissingTypeError to remove duplicate warnings (issue 24610)
R=leafp@google.com

Review URL: https://codereview.chromium.org/1413743003 .
2015-10-17 08:20:46 -07:00
Brian Wilkerson 204ee60bd0 Add a public API for the results of constant evaluation
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1410643003 .
2015-10-17 07:51:10 -07:00
Siva Annamalai 040637a0e0 Added option --snapshot-after-run to enable an application snapshot to be taken after running the application.
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1413753002 .
2015-10-16 17:10:30 -07:00
Srdjan Mitrovic 8915fb6fde More work for background compilation; move pending_functions_ from ObjectStore to Thread.
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1409173002 .
2015-10-16 17:02:43 -07:00
Konstantin Shcheglov 67576340b0 Declare IndexableObject.file instead of Source.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409203002 .
2015-10-16 14:43:49 -07:00
Brian Wilkerson adb8ebd0e6 Remove obsolete flag to enable package support
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1411833002 .
2015-10-16 13:43:00 -07:00
Ryan Macnak 14b7f9872f dart2js-dump-info: Explicitly pass architecture to test script like already done for build script.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1412823002 .
2015-10-16 13:42:05 -07:00
John McCutchan da946fbf99 Simplify timeline backend
Now that we have a central list of all threads that are interacting with the VM we can stop relying on the Isolate's thread registry to cache timeline blocks.

- Move from caching blocks in the Isolate's thread registry and caching them in the Thread directly.
- This allows cached blocks to have events from multiple isolates, increasing usage density and reducing the number of blocks being cached at any given time.
- We no longer need a distinct global block, this allows me to remove a bunch of dead code.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1402383003 .
2015-10-16 13:36:58 -07:00
Ryan Macnak a08d80b25a Precompilation: Including generative constructor entry points should mark a class as instantiated.
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1405253004 .
2015-10-16 13:32:13 -07:00
John McCutchan a0c50a1836 Fix Windows take 3
BUG=

Review URL: https://codereview.chromium.org/1408743007 .
2015-10-16 13:11:46 -07:00
Brian Wilkerson 3825cf0cd4 Add an experimental domain
R=paulberry@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org/1412683002 .
2015-10-16 12:56:13 -07:00
John McCutchan 5cc6d83127 Fix windows take 2
BUG=

Review URL: https://codereview.chromium.org/1410103002 .
2015-10-16 12:49:22 -07:00
Konstantin Shcheglov 381d3ac549 Require SDK >= 1.12 to start using '?.' syntax.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1412773002 .
2015-10-16 12:45:03 -07:00
John McCutchan d7de5ca71f Add exceptionPauseMode to Isolate response in service.md
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/1408933004 .
2015-10-16 12:26:19 -07:00
Ryan Macnak 783ed2470b Change default build and test architecture to x64.
Precompilation isn't supported on IA32 so local testing misses it.

R=srdjan@google.com

Review URL: https://codereview.chromium.org/1408783005 .
2015-10-16 10:59:08 -07:00
Konstantin Shcheglov ce6614f2dc Disable completion in comment text.
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1410893002 .
2015-10-16 10:38:47 -07:00
Stephen Adams f80d85dee0 Generalize and_operation_on_non_int_operand_test.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1411633002 .
2015-10-16 10:29:14 -07:00
John McCutchan d3f71ec939 Fix windows build
BUG=

Review URL: https://codereview.chromium.org/1411813002 .
2015-10-16 10:21:04 -07:00
John McCutchan e36b9fa3bf Complete support for Windows TLS destructors
- Maintain a list of TLS destructors that should be run when a thread exits.
- Walk that list on thread exit and invoke destructors.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1410493002 .
2015-10-16 10:00:44 -07:00
pq a047373b4f Update DEPS to latest analyzer_cli.
Grabs fixed analyzer_cli.

Also updates linter rev to latest which picks up the linter package version bump.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1406273002 .
2015-10-16 08:48:05 -07:00
Konstantin Shcheglov 18a29ba8a8 Tweak for make test passing with useTaskModel = true.
A real fix after final actual switching.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410493005 .
2015-10-16 08:29:35 -07:00
Asger Feldthaus ee0f98ab33 dart2js cps: Ensure parameter default values are emitted.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1411763002 .
2015-10-16 17:00:32 +02:00
John McCutchan 9c4a0364de Add missing dependency from gen_snapshot to generate_resources_cc_file
BUG=

Review URL: https://codereview.chromium.org/1408113002 .
2015-10-16 07:42:28 -07:00