Commit graph

31967 commits

Author SHA1 Message Date
danrubel 9c9108d51a no keyword suggestions in library identifier or property accessor
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1151493004.
2015-06-12 09:39:40 +02:00
Stephan Herhut 4d0a4e1814 Revert v8 version changes, back to 4.4.
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//1179093004.
2015-06-12 09:37:49 +02:00
Stephan Herhut d9f3e657b4 Temporarily update v8 to 4.3.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1184553003.
2015-06-12 09:34:24 +02:00
Stephan Herhut b01d636bcd Temporarily update v8 to 4.2.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1175333002.
2015-06-12 09:33:47 +02:00
Stephan Herhut 8d6879443a Temporarily update v8 to 4.1.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1177953003.
2015-06-12 09:33:16 +02:00
Stephan Herhut 056da9f8df Temporarily update d8 to 3.31.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1177183002.
2015-06-12 09:29:17 +02:00
Soren Gjesse 82535a6e91 Resolve the executable path on Mac OS when sym-linked
Don't try to test sym-linked files on Windows as Junctions only support
directories.

This helps to locate the Dart SDK (if any) from the path of the dart
executable. On Linux the use of /proc/self/exe already takes care of this.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//1178643007.
2015-06-12 09:26:47 +02:00
Stephan Herhut b652e0f82f Add pattern for IntelliJ project files to gitignore.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1176373002.
2015-06-12 09:01:03 +02:00
Siva Annamalai 298a2f467f Add an assertion to ensure that the return type and types of parameters are canonical or a TypeParameter.
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1182673002.
2015-06-11 18:09:41 -07:00
Gilad Bracha 58708e3ad1 Specify behavior of e?.v++ and e?.v--
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1181733003.
2015-06-11 15:01:06 -07:00
Brian Wilkerson 585402d77f Attempt to fix the build by backing out HTML support
Review URL: https://codereview.chromium.org//1177983003.
2015-06-11 14:44:00 -07:00
pq c0481bf995 Analyzer version bump.
This tags a version that provides options support for consumption by `analyzer_cli`.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1177233006.
2015-06-11 13:47:36 -07:00
Brian Wilkerson 980978c967 Support for parsing HTML in the new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1185443002.
2015-06-11 13:24:20 -07:00
Konstantin Shcheglov f3c28ef449 Don't create navigation regions for not existing sources.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1180883003.
2015-06-11 13:21:12 -07:00
Konstantin Shcheglov c2cc0387a8 Create LibraryElement with SDK context for SDK sources.
This fixes 3 or 6 failing Analysis Server tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1180673008.
2015-06-11 11:57:23 -07:00
pq c23a060539 Supported plugin access.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1179743003.
2015-06-11 11:34:24 -07:00
Konstantin Shcheglov b8067b5fb9 Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying.
This fixes many co19 tests, so I guess it might solve the problems with constants you mentioned.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1183533002.
2015-06-11 10:47:26 -07:00
Konstantin Shcheglov cdced40bd5 Add AnalysisContext.onResultComputed().
Add RESOLVED_UNIT_NO_CONSTANTS as a public result.

Document results that are computed with the task model.
We need this to be able to use onResultComputed() in Analysis Server and
know that we will get enough information.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1181603004.
2015-06-11 10:44:11 -07:00
pq 230f594328 Options plugin API.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1175253005.
2015-06-11 10:42:21 -07:00
pq 829f2da883 Type fix.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1181723002.
2015-06-11 10:40:01 -07:00
Paul Berry b715b97147 Don't visit named argument labels when computing constant dependencies.
This fixes some crashes with the new task model.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1178203002.
2015-06-11 10:36:36 -07:00
Konstantin Shcheglov 99ce0f107f Remove dead code.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1182443005.
2015-06-11 10:04:56 -07:00
Konstantin Shcheglov ad2ac9f1fe Add AnalysisDriver.onResultComputed().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1179753002.
2015-06-11 08:12:31 -07:00
Konstantin Shcheglov f584413999 Build LIBRARY_ELEMENT after RESOLVED_UNIT6 for all units in the closure of a library.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1177963002.
2015-06-11 08:05:59 -07:00
Johnni Winther ee1be89b30 Support foreigns as external.
BUG=

Review URL: https://codereview.chromium.org//1169083004.
2015-06-11 15:27:56 +02:00
Johnni Winther 8a0c73cf4c Move computeType to TypedElement and TypeDeclarationElement.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1172693003.
2015-06-11 15:17:52 +02:00
Johnni Winther 6414489318 Remove computeSignature from FunctionElement.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1165363004.
2015-06-11 15:07:34 +02:00
Stephan Herhut 69d7a01b06 dart2js: Fix minor indentation issues.
BUG=
TBR=karlklose@google.com

Review URL: https://codereview.chromium.org//1173423002.
2015-06-11 14:47:36 +02:00
Stephan Herhut dfcadddb11 dart2js: Fix hints in code base.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1173403002.
2015-06-11 13:11:17 +02:00
Karl Klose e4b56654ff Update dart2js-cps_ir test expectations with better annotations.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1181613003.
2015-06-11 10:56:56 +02:00
Stephan Herhut e0e96624b9 dart2js: Use frequency of occurence to sort metadata indices.
BUG=
R=johnniwinther@google.com, karlklose@google.com, sigurdm@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1153243003.
2015-06-11 10:13:32 +02:00
Rico Wind eb3e510b41 Add uploaded linux arm d8 sha file
TBR=sra@google.com
BUG=

Review URL: https://codereview.chromium.org//1180743003.
2015-06-11 09:16:24 +02:00
Karl Klose c4ef9e3420 Mark tests as passing in host-checked mode after 953a6fd75f.
TBR=asgerf@google.com

Review URL: https://codereview.chromium.org//1181543003.
2015-06-11 08:41:04 +02:00
Regis Crelier 9edc6e5a6d Detect zero receiver of modInverse (may not converge and time out
in that case).

See #23502

Review URL: https://codereview.chromium.org//1177063002.
2015-06-10 16:40:24 -07:00
Stephen Adams 7fb7d0f011 Include all allocations in trivial dead-store elimination
This will eliminate dead scope boxes, e.g. https://github.com/dart-lang/sdk/issues/16816

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1177603002.
2015-06-10 16:36:22 -07:00
Brian Wilkerson caa03b0b9f Capture more errors and improve duplicate error removal
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1176983002.
2015-06-10 16:32:45 -07:00
Regis Crelier 90315a1694 Remove bigint reference in js_number.dart
Review URL: https://codereview.chromium.org//1177873002.
2015-06-10 15:34:43 -07:00
Regis Crelier f6f338ce67 Implement modInverse (bigint version does not support even modulus yet).
Added tests.

See #23502

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1174513004.
2015-06-10 15:01:46 -07:00
Paul Berry c03b8fe451 Ensure that prefix?.loadLibrary() generates the proper compile-time error.
loadLibrary() is special-cased in analyzer, so we need special-case
code to make sure that it can't be invoked using "?.".

Fixes #23463.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1177833002.
2015-06-10 14:43:46 -07:00
Ryan Macnak f2b59c3ed9 Make guard_cid and nullable_cid half words.
Add missing half-word instructions for ia32/x64.

46.0kB -> 38.4kB (-16.5%) of Field in hello world

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1176703002.
2015-06-10 14:14:50 -07:00
Paul Berry 2f610a3ff5 Report a compile-time error if a const field is multiply initialized.
This CL makes analyzer consistent with the VM and the spec, by
producing a compile-time error for code such as:

    class C {
      final x = 1;
      const C() : x = 2;
    }
    main() {
      const C();
    }

Note that Dart2js also produces an error in this circumstance, but its
error is too general (the error should only be produced if the const
constructor is invoked using "const"; if the const constructor is
invoked using "new", or is not invoked at all, it should only be a
warning).  See #23618.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1175073002.
2015-06-10 14:02:43 -07:00
Brian Wilkerson e1ba93c4f1 Filter additional error codes
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1169833007.
2015-06-10 13:27:03 -07:00
Srdjan Mitrovic acadc9017c Inline instanceOf and 'as' operations; fix a bug in code emission
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1175803003.
2015-06-10 13:17:51 -07:00
Gilad Bracha c448d7fb0b Make package: URI schema implementation dependent per latest DEP.
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1170393002.
2015-06-10 12:36:31 -07:00
Srdjan Mitrovic d9860cb6bc Fix printing of stack overflow stacktraces
BUG=23614
R=asiva@google.com

Review URL: https://codereview.chromium.org//1174083002.
2015-06-10 11:28:21 -07:00
Brian Wilkerson f2954e5237 Fix a test to work with the new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1175843003.
2015-06-10 09:05:41 -07:00
Asger Feldthaus ff104736f2 dart2js cps: Handle type variables in factory constructors.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1179503002.
2015-06-10 15:04:43 +02:00
Rico Wind 149e832c81 Remove suppression for LibTest/math/sin_A01_t02 on v8
The rolll to 4.4 has eliminated this issue

R=sra@google.com
BUG=

Review URL: https://codereview.chromium.org//1173023002
2015-06-10 14:26:27 +02:00
Asger Feldthaus 953a6fd75f dart2js cps: Clean up in type propagation.
Class names are no longer private. optimizers.dart whitelists the class
that needs to be exposed, so the privacy makes little difference.

Methods on AbstractValue that require access to the type system or
other "external thing" have been moved to ConstantPropagationLattice.
It should help readability and avoid parameter inflation when more
external things are suddenly needed to answer a query.

The UnitTypeSystem has been removed and TypeSystem has been merged
into TypeMaskSystem. The generic variable T has been removed as well.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1173563002.
2015-06-10 14:04:36 +02:00
Florian Schneider 09b59b6c16 Fix checked mode service test.
The object pool is not an Instance, but a VM object now.

TBR=johnmccutchan@google.com,

Review URL: https://codereview.chromium.org//1174943002.
2015-06-10 13:24:09 +02:00