Commit graph

89066 commits

Author SHA1 Message Date
Konstantin Shcheglov 98b146d881 Use analyzeExpression() in more places, so resolve SwitchExpression.
Change-Id: Ibd715c6a8fbe8aad07daebef42a544629e42fbe0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-07 00:18:27 +00:00
Chloe Stefantsova 4b1eba51eb [cfe] Handle rest patterns in map patterns
Part of https://github.com/dart-lang/sdk/issues/49749

Closes https://github.com/dart-lang/sdk/issues/50886

Change-Id: Ie44c35030aa3e74ab0b65f2e0abd0c5fb207976e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278501
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
2023-01-07 00:09:45 +00:00
pq 5b2d70625a process sdk constraints in options validation
Change-Id: I3326d3b894939b26289416b66239bf98d31d8309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2023-01-06 23:50:48 +00:00
Konstantin Shcheglov 256f79cd96 Extract VariablePattern, use it to infer implicit field/getter names.
Change-Id: I47e594592d574747674199e81b7556cf50464a1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278642
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-06 22:54:27 +00:00
Konstantin Shcheglov 5879990be0 Separate WildcardPattern and its shared analysis.
Change-Id: I39fc26fa2f3390338cd14433248dd58c51fd3d1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278527
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-06 20:32:26 +00:00
Nate Biggs 0b4215c9f5 [dart2js] Fix sound null safety bug in serialization.
`null` is a valid key in the cache as it has a specific serialization index that gets tracked.

Change-Id: Id39e44bb1cd8e8015a851aeb89620e6891430940
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278580
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2023-01-06 20:23:11 +00:00
Brian Wilkerson 98ea469c0d Add information about how to write diagnostic documentation
I thought it would be good to capture some of the information we have
about how the documentation for the analyzer diagnostics are currently
written.

I'm mostly interested in making sure that the description is clear.

We can update this if there are changes we decide to make going forward.

Change-Id: I27c78ce04fb86d0263a1081d7c8f42c3ebfa7b0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278534
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
2023-01-06 19:18:49 +00:00
Paul Berry 5d7b701d12 Remove dart migrate command.
Bug: https://github.com/dart-lang/sdk/issues/50319
Change-Id: I216a20afe8382eab5872672b2e01ed1daf7ac78d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278367
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2023-01-06 17:21:35 +00:00
Ahmed Ashour 11a25ca0b3 Reland "[analyzer] add UNNECESSARY_NAN_COMPARISON hint"
This is a reland of commit 254da67495

Original change's description:
> [analyzer] add `UNNECESSARY_NAN_COMPARISON` hint
>
> Fixes #44649
>
> Change-Id: I3784f7222a217e5b6ca485c02e9a889964ffcc8c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269881
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: I868d46df69f178094742d9193de5d347ea2cc60b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278440
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2023-01-06 17:00:16 +00:00
Danny Tuppeny 5b50a61918 [dds/dap] Fix handling of errors when fetching full strings
Fixes https://github.com/dart-lang/sdk/issues/50802.

Change-Id: Ia2bda968708f34aa48c6b92b2f19c24c603fb85c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278349
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2023-01-06 16:54:03 +00:00
Sam Rawlins e0b193959f [test_runner] move hint filtering out of analyzer_cli into test_runner
Fixes https://github.com/dart-lang/sdk/issues/50887

Change-Id: I770b56b908d76f728f58b96e57928c412eebbafd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278370
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2023-01-06 16:51:53 +00:00
Kevin Chisholm 68358bceee update changelog to reflect Metrics API deprecation
Change-Id: I92138c3a1dbf6be150f9b695d759034d2058d365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278531
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2023-01-06 15:56:58 +00:00
William Hesse e8283b0839 [io] Improve scheduling of IO worker threads
The allocation of the at most 32 IO worker threads to IO requests
includes an inefficient check that a thread is free, when a request
completes.

A server application was taking 5% of its time running this check,
which is a .contains call on HashMap.values.

This CL replaces it with a use count on each IO thread, which is
checked against 0.

Bug: https://github.com/dart-lang/sdk/issues/50907
Change-Id: I6d13f9c62d36c34f165b2b4e32a48caeb6f9a77b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278503
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2023-01-06 15:47:57 +00:00
Ben Konyi 112e1213dc [ package:dds ] Prep for 2.6.0 release
Change-Id: I7ffcd1c9cdf23906324ef77521216bb293259c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276620
Reviewed-by: Dan Chevalier <danchevalier@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2023-01-06 15:26:34 +00:00
Alexander Markov b214bb03b0 [vm/compiler] Propagate static types through record field accesses
TEST=TypePropagator_RecordFieldAccess

Issue: https://github.com/dart-lang/sdk/issues/49719
Change-Id: I18f8fc1ca1c97722f10b280afbe943bb4c948e17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278520
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2023-01-06 15:15:08 +00:00
Johnni Winther c70d266270 [cfe] Support external constructor with final fields
This adds support for having a final field and an external constructor
without error, assuming that the external constructor initializes the
final field. This supports the inline class with external members use
case.

Change-Id: Ie297ccc39b0a0731c146f9ac0698bba3fd83bfeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278502
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
2023-01-06 12:25:21 +00:00
Jens Johansen 79fd3dde08 [parser] 'on' after 'try' is always an on-clause
https://github.com/dart-lang/language/blob/master/accepted/future-releases/records/records-feature-specification.md#ambiguity-with-on-clauses

Fixes https://github.com/dart-lang/sdk/issues/49980

Change-Id: I0dadbdd5bf7ac1fef69191e38eaaa705cda60f2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275922
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2023-01-06 11:11:59 +00:00
Jens Johansen e34600d8b8 [CFE] Fix crash on parse error in try on clause
Change-Id: I82de28c4a44cbb9a671ba96455e7955c9fc7f6e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278340
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2023-01-06 09:56:46 +00:00
Josh Soref 50b94ef9fc Spelling runtime bin
TEST=build VM

Closes: https://github.com/dart-lang/sdk/pull/50862

GitOrigin-RevId: ae54b37666f70f670ee3af11c984c7e9a7e9da26
Change-Id: I459fda0439a1cd368f488a70d84ee6bb915e60bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277761
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2023-01-06 07:48:22 +00:00
Ahmed Ashour 6664304545 [analysis_server] add fix for super_invocation_not_last
Fixes #50829

Change-Id: I0428fc8118bc99f4df45c231f70b3de43faddb05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277140
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2023-01-06 02:08:05 +00:00
Sam Rawlins a5912c6c58 Enforce strict-casts in analyzer
Broadly, this _adds_ text to the code, as making something explicit which was previously implicit generally requires adding characters. The fixes are of the form:

* `int x = y /* dynamic */;` --> `var x = y as int;`
* `Map<A, B> x = y; --> `var x = y.cast<A, B>();`

Most of the changes are in code which has parsed YAML or which has parsed arguments. Go figure. :)

Change-Id: I1107688bf4ce9c1ec3ed6a4cef56d4d968048e2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278522
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-06 01:59:47 +00:00
Ahmed Ashour a174b981e4 [analysis_server] associate RemoveAnnotation with some diagnostics
Fixes #50788

Change-Id: Iea8753c00b61366e23301937a48fadaadb065082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-05 22:51:32 +00:00
Konstantin Shcheglov 719a0629b1 Report DUPLICATE_REST_ELEMENT_IN_PATTERN-REST and REST_ELEMENT_NOT_LAST_IN_MAP_PATTERN.
Change-Id: I4bf3446a10ab8e280f9b73220384f8daf96171c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278523
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-05 21:44:40 +00:00
Konstantin Shcheglov fb918203ac Test that parsing patterns in ForPartsWithExpression works.
Change-Id: I91b91f8fa0fb503dcdabbe3f4ae6892ad0c59697
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-05 21:10:19 +00:00
Danny Tuppeny f11bec54e0 [analysis_server] Don't include default values when adding type annotations
Fixes https://github.com/Dart-Code/Dart-Code/issues/4312.

Change-Id: Id5376d6ad28b7af3a64c49014e4c32306a420d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2023-01-05 16:51:18 +00:00
Paul Berry 69f4dc0dcd Remove unused parts of migration tooling
Change-Id: Ib18224f42880c47be63e6f6814db99ac05eced48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278373
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2023-01-05 15:59:07 +00:00
Chloe Stefantsova e925066175 [cfe] Adjust scoping for variable patterns in switch expressions
Part of https://github.com/dart-lang/sdk/issues/49749

Change-Id: I32f3ebf6c45afbbdc291d8f919b14266b646b998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278347
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
2023-01-05 15:49:44 +00:00
Konstantin Shcheglov 18566d0cb6 Report duplicate rest patterns in list/map patterns, and not-last rest pattern in map pattern.
Change-Id: I48238cc230f5a1bcff1e1cb4ab80731c2b978396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278369
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2023-01-05 15:40:18 +00:00
Ahmed Ashour 17abdd6d2d [flow analysis] fix label statement
Fixes #50294

Change-Id: I39503270f82788a9edb4ce6c53251b0e0ebb05fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277400
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2023-01-05 13:49:40 +00:00
Chloe Stefantsova 4a8c6fa480 [cfe] Support guards and multiple heads in pattern switch statements
Part of https://github.com/dart-lang/sdk/issues/49749

Change-Id: I6c0dcd4bd2cb7921c27168b71f61f1793c8b2a12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278182
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
2023-01-05 11:36:28 +00:00
Michael Thomsen be3d924873 Roll pub to pick up Dart 3 alpha output change:
https://github.com/dart-lang/pub/pull/3723

Bug: n/a
Change-Id: Icab24cb3dfe31df59c6afbe70336b92b7f9aa8df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278348
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2023-01-05 10:48:50 +00:00
Ahmed Ashour 8b32c3ecb8 [CFE] PRESUBMIT to handle dictionaries on Windows
Fixes #50891

Change-Id: Iddbbe17290548683bd141b74da5106a0be154bc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278345
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2023-01-05 08:59:08 +00:00
Johnni Winther 9aa28ddc3b [cfe] Support inline generative constructor access
Change-Id: I4608f2fe8ab0a067814639c9dd160a690c3dad84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278180
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2023-01-05 08:53:38 +00:00
Ahmed Ashour 4bf325dd90 [analysis_server] remove unneeded new
Fixes #49901

Change-Id: I7729e29c1e7ca73a824762156fd68d5d8a2516fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258243
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-05 03:05:58 +00:00
Josh Soref 1ab011a2a7 Spelling tests web
Closes https://github.com/dart-lang/sdk/pull/50879

TEST=only changes to spelling to comments and internal string messages
GitOrigin-RevId: 3fa4104fa17054ea2247118a1b6213c62f2749e0
Change-Id: I776120bb2492c662dd32612dd2f6a670b5891e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278060
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-01-05 01:26:52 +00:00
Jackson Gardner 4970f7fa82 [dart2wasm] Emit code for assert initializers.
Change-Id: I0eb69de0027e51c7b821c2da045fe91d65ab4dc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278091
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Jackson Gardner <jacksongardner@google.com>
2023-01-05 00:23:40 +00:00
Simon Binder 3b1fbb9cd8 [analyzer] Add facility to instantiate record types
This adds the `recordTypeWith` method to `TypeProvider`, a method
instantiating a record with provided positional and named fields.

By instantiating specific record types, we can match user-defined types
against specific record structures, for instance to validate that a
user-defined type is compatible to a certain record. For me, this would
be a helpful addition to the analyzer's public API.

Change-Id: I52e70eb0cbb0a0edf919b7b0f8901e6de1e00a64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2023-01-04 22:35:28 +00:00
Konstantin Shcheglov c7f509379d Report NON_CONSTANT_RELATIONAL_PATTERN_EXPRESSION
Change-Id: I2ef6ad04d9dfcc51faa239ddeae3122bfe969672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278366
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-04 22:23:38 +00:00
Devon Carew e6c14da280 [deps] rev bazel_worker, benchmark_harness, boolean_selector, browser_launcher, clock, crypto, csslib, dartdoc, html, http, http_multi_server, intl, package_config, pool, protobuf, pub_semver, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, test_reflective_loader, watcher, web_socket_channel, yaml
Revisions updated by `dart tools/rev_sdk_deps.dart`.

bazel_worker (9f21e1d..b35c25e):
  b35c25e  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#66)

benchmark_harness (ee7a253..76881df):
  76881df  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#80)

boolean_selector (5082b3d..ba7d86b):
  ba7d86b  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#41)

browser_launcher (2712dda..f2f01e4):
  f2f01e4  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#37)

clock (8a8231f..6b8b7bf):
  6b8b7bf  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#41)

crypto (bf0c33b..f854f2f):
  f854f2f  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#138)

csslib (34203c0..d776535):
  d776535  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#156)

dartdoc (ce25524..9ed196f):
  9ed196f1  2023-01-03  Sam Rawlins  Move many test files to test_reflective_loader (#3284)

html (28fb8b9..3dd00b0):
  3dd00b0  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#193)

http (38d5dd9..d434d42):
  d434d42  2023-01-03  Brian Quinlan  Make it possible to use a custom CronetEngine with runWithClient (#843)

http_multi_server (e31c698..beb40a7):
  beb40a7  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#47)

intl (59e7bff..c61fdd1):
  c61fdd1  2023-01-04  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#528)
  2a5e3a2  2023-01-04  Copybara-Service  Merge pull request #527 from mateendev3:patch-2
  07a5847  2022-12-31  Mateen Mehmood  Update date_format.dart

package_config (abb4aec..2e1a8ec):
  2e1a8ec  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#128)

pool (1ea5b03..713e631):
  713e631  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#59)

protobuf (1d1c92a..dd04535):
  dd04535  2023-01-04  Mahdi K. Fard  Fix avoid_renaming_method_parameters linter warning. (#783)
  4b1fc34  2023-01-04  Mahdi K. Fard  Removes a non-existing lint rule. (#784)

pub_semver (1723111..3946e33):
  3946e33  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#76)

source_map_stack_trace (8d8078f..e5f9564):
  e5f9564  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#31)

source_maps (b031e2c..d995912):
  d995912  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#70)

source_span (d1d47e5..72d5c55):
  72d5c55  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#89)

sse (2de27fe..3c37edb):
  3c37edb  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#73)

stack_trace (cf3562e..c08ee90):
  c08ee90  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#125)

stream_channel (9143047..0a7800a):
  0a7800a  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#83)

term_glyph (822cd5b..2bf4594):
  2bf4594  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#30)

test (8235a25..3415089):
  34150897  2023-01-03  dependabot[bot]  Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (#1838)
  5f01dd97  2023-01-03  dependabot[bot]  Bump github/codeql-action from 1.0.26 to 2.1.37 (#1839)

test_descriptor (13dbc20..b73c691):
  b73c691  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#46)

test_process (1774aa7..62ea2ba):
  62ea2ba  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#37)

test_reflective_loader (52b6753..cf58259):
  cf58259  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#43)

watcher (3259107..2e0db71):
  2e0db71  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#132)

web_socket_channel (a90e740..ebd0fe9):
  ebd0fe9  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#244)

yaml (f699275..02be51e):
  02be51e  2023-01-03  dependabot[bot]  Bump actions/checkout from 3.1.0 to 3.2.0 (#133)

Change-Id: I56af76e89a75b0712b290ea154f606781183bec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278368
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-04 21:48:02 +00:00
Brian Wilkerson 1170c55eaa Update the checklist for new language features
Change-Id: I4022bd3a79be25d006178ad681effd035ff7f9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277045
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2023-01-04 21:47:32 +00:00
Konstantin Shcheglov 445085471d Report NON_CONSTANT_MAP_PATTERN_KEY and EQUAL_KEYS_IN_MAP_PATTERN.
Change-Id: I20922047abe62292b84798b7cf540d93f1b5f0d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-01-04 21:21:30 +00:00
Nate Biggs 1469539e65 [dart2js] Fix type of _RecipeToIdentifier.
Change-Id: I59396791e23b5ea96848afeb087c795be389e041
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278420
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 20:49:01 +00:00
Konstantin Shcheglov 79e6beaf7d Prepare to publish analyzer 5.4.0 and _fe_analyzer_shared 52.0.0
Change-Id: Iafb9a1f8d5ce9f8502795192c9cbc6b26cb337c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278300
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-04 19:33:48 +00:00
Konstantin Shcheglov 6669eca110 Separate LogicalAndPattern and LogicalOrPattern.
Change-Id: Ie1202dc99cdddd59f0233992dd15b521758990e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278301
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-01-04 19:08:39 +00:00
Nate Biggs cb87060664 [dart2js] Clean up leftover null safety hints.
Change-Id: Iebc59835018d2181760d3b6afc4cf18988c9dfb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278260
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2023-01-04 18:36:38 +00:00
Nate Biggs a1dc4a9e76 [dart2js] Migrate memory compiler and helpers to null safety.
Change-Id: I578549e18acfeba4c450033b76959a0899b11fc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278244
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 18:36:38 +00:00
Nate Biggs 0a8521f2da [dart2js] Migrate more files outside of the main dart2js app.
Change-Id: I9f717f70e7166f449196d71b1c06967553dbb0cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278243
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 18:36:38 +00:00
Nate Biggs 692a4950b0 [dart2js] Clean up null safety migration partial migrated files.
Change-Id: Ieecbad0b192a65118a7aa1e400a792661a339a3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278242
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 18:36:38 +00:00
Nate Biggs 093d67157a [dart2js] Clean up null safety migration interfaces for compiler.dart.
Change-Id: I8aa5ef1600648262e605073c36ad31af3e46b0ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278241
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 18:36:38 +00:00
Nate Biggs ddb9b8f7a7 [dart2js] Clean up some null safety migration interfaces.
Change-Id: I5c4d813ba724b9649e3687b0b4b69a68b26cd0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278240
Reviewed-by: Mayank Patke <fishythefish@google.com>
2023-01-04 18:36:38 +00:00