Commit graph

13338 commits

Author SHA1 Message Date
Stephen Adams 94df5a0c24 dart2js: Avoid empty else clauses in generators.
R=sigurdm@google.com

Committed: a02c5798a4

Review URL: https://codereview.chromium.org/1916863002 .

Reverted: 803826256d
2016-07-26 09:58:34 -07:00
John McCutchan 50c141d298 Mark closure identity test as pass, fail for reload bots
BUG=

Review URL: https://codereview.chromium.org/2181233003 .
2016-07-26 06:38:06 -07:00
Jacob Richman 9648db46be TBR. Add back line that should not have been removed.
BUG=

Review URL: https://codereview.chromium.org/2179253002 .
2016-07-25 17:53:27 -07:00
Konstantin Shcheglov f8c32c5ea1 Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of function typed constructor parameters.
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26860

Review URL: https://codereview.chromium.org/2178123003 .
2016-07-25 14:56:47 -07:00
Jacob Richman 410cde6023 Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status
Update pkg/js CHANGELOG.md to address comment from previous CL.

BUG=

Review URL: https://codereview.chromium.org/2179153002 .
2016-07-25 13:20:25 -07:00
Jacob Richman 96ca5db7e5 Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js.
BUG=
R=alanknight@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2150313003 .
2016-07-25 09:59:01 -07:00
Johnni Winther 6549cd24af Split serialization tests further
+ add helpers to compute the split for reuse between tests.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2162053005 .
2016-07-25 10:36:37 +02:00
William Hesse 5790e88f00 Update status for co19 test that also fails on linux Chrome 53.
Also change status for dart2js_native/native_call test from compile-time
error to a runtime error.

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2173653004 .
2016-07-22 18:51:22 +02:00
William Hesse 0502a04122 Update status for Chrome 53
BUG=
TBR=kustermann@google.com

Review URL: https://codereview.chromium.org/2175573003 .
2016-07-22 16:05:45 +02:00
Jacob Richman bbb0c3f727 Seems like this is all that is required to support callable JS objects. dartbug.com/25321
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2164483004 .
2016-07-20 13:16:37 -07:00
John McCutchan f79756b88d Hot reload status file updates
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
2016-07-20 11:02:23 -07:00
William Hesse ca49303576 Revert "Add fast-mode Uri class."
This reverts commit 00090a0c72.

Revert "Add fast-mode Uri class."

This reverts commit 323ca7e410.

Revert "Fix regression for the one case where we deliberately don't follow the RFC."

This reverts commit b39e048c4b.

Revert "Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key."

This reverts commit a11ad27723.

BUG=https://github.com/dart-lang/sdk/issues/26917
TBR=keertip@google.com

Review URL: https://codereview.chromium.org/2167663002 .
2016-07-20 14:32:52 +02:00
Jacob Richman bcf224b3e6 Regression tests for 25658 and 24817.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168493002 .
2016-07-19 17:08:58 -07:00
Alan Knight 4db29e8fbc Add a couple of additional XSS tests
BUG=

Review URL: https://codereview.chromium.org/2160413002 .
2016-07-19 13:37:45 -07:00
Keerti Parthasarathy 69a8b11f67 Fix for uri replace whene uri has fragment. Was adding a second '#'.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2158933003 .
2016-07-18 16:31:43 -07:00
Alan Knight 30b489578d Revert "Reapply zone tasks."
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00
Harry Terkelsen c5728623b9 remove dependency on compiler from resolution
This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2123073003 .
2016-07-18 10:40:21 -07:00
Johnni Winther 941691650c Split out long-running serialization test and add timings to output
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2156033002 .
2016-07-18 14:09:53 +02:00
Johnni Winther 3305201211 Serialize this-types in NativeBehavior separately.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2150333002 .
2016-07-18 10:42:23 +02:00
Alan Knight 2107c13ba2 Adjust FF/Win status for webgl extension tests
BUG=

Review URL: https://codereview.chromium.org/2161443002 .
2016-07-15 17:27:08 -07:00
Alan Knight e610d803b1 Update test status for webgl extension tests, fix one typo in extension name
BUG=

Review URL: https://codereview.chromium.org/2152393002 .
2016-07-15 15:00:15 -07:00
John McCutchan 7fa9393105 Remove windows debug print and trace shutdown on some tests
BUG=

Review URL: https://codereview.chromium.org/2153813003 .
2016-07-15 14:53:54 -07:00
Ryan Macnak c41c249f75 Remove reference to deleted flag --print-object-histogram.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2153193002 .
2016-07-15 12:50:03 -07:00
Alan Knight b9316f9882 Recognize WEBGL extensions on Firefox (copy with regenerated files)
Both of the following objects need to map to Dart type 'AngleInstancedArrays'

    [object ANGLEInstancedArrays]
    [object ANGLE_instanced_arrays]

Fixes https://github.com/dart-lang/sdk/issues/26850

BUG=

patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1)

R=sra@google.com

Review URL: https://codereview.chromium.org/2150003002 .
2016-07-15 12:48:22 -07:00
Stephen Adams 1eee3c7dc7 dart2js js_runtime: faster code for floor() & ceil()
Within the [-2^31, 2^31) range it is faster to truncate and correct at boundaries than call Math.ceil/Math.floor.

Each call to toInt() has been specialized to the calling operator (ceil, floor, ~/ etc).

This makes the conversion faster (values are already integral) and lets us put the name of the operation and original operands in conversion errors, e.g

(a / b).floor();  // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Infinity.floor()

a ~/ b;   // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Result of truncating division is Infinity: 132 ~/ 0

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1405113003 .

Downside: an extra 400 bytes
2016-07-15 12:27:59 -07:00
John McCutchan c692a64e5a Rework how enums are implemented and reloaded
- Enum instances now hold their index and their label. Before the labels were held in a static array to the side and the index was used to look up the label.

- Before and after reload enum instances are now paired (by label) and put into the 'become' table.

Fixes https://github.com/dart-lang/sdk/issues/26877

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2153143002 .
2016-07-15 10:52:20 -07:00
Johnni Winther 5c5a46a6e1 Serialize data for LibraryElement.getImportsFor
R=het@google.com

Review URL: https://codereview.chromium.org/2150533002 .
2016-07-15 10:16:51 +02:00
Johnni Winther 72fed51ac0 Enable deferred tests on d8/Windows.
The preamble now sets up the currentScript property.

R=het@google.com

Review URL: https://codereview.chromium.org/2141423002 .
2016-07-15 10:02:04 +02:00
Johnni Winther f2e435ba88 Serialize prefix members.
R=het@google.com

Review URL: https://codereview.chromium.org/2150493002 .
2016-07-15 09:55:34 +02:00
Johnni Winther 9214293d29 Test ImportElement and fix PrefixElementZ.isTopLevel
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2150473002 .
2016-07-15 09:47:29 +02:00
John McCutchan 6c27b6e381 Tweak for hot reload status file
Enum identity tests can sometimes pass.

BUG=

Review URL: https://codereview.chromium.org/2147183003 .
2016-07-14 07:56:56 -07:00
John McCutchan c6141005a9 More status file updates for hot reload
BUG=

Review URL: https://codereview.chromium.org/2151743003 .
2016-07-14 07:14:25 -07:00
Stephen Adams 8ab2c30bae Fix html/js_type_test for Dartium
... by moving @JS code into a separate library.

TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/2146283002 .
2016-07-13 19:00:34 -07:00
Stephen Adams 0b4a3d8da7 Type test tests for js interop
R=jacobr@google.com
TBR=jacobr@google.com

Committed: 081eec517b

Review URL: https://codereview.chromium.org/2133563002 .

Reverted: 093604ce51
2016-07-13 17:48:53 -07:00
Todd Turnidge 77b99396e8 Disallow deferred loading when using isolate reloading.
Update status files.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2144113002 .
2016-07-13 15:25:06 -07:00
John McCutchan 80cca0ec0e More status file updates for reload bots
BUG=

Review URL: https://codereview.chromium.org/2146043002 .
2016-07-13 09:19:20 -07:00
Ryan Macnak cdacb9b8a2 Update status files for caching-JIT snapshots.
Review URL: https://codereview.chromium.org/2144813004 .
2016-07-12 18:31:40 -07:00
Ryan Macnak 597e933f17 Update status files for product mode.
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2143803002 .
2016-07-12 15:57:46 -07:00
John McCutchan 04dc67e2b3 More hot reload status file updates
BUG=

Review URL: https://codereview.chromium.org/2143213002 .
2016-07-12 13:54:16 -07:00
John McCutchan 09944945ab Update service.status for hot_reload
BUG=

Review URL: https://codereview.chromium.org/2142143003 .
2016-07-12 12:41:20 -07:00
Ryan Macnak b7539aaf11 Triage hot reload mirrors failures.
BUG=http://dartbug.com/26836
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2136283003 .
2016-07-12 11:15:27 -07:00
Brian Wilkerson afd21330f7 Generalize the first argument in an assert to be an expression (issue 26865)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140673004 .
2016-07-12 11:02:51 -07:00
Regis Crelier 9ebf264b70 Update dart2js language status file with crashing tests (issue was filed).
R=asiva@google.com

Review URL: https://codereview.chromium.org/2146533002 .
2016-07-12 10:50:13 -07:00
John McCutchan fbe4227c9e Hot reload co19 status updates
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2139343002 .
2016-07-12 10:42:15 -07:00
Johnni Winther 38dd1553e8 Support checked mode
Checked mode checks are now always stored in the WorldImpact meaning that
data doesn't have to be serialized with checked mode enabled.

R=het@google.com

Review URL: https://codereview.chromium.org/2129183002 .
2016-07-12 10:10:12 +02:00
Regis Crelier 455110c6ee Tighten check disallowing use of initializing formals (fixes #26855).
Add regression test.
Add exception for analyzer (filed an issue).

R=asiva@google.com

Review URL: https://codereview.chromium.org/2139003002 .
2016-07-11 15:30:24 -07:00
John McCutchan 257bd302bb Update language.status for hot reload tests
BUG=

Review URL: https://codereview.chromium.org/2134393002 .
2016-07-11 14:40:15 -07:00
John McCutchan 24a0988df6 Hot reload fixes for isolate tests
- [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....)
- [x] Only check that an isolate has reload if it was ever runnable.
- [x] Skip some isolate tests that use deferred libraries or are checking for closure identity.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2141763002 .
2016-07-11 13:58:26 -07:00
John McCutchan ef71bc1834 Improve hot reload test mode
- [x] Start reloading even earlier.
- [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too).
- [x] Adjust the reload every back off curve to be linear in the beginning.
- [x] Cap the reload every threshold at 1,000,000
- [x] Test status file updates.
- [x] Stop disabling the background compiler / OSR when running tests.
- [x] Skip multi tests with compilation errors when reloading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2133823002 .
2016-07-11 12:29:13 -07:00
Stephen Adams 093604ce51 Revert "Type test tests for js interop"
Need suppress or to investigate alternative to script injection for cps mode

BUG=

Review URL: https://codereview.chromium.org/2134973002 .
2016-07-08 20:21:47 -07:00