After status files are updated with failures from this run, we will try again.
R=brian.wilkerson@google.com
Revert "DEPS ans status files updated to the last co19 commit (#29604)"
This reverts commit 70b2b3f6b1.
Revert "Fix typos introduced in DEPS by 70b2b3f6b1bb2def061f80b7693cd89e23fa9134"
This reverts commit 9e9f7210d0.
BUG=
Review-Url: https://codereview.chromium.org/2933403002 .
Linter `0.1.31`:
* New `prefer_foreach` lint.
* New `use_string_buffers` rule.
* New `unnecessary_overrides` rule.
* New `join_return_with_assignment_when_possible` rule.
* New `use_to_and_as_if_applicable` rule.
* New `avoid_setters_without_getters` rule.
* New `always_put_control_body_on_new_line` rule.
* New `avoid_positional_boolean_parameters` rule.
* New `always_require_non_null_named_parameters` rule.
* New `prefer_conditional_assignment` rule.
* New `prefer_conditional_assignment` rule.
* New `avoid_types_on_closure_parameters` rule.
* New `always_put_control_body_on_new_line` rule.
* New `use_setters_to_change_properties` rule.
* New `avoid_returning_this` rule.
* New `avoid_annotating_with_dynamic_when_not_required` rule.
* New `prefer_constructors_over_static_methods` rule.
* New `avoid_returning_null` rule.
* New `avoid_classes_with_only_static_members` rule.
* New `avoid_null_checks_in_equality_operators` rule.
* New `avoid_catches_without_on_clauses` rule.
* New `avoid_catching_errors` rule.
* New `use_rethrow_when_possible` rule.
* Many lint fixes (notably `prefer_final_fields`, `unnecessary_lambdas`, `await_only_futures`, `cascade_invocations`, `avoid_types_on_closure_parameters`, and `overridden_fields`).
* Significant performance improvements for `prefer_interpolation_to_compose_strings`.
* New `unnecessary_this` rule.
* New `prefer_initiliazling_formals` rule.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2865163002 .
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.
The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.
This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.
As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.
This change is a prerequisite for assembling the SDK in GN
rather than with a python script:
https://codereview.chromium.org/2848943003/
and will be nicer for making prebuilt SDKs for Fuchsia.
Resubmitting this with the following fixes:
1. Rolls further forward to get past a GN bug
2. Fixes the Android build.
3. Style cleanups in gn.py
Review-Url: https://codereview.chromium.org/2858873005 .
This reverts commit 6bf2c800fd.
There is still some strangeness with the new GN binary not wanting
to do an incremental build on top of a build that used an old GN
binary.
Review-Url: https://codereview.chromium.org/2861903002 .
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.
The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.
This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.
As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.
This change is a prerequisite for assembling the SDK in GN
rather than with a python script:
https://codereview.chromium.org/2848943003/
and will be nicer for making prebuilt SDKs for Fuchsia.
Review-Url: https://codereview.chromium.org/2855283002 .
This reverts commit cc968ca45b.
This CL will have to be relanded in two pieces so that the
update to tools/gn.py lands before the unmodified version
can invoke the updated GN binary.
Review-Url: https://codereview.chromium.org/2855973006 .
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.
The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.
This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.
As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.
This change is a prerequisite for assembling the SDK in GN
rather than with a python script:
https://codereview.chromium.org/2848943003/
and will be nicer for making prebuilt SDKs for Fuchsia.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2854583002 .
toolchain_prefix was not correctly propagated everywhere it needed to
go. This CL also adds an error to build.py if someone tries to use
--toolchain as it is not supported there.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2797303005 .
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.
Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.
R=zra@google.com
Review-Url: https://codereview.chromium.org/2750843003 .
Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.
stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2735303002 .
* DEPS and status files updated to the latest co19 commit
* Status files updated according latest buildbot results
* Status file updated for Dartium webgl tests
This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the master branch in the kernel repository
R=asgerf@google.com
Review-Url: https://codereview.chromium.org/2561723003 .
co19 test suite updated to commit f05d5aee5930bfd487aedf832fbd7b832f502b15 of dart-lang/co19 repository, dated Nov 21 2016.
Status files are updated for this roll.
This updates co19 to commit 2e98931a4d40781110220d4b2d131efa6fc4669d
Merge branch 'co19patch' into rebased_co19_patch
Sort status lines ignoring alphabetical order
Status files updated according lates buildbot run results
Status files updated according the latest Chrome run
dart2js files updated for FF and Chrome on Linux
DEPS and VM status files updated
status file updated according Linux run
Status files updated according latest Dartium run
dart2js status file updated according the last tests run on FF
dart2js status file updated according the last tests run on Chrome and FF
Analyzer and VM status files are updated according last versions of co19 and sdk
BUG=
R=sortie@google.com
Review URL: https://codereview.chromium.org/2528953002 .
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.
Some status files are updated to reflect new test outcomes.
* New `cascade_invocations` lint.
* Expand `await_only_futures` to accept classes that extend or implement `Future`.
* Improve camel case regular expression tests to accept `$`s.
* Fixes to `parameter_assignments` (improved getter handling and an NPE).
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2522563003 .
* Analyzer and VM status files are updated according last versions of co19 and sdk
* dart2js status file updated according the last tests run on Chrome and FF
* dart2js status file updated according the last tests run on FF
* Status files updated according latest Dartium run
* status file updated according Linux run
* DEPS and VM status files updated
* dart2js files updated for FF and Chrome on Linux
* Status files updated according the latest Chrome run
* Fixed cast exception in `dart_type_utilities` (dart-lang/sdk#27405).
* New `parameter_assignments` lint.
* New `prefer_final_fields` lint.
* New `prefer_final_locals` lint.
* Markdown link fixes in docs (#306).
* Miscellaneous solo test running fixes and introduction of `solo_debug` (#304).
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2369463003 .
This change:
- Sucks in gn binaries
- Sucks in a version of llvm that the GN build likes
- Adds tools/gn.py to invoke gn
- Adds a root BUILD.gn and .gn file
- Removes chrome boilerplate we don't need
- etc.
This lets us do a standalone build of the 'runtime'
target for x64, ia32, arm, arm64, mips, and the
simulators on Linux, and arm and arm64 on Android.
It does not include tcmalloc, and hasn't been tested
on Mac or Windows. That work and more cleanup of
chrome boilerplate will come in follow-up CLs.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2350583002 .
Dart and Flutter engine both need to have the code generated for
boringssl under //third_party/boringssl. To avoid having two
copies of this code, this CL removes it from the Dart repo and
instead pulls it from a github repo that Flutter engine can
share.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2354623003 .
Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.
product binary size:
before x64: 9569600
after x64: 9807840
increase: 238240 (2.5%)
before ia32: 9122836
after ia32: 9360944
increase: 238108 (2.6%)
before mips: 9418680
after mips: 9640940
increase: 222260 (2.4%)
InitialRSS:
product:
before x64: 6307840
after x64: 7430144
increase: 1122304 (17.8%)
release (--no-profiler)
before x64: 7843840
after x64: 9207808
increase: 1363968 (17.4%)
R=asiva@google.com, whesse@google.com
Review URL: https://codereview.chromium.org/2316813002 .
* Updated tests to use package `test` (#302).
* Fixed false positive on `[]=` in `always_declare_return_types` (#300).
* New `invariant_booleans` lint.
* New `literal_only_boolean_expressions` lint.
* Fixed `camel_case_types` to allow `$` in identifiers (#290).
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2309333002 .
There are following changes:
1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2298913003 .
commit 73b9e73bec11431e48b22f75942acba923d37784
Author: Priscilla Lee <priscillalee@google.com>
Added list of imports to library modules (needed in order to discover filepaths of summaries, allowing the dev_compiler to run in the browser).
commit db950878eded7ab400c71f4a7b0c9cfd66b06fd3
Author: Brenna Milligan <bmilligan@google.com>
Get rid of library proto information for debugger libraries
commit 930e1bd50d27e5156b137cbf263fec509812e3ee
Author: Vijay Menon <vsm@google.com>
Fix wrt analyzer tip
commit 2699745b635dcb626ba81eb0f412092ab1143584
Author: Vijay Menon <vsm@google.com>
Test against dev version of analyzer on travis
commit c6f1ea6e6ab0f17afe335f4b59ed9719235ee14a
Author: Brenna Milligan <bmilligan@google.com>
Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable.
commit d7c240f3c3cdeca2868550bdf8113f312b7d9c88
Author: John Messerly <jmesserly@google.com>
fixes#616, statics on callable functions
also fixes `this` for them
commit e5c2aac3fbb503fe0ede030dca9bfdc36bb0093a
Author: John Messerly <jmesserly@google.com>
fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`
commit 4219a9e3c073f44a804c09f6325b56c7af35b14e
Author: Vijay Menon <vsm@google.com>
Rename build-root to library-root
commit 5d436cee38134c2c3ad9db196ba2a727938adf82
Author: Vijay Menon <vsm@google.com>
Fix analyzer error
commit 16b287c89771d76ffe25dfba708d40a5b364dcf0
Author: Priscilla Lee <priscillalee@google.com>
Working compiler in browser.
BUG=
R=jmesserly@google.com
commit a3d34798bd2784bb04e24b73c2355df32c807294
Author: Brenna Milligan <bmilligan@google.com>
Addition of StackTrace formatters