Commit graph

610 commits

Author SHA1 Message Date
Zachary Anderson d9eb629ffa [infra] Use Clang for ia32 and arm64. Use the dl'd sysroots by default.
This CL switches the ia32 and arm64 builds to use clang by default.
The arm build can't be switched at least until we roll clang to
pick up the fix for https://reviews.llvm.org/D34691.

This CL also changes to use the sysroots from wheezy (and jessie
for arm64) by default so that we can be building/testing locally with
the same setup as we are shipping in the SDK.

Change-Id: I09a1907ee7f78c3f4bb8d56ffdbbd6107ed054d9
Reviewed-on: https://dart-review.googlesource.com/25160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2017-12-02 06:19:33 +00:00
pq 8f84f3c890 Bump DEPS to latest linter (0.1.40).
* `avoid_unused_constructor_parameters` updated to better handle redirecting factory constructors
* `avoid_returning_this` improvements
* `prefer_bool_in_asserts` improvements
* miscellaneous documentation fixes

Bug:
Change-Id: I2328b495268770795ca00660f1a1910b8d99184f
Reviewed-on: https://dart-review.googlesource.com/25680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-01 22:28:15 +00:00
Andrew Wilson de20c96c54 Update intl to 0.15.2
Change-Id: I4a54c089e47f095f1782ee6998f0a10a65ab2cdd
Reviewed-on: https://dart-review.googlesource.com/20303
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2017-11-13 16:33:15 +00:00
pq c0df9d42c6 Bumpt DEPS to linter 0.1.39.
* `prefer_interpolation_to_compose_strings` update to allow concatenation of two non-literal strings
* `prefer_interpolation_to_compose_strings` updated to allow `+=`
* lots of rule documentation fixes and enhancements
* fix for `prefer_const_constructors_in_immutables` false positive with redirecting factory constructors

Bug:
Change-Id: I6c095567ef92ad47fc57cbcbfb6745d0173043c4
Reviewed-on: https://dart-review.googlesource.com/18380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-11-02 18:54:44 +00:00
pq 87820ba686 Bump linter DEP to 0.1.38
* `public_member_api_docs` fix for package URIs

Bug:
Change-Id: Ie508095d10c58a91d28cc39619b83010809d31b5
Reviewed-on: https://dart-review.googlesource.com/16860
Reviewed-by: Devon Carew <devoncarew@google.com>
2017-10-26 17:38:00 +00:00
Kevin Moore 3c14e5277a DEPS: latest published pkg/mime
Change-Id: I94c27668d14e94d6f159d25e5a4400438d6b385b
Reviewed-on: https://dart-review.googlesource.com/16604
Reviewed-by: William Hesse <whesse@google.com>
2017-10-26 15:58:20 +00:00
pq c7d5a92751 Bump linter DEP to 0.1.37.
* `avoid_positional_boolean_parameters` updated to allow booleans in operator declarations
* `comment_references` fixed to handle incomplete references
* `non_constant_identifier_names` updated to allow underscores around numbers

Bug:
Change-Id: Iac4057f9b0defaf8e5dbee8247f3fd29b729017b
Reviewed-on: https://dart-review.googlesource.com/16324
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-24 21:45:25 +00:00
pq 0c4476c20b Bump Linter DEP to pickup 0.1.36.
Changes include:

* new `avoid_unused_constructor_parameters` lint
* new `prefer_bool_in_asserts` lint
* new `prefer_typing_uninitialized_variables` lint
* new `unnecessary_statements` lint
* `public_member_api_docs` updated to only lint source in `lib/`
* 'avoid_empty_else' fixed to ignore synthetic `EmptyStatement`s
* updated library prefix checking to allow leading `$`s
* miscellaneous documentation fixes
* Dart SDK constraints restored (removed unneeded `2.0.0-dev.infinity` constraint)

Bug:
Change-Id: I61a9be33654175669bcb8ea580fea372943c5a16
Reviewed-on: https://dart-review.googlesource.com/16080
Reviewed-by: Devon Carew <devoncarew@google.com>
2017-10-23 22:42:41 +00:00
P.Y. Laligand ce79a77331 Remove Fuchsia-specific build files.
Also fix Fuchsia tools to account for new project location (//third_party/dart).

Change-Id: If89a934729c4fa44229eaca83219dbdf8bb700a8
Bug:
Reviewed-on: https://dart-review.googlesource.com/14800
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-19 17:52:37 +00:00
Nate Bosch fe0e592589 Update to latest barback
Bug:
Change-Id: Ib0fb7ceae5ac15fd711c2a66a10507654e52c291
Reviewed-on: https://dart-review.googlesource.com/11641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-06 19:56:29 +00:00
Janice Collins bf7d7a09fb Upgrade dartdoc to 0.14.1.
Bug:
Change-Id: I54a7b102befc11cffda51b989678eb1b84956638
Reviewed-on: https://dart-review.googlesource.com/11643
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2017-10-05 23:11:23 +00:00
Alexander Aprelev 2b69607e47 Roll observatory pub packages to pick up updated packages.
Bug:
Change-Id: I3d1ecf2dc63b9d3fec6c67bf31dbb31252c4f26d
Reviewed-on: https://dart-review.googlesource.com/8401
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2017-09-28 00:11:38 +00:00
William Hesse f00f9099d1 Update DEPS to more recent package versions
Bug:
Change-Id: If6cca158ae5afbf55d0a509828b662a449db8189
Reviewed-on: https://dart-review.googlesource.com/8561
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2017-09-27 13:33:35 +00:00
Kevin Moore 8b4322df72 Use tag for pkg/pool in DEPS
Change-Id: Ie9e464ab93498d3783652df360ca902cdecded3e
Reviewed-on: https://dart-review.googlesource.com/7582
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
2017-09-21 16:00:13 +00:00
Kevin Moore 03dfeb78f5 Update stack_trace in DEPS
Change-Id: I1fe67bd4be6db587cc39bd11aef6d91a4e1772c5
Reviewed-on: https://dart-review.googlesource.com/7520
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
2017-09-21 15:30:47 +00:00
Brian Wilkerson a6adcece9c Pull the latest version of isolate into the SDK
Change-Id: Ice7795b335b10084889d66fe9cd606071344b326
Reviewed-on: https://dart-review.googlesource.com/7402
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2017-09-21 14:13:12 +00:00
keertip e4d28e60fc Update DEPS to pull in packages for zone strong changes
Bug:
Change-Id: If69f46c9f5d7643e954400b63d1b867bbae7f39b
Reviewed-on: https://dart-review.googlesource.com/7103
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2017-09-19 21:48:23 +00:00
Jacob MacDonald 2506174830 update pub for latest changes
Bug:
Change-Id: I67d3ade64561f8623df4fc6ab488e33bac2db480
Reviewed-on: https://dart-review.googlesource.com/3281
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-15 22:36:44 +00:00
Janice Collins 2fd9b3090c Update dartdoc to v0.13.0+3
Bug:
Change-Id: I8dc22bb5d869239d3fd35979a1d2b95288364da3
Reviewed-on: https://dart-review.googlesource.com/4860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2017-09-11 16:34:26 +00:00
Ben Konyi 9782b8b5b5 Rolling forward package:test to 0.12.24+2 to fix issues blocking migration of some stream related tests.
Bug:
Change-Id: Ia1a06e883fcd682bb70712e080be681e63a14aec
Reviewed-on: https://dart-review.googlesource.com/4523
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-08 22:24:58 +00:00
Zachary Anderson e94ff71e64 [infra] Roll back toolchain due to crasher on mac.
related #30642

Change-Id: Id1777132d4447da45eec07513406b25e9c1795b0
Reviewed-on: https://dart-review.googlesource.com/4061
Reviewed-by: William Hesse <whesse@google.com>
2017-09-07 16:14:40 +00:00
Leaf Petersen afcacb2c2e Update matcher version in DEPS.
Update matcher to the latest version including some fixes to make the 
API friendlier to typed code.

Bug:
Change-Id: I059c82da8b64cf28388b162db6a115918fa27427
Reviewed-on: https://dart-review.googlesource.com/3705
Reviewed-by: Kevin Moore <kevmoo@google.com>
2017-09-07 04:30:56 +00:00
Janice Collins ece0a2a728 Update dartdoc to 0.13.0+2. This will fix SDK doc generation
without dartium.

BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/3011863002 .
2017-09-01 14:02:46 -07:00
Zachary Anderson d1b542f8cd Reland: [infra] Roll clang toolchain forward
Build spuriously worked after initial roll due to stale files hanging
around longer than they should have. This CL relands and updates
(hopefully) all the necessary paths.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/3010023002 .
2017-09-01 11:15:40 -07:00
William Hesse bf6ea50b95 Revert "[infra] Roll clang toolchain forward"
This reverts commit a60fb341f5.
The toolchain.stamp files are missing on buildbots, causing failures.
This occurred on the second run after the commit, indicating that
perhaps the files are no longer created, or something.

BUG=
R=mkroghj@google.com
CC=zra@google.com

Review-Url: https://codereview.chromium.org/3009983002 .
2017-09-01 14:42:35 +02:00
Zach Anderson a60fb341f5 [infra] Roll clang toolchain forward
This is to match the version used by Flutter.

R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/3005903002 .
2017-08-31 21:49:02 -07:00
William Hesse 416d3f7bbe Fix typo in DEPS
Introduced in https://codereview.chromium.org/3001393002/

BUG=
R=athom@google.com

Review-Url: https://codereview.chromium.org/3003123003 .
2017-08-22 18:42:29 +02:00
William Hesse 67b116b150 Point DEPS to mirrored repos of dart-lang packages, add term_glyph.
BUG=https://github.com/dart-lang/sdk/issues/30445
BUG=https://github.com/dart-lang/sdk/issues/30458
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/3001393002 .
2017-08-22 18:32:43 +02:00
Zach Anderson 783f1e8c04 [infra] Remove dependency on gyp
R=rmacnak@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/3003433002 .
2017-08-18 08:51:40 -07:00
Carlo Bernaschina a67d798841 Update observatory_pub_packages dependency
Updated all observatory dependencies.
In particular charted to 0.4.8

R=rmacnak@google.com
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2990913002 .
2017-07-31 13:03:35 -07:00
pq 1892b79b29 Bump linter to 0.1.35.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2991033002 .
2017-07-31 11:07:04 -07:00
William Hesse c1db164c8b Revert "Remove "Windows toolchain" step from DEPS. May only be used by gyp."
This reverts commit 5a8520ba91.
Also reverts removal of gyp from Dart DEPS.

BUG=
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2986943002 .
2017-07-27 13:54:40 +02:00
William Hesse 5a8520ba91 Remove "Windows toolchain" step from DEPS. May only be used by gyp.
BUG=570091, 748486
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2988953002 .
2017-07-27 13:20:52 +02:00
William Hesse c8b39cee64 Improve DEPS compatibility with planned gclient changes
BUG=570091, 748486
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2989783002 .
2017-07-27 13:07:19 +02:00
Jennifer Messerly fb613c0635 fix #29766, fix #29782 - fix override checker's interface checking
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2981183003 .
2017-07-21 16:02:52 -07:00
Alexander Markov 3e4bef64a7 Update Dart SDK dependency for Crypto package to 2.0.2
The new version of Crypto library is prepared for limiting integers
to 64 bits (--limit-ints-to-64-bits) mode.

Issue #30103.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2989503002 .
2017-07-21 13:07:51 -07:00
Kevin Moore 7e5fc085cf Bring in latest pkg/http
Fixes https://github.com/dart-lang/sdk/issues/30210

R=matanl@google.com

Review-Url: https://codereview.chromium.org/2982293002 .
2017-07-19 19:55:32 -07:00
pq 46f53a7d83 Bump DEPS to pickup current package_config.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2987493002 .
2017-07-19 15:32:26 -07:00
Konstantin Shcheglov fcc205e1a6 Add mockito to DEPS.
R=devoncarew@google.com, whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2976143002 .
2017-07-19 10:09:36 -07:00
Kevin Moore a7677c89f4 This DEP hasn't been touched in 2 years – can't see any uses
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2976413002 .
2017-07-19 08:27:02 -07:00
Kevin Moore 500f5cb324 2nd try: SDK dep cleanup
Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc

R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2978233002 .
2017-07-18 13:13:50 -07:00
Sigmund Cherem e8b6af0ef8 document protocol for updating dart_style
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2983023002 .
2017-07-18 12:51:42 -07:00
Kevin Moore f33a75257d remove pkg/metatest from DEPS
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2983763002 .
2017-07-18 08:27:20 -07:00
Kevin Moore b6d15d87bc Revert "Remove several packages from DEPS"
Looks like we have tests that require these

This reverts commit 7a9cc03c09.

Review-Url: https://codereview.chromium.org/2980303002 .
2017-07-18 07:36:37 -07:00
Kevin Moore 7a9cc03c09 Remove several packages from DEPS
Copied the corresponding code from pkg/web_components

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2977333002 .
2017-07-18 07:21:19 -07:00
pq ffa21c0d26 Bump linter to 0.1.33
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2979123002 .
2017-07-17 09:34:22 -07:00
Jacob MacDonald c4ea80a74c update pub to get --build-delay arg and remove require.js loading timeouts
BUG=
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2968213002 .
2017-07-06 14:16:09 -07:00
Bob Nystrom d107b64680 Bring the latest dart_style into the repo. (#30083) 2017-07-06 10:37:11 -07:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server.
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
Natalie Weizenbaum f4750db137 Bring in the latest pub. (#30053) 2017-06-29 13:50:09 -07:00
Devon Carew ebffa49eac Bump the deps for package:http and package:usage.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2958603002 .
2017-06-23 12:54:17 -07:00
William Hesse 232684aac0 Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2954443002 .
2017-06-22 11:46:13 +02:00
Janice Collins 517b0adbaf Update dartdoc to v0.13.0+1.
Also update markdown.  I have reviewed the changes from 0.11.2 to
0.11.3 and they LGTM.  With this change, dartdoc tests should
pass reliably from within the SDK.

BUG=
R=devoncarew@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2950973002 .
2017-06-21 07:58:25 -07:00
William Hesse 823e7c6b03 Revert "Merge branch 'co19roll'"
This reverts commit 42cc7d570c.

BUG=
TBR=sortie@google.com

Review-Url: https://codereview.chromium.org/2952573003 .
2017-06-21 07:15:25 +02:00
William Hesse 42cc7d570c Merge branch 'co19roll'
Update co19 status files with results from buildbot.

Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d

BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2948763003 .
2017-06-21 06:34:55 +02:00
Zachary Anderson 8bf8623eb4 [infra] Uses github mirror for protobuf and tuple.
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2946923002 .
2017-06-20 12:35:24 -07:00
William Hesse 2b6fbc7069 Revert co19 roll attempt
Revert "Status files updated according to buildbot log (#29929)"

This reverts commit 5b7a7958b2.

Revert "Fix Dartium DEPS typo in co19 roll"

This reverts commit 4996568879.

BUG=

Review-Url: https://codereview.chromium.org/2949543002 .
2017-06-19 13:17:55 +02:00
Sergey G. Grekhov 5b7a7958b2 Status files updated according to buildbot log (#29929)
* DEPS ans status files updated to the last co19 commit

* Commented lines deleted from .status file

* DEPS ans status files updated to the last co19 commit

* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110

* Fix for https://github.com/dart-lang/co19/issues/87 added

* Fix for https://github.com/dart-lang/co19/issues/88 added

* Status files updated according to buildbot log
2017-06-19 12:55:32 +02:00
Janice Collins 14bbfa2321 Upgrade dartdoc to v0.12.0.
Tested manually, can generate SDK and package docs not withstanding https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the integration test pass (comment docs have changed for some SDK libraries since 0.12.0).

BUG=
R=devoncarew@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2919823002 .
2017-06-16 07:51:13 -07:00
Jacob MacDonald b5717a77ae update pub to get latest dartdevc fixes
BUG=
R=jacobr@google.com, nweiz@google.com

Review-Url: https://codereview.chromium.org/2939763002 .
2017-06-13 13:24:45 -07:00
William Hesse dc08a02cbc Revert co19 roll attempt.
After status files are updated with failures from this run, we will try again.

R=brian.wilkerson@google.com

Revert "DEPS ans status files updated to the last co19 commit (#29604)"

This reverts commit 70b2b3f6b1.

Revert "Fix typos introduced in DEPS by 70b2b3f6b1bb2def061f80b7693cd89e23fa9134"

This reverts commit 9e9f7210d0.

BUG=

Review-Url: https://codereview.chromium.org/2933403002 .
2017-06-13 20:31:19 +02:00
Sergey G. Grekhov 70b2b3f6b1 DEPS ans status files updated to the last co19 commit (#29604)
* DEPS ans status files updated to the last co19 commit

* Commented lines deleted from .status file

* DEPS ans status files updated to the last co19 commit

* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110

* Fix for https://github.com/dart-lang/co19/issues/87 added

* Fix for https://github.com/dart-lang/co19/issues/88 added
2017-06-13 19:49:18 +02:00
Kevin Moore c31c3c436b Remove unused which/when packages from DEPS
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2934843003 .
2017-06-12 17:53:01 +02:00
Natalie Weizenbaum 4146852999 Bring in the latest http_throttle. (#29793)
Bring in the latest http_throttle.

See dart-lang/pub#1610
2017-06-08 15:14:28 -07:00
Jacob MacDonald 5aba20af0d update pub to latest
BUG=
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2908783003 .
2017-05-27 16:57:13 -07:00
Jacob MacDonald 97b750425d update source_span to 1.4.0
BUG=
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2897403005 .
2017-05-25 13:25:39 -07:00
Jacob MacDonald 6b1c7e9407 update pub to latest
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2903723002 .
2017-05-23 15:27:11 -07:00
Jacob MacDonald dec38f2b2c update pub in the sdk
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2902723003 .
2017-05-23 12:38:18 -07:00
Keerti Parthasarathy e185aa63b2 Update async package to include fix for Stream changes
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2888933003 .
2017-05-18 14:35:19 -07:00
Jacob MacDonald fa834e7d39 update to latest pub
BUG=
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2894663002 .
2017-05-18 12:24:12 -07:00
pq ba1a6e39f3 Update to fresh cli_util (0.1.0).
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2894433002 .
2017-05-17 11:04:29 -07:00
Jacob MacDonald 7404b586cb fix mac pub tests
BUG=
R=nbosch@google.com

Review-Url: https://codereview.chromium.org/2888563003 .
2017-05-16 12:40:55 -07:00
Jacob MacDonald b60cfc2edc update pub and barback for ddc support
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2889683002 .
2017-05-16 10:52:00 -07:00
Terry Lucas f27144d7b5 Roll 50: Updated for push to origin/master.
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Bob Nystrom 224cb59528 Update dart_style to 1.0.6. (#29591)
This brings in support for URIs in "part of" directives.
2017-05-10 09:19:48 -07:00
pq 8fba8ccd97 Bump DEPS to linter 0.1.31.
Linter `0.1.31`:

* New `prefer_foreach` lint.
* New `use_string_buffers` rule.
* New `unnecessary_overrides` rule.
* New `join_return_with_assignment_when_possible` rule.
* New `use_to_and_as_if_applicable` rule.
* New `avoid_setters_without_getters` rule.
* New `always_put_control_body_on_new_line` rule.
* New `avoid_positional_boolean_parameters` rule.
* New `always_require_non_null_named_parameters` rule.
* New `prefer_conditional_assignment` rule.
* New `prefer_conditional_assignment` rule.
* New `avoid_types_on_closure_parameters` rule.
* New `always_put_control_body_on_new_line` rule.
* New `use_setters_to_change_properties` rule.
* New `avoid_returning_this` rule.
* New `avoid_annotating_with_dynamic_when_not_required` rule.
* New `prefer_constructors_over_static_methods` rule.
* New `avoid_returning_null` rule.
* New `avoid_classes_with_only_static_members` rule.
* New `avoid_null_checks_in_equality_operators` rule.
* New `avoid_catches_without_on_clauses` rule.
* New `avoid_catching_errors` rule.
* New `use_rethrow_when_possible` rule.
* Many lint fixes (notably `prefer_final_fields`, `unnecessary_lambdas`, `await_only_futures`, `cascade_invocations`, `avoid_types_on_closure_parameters`, and `overridden_fields`).
* Significant performance improvements for `prefer_interpolation_to_compose_strings`.
* New `unnecessary_this` rule.
* New `prefer_initiliazling_formals` rule.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2865163002 .
2017-05-08 12:53:51 -07:00
Zach Anderson 726732dd6b [infra] Roll clang to match the version used by Flutter
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.

The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.

This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.

As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.

This change is a prerequisite for assembling the SDK in GN
rather than with a python script:

https://codereview.chromium.org/2848943003/

and will be nicer for making prebuilt SDKs for Fuchsia.

Resubmitting this with the following fixes:
1. Rolls further forward to get past a GN bug
2. Fixes the Android build.
3. Style cleanups in gn.py

Review-Url: https://codereview.chromium.org/2858873005 .
2017-05-06 21:45:00 -07:00
Bob Nystrom 6db2290cc5 Upgrade to the latest dart_style.
There are not real substantive changes, just a tiny tweak around the
new function alias syntax when metadata is in play.

R=jakemac@google.com

Review-Url: https://codereview.chromium.org/2857133005 .
2017-05-04 14:06:21 -07:00
Zachary Anderson ab422ad194 Revert "[infra] Roll clang to match the version used by Flutter"
This reverts commit 6bf2c800fd.

There is still some strangeness with the new GN binary not wanting
to do an incremental build on top of a build that used an old GN
binary.

Review-Url: https://codereview.chromium.org/2861903002 .
2017-05-03 15:56:21 -07:00
Zachary Anderson 6bf2c800fd Reland: [infra] Roll clang to match the version used by Flutter
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.

The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.

This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.

As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.

This change is a prerequisite for assembling the SDK in GN
rather than with a python script:

https://codereview.chromium.org/2848943003/

and will be nicer for making prebuilt SDKs for Fuchsia.

Review-Url: https://codereview.chromium.org/2855283002 .
2017-05-03 15:42:46 -07:00
Zachary Anderson 958c25c1db Revert "[infra] Roll clang to match the version used by Flutter"
This reverts commit cc968ca45b.

This CL will have to be relanded in two pieces so that the
update to tools/gn.py lands before the unmodified version
can invoke the updated GN binary.

Review-Url: https://codereview.chromium.org/2855973006 .
2017-05-03 15:16:21 -07:00
Zachary Anderson cc968ca45b [infra] Roll clang to match the version used by Flutter
Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart
on that toolchain, as well. This roll should entail no changes to
glibc version requirements on Linux.

The Fuchsia buildtools distribute clang-format with the toolchain
rather than separately, so this CL introduces forwarding scripts
that are copied to the right place under //buildtools.

This CL sets the default for the number of workers in //tools/gn.py
to 1, as the newer GN version fails occasionally when run
concurrently with other invocations.

As Flutter does, this CL uses the clang toolchain to build for
Android. Thus, it is now possible to build for Android on MacOS.

This change is a prerequisite for assembling the SDK in GN
rather than with a python script:

https://codereview.chromium.org/2848943003/

and will be nicer for making prebuilt SDKs for Fuchsia.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2854583002 .
2017-05-03 14:50:59 -07:00
Bob Nystrom 5d311f151a Bring dart_style 1.0.4 into the repo. (#29487) 2017-04-26 14:54:05 -07:00
Jacob MacDonald 3bc1b72927 update bazel_worker package to v0.1.4
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2846583002 .
2017-04-26 13:51:34 -07:00
Mike Fairhurst 18917ea588 Remove angular from DEPS
BUG=
R=keertip@google.com

Review-Url: https://codereview.chromium.org/2829923006 .
2017-04-21 10:15:18 -07:00
Vijay Menon 916205f5d6 Roll DEPS forward
Pick up strong mode fixes on source_maps and protobuf

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2835643003 .
2017-04-21 08:04:53 -07:00
Kevin Moore fab7b0028f Update to the latest dart2js_info 0.5.4+2
Review-Url: https://codereview.chromium.org/2824783002 .
2017-04-17 10:42:13 -07:00
Zachary Anderson e79354546d Update DEPS for BUILD.gn in func package
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2820713003 .
2017-04-14 13:26:35 -07:00
Mike Fairhurst 37aeef8d6e Tick angular analyzer DEPS to 0.0.8
BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2814793006 .
2017-04-14 08:22:57 -07:00
Bob Nystrom 8abc899c0a Bring in the latest Pub.
R=nbosch@google.com

Review-Url: https://codereview.chromium.org/2805893004 .
2017-04-07 17:57:04 -07:00
Bob Nystrom 611f014645 Bring the latest scheduled_test into the repo.
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2809473002 .
2017-04-07 17:47:34 -07:00
pq 2bc70e6a26 Bump Linter to latest (0.1.30).
R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/linter/issues/491
Review-Url: https://codereview.chromium.org/2807633002 .
2017-04-07 12:37:14 -07:00
Zachary Anderson f1c7a22c43 [infra] Fixes for cross-toolchains
toolchain_prefix was not correctly propagated everywhere it needed to
go. This CL also adds an error to build.py if someone tries to use
--toolchain as it is not supported there.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2797303005 .
2017-04-06 15:03:26 -07:00
Bob Nystrom 8bda93d58c Update dart_style.
This brings in an important fix for formatting generic function-typed
parameters. See:

https://github.com/dart-lang/dart_style/issues/613

R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2805103002 .
2017-04-06 14:03:25 -07:00
Mike Fairhurst 1a8ef13fd1 We ended up needing just one more change to angular, versions ticked.
BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2793693002 .
2017-04-04 08:47:34 -07:00
Janice Collins 17b1e30d04 DEPS to pull pre-release dartdoc for generic function types
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2795653003 .
2017-04-04 07:54:00 -07:00
Nate Bosch 5f6c950695 Update to latest pub
BUG=
R=kevmoo@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2789213002 .
2017-04-03 11:24:00 -07:00
Mike Fairhurst a5a65d09a4 Tick angular analyzer to v0.0.6
BUG=
R=keertip@google.com

Review-Url: https://codereview.chromium.org/2793663002 .
2017-03-31 13:27:40 -07:00
Bob Nystrom cc1ba091e8 Bring dartfmt 1.0.1 (now 1.0.2) into the SDK.
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2777623003 .
2017-03-29 15:54:19 -07:00
Mike Fairhurst b4dbe8eba0 Re-add first copyright comment to DEPS, removed by mistake
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2779113005 .
2017-03-29 12:10:53 -07:00
Mike Fairhurst fd6c486760 add angular analyzer to DEPS for distribution in google builds
BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2601863002 .
2017-03-29 11:01:53 -07:00
Bob Nystrom c62ddf2d40 Update dartfmt to 1.0.0
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2765093002 .
2017-03-23 14:19:52 -07:00
William Hesse ae0bbc3d22 Update DEPS to use github mirror for two more repos
BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2763003002 .
2017-03-21 16:45:56 +01:00
Kevin Moore 3e898f12ba Bring in the latest pub
with associated CHANGELOG updates

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2758753004 .
2017-03-17 15:15:10 -07:00
Kevin Moore 84db9aea7b Bring in latest pub
2nd try

Closes https://github.com/dart-lang/sdk/issues/28924

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2748023007 .
2017-03-16 10:36:49 -07:00
Emily Fortuna b3adee9ea5 Your prayers to the Revert Gods have been answered.
Revert "Bring in the latest pub with telemetry support."

This reverts commit 48e4e2c2fa.

Dart Gardening.

BUG=

Review-Url: https://codereview.chromium.org/2750173003 .
2017-03-15 17:43:58 -07:00
Bob Nystrom 48e4e2c2fa Bring in the latest pub with telemetry support.
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2751233003 .
2017-03-15 17:22:03 -07:00
Kevin Moore 36635d3c05 Bring in the latest pub
...2nd attempt

1st attempt: b3997dfc0c
reverted in 77ff7cf727

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2752963003 .
2017-03-15 16:31:58 -07:00
Ryan Macnak 877284947b Rename TARGET_OS_* to HOST_OS_*.
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.

Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2750843003 .
2017-03-15 13:11:05 -07:00
William Hesse 3281587d84 Update DEPS to use chromium mirrors of more package repos
BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2752783002 .
2017-03-15 16:02:51 +01:00
William Hesse 77ff7cf727 Revert "Bring in the latest pub."
This reverts commit b3997dfc0c.
Many pub tests are failing on Mac OS.

BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2749643005 .
2017-03-15 11:00:23 +01:00
Natalie Weizenbaum b3997dfc0c Bring in the latest pub. 2017-03-14 13:12:52 -07:00
Jacob Richman 7ba7e0cee6 Make all DDC internal stack traces apply source maps.
Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.

stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2735303002 .
2017-03-08 19:13:00 -08:00
William Hesse a45c4ce68f Update third-party packages to most recent versions
BUG=
R=keertip@google.com, nweiz@google.com

Review-Url: https://codereview.chromium.org/2702483003 .
2017-02-17 00:33:09 +01:00
Kevin Moore cbdf0aec6f DEPS: Updated to latest dart2js_info
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2682083006 .
2017-02-10 14:34:41 -08:00
Bob Nystrom 955a45b06e Update to the latest dart_style.
This fixes a critical bug where dartfmt would discard type arguments
to some method calls. See:

https://github.com/dart-lang/dart_style/pull/583

R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2676663005 .
2017-02-03 15:50:43 -08:00
Kevin Moore d1be8f8b04 updated to latest dart2js_info
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2672803003 .
2017-02-03 08:58:47 -08:00
Sergey G. Grekhov 2a73c6427d DEPS ans status files updated to the last co19 commit (#28486)
co19 updated to version 4af9ef149be554216c5bb16cbac8e50d4c28cdf1
2017-01-31 10:12:58 -08:00
Peter von der Ahé f2faa44730 Move package:testing to SDK.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2624373003 .
2017-01-31 11:16:03 +01:00
Kevin Moore c1a0b12159 use latest pkg/isolate
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662723002 .
2017-01-28 13:53:17 -08:00
Sigmund Cherem 139d5d15db Roll pub to the latest version.
BUG=
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2659083002 .
2017-01-27 16:48:58 -08:00
Bob Nystrom ec81103718 Bring dart_style 0.2.15 into the repo.
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2655503003 .
2017-01-23 14:24:16 -08:00
Sergey G. Grekhov 5624919085 Status files updated accordint latest buildbot results (#28452)
* DEPS and status files updated to the latest co19 commit

* Status files updated according latest buildbot results

* Status file updated for Dartium webgl tests
2017-01-23 16:46:01 +01:00
Jacob MacDonald 032c2bb370 update bazel_worker to 0.1.2
R=keertip@google.com

Review-Url: https://codereview.chromium.org/2641793005 .
2017-01-20 08:12:52 -08:00
William Hesse 34bfb3342b Revert "DEPS and status files updated to the latest co19 commit (#28445)"
This reverts commit 8cfaa86180.

BUG=
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2646023003 .
2017-01-20 04:15:59 +01:00
Sergey G. Grekhov 8cfaa86180 DEPS and status files updated to the latest co19 commit (#28445) 2017-01-20 02:59:49 +01:00
Brian Wilkerson a77748b61e Pull in the latest version of linter
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2640973002 .
2017-01-18 14:19:45 -08:00
Bob Nystrom f0fcb81292 Bring in the latest pub.
This rolls back the "tar --name" fix which breaks pub lish on Mac.

R=nweiz@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2636593003 .
2017-01-13 13:12:22 -08:00
Brian Wilkerson fac5f92965 Update DEPS to pull in the latest version of linter
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2623323002 .
2017-01-11 14:03:29 -08:00
Brian Wilkerson b9fc9497e2 Update the DEPS file to pull in the latest version of dart_style
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2622623004 .
2017-01-11 11:17:20 -08:00
Paul Berry 443f2a0672 Roll latest linter into DEPS.
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2620373002 .
2017-01-11 11:11:48 -08:00
Zachary Anderson 792982b75b Roll compiled-in root certs forward
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2622663003 .
2017-01-09 12:48:27 -08:00
pq 69f1cb0ecb Bump DEPS to pull in latest linter ( 0.1.30-alpha.1).
* corresponds to ` 0.1.30-alpha.1`.
* includes invariant_boolean, invariant_booleans mismatch fix.

BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2619463002 .
2017-01-05 15:44:47 -08:00
William Hesse 31e96a85c9 Update package_resolver version in DEPS
BUG=https://github.com/dart-lang/package_resolver/issues/1
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2606353002 .
2017-01-03 15:00:16 +01:00
William Hesse edbcd63813 Update pub to revision d7649be15213c43669a40c33af516d8eb210e876
BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2590273003 .
2016-12-21 11:20:20 +01:00
keertip 3d00c2251f rev dartdoc version in DEPS to 0.9.8+1
BUG=
R=devoncarew@google.com

Review URL: https://codereview.chromium.org/2572303002 .
2016-12-15 10:05:55 -08:00
Karl Klose ff99a0ce59 Merge kernel closure conversion into the Dart SDK
This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the master branch in the kernel repository

R=asgerf@google.com

Review-Url: https://codereview.chromium.org/2561723003 .
2016-12-15 10:16:22 +01:00
Zachary Anderson c1f00f786a BoringSSL: Roll forward
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2575593002 .
2016-12-13 14:36:34 -08:00
Paul Berry dea023d345 Upgrade "path" package to 1.4.1 and eliminate analyzer test workaround.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569043002 .
2016-12-12 14:08:59 -08:00
Brian Wilkerson ebf5fbcd0e Remove references to the linter plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2567863002 .
2016-12-10 10:00:20 -08:00
YoungSeok Yoon 5215e2b1ed Advance linter_rev (#28061) 2016-12-09 16:22:25 -08:00
Natalie Weizenbaum bcafb22926 Bring in the latest pub. (#28040)
This fixes a bug brought in by 73a9897d20.
2016-12-08 13:42:04 -08:00
Natalie Weizenbaum 73a9897d20 Bring in the latest pub. (#28035) 2016-12-08 13:17:30 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
2016-12-07 10:51:33 -08:00
Brian Wilkerson 20baedc660 Reapply "Move the linter core to the analyzer package"
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559773002 .
2016-12-07 09:57:17 -08:00
Paul Berry 1a172e935b Revert "Move the linter core to the analyzer package"
This reverts commit 6d9d5f53a1, which
was causing analysis server unit tests to fail.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2561573003 .
2016-12-07 05:36:46 -08:00
Brian Wilkerson 6d9d5f53a1 Move the linter core to the analyzer package
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2553203002 .
2016-12-06 09:42:26 -08:00
William Hesse 2fcf38a156 Roll back yaml version in DEPS to 2.1.11
Rejecting duplicate keys breaks download of existing Dart packages.
BUG=https://github.com/dart-lang/pub/issues/1479
R=lrn@google.com
CC=mit@google.com,nweiz@google.com,kustermann@google.com

Review URL: https://codereview.chromium.org/2548313002 .
2016-12-05 11:27:38 +01:00
Brian Wilkerson 6bb28d748a Pull in linter to fix the bots
Review URL: https://codereview.chromium.org/2548073002 .
2016-12-02 17:08:36 -08:00
Brian Wilkerson 28be4aff79 Update the version of linter being used
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2546153003 .
2016-12-02 14:29:29 -08:00