Commit graph

25245 commits

Author SHA1 Message Date
sgjesse@google.com 8213dd365b Add option to HttpClient to turn of auto uncompression
R=ajohnsen@google.com
BUG=http://dartbug.com/19769

Review URL: https://codereview.chromium.org//370743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38012 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 12:59:37 +00:00
ricow@google.com 21727711ab I have no idea if this is actually what we want to do, but we are hitting the long path issue on windows several times day for this.
If you want to do something else just close this off

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//278583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38011 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 12:42:13 +00:00
ajohnsen@google.com d3411334c8 Fix links of VirtualDirectory.
BUG=https://code.google.com/p/dart/issues/detail?id=19717
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//370753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38010 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 12:04:25 +00:00
ajohnsen@google.com 877d4c2138 Validate headers when added to HttpHeaders.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//364313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38009 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 11:04:03 +00:00
asgerf@google.com dd49196958 dart2dart: Copy propagation in dart_tree.
Moving assignments w := v are eliminated by assigning directly to w at the definition of v.

Since we can't check if v is live after the assignment, this only clicks when we have the unique use of v.

BUG=
R=kmillikin@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//368363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38008 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 10:59:51 +00:00
ricow@google.com 7ae5298b7d Prepare compiler annotated steps for running on ie11 and ie10 on the full windows builders.
I will not commit this until I update the bots

R=whesse@google.com

Review URL: https://codereview.chromium.org//367373005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38007 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 10:31:22 +00:00
asgerf@google.com af6b016d57 dart2dart: Fixed assertions in IR.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//373463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38006 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 10:20:33 +00:00
asgerf@google.com 7f4ac7d27e dart2dart: Support for inner functions in new IR.
In CPS, closure variables are modeled as ref cells. In tree, variables
are in scope within inner functions and closure variables are handled directly.

In Dart, a function must be declared if it has a return type or is recursive.
Therefore tree now has both FunctionExpression and FunctionDeclaration, the latter
is mainly to be used for functions that cannot occur in expression context.

The CPS also has two ways of creating functions, CreateFunction and DeclareFunction,
but here the latter is only strictly necessary for recursive function.

The CL also contains quite a bit of other code improvements that came along.

BUG=
R=kmillikin@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//366853007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38005 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 10:09:16 +00:00
ahe@google.com 29b8573e1a Fix warnings about unused code.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//368293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38004 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 09:31:23 +00:00
ahe@google.com 0d8ae73393 Settings pane "done" button renamed to "close".
BUG=https://code.google.com/p/dart/issues/detail?id=17858
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//363013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38003 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 09:23:44 +00:00
whesse@google.com bb59b9fa85 Revert r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid."
This reverts CL https://codereview.chromium.org/363323002/
We found that the flaky timeouts are real renderer crashes, and this change does not seem to help.  We will instead report more data on the renderer crashes.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//373453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38002 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 09:19:08 +00:00
floitsch@google.com 8c26700191 Hide the URIs in minified mode.
BUG= http://dartbug.com/18903
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//371553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38001 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 08:44:56 +00:00
sigurdm@google.com 9584fab35b Dart2js Avoid file-names of deferred .part-files from getting too long.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//368193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38000 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 07:51:47 +00:00
johnniwinther@google.com f75df05ddd Add better error reporting to utils tests.
BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//368983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37999 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 07:48:08 +00:00
scheglov@google.com 71d80abdce Skip analyzer tests in browsers.
As we do for analysis_server.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//365213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37997 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 01:21:45 +00:00
aprelev@gmail.com 8e4610a96c Fix debugging module(replace int with intptr_t) so it works on Windows x64.
R=iposva@google.com

Review URL: https://codereview.chromium.org//369023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37996 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 23:25:58 +00:00
scheglov@google.com 570d537b0f Update HoverInformation to include offset, length, kind.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//366183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37995 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 22:06:13 +00:00
scheglov@google.com 1f45100688 Move Index and IndexStore implementations into Engine.
Also move most of the related tests.

LocalIndex test is commented out, because relies on the infrastucture existing only in Server - virtual file system, mocks.
We need to move it into Engine or extract into a separate package.

This CL also removes Dart implementation of BTree.
We now use a different approach to implementing the index.

Bots are red after the previous CL, I hope that this one will fix at least some redness.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//365193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37993 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 21:30:25 +00:00
scheglov@google.com 82d67d0d87 Add highlight regions for comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//366163003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37992 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 20:49:50 +00:00
scheglov@google.com 4b5436f498 IndexStore, Index and SearchEngine APIs and partial implementatons.
IndexStore and Index implementations are not moved yet to engine package.

SearchEngine implementation is not cleaned up yet, there is only (commented) raw java2dart translation result.

Index contributions are present, but without tests yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//363373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37991 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 19:06:33 +00:00
kevmoo@google.com bc4c2eba68 Fixed example in dart:html Events
BUG= https://code.google.com/p/dart/issues/detail?id=19641
R=efortuna@google.com

Review URL: https://codereview.chromium.org//365083006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37990 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 19:03:13 +00:00
brianwilkerson@google.com 13b10de8db Add failing test
R=scheglov@google.com

Review URL: https://codereview.chromium.org//363363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37989 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 17:55:35 +00:00
iposva@google.com 9fa3af0b08 - Correct the conditions under which Dartium does not properly implement
the isolate library API.

Review URL: https://codereview.chromium.org//370603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37988 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 16:40:01 +00:00
iposva@google.com f8419248fb - Disable isolate pause test on Dartium.
Review URL: https://codereview.chromium.org//365063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37985 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 13:38:41 +00:00
whesse@google.com 419bf8df29 Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid.
BUG=dartbug.com/19127
R=kustermann@google.com

Review URL: https://codereview.chromium.org//363323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37983 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:59:59 +00:00
iposva@google.com 5686b6a793 - Implement Isolate.pause and Isolate.resume.
- Implement a minimum Capability functionality.

R=asiva@google.com

Review URL: https://codereview.chromium.org//354763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37982 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:56:02 +00:00
johnniwinther@google.com 182be26ad2 Add ResolutionResult as intermediate value in ResolutionVisitor and use it to mark assert.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//365043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37981 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:15:21 +00:00
floitsch@google.com 1c511b0a1a Mark a few more tests as slow.
Review URL: https://codereview.chromium.org//370523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37980 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 11:24:09 +00:00
johnniwinther@google.com 13c4a04fff Generate mock libraries and assert that helpers are non-null.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//362243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37979 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 09:32:55 +00:00
lrn@google.com c1ac924205 Fix type error in dart2js typed data.
Disable as{Int32x4,Float32x4,Float64x2} in dart2js ByteBuffer.
Needs a cleanup to put the ByteBuffer implementation in the same
library as the implementation, since there is no "native"
implementation.

I'll clean up the typed-data library next, to use a patch file instead
of unnecessary duplicating code between dart2js and the VM.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//368193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37978 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 09:04:29 +00:00
sigurdm@google.com 9a12541144 Handle unresolved elements in the new IR
Also handle static calls to identical.

It seems the renamer takes care of these - mostly we just have to not
give up.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//363113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37977 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 08:51:17 +00:00
asgerf@google.com 139a3eff6c Fixed static type warning annotation in rewrite_implicit_this_test.dart.
BUG=

Review URL: https://codereview.chromium.org//367263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37976 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 08:39:31 +00:00
asgerf@google.com 4d2066a776 dart2dart: Use implicit 'this' when generating Dart code.
Expressions like this.x will be printed simply as x.
The renaming phase seems to disambiguate things so x is not captured.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//362343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37975 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 08:06:17 +00:00
lrn@google.com 085d99b079 Add typed data view creation functions on ByteBuffer.
This provides a better model and better separation for typed data.

Currently the only thing you can do with a ByteBuffer is pass
it as argument to a typed data .view factory method, which then
uses internal-only functionality to create the view.

With this change, the functionality of creating the view,
and understanding the internals of the ByteBuffer, is put on the
ByteBuffer class itself.

The view constructors on the typed data classes are retained, but
they just forward to the buffer's method. This provides backwards
compatibility and familiarity.

This change allows mocking the ByteData object. There is no hidden
connection between the constructor and the buffer that other objects
can't implement.

The change is non-breaking - it only adds methods to ByteBuffer, and
there have been absolutely no reason to extend ByteBuffer until now,
because it won't work anyway.

R=asiva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//364833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37974 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 07:48:57 +00:00
karlklose@google.com 2e8bdd4128 Revert "Emit declarations for typedefs that are needed by reflection."
Does not work in csp-drt.

This reverts commit r37945.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//363223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37973 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 07:24:08 +00:00
scheglov@google.com 64f238ba34 Implemention of the 'analysis.overrides' notification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//364083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37971 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 03:24:27 +00:00
rnystrom@google.com 2dffdf49ae Fix more pub bugs.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//364973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37968 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 01:18:09 +00:00
rnystrom@google.com 8b0c227b9e Fix pub.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//364943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37967 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 00:11:32 +00:00
nweiz@google.com f2fdcf8df1 Support passing CSP configuration to the dart2js transformer.
R=rnystrom@google.com
BUG=19465

Review URL: https://codereview.chromium.org//368103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37966 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:55:56 +00:00
nweiz@google.com 4ac8e0563a Roll forward revision 37912.
Both polymer and code_transformers test flakes should now be fixed.

R=rnystrom@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//367023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37965 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:53:57 +00:00
mlippautz@google.com f7e931bb7d observatory: add class view based on end token position
vm: add method to compute end token positions

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//361743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37964 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:22:50 +00:00
rnystrom@google.com d0d175bf69 Add a "pub global run" command.
BUG=https://code.google.com/p/dart/issues/detail?id=18538
R=nweiz@google.com

Review URL: https://codereview.chromium.org//354763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37963 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:12:35 +00:00
rnystrom@google.com 824f4d2ea9 Fix typo in readme.
BUG=https://code.google.com/p/dart/issues/detail?id=19106
R=nweiz@google.com

Review URL: https://codereview.chromium.org//362383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37962 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:07:13 +00:00
rnystrom@google.com c5a4f6b713 Fix deactivate usage tests.
BUG=https://code.google.com/p/dart/issues/detail?id=19784
R=nweiz@google.com

Review URL: https://codereview.chromium.org//362353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37961 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:05:25 +00:00
sigmund@google.com a656bf89ea Fix typo in observe-list
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//368883004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37960 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 22:35:13 +00:00
hausner@google.com 5d720cad82 Fix assertion in Dartium loading
A library may be marked as “loaded with error” multiple times it it
consists of parts. Fix an assertion that caused some tests in Dartium
to fail.

Fixes issue 19758.

R=regis@google.com

Review URL: https://codereview.chromium.org//369573006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37958 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 22:09:29 +00:00
koda@google.com 655b16b2d6 Include parent field/list index in retaining path.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//350403005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37956 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 20:37:56 +00:00
sigmund@google.com c86aa123d0 Update docs on @observable to hint about mixin Observable.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//368793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37955 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 19:04:57 +00:00
scheglov@google.com 179c102d78 Implementation for 'analysis.occurrences' notification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//367973006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37954 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 18:38:01 +00:00
regis@google.com aac127e4dd Add missing call to finalize type parameters when finalizing upper bounds.
Fixes issue 19757.

Review URL: https://codereview.chromium.org//367113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37953 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 18:06:42 +00:00