Ryan Macnak
7fa49e9910
Resolve disagreement between build.py and test.py over which architectures are included in 'all'.
...
R=zra@google.com
Review URL: https://codereview.chromium.org/2162793004 .
2016-07-19 15:32:18 -07:00
Carlo Bernaschina
b7ffd9339c
Converted Observatory nav-menu element
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2162733002 .
2016-07-19 15:28:29 -07:00
Carlo Bernaschina
0cc589e104
Converted Observatory nav-refresh element
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2161633005 .
2016-07-19 15:20:04 -07:00
John Messerly
78f129bdba
fix #26404 , incorrect cast on async function return
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2159033002 .
2016-07-19 14:16:52 -07:00
Alan Knight
4db29e8fbc
Add a couple of additional XSS tests
...
BUG=
Review URL: https://codereview.chromium.org/2160413002 .
2016-07-19 13:37:45 -07:00
Brian Wilkerson
b5c34db44c
Add a partition for packages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2167493002 .
2016-07-19 12:52:36 -07:00
Brian Wilkerson
68561695f0
Add a hook to ContextBuilder needed by server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2163003002 .
2016-07-19 12:29:29 -07:00
Florian Schneider
daea7e69ca
Revert "Fix use-after-free in isolate reload."
...
This reverts commit 16e577741d
.
TBR=johnmccutchan@google.com ,
BUG=
Review URL: https://codereview.chromium.org/2162113002 .
2016-07-19 10:44:58 -07:00
Jacob Richman
e010460709
Utility class of static methods to efficiently manipulate typed JSInterop objects in a dynamic manner. Fix for @JS classes that are _private. Bug #25038 @JS on a _Private class in Dartium
...
Tests are in the separate Dart2JS CL
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2158493003 .
2016-07-19 10:37:20 -07:00
Carlo Bernaschina
addbf1ea99
Avoid to run Observatory UI tests on DRT
...
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org/2160313002 .
2016-07-19 10:33:07 -07:00
Florian Schneider
16e577741d
Fix use-after-free in isolate reload.
...
The reload context may still be used if an error is reported.
BUG=#26895
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2159923003 .
2016-07-19 10:25:02 -07:00
Ryan Macnak
e94012cd24
Fix crash looking at a Code object in an AOT program with the service protocol.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2157223002 .
2016-07-19 09:48:12 -07:00
Carlo Bernaschina
250f2a92a4
Converted Observatory view-footer element
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2154413002 .
2016-07-19 09:43:21 -07:00
William Hesse
bde8d3efc6
Revert "Don't call _ensureRequestAnimationFrame in Dartium."
...
This reverts commit bf8eeef6a0
.
Revert "Fix animationFrameRequest for dartium."
This reverts commit 3daaf3849f
.
BUG=https://github.com/dart-lang/sdk/issues/26906
Review URL: https://codereview.chromium.org/2159183003 .
2016-07-19 13:56:36 +02:00
Konstantin Shcheglov
c2dc61ffa5
Fixes for updating synthetic element offsets.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2158973003 .
2016-07-18 17:39:26 -07:00
Keerti Parthasarathy
69a8b11f67
Fix for uri replace whene uri has fragment. Was adding a second '#'.
...
BUG=
R=het@google.com
Review URL: https://codereview.chromium.org/2158933003 .
2016-07-18 16:31:43 -07:00
pq
2a2424a314
Bump analyzer to 0.27.4-alpha.17
.
...
* Support for trailing commas in parameter and argument lists (#26647 ).
* Strong mode breaking change: can now infer generic type arguments from the constructor invocation arguments (#25220 ).
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2163503002 .
2016-07-18 16:28:39 -07:00
Florian Schneider
37dbf25f13
VM: Mark loads from final captured locals immutable.
...
This enables load elimination across calls for these locals.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2160613004 .
2016-07-18 13:32:51 -07:00
Alan Knight
30b489578d
Revert "Reapply zone tasks."
...
This reverts commit 6a7c037aa6
.
BUG=
Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00
Konstantin Shcheglov
eb74334333
Update 'new' in [new Name] comment references.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2158083003 .
2016-07-18 12:57:14 -07:00
Devon Carew
c52843e42d
Validate the regex used in search.findTopLevelDeclarations.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2160723002 .
2016-07-18 12:13:12 -07:00
Konstantin Shcheglov
b702fa4354
Flatten the if-else sequence.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2158913003 .
2016-07-18 11:11:24 -07:00
Carlo Bernaschina
3ebcc9fdd5
Added custom tags helper classes to the Observatory
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2154343002 .
2016-07-18 11:08:32 -07:00
Brian Wilkerson
0932b19dca
More work on ContextBuilder
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2156273002 .
2016-07-18 11:00:24 -07:00
Konstantin Shcheglov
55fcc03572
Use the new StaticWarningCode.UNDEFINED_IDENTIFIER_AWAIT error.
...
...instead of StaticWarningCode.UNDEFINED_IDENTIFIER
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2162523003 .
2016-07-18 10:48:55 -07:00
John McCutchan
b6e17330ed
Fix DevFS on Android devices
...
- [x] Allow a system temporary directory to be set on Android.
- [x] This is set on Flutter's engine startup path which fixes DevFS on Android devices.
Related to https://github.com/dart-lang/sdk/issues/4413
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2156243002 .
2016-07-18 10:45:53 -07:00
Konstantin Shcheglov
bf19d4147a
Another fix incremental constants - annotations should use the old unit element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2160673002 .
2016-07-18 10:43:42 -07:00
Harry Terkelsen
c5728623b9
remove dependency on compiler from resolution
...
This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org/2123073003 .
2016-07-18 10:40:21 -07:00
Zachary Anderson
43e89ccdd3
DBC: Make unoptimized static calls call through ICData
...
Isolate reloading works by manipulating ICData. Unoptimized
static calls won't go to the new function after a reload unless
the calls go through the ICData.
R=vegorov@google.com
Review URL: https://codereview.chromium.org/2149993006 .
2016-07-18 10:39:09 -07:00
Zachary Anderson
b30da81483
Fuchsia: Hello, Fuchsia!
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2158673002 .
2016-07-18 10:35:03 -07:00
Konstantin Shcheglov
056e0f16a6
Remove ConstantFinder constructor parameters.
...
ConstantFinder does not use any of these parameters.
Also remove corresponding parameters in clients.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2154083002 .
2016-07-18 10:30:32 -07:00
Konstantin Shcheglov
9b98a0ef89
Test that after context.applyChanges() with limited invalidation, results are correctly recomputed.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2157973002 .
2016-07-18 10:05:50 -07:00
Brian Wilkerson
3924815e34
Remove unused code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2156193002 .
2016-07-18 09:49:10 -07:00
Sam Rawlins
b5ffdbf584
Use an identifier's name when erroring on ref-before-decl
...
BUG=https://github.com/dart-lang/sdk/issues/26902
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2154133003 .
2016-07-18 09:46:36 -07:00
Sam Rawlins
e60c1e4c59
Add an UNDEFINED_IDENTIFIER_AWAIT warning
...
BUG=https://github.com/dart-lang/sdk/issues/22625
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2156003004 .
2016-07-18 09:45:36 -07:00
Lars Bak
d59f3eaeca
Added negative is check support ot simpleInstanceOf.
...
BUG=
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2153013002 .
2016-07-18 09:20:33 -07:00
John McCutchan
1ff0f72158
Fix DevFS writes with subdirectories
...
- [x] Add a test case for multiple level directory DevFS write
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org/2157013002 .
2016-07-18 08:58:40 -07:00
Konstantin Shcheglov
50a9fd807a
Update COMPILATION_UNIT_CONSTANTS after incremental elements building.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2155923002 .
2016-07-18 08:53:59 -07:00
Konstantin Shcheglov
6cd42f5665
Invalidate resolution if a unit instantiate a class with the unnamed constructor change.
...
This invalidates more often than it should.
We could refined it later to invalidate only if the instantiation is
with the unnamed constructor only.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2156873002 .
2016-07-18 08:38:37 -07:00
Konstantin Shcheglov
111cd73778
Don't schedule SOURCE_KIND computation when it is know already.
...
This fixes the problem when after limited invalidation we put the
changed source into the unknownSourceQueue, and schedule computation of
SOURCE_KIND, which actually never happens, because it is already valid.
The limited invalidation test will follow in a sepatate CL, because
it depends on fixing the modificationTime problem I sent for review
earlier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2155023002 .
2016-07-18 08:28:34 -07:00
Konstantin Shcheglov
63cccd0c5b
Always update 'modificationTime' in _sourceChanged().
...
We are going to make the entry to correspond the new source state,
by performing either limited or full invaliation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2155013002 .
2016-07-18 08:26:10 -07:00
Terry Lucas
2b1816c869
Added switch to disable generating cached_patches.dart file (Dartium only).
...
The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to
re-gen the sdk/lib files using:
./go.sh --no-cached-patches
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2154863002 .
2016-07-18 05:45:33 -07:00
Johnni Winther
941691650c
Split out long-running serialization test and add timings to output
...
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/2156033002 .
2016-07-18 14:09:53 +02:00
Johnni Winther
3305201211
Serialize this-types in NativeBehavior separately.
...
BUG=
R=het@google.com
Review URL: https://codereview.chromium.org/2150333002 .
2016-07-18 10:42:23 +02:00
Alan Knight
2107c13ba2
Adjust FF/Win status for webgl extension tests
...
BUG=
Review URL: https://codereview.chromium.org/2161443002 .
2016-07-15 17:27:08 -07:00
John Messerly
4b3c06f3c5
add no-implicit-casts and no-implicit-dynamic options
...
* adds these to dartanalyzer command line
* adds them to .analysis_options
R=leafp@google.com
Review URL: https://codereview.chromium.org/2144383002 .
2016-07-15 16:08:20 -07:00
Alan Knight
e610d803b1
Update test status for webgl extension tests, fix one typo in extension name
...
BUG=
Review URL: https://codereview.chromium.org/2152393002 .
2016-07-15 15:00:15 -07:00
John McCutchan
7fa9393105
Remove windows debug print and trace shutdown on some tests
...
BUG=
Review URL: https://codereview.chromium.org/2153813003 .
2016-07-15 14:53:54 -07:00
John McCutchan
4bfdaa83b2
Fix Windows bots
...
BUG=
Review URL: https://codereview.chromium.org/2149193004 .
2016-07-15 14:34:29 -07:00
Zachary Anderson
b43b9bad86
DBC: UnboxedConstantInstr
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2150933008 .
2016-07-15 14:25:40 -07:00