This reverts commit 51ee5ce40e.
Reason for revert: The windows vm-product builder is crashing on all tests after this commit. The MSVC 2017 compiler apparently builds a crashing executable for product mode. Failing build is at https://luci-milo.appspot.com/buildbot/client.dart/vm-win-product-x64-be/8697
Original change's description:
> Reland: [Windows] Update toolchain to MSVC 2017
>
> Reland of https://dart-review.googlesource.com/#/c/sdk/+/8168/ following
> fixes to bots.
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: I861ee4ab10513b93ea3fb1c357766e0f942afd10
> Reviewed-on: https://dart-review.googlesource.com/8730
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I465ad7586a76b27f6a9aa9431efbe0eb3d934b4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8800
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Before this CL we skipped procedure bodies in kernel_loader.cc by
parsing the body (but not storing anything).
With this CL we now skip them directly (i.e. don't read them at all)
in kernel_loader.cc by using the newly available extra indexes in kernel.
Change-Id: I48cf0599b2a85102c9008ff7c455785151ef3c9c
Reviewed-on: https://dart-review.googlesource.com/5764
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
- Weaken assert for identity reloads to account for lazy finalization.
- Store actual field end positions instead of computing from a terminating semicolon.
- Consider unfinalized classes to be unchanged if they have same sequence of tokens.
Change-Id: I3fcd7fed924bfac47dc382702ce63207bb8aa031
Reviewed-on: https://dart-review.googlesource.com/8164
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Change-Id: I7bd4356556023ff4a56d876684ea63bad1917b07
Reviewed-on: https://dart-review.googlesource.com/8341
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
The `dart2js_options` flag was used in some other codepaths including
"runtime=d8", this change allows us to pass --dart2js-options when using a
browser runtime as well.
Change-Id: I2864f52aff320ab3c2fbfb5a3b4bce34798a1792
Reviewed-on: https://dart-review.googlesource.com/8738
Reviewed-by: Emily Fortuna <efortuna@google.com>
Passing the type argument vector <int> in the 'none' configuration is not
correct, but this is not what this test is supposed to check.
Change-Id: I2afd2987e572a6b4340a7d70ee92878abc67055e
Reviewed-on: https://dart-review.googlesource.com/8729
Reviewed-by: Ben Konyi <bkonyi@google.com>
In Flutter, the timeline buffer overflows much more quickly than the profile buffer, but usually timeline events are more helpful than profile ticks for understanding performance. This commit trades profile buffer space for timeline event space.
32-bit:
profile buffer: 12MB -> 6MB
timeline buffer: 0.5MB -> 2MB
Also increase the default sample depth to better handle Flutter's deep tree walks.
Change-Id: If092047fa89b2b3e57e57370bc435a591497b566
Reviewed-on: https://dart-review.googlesource.com/5903
Reviewed-by: Todd Turnidge <turnidge@google.com>
Actual SDK already uses generic syntax.
This also fixes some failures in Kernel tests :-)
R=brianwilkerson@google.com, paulberry@google.com
Bug:
Change-Id: Ie9bd5a058150522210671feb7009c233f5240add
Reviewed-on: https://dart-review.googlesource.com/8706
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Restoring non_const_super_negative_test (which was outside the migrated block) to strong tests.
Bug:
Change-Id: I012d1fc6ce3b0aa3dc070894699bb9a3ed8ab8ac
Reviewed-on: https://dart-review.googlesource.com/8724
Reviewed-by: Phil Quitslund <pquitslund@google.com>
(Migration moved helper when it should have been copied.)
Bug:
Change-Id: I5bdb97ea2411b3882f4689e5b34316287eb5277c
Reviewed-on: https://dart-review.googlesource.com/8722
Reviewed-by: Ben Konyi <bkonyi@google.com>
This should make it possible to run compile_platform_test.dart inside
google3, where package layout conventions are more strictly enforced
(files in test/ cannot import files in tool/).
Change-Id: I2299e0340b0edfc1a684a635de8cf87ecb9f241f
Reviewed-on: https://dart-review.googlesource.com/8701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This method figures out which method a given forwarding node resolves
to, accounting properly for the fact that when there is multiple
inheritance, the inherited method is the one with the most specific
type.
Change-Id: Ia412e2d195dd697e35c1c08480b51f2a6bd1cac5
Reviewed-on: https://dart-review.googlesource.com/8360
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This allows the test to pass in situations where it is not run from
the root of the SDK directory.
Change-Id: I855ec4529af6f18db41964f6976232358e94c920
Reviewed-on: https://dart-review.googlesource.com/8680
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This reverts commit 42d93ff083.
Reason for revert: The windows bots don't have the correct authorization file to download our internal copy of MSVC 2017.
Original change's description:
> [Windows] Update toolchain to MSVC 2017
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
> Reviewed-on: https://dart-review.googlesource.com/8168
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I89dd1c8250d997a01bbc8de1a13cd86d5342c316
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8660
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This is mainly to support upcomping changes in BoringSSL, and to keep
our version of MSVC up-to-date with Chromium.
Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
Reviewed-on: https://dart-review.googlesource.com/8168
Reviewed-by: William Hesse <whesse@google.com>
The bot had several timeouts during the day. It may be similar to what
was fixed in
5263d17f74
Change-Id: Ife4a1e6d2b40992d260ae03287d844ee9cceb79b
Reviewed-on: https://dart-review.googlesource.com/8600
Reviewed-by: Karl Klose <karlklose@google.com>
This reverts commit 83de2423ae.
Reason for revert: Error causing the revert did not seem to be related to this change anyway.
Original change's description:
> Revert "Simplify logic for creating a single IsolateRunner in analyzer."
>
> This reverts commit 7867fed521.
>
> Reason for revert:
> Type error caught by DDC where the type of the function passed to isolate.run isn't what the runner expects.
>
> Original change's description:
> > Simplify logic for creating a single IsolateRunner in analyzer.
> >
> > Change-Id: I8583f9947fde8f4cf87d7feb64c8eb170a19e81d
> > Reviewed-on: https://dart-review.googlesource.com/6941
> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
>
> TBR=lrn@google.com,scheglov@google.com
>
> Change-Id: I5a0e46e345673dee447fd848c064dd0039832fb1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/7280
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
TBR=lrn@google.com,scheglov@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ic3793a85d979b695dc62bafd19c490aa24547682
Reviewed-on: https://dart-review.googlesource.com/8060
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
