languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity
42324 commits 11 branches 6011 tags 1.4 GiB
Commit graph

42324 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ryan Macnak
7ea4a11146 Move printing snapshot sizes behind a flag. 
R=asiva@google.com

Review URL: https://codereview.chromium.org/2504663003 .
 2016-11-16 09:07:17 -08:00
Zachary Anderson
8606013647 GN: Removes libdart_nosnapshot_precompiled_runtime 
It doesn't make sense, and building its build is broken.

Review URL: https://codereview.chromium.org/2504343002 .
 2016-11-16 08:57:17 -08:00
Sigmund Cherem
cef521645f Skip FE tests under dart2js + fast-startup (which doesn't support dart:mirrors) 
BUG=

Review URL: https://codereview.chromium.org/2505063002 .
 2016-11-16 08:42:29 -08:00
Sigmund Cherem
d89dab56b5 Fix IE11 issue: this complements the CL I sent last week. It turns out that 
there are two places where we do this check. This is why the test that I added
appears to be failing in the bots.

BUG=
R=jakemac@google.com

Review URL: https://codereview.chromium.org/2504883002 .
 2016-11-16 08:38:24 -08:00
Vyacheslav Egorov
6f1efe295c VM: Remove _nativeScript external. JS has no equivalent. 
It was added to @patch member in the VM patches.

The right fix is to remove @patch annotation from the _nativeScript.

TBR=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2506033002 .
 2016-11-16 16:36:10 +01:00
Vyacheslav Egorov
8b123831e5 VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target. 
TBR=zra@google.com

Review URL: https://codereview.chromium.org/2508923002 .
 2016-11-16 16:11:09 +01:00
Dan Rubel
be507709ed update builder test for Windows 
Review URL: https://codereview.chromium.org/2510713002 .
 2016-11-16 09:50:56 -05:00
Vyacheslav Egorov
eb38fb5d67 VM: Fix incorrect free in TryReadKernel. 
SniffForMagicNumber updates buffer pointer to skip snapshot magic number.

Thus we have to preserve and pass original buffer pointer to the free(...) call.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2503363002 .
 2016-11-16 14:40:57 +01:00
Dan Rubel
abffe25b7d integrate analysis options include directive into context builder 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2505753002 .
 2016-11-16 08:25:43 -05:00
Vyacheslav Egorov
23fd1a184b VM: Support bootstrapping core libraries from Kernel binaries instead of source. 
BUG=http://dartbug.com/27590
R=asiva@google.com

Review URL: https://codereview.chromium.org/2485993002 .
 2016-11-16 13:56:20 +01:00
Johnni Winther
12e2244310 Compute WorldImpact in NativeEnqueuer. 
R=het@google.com

Review URL: https://codereview.chromium.org/2498403002 .
 2016-11-16 11:21:46 +01:00
Johnni Winther
bce19eba04 Compute WorldImpact for mirror analysis. 
R=het@google.com

Review URL: https://codereview.chromium.org/2500373003 .
 2016-11-16 11:08:36 +01:00
Johnni Winther
b95379102a Remove Registry 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2500413002 .
 2016-11-16 10:57:10 +01:00
Ryan Macnak
d4b5793307 Enable service tests for app snapshots. 
Issue #27806

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2496993002 .
 2016-11-15 16:12:59 -08:00
Sigmund Cherem
8103739900 Fix issue #27830: the type of an super-set assignment expression is the type of 
the rhs.

The issue was introduced in a recent refactor in commit 37afcd5197

BUG= https://github.com/dart-lang/sdk/issues/27830
R=sra@google.com

Review URL: https://codereview.chromium.org/2508513003 .
 2016-11-15 15:59:24 -08:00
Stephen Adams
4bd5671a31 Fix HTypeConversion.checkedInput 
For function types, HTypeConversion.checkedInput would return the call
to the method on the reified type object.  Now the construction of the
call is deferred to codegen.dart, so the input is available directly.

The optimizer also detects checks (type assertions and 'as' casts) on
`null` values and removes the useless test.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org/2497313003 .
 2016-11-15 15:51:54 -08:00
Paul Berry
7336101b28 Change BazelWorkspace so that it checks the main source directory before READONLY. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2502103003 .
 2016-11-15 15:21:47 -08:00
Florian Schneider
2a40a14c7a Improve noSuchMethod error message for type objects. 
This CL improves the message when trying to invoke 'call' on _Type objects. This often happens
when 'new' is forgotten ("C()" instead of "new C()")

Fixes #27651.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2507493003 .
 2016-11-15 15:20:17 -08:00
Kevin Moore
4e17c8b1f8 Observatory: remove unused imports 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2505673002 .
 2016-11-15 15:11:43 -08:00
Ryan Macnak
3413ebf3a7 Mark more IO tests as failing on Android. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2497423004 .
 2016-11-15 15:03:51 -08:00
Paul Berry
1c2268b13e Move scanner tests into the front_end package. 
This required moving the following classes into front_end as well:
- CharSequenceReader
- SubSequenceReader
- JenkinsSmiHash

A small amount of the functionality of GatheringErrorListener and
AnalysisError had to be replicated, to avoid a dependency on the
analyzer package.  In a future CL I will either refactor this code to
make it available to the rest of the front end, or, if
GatheringErrorListener and AnalysisError wind up getting moved into
the front end, I will un-do the replication.

I also took the liberty of addition functionality to JenkinsSmiHash to
make it easier to use.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2508483002 .
 2016-11-15 14:53:49 -08:00
John McCutchan
f0f32a0e29 Map deleted enum values to a sentinel value. 
Fixes #27802

BUG=
R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2498863002 .
 2016-11-15 14:15:36 -08:00
Kevin Moore
90da9eeddc Revert "Remove smoke and observe from SDK DEPS" 
This reverts commit 4710e92cfc.

Analyzer tests seem to still want to use the SDK DEPS for observatory – which needs smoke and observe

Review URL: https://codereview.chromium.org/2508523002 .
 2016-11-15 12:58:51 -08:00
Zachary Anderson
c172f60bd4 Adds an environment variable that makes generate_buildfiles.py a no-op 
R=whesse@google.com

Review URL: https://codereview.chromium.org/2507483002 .
 2016-11-15 12:54:49 -08:00
Jacob Richman
fb467ef68a Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2504733002 .
 2016-11-15 12:52:28 -08:00
Kevin Moore
4710e92cfc Remove smoke and observe from SDK DEPS 
R=whesse@google.com

Review URL: https://codereview.chromium.org/2500393003 .
 2016-11-15 12:38:40 -08:00
Dan Rubel
c1451ac218 fix include options test on windows 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2505633002 .
 2016-11-15 15:13:25 -05:00
Bob Nystrom
926df1e5b3 Rewrite build_pkgs.sh and build_test_pkgs.sh in Dart. 
The bots need to run these before running the tests, so I'm porting them
to Dart so they'll run on Windows.

As a nice bonus, they're much faster now, I'm assuming because we use
one warmed up VM for all of the packages.

build_test_pkgs.sh on my machine went from ~12 seconds to ~4.

R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2498673003 .
 2016-11-15 11:14:37 -08:00
John McCutchan
6a458a8294 Mark two isolate spawn tests as pass / fail under hot reload because they are timing dependent 
BUG=

Review URL: https://codereview.chromium.org/2505613003 .
 2016-11-15 11:07:35 -08:00
Ryan Macnak
f5b1f158c0 Exclude all references into the VM isolate in heap snapshots. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2501343004 .
 2016-11-15 11:03:25 -08:00
Kevin Moore
cee0f585ad Remove pkg/pub_cache from pkg/third_party 
R=devoncarew@google.com

Review URL: https://codereview.chromium.org/2498983006 .
 2016-11-15 10:47:01 -08:00
John McCutchan
a584ee7141 Fix status file typo 
BUG=

Review URL: https://codereview.chromium.org/2501393002 .
 2016-11-15 10:42:07 -08:00
Paul Berry
da70cf3be2 Rename CompilationError.location to CompilationError.span 
This should avoid some confusion since its type is SourceSpan, not
SourceLocation.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2503853003 .
 2016-11-15 10:36:51 -08:00
Zach Anderson
d5466b0c92 Simplifies the blocking file lock test 
This test is complicated and times out flakily. This CL simplifies the test.
There is one place it may still have flakey timeouts, which I'll address if
it happens in practice.

related #27456

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2501803002 .
 2016-11-15 10:24:05 -08:00
Paul Berry
0c928771fc Revert "Connect analyzer's AnalysisError object to front_end's CompilationError." 
This reverts commit fc5270df72.

TBR=scheglov@google.com, brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2503803003 .
 2016-11-15 10:00:34 -08:00
Vijay Menon
588f10ee8e Skip queryall_test on canary. See #27794 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2492903002 .
 2016-11-15 09:49:05 -08:00
Ryan Macnak
aa47407ab8 Observatory: Add view of dominator tree with siblings merged by class. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2480293003 .
 2016-11-15 09:43:48 -08:00
Jacob Richman
27287baa57 Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2500283002 .
 2016-11-15 09:35:44 -08:00
Ryan Macnak
30517b2d1e Also push process_test when testing on Android hardware. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2505483002 .
 2016-11-15 09:26:36 -08:00
Vijay Menon
9da150f2fb Mark two more tests as passing on DDC / FF 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2498423002 .
 2016-11-15 08:42:41 -08:00
Vijay Menon
5716000c23 Mark test as passing on FF 
Now passing on FF 50.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2506663002 .
 2016-11-15 08:18:09 -08:00
Zachary Anderson
22ff72161f GN: Remove bogus argument to gn.py 
Review URL: https://codereview.chromium.org/2507463002 .
 2016-11-15 07:59:41 -08:00
John McCutchan
50b47360bd Update more status files for hot reload bots 
BUG=

Review URL: https://codereview.chromium.org/2500343003 .
 2016-11-15 07:34:03 -08:00
Johnni Winther
03bf746918 Remove static clues from spawn_uri_child_isolate.dart 
- the tests should be able to work without it.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2497293003 .
 2016-11-15 13:19:29 +01:00
Johnni Winther
128727744c Remove Selector.sameNameHack 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2501563002 .
 2016-11-15 13:03:27 +01:00
Jens Johansen
e9c78330f2 Test showing crash when stepping through new Map creation. 
Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*, bool) const

[...]

Filed as bug https://github.com/dart-lang/sdk/issues/27790.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/2486213002 .
 2016-11-15 12:49:44 +01:00
Ryan Macnak
a01c637522 Make arm32 cpu detection recognize the DragonBoard as arm64. 
R=zra@google.com

Review URL: https://codereview.chromium.org/2497273003 .
 2016-11-14 16:55:25 -08:00
Todd Turnidge
1cdb3d2155 Revert "JumpToFrame refactor" 
This reverts commit 5ed13d3298.

BUG=

Review URL: https://codereview.chromium.org/2503623003 .
 2016-11-14 15:57:01 -08:00
Harry Terkelsen
de49cba535 kernel->ssa: get simple constructors working 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2498493003 .
 2016-11-14 15:45:57 -08:00
Paul Berry
fc5270df72 Connect analyzer's AnalysisError object to front_end's CompilationError. 
AnalysisError implements CompilationError but provides additional
services, such as extensibility via the `getProperty` method.

Note: CompilationError.location has been renamed to
CompilationError.span to avoid confusion (since its type is
`SourceSpan`, not `SourceLocation`).

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2498133002 .
 2016-11-14 15:30:10 -08:00