Commit graph

521 commits

Author SHA1 Message Date
Sigurd Meldgaard 7e0c2c83f4 Update pub revision
New in this update:
```
git log --oneline --no-decorate 9f00679ef47bc79cadc18e143720ade6c06c0100..980fc947db32bca6ae7d07fbb4ad0fcdba0050ec
980fc947 Add support for global activating package from a custom pub URL (#2041)
605cafb1 "features" is not a completely implemented or documented – hide flags (#2045)
73b66cd3 Merge pull request #2035 from sigurdm/logout_command
2b03587d dartfmt again
ea805dfb Fix help-expectation
6f759c1f gitfmt
90079421 deps: move package_resolver to a dev dependency
297f017a enable and fix a number of lints
f70ee39b Update to latest dependencies, require dart 2.1, fix lints
3446fb0d Add logout command
283471e7 Merge pull request #2016 from RedBrogdon/changelog
4c00f413 Update/add www.dartlang.org URLs (#2021)
f7b147f9 Correcting nerfed changelog test.
b9308223 Edited warning messages, addressed review issues.
9e9c8ed7 Fixed race conditions in test case. (#2020)
ec972168 Removed references to gitsubmodules (#2019)
ac8ad792 Copyright dates.
f9d35d34 Formatted via dartfmt.
a3351369 Adding ChangelogValidator to the list of validators.
a826b121 Adds changelog validator and its tests.
2233e3d5 Update the required pkg:http (#1996)
75d8453a Update all of the obvious dependencies
d07dafa5 Fix unnecessary `this` lints
43a91d12 Update to latest build_runner (#1966)
b3a2cfb7 Add check for a scheme on PUB_HOSTED_URL (#1972)
6626bda3 Update tests for SDK constraint validation (#1968)
```


Change-Id: Ib7c5ec86e5a6d67094b8e70a32ff41efe571c074
Reviewed-on: https://dart-review.googlesource.com/c/94380
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2019-02-26 15:59:12 +00:00
Sigmund Cherem e3b8065625 Add support for --dump-info=binary
We continue to accept `--dump-info`, but now also accept `--dump-info=binary` so
we can use the new cheaper encoding.

Change-Id: I971cb9a3634ae1a333cfee14b2927c0e25000a01
Reviewed-on: https://dart-review.googlesource.com/c/93823
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2019-02-21 17:54:39 +00:00
Bob Nystrom 59efe201fd Fix mistake in CHANGELOG.
Must have forgotten to save this before uploading the new patch
yesterday.

Change-Id: I17967886c5138d609171030350c2b329f17b4650
Reviewed-on: https://dart-review.googlesource.com/c/93282
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2019-02-14 20:48:39 +00:00
Bob Nystrom 763035eb40 Clean up and merge dev CHANGELOG entries for stable release.
Change-Id: Ifc8f03b7783e9dcadb363e2ecee31a861f487965
Reviewed-on: https://dart-review.googlesource.com/c/92766
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2019-02-14 01:46:57 +00:00
Lasse R.H. Nielsen e6a181a583 Add set literal release comment to changelog.
Change-Id: Ic319d20a398f10a0fb3572458baa3cd58000e247
Reviewed-on: https://dart-review.googlesource.com/c/92427
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-02-13 13:02:06 +00:00
pq cccaae2b01 bump to linter 0.1.82
The Set literals support in 0.1.82 looks good for Flutter after a test migration
(https://github.com/flutter/flutter/pull/27811).

flutter-analyze-try is meant to break but only flag legitimate opportunities to migrate (validated in PR above).


Change-Id: Ie63d00cd006a96cd7f2df44b82ff8a82cf73b6bc
Reviewed-on: https://dart-review.googlesource.com/c/92761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-02-12 17:38:18 +00:00
pq d32ca512ec fix linter changelog entry
Linter 0.1.80 does not actually include the fixes to `prefer_collection_literals`.

Change-Id: I4956c43ecea4f8ec8ca4a1a8d7e8de9b07ff815c
Reviewed-on: https://dart-review.googlesource.com/c/92538
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-02-10 23:57:38 +00:00
pq 4b8ff1275c bump to linter 0.1.80 (set literals FTW!)
* updated `prefer_collection_literals` to support Set literals
* deprecated `super_goes_last`
* (internal) migrations to analyzer's preferred `InheritanceManager2` API

Change-Id: I9491c2128dd0360cd1d768242c3d1aac10687d08
Reviewed-on: https://dart-review.googlesource.com/c/92406
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-02-08 19:05:31 +00:00
Ben Konyi b625926038 [ VM / dart:io ] Updated Link implementation for Windows to use actual symbolic links.
Change-Id: I22a598e7c1f249d9150cc5ceee96daa0291e753e
Reviewed-on: https://dart-review.googlesource.com/c/90362
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-01-29 19:26:47 +00:00
Alexander Thomas 24fa01dbae [release] Update changelog with changes from dev branch
TBR=whesse@google.com

Change-Id: I100edbb9169bd6b8e22769d4699118c30652adb4
Reviewed-on: https://dart-review.googlesource.com/c/91560
Reviewed-by: Alexander Thomas <athom@google.com>
2019-01-29 14:51:27 +00:00
Aske Simon Christensen f066c05319 Rename klass getter on InstanceConstant to classNode
This achieves consistency with similar getters in the API.

This is technically a breaking change, since it changes a published
part of the Kernel API. Since the constants API is relatively new and
so far only used internally in the AOT compiler, the change is
expected to be unproblematic.

Closes https://github.com/dart-lang/sdk/issues/35696

Change-Id: I3ca30922580d226ccbdb6f77496983c21ef2102b
Reviewed-on: https://dart-review.googlesource.com/c/90220
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2019-01-28 13:31:05 +00:00
pq 8e0bc806b9 bump to linter 0.1.79
Change-Id: I3203eeab9ca3970c00113d33ec8174e4fd88d3f3
Reviewed-on: https://dart-review.googlesource.com/c/91167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-01-25 21:51:24 +00:00
Ben Konyi bb560bb233 [ VM / dart:io ] Adding to a closed IOSink now throws a StateError
Based off of these original changes:
https://codereview.chromium.org/2857393003

This is a breaking change and will require an annoucement stating such
before landing.

Fixes #29554.

Change-Id: Ibb56fd49648edc6b9fd567240a3bebb05a14234d
Reviewed-on: https://dart-review.googlesource.com/c/90120
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2019-01-25 19:23:56 +00:00
Sam Rawlins f4afaee422 Adjust dart2js notes
The sentence starting with "Because" is not a third "In particular"
bullet point.

Change-Id: Icdd2bc82b3650d9595a571de459e9683a6c0a41b
Reviewed-on: https://dart-review.googlesource.com/c/91040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2019-01-24 20:22:41 +00:00
Sam Rawlins e285f75bbe Fix dart:html and other entries in CHANGELOG:
* Fixed big rendering bug where the entire CHANGELOG was indented at
  the dart:html bulleted list, because of an un-coded `<Object>`, which
  is an HTML tag. See
  5b1daaac6c/CHANGELOG.md
* Markdown link references were not referred to.
* Wrapped everything at 80-chars.

Change-Id: I9698efe7cda175ed50c2c85018f438c5717048a8
Reviewed-on: https://dart-review.googlesource.com/c/90126
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2019-01-20 00:33:25 +00:00
Stephen Adams aeaf82577e dart:html: Add Element.removeAttribute
- Improve `element.attributes.remove(name)` to compile to `element.removeAttribute(name)`.
- Improve `element.getNamespacedAttributes(namespace).remove(name)` to compile to
  `element.removeAttributeNS(namespace, name)`.
- Add removeAttribute[NS].
- Add hasAttriute[NS].
- Assert attribute names are not null to prevent conversion to "null"/"undefined".
- TODO: Assert values are not null to prevent conversion to "null"/"undefined".
- namespaceURI does not need checking since null and undefined map to 'no namespace'.

Fixes https://github.com/dart-lang/sdk/issues/35655

Change-Id: Ie5bee23c88e8fb92f9d46f29fdf4b7f3175a2aa3
Reviewed-on: https://dart-review.googlesource.com/c/90160
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2019-01-18 19:06:24 +00:00
Dan Field 5b1daaac6c Exposes a thin layer over getsockopt/setsockopt for supported platforms.
This allows developers to have more fine grained control over socket
options supported by their platforms, particularly when there is not a
nice way to encapsulate differences between IPv4 and IPv6 options (as
with IP_MULTICAST_IF and IPV6_MULTICAST_IF).  It also begins the work
of exposing socket level and option values, although keeping it for now
only to a minimum necessary to assist with setting the multicast
interface for datagram sockets.

This CL also marks `multicastInterface` as deprecated.

Bug: https://github.com/dart-lang/sdk/issues/17057
Change-Id: I39b3bf3d32d39de1c777acea4425d6eb2226355d
Reviewed-on: https://dart-review.googlesource.com/c/89164
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2019-01-17 23:05:21 +00:00
Sam Rawlins 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split
Change-Id: Ibf5d90a6812181f71c251f064cad6eb890975af9
Reviewed-on: https://dart-review.googlesource.com/c/89840
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2019-01-16 18:46:54 +00:00
Terry Lucas edca6169c1 Fixed a number of dart:html P1 issues.
- Fixed HTML API's with callback typedef to correctly convert Dart function to JS function.
- Expose HttpStatus from dart:html
- Expose DomName ondblclick and dblclickEvent for Angular analyzer.
- Fixed removeAll should be Iterable<Object> to match Set's removeAll not Iterable<E>.
- Fixed a number of DataTransferItem, Entry, FileEntry and DiretoryEntry returning NativeJavaScriptObject needed type registered in DDC.
- Added ability to allow local file access from Chrome browser added -local in ddb.

R=vsm@google.com

Fixes #30278
Fixes #35484
Fixes #34318
Fixes #35510

Change-Id: Ide8c04716c54045e837781d489562f27b694b109
Reviewed-on: https://dart-review.googlesource.com/c/89340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2019-01-15 17:21:50 +00:00
Alexander Thomas 3104aea6f7 [release] Add changelog entry for breaking mirrors change
TBR=vegorov@google.com

Change-Id: I38d43e86fce90d22672eaf2386a82135772e7345
Reviewed-on: https://dart-review.googlesource.com/c/89287
Reviewed-by: Alexander Thomas <athom@google.com>
2019-01-14 16:19:47 +00:00
Alexander Thomas 37fba56cdc [release] Update changelog with changes from dev branch
Change-Id: I9ead586b35a122f07179c49acd6685bce321dbc5
Reviewed-on: https://dart-review.googlesource.com/c/89286
Reviewed-by: William Hesse <whesse@google.com>
2019-01-14 15:51:46 +00:00
Radu Vasilescu edb68daa2c DateTime decimal separator: Added ',' version to regex and docs, added unit tests
Change-Id: I04a566ee1ac39074f0b410e5aec5cff8c8b2ae02
Reviewed-on: https://dart-review.googlesource.com/c/88904
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-01-10 16:29:58 +00:00
Stephen Adams 651d19cdaa Ignore --fast-startup flag, assume true
Change-Id: I7a41160bf7f5bb403177b19613de2889e0fa2b44
Reviewed-on: https://dart-review.googlesource.com/c/87424
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2019-01-09 21:22:57 +00:00
Sam Rawlins e5c32261da Add note about new Literal codes
Bug: https://github.com/dart-lang/sdk/issues/34259
Change-Id: I0efd1c750f453b76e7e91482abc5843196c5b8ad
Reviewed-on: https://dart-review.googlesource.com/c/88761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2019-01-08 21:30:17 +00:00
pq 272088a4f7 linter 0.1.78
Change-Id: I8aa41ea3702efb9ca41b29a14c31140ff586129d
Reviewed-on: https://dart-review.googlesource.com/c/88431
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-01-04 23:52:43 +00:00
Janice Collins 807421cc44 Update dartdoc to 0.27.0.
Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.27.0

Change-Id: I7cdd2437d1e8d4178462e9cd4fe49fa61d45c3d9
Reviewed-on: https://dart-review.googlesource.com/c/88380
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2019-01-04 20:16:24 +00:00
Sam Rawlins a4ba658dfb Update analyzer CHANGELOG entry with annotations
Change-Id: I948e2d7a61c76a9c457d4d12314368a1360623f9
Reviewed-on: https://dart-review.googlesource.com/c/88360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2019-01-03 23:43:39 +00:00
pq 3d702164c9 Revert "bump to linter 0.1.77"
This reverts commit 168dcbf7cc.

Change-Id: Ifbfcec7f16ef03b3f639a3c3b4ca44ff7a910b4e
Reviewed-on: https://dart-review.googlesource.com/c/88340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-01-03 22:31:23 +00:00
pq 168dcbf7cc bump to linter 0.1.77
Change-Id: I702f7253d28b2fd4ab2bbd67821247192b081bb8
Reviewed-on: https://dart-review.googlesource.com/c/88286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-01-03 20:06:32 +00:00
pq 02cdda28c5 bump to linter 0.1.76
* `unnecessary_parenthesis` updated to allow wrapping a `!` argument
* miscellaneous documentation grammar and spelling fixes
* improved error messages for `always_declare_return_types`
* fix `prefer_final_fields ` to work with classes that have generic type arguments
* (internal): deprecated code cleanup
* fixed false positives in `unrelated_type_equality_checks`


Change-Id: I375a70aa86d5816881ea5d8faac65e5c3e72c80b
Reviewed-on: https://dart-review.googlesource.com/c/87422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-12-17 18:19:47 +00:00
Sigmund Cherem 2a39f63c2a Record deferred accesses in kernel world impacts and use it for splitting only
under a flag.

This reapplies commit 70e1517d98, but adds a flag
to gradually migrate users before enabling it by default.

Patchset 1 matches the old CL

Change-Id: Iaf7ee3dec8d4aa658f0b4334549b507e5a610a68
Reviewed-on: https://dart-review.googlesource.com/c/86444
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-12-06 23:20:38 +00:00
Paul Berry 670f9ab49b Merge commit '65401da92251a7318e3264b816ce0c4e14701751' into analyzer 2018-12-04 15:38:21 -08:00
pq bfee7fa626 bump linter to 0.1.75
(note that https://github.com/dart-lang/linter/pull/1296 needs to land first and 0.1.75 tagged in GH)

Change-Id: Icf022f60c1b2f6cf2371ea24036649ac4df1b1d5
Reviewed-on: https://dart-review.googlesource.com/c/86081
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-12-04 21:56:43 +00:00
Paul Berry 854a7cfe15 Merge commit '43113760f2ea114c183f8965b0d48fbb7469dc7f' into analyzer
Conflicts:
	DEPS
2018-11-28 08:38:52 -08:00
pq 801cea545d linter 0.1.73
# 0.1.73

* deprecated `prefer_bool_in_asserts` (redundant w/ Dart 2 checks)
* improved doc generation to highlight deprecated and experimental lints
* bumped analyzer lower-bound to `0.33.4`
* bumped SDK lower-bound to `2.1.0`
* new lint: `unnecessary_await_in_return`


Change-Id: I00bf626029d8e1290193e3e83a9894f175046048
Reviewed-on: https://dart-review.googlesource.com/c/85425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-11-28 00:19:52 +00:00
Paul Berry e649ed1aa3 Merge commit 'c1daa3276566e48dac6f52742264578092c56a35' into analyzer 2018-11-21 08:47:55 -08:00
Sigmund Cherem 6e8fe410bb Mention libraries-spec in the changelog as well
Change-Id: I8b1dcdd4554c8c46fb852700ca6e1c34edd6fdfa
Reviewed-on: https://dart-review.googlesource.com/c/84961
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Auto-Submit: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-11-20 20:48:00 +00:00
Paul Berry 6d8e14c9db Merge commit 'f56fea3e6389727df2cae5c6feebcdd49437b12a' into analyzer 2018-11-19 08:24:02 -08:00
Alexander Thomas f9ce4729c5 [release] Update changelog with correct release date for 2.1.0
TBR=whesse@google.com

Change-Id: I37f041373f3902c4f03d770f87e52bdd129514b6
Reviewed-on: https://dart-review.googlesource.com/c/84635
Reviewed-by: Alexander Thomas <athom@google.com>
2018-11-19 11:27:50 +00:00
Alexander Thomas 52d1a2b29b [release] Prepare changelog and version for 2.2.0-dev.0.0
TBR=whesse@google.com

Change-Id: I4e168ef4c48597d6a5eeabcfcece32044eccc3a8
Reviewed-on: https://dart-review.googlesource.com/c/84634
Reviewed-by: Alexander Thomas <athom@google.com>
2018-11-19 11:02:51 +00:00
Brian Wilkerson 4abe764b79 Update the changelog to include information about implicit-casts
Change-Id: Id64602bf1668c45925789ffee817860ae5a1db76
Reviewed-on: https://dart-review.googlesource.com/c/84444
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-11-14 19:55:36 +00:00
Sigmund Cherem b484aada21 Remove library-root option - replace it with a libraries-spec option instead
Change-Id: Ie1df52cdaa7ab4381a4c1b94c61a1210f0f31b5f
Reviewed-on: https://dart-review.googlesource.com/c/83641
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-11-09 22:40:28 +00:00
Bob Nystrom 460451be99 Update the CHANGELOG for 2.1.0.
This merges all of the entries for the 2.1.0-dev versions. It also
incorporates the notes from https://github.com/dart-lang/sdk/issues/34611.

Change-Id: I8a95863fbf8735c5cb7a9834b6be89fdc8c06017
Reviewed-on: https://dart-review.googlesource.com/c/82361
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-11-03 00:05:57 +00:00
qtbeee fa3df86c5f Update http status codes
Closes #34946
https://github.com/dart-lang/sdk/pull/34946

GitOrigin-RevId: 1ceac033effa8edea93d985e03aecce0ed833aea
Change-Id: Ia9580c131446ba41feacb889d7ff229f6f966821
Reviewed-on: https://dart-review.googlesource.com/c/81741
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-10-30 15:54:58 +00:00
Nate Bosch 655310ddf2 Add ArgumentError.checkNotNull utility
In the places where other utilities like `RangeError.checkNotNegative`
are used it reads nicer to call through a similar signature than to
follow a conditional with the utility.

Change-Id: Idd89b2934020fb55e57a22c39773fd7879d1c28f
Reviewed-on: https://dart-review.googlesource.com/c/81287
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-10-24 23:34:15 +00:00
Nate Bosch 03eafc0b2e Add fromEntries on HashMap and LinkedHashMap
Closes #34818

Change-Id: I77b117c16169a5c5bd5655e851256930a2ea5a28
Reviewed-on: https://dart-review.googlesource.com/c/81188
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-10-23 20:53:34 +00:00
pq f51ccbc010 bump to linter 0.1.70
* fix NPE in `prefer_iterable_whereType`

Change-Id: Ia1d583e2b887c09c4587443cbb4902432b2c34ed
Reviewed-on: https://dart-review.googlesource.com/c/80681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-18 17:28:29 +00:00
pq 5dfe3c8f94 bump to linter 0.1.69
* improved message display for `await_only_futures`
* performance improvements for `null_closures`
* new lint: `avoid_returning_null_for_void`

Change-Id: Ib00f88cc93e1b81fd6d87880edfc1440233c1538
Reviewed-on: https://dart-review.googlesource.com/c/80507
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-10-17 22:26:47 +00:00
pq 4506e1d179 add linter changes (#34817)
fixes: #34817

Change-Id: I3c174cdd1fb438f6885704b022809356ccf22b49
Reviewed-on: https://dart-review.googlesource.com/c/80500
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-17 17:41:26 +00:00
Sam Rawlins 56306b90ee Fix html changes markdown syntax:
Bug: https://github.com/dart-lang/sdk/issues/34815
Change-Id: I73aa8ee54bcc48ca76f8744316c9d2e38b108239
Reviewed-on: https://dart-review.googlesource.com/c/80268
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-10-16 17:48:22 +00:00