languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:21:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
68582 commits 11 branches 6011 tags 1.4 GiB
Commit graph

68582 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alexander Thomas 7bf088e4dd [release] Prepare the CHANGELOG for 2.7.0 
TBR=whesse@google.com

Change-Id: I3ba75be4eb7194ded270179c842ed8949a75d4ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127480
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-12-06 15:13:28 +00:00
Konstantin Shcheglov 54e1c16c1c Fix empty_catches in analyzer. 
R=brianwilkerson@google.com

Change-Id: I6abc5acbd93aa12df8ff6226c49f9b72c0313c92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127426
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 15:03:30 +00:00
Konstantin Shcheglov 54b7543c55 Fix unnecessary_const in analyzer. 
The only non-mechanical change is update for tool/diagnostics/generate.dart
to handle MethodInvocation, because without resolution and without
explicit `new` and `const` we get MethodInvocation(s).

R=brianwilkerson@google.com

Change-Id: Ib89ce9c37066e9b27ad03aed96b349ef36f11d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 15:03:00 +00:00
Erik Ernst 80a400297a [cfe] Add initial version of support for nonfunction-type-aliases 
Change-Id: I9ff3f0c18a31bd1e0d16ba8b6ccd0cc261250c11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127005
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-06 13:35:30 +00:00
Johnni Winther 97c2ca5ff1 [cfe] Use valid static types and file offsets in collections transformation 
Closes #39566

Change-Id: I589d0dd568b3ea939bb1238b1c61fca6867e737e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127320
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-06 10:58:20 +00:00
Jonas Termansen daa400bada [sdk] Fix all uses of the view() constructor to always use offsetInBytes. 
The list being viewed can sometimes itself be a sublist view, but the
default view() constructor doesn't take that into account, and instead the
caller needs to be aware of the case. This change makes all such uses use
offsetInBytes, even in cases that's not needed, so it's trivial to audit
that it's always used correctly. In the cases it's not needed, it just gets
the value 0 and it's a no-operation. In the cases it's needed, it fixes a
bug, such as in _WebSocketProtocolTransformer.add().

Closes #39589

Change-Id: I6e9bd5510f48ce378bdec2c64b56fe789dfb27ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127165
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2019-12-06 10:37:00 +00:00
Jens Johansen 0dc6d59d52 [CFE] Fix crash caused by name clash of loadLibrary tearoff method 
Fixes #39682

Change-Id: I0e326df9390e05ede939f0019e94f8abe1fb7983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127460
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-06 09:29:19 +00:00
Konstantin Shcheglov 0bca6aaf10 Fix avoid_return_types_on_setters in analyzer. 
R=brianwilkerson@google.com

Change-Id: If7132980451d76c777d3734abbb89ece5ad3e3d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127425
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 01:48:48 +00:00
Kallen Tu e11cf75bd9 [dart2js] Propagate kernel variance to emit annotations in RTI table. 
Change-Id: I4612c50828f5d85115e15838e2cc2117446b07ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127201
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-12-06 01:26:58 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer. 
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 01:11:30 +00:00
Devon Carew 723baf767f [analyzer] fix an npe in fix_internal.dart:2171 
Bug: https://github.com/dart-lang/sdk/issues/39673
Change-Id: Iad903410ba5fecfa61992c2dfba9289c07234269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-06 00:56:10 +00:00
Robert Nystrom 5adff879e3 Widen the SDK constraint on dart_internal to include 2.7.0. 
Change-Id: I55e9b1224f69268ccfb8ba345d3a9d62d3d93838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127449
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-12-06 00:54:30 +00:00
Konstantin Shcheglov eee20b4e60 Fix prefer_equal_for_default_values in analyzer. 
Change-Id: Ia72a2ac31d6cf6329c78baad6954ac9595a6c45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 00:00:30 +00:00
Konstantin Shcheglov f772b572c8 Fix curly_braces_in_flow_control_structures lint. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I63cb372bf04f80182f873e2143971cb3cf1392fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-05 23:46:13 +00:00
Nate Bosch bf7f27a2c5 Remove comment about inlining constants. 
Followup for #36285

Primitive constants are already inlined for us.

Change-Id: I99edcd2076795c9ee5d043bd3028d31dea744cad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123546
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-12-05 23:21:20 +00:00
asiva b99599bae1 More cleanup of the loader code. 
Change-Id: I8ee048f2a06f8aa54cb5efb832740a53b2bd042d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127444
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-12-05 23:07:55 +00:00
pq a3953b607d linter 0.1.105 
Change-Id: Id3d59bf77326a6fb98e8d5632953e9a3f1ddf512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127340
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-05 23:01:41 +00:00
Sam Rawlins 41d8b9ee63 NNBD Migrator: Handle super redirecting initializers 
Change-Id: I52043caaad81a89fe12cc554c32d1b0943d37b27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127420
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-12-05 22:59:50 +00:00
Nicholas Shahan baf1afa902 [dartdevc] Opt in dart:collection patch file for NNBD support 
Pairs best with https://dart-review.googlesource.com/c/sdk/+/127161

Change-Id: I7450128ddc7a59e05c518d22301b1a493a39e16a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127222
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-12-05 22:49:00 +00:00
Konstantin Shcheglov 845fccc337 Issue 35818. Use getDisplayString() in _ElementWriter. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35818
Change-Id: I9a86729ba48cf599c45afee2c7ba83f32ba3c30b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-05 22:21:55 +00:00
Liam Appelbe e20ff1e054 [vm] Prevent late fields from being unboxed 
When unboxed doubles are assigned to late fields, it conflicts with the
late field logic and causes a crash.

Bug: https://github.com/dart-lang/sdk/issues/38841
Bug: https://github.com/dart-lang/sdk/issues/39658
Change-Id: I641f597006114f02473a20f8c2526eeaf4fe813f
Fixes: https://github.com/dart-lang/sdk/issues/39658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127442
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-12-05 22:19:00 +00:00
Sam Rawlins 7ac3f3e904 NNBD migrator: Visit metadata on top-level functions 
Change-Id: I6825f03ca754e05a6a8a7d4a9d3c13d9baa5ddaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127400
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-05 22:13:49 +00:00
Konstantin Shcheglov eba38af5d1 Add DartType.getDisplayString() 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3849ccb4d2359fddf470b42280e3ea21e38f3664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-05 21:29:20 +00:00
asiva f7aff739bd Fix Isolate.packageRoot to account for the fact that it returns a Future. 
Change-Id: If4b7c3a66aa3071beadf29a57ac84a8e2228ffb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127341
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-12-05 19:23:19 +00:00
Robert Nystrom 1ff20f1e24 Rename "inv_cse_licm.dart" to "inv_cse_licm_test.dart". 
Without "_test.dart" in the name, the test runner will not actually
run it.

Change-Id: Ia4f8d33c6b294879909b0a838971df21cae4e67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127100
Reviewed-by: Teagan Strickland <sstrickl@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-12-05 18:49:09 +00:00
Janice Collins 7fcff7e87f Allow passing the sdk root for analysis to trial_migration. 
Also redirects usage warnings to stderr, adds --help, and verifies that the sdk
you pass in actually supports NNBD.

Change-Id: Ia758f69648f88108b3c0df9de46ab246d3db0c9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127202
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2019-12-05 18:43:19 +00:00
Alexander Aprelev 929877c822 [gardening] Fix gen_kernel path on Windows for product_aot_kernel_test.dart. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/127004.

Change-Id: I2ccdfee835beb5182a73ca065dae1791e526295f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127380
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-12-05 18:40:49 +00:00
Nicholas Shahan bef857b6cb Fix dart:collection analysis errors in NNBD fork 
Change-Id: Id4a5e5b100ca1c429070263555ab730622644d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127161
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-12-05 18:20:09 +00:00
Nicholas Shahan 88e26cd5d9 [dartdevc] Fix DDK sourcemap tests to use the right version of the SDK 
Change-Id: I1fbed66efd51f02f0faa3b489013a398f8edcd1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127260
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-12-05 15:43:29 +00:00
Samir Jindel 1d4c45d2d0 Re-land "[vm/cfe] Elaborate for-in statements during async transform" 
This removes the component of the change which updates the kernel binary
format.

Change-Id: I86dbfe0ea61453bbea6eee200743961d0d0c3814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127002
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Teagan Strickland <sstrickl@google.com>
 2019-12-05 14:06:08 +00:00
Dmitry Stefantsov 47a9ebea76 [cfe] Make API of as-instance-of and legacy LUB/GLB library-specific 
Change-Id: I1991c66e654ef537243d9f25f17070acbfa13af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126380
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-05 13:32:28 +00:00
Jonas Termansen ae14121ce7 [benchmark] Test addition of the whole d8 directory to builds. 
Change-Id: I152c86b3e0e48944940291b8f2c0c5a20f9a4c1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127142
Reviewed-by: Stephen Adams <sra@google.com>
 2019-12-05 12:29:31 +00:00
Johnni Winther e4e3f3fbc4 [cfe] Handle for-in on type variables in TypeEnvironment.forInElementType 
Closes #39565

Change-Id: I5b4c437879be0a97b306c5cc3579faac917d7e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127162
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-05 12:26:58 +00:00
Clement Skau c1565a7e64 [SDK] Cleans up a few unused functions in core_types.dart. 
Change-Id: I5fc97b26f194434e70c814ba78ae6d17f97f4fbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127145
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2019-12-05 12:04:38 +00:00
Jonas Termansen 225682f868 [infra] Try to handle failing to restore the crash resource limit instead. 
Bug: #39662
Change-Id: Ib7401e050f7cc778ef3c020f2dbf5a7c46addde3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127164
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2019-12-05 10:30:03 +00:00
Karl Klose 1a41670ed0 [infra] Temporarily disable exception for invalid core pattern 
Bug: #39662
Change-Id: I68654fcbc819e0f63f57b4f68c8934969aca6858
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127163
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-12-05 09:46:09 +00:00
Konstantin Shcheglov 47383da053 Update LUB for Null vs star. 
As specified in https://github.com/dart-lang/language/pull/700

Change-Id: I324841799a485600bf1ebfd54cd852465efac715
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126981
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-05 03:55:48 +00:00
asiva 5ff9a2ed37 Cleanup the loader code to remove some unused pieces. 
Change-Id: I026b2b0dfb964c2dd67a9022260e4aba9c019e9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125444
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-12-05 02:44:18 +00:00
Fizaa Luthra b8dbaaa527 [dartfuzz] Fix infinite recursion in call methods 
Change-Id: Ia9add544bdb12fa806dbcfcedf41ccf023d48fa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127204
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-12-05 00:24:08 +00:00
Vijay Menon 6dc48ab999 [dartdevc] Destructure optional positional parameters 
Use ES6 destructuring to handle optional positional arguments more compactly.
Note, this doesn't actually change calling convention in DDC, just how
optionals are handled at the callee.

Given Dart:
  void foo(arg1, arg2, [opt1, opt2 = def2]) {
    ...
  }
old JS:
  function foo(arg1, arg2, opt1, opt2) {
    if (opt1 === void 0) opt1 = null;
    if (opt2 === void 0) opt2 = 42;
    ...
  }
new JS:
  function foo(arg1, arg2, opt1 = null, opt2 = def2) {
    ...
  }

We should be able to similar with named params.

Change-Id: I8491a4517d729ab1dec40c1ed2073b9c33cdffe0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124107
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-12-04 23:19:26 +00:00
Kallen Tu 53bbe6c88c [dart2js] Added variance support for static subtype checking. 
Change-Id: I0731884aad68e3dd7f84658d75e946ca5db62bbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127063
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-12-04 20:54:16 +00:00
Alexander Markov f56b0f6907 [vm/aot/tfa] Whole-program constant propagation 
Size:
flutter_gallery total size -2.48% (arm), -2.3% (arm64)
flutter_gallery instructions size -2.91% (arm), -2.77% (arm64)
velocity_tracker_bench total size -7.5% (arm), -7.1% (arm64)

Performance:
SkeletalAnimation +46.02% (Intel Core i5), +37.75% (Intel Xeon), +24.86% (arm), +39.75% (arm64).
FfiMemory.Pointer* +44-64% (x64)
FfiMemory.PointerPointer +436-465% (x64), +443% (arm64).

Issue: https://github.com/dart-lang/sdk/issues/37710

Change-Id: I6221bfa02b165ccc17d4ee8b857bb89212febaff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125936
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-12-04 19:19:29 +00:00
Ryan Macnak 9929b53c71 [vm, gc] Allow old-space collections for allocations during safepoints. 
Earlier versions of the safepointing mechanism had trouble with this, so we skipped the collections expecting a higher-level caller to eventually clean-up. This is no longer necessary.

Disallow old-space collections under a force-growth scope.

Bug: https://github.com/dart-lang/sdk/issues/39484
Bug: https://github.com/dart-lang/sdk/issues/39493
Change-Id: Id5027899d06a29a307ceeca21dd4d1bc96c94920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127102
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-12-04 19:08:09 +00:00
Mark Zhou a4bac1fb10 [dartdevc] Migrating dart:_js_helper and dart:_interceptors to NNBD. 
Subsumes the reland of https://dart-review.googlesource.com/c/sdk/+/125994

Change-Id: Ie12c8d473303d0ce7379828caf7523b26733ab75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126610
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2019-12-04 18:23:29 +00:00
Brian Wilkerson 2bb60763c3 Fix remove_type_annotation fix/assist to work with for loops (issue 39628) 
Change-Id: Ie212ea369cb2c0d4d8b37b50928d3935fad6a445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-04 16:15:08 +00:00
Martin Kustermann c52acadd15 [vm/ffi] Split up some tests/ffi into vmspecific and non-vmspecific 
The separation will allow flutter/flutter integration tests to run the
non-vmspecific parts.

Change-Id: I0e771f1247ec62d2f0c3faa95ee10560e62524f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127144
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-12-04 15:56:08 +00:00
Martin Kustermann 1bbbc9f599 [vm/aot] Check in test to ensure in PRODUCT mode we don't retain any code in dart:vmservice_io/dart:_vmservice 
The CL also updates a number of pragma annotations to be conditional on
non-product mode.

Change-Id: Ia00b5089d54bbb8f6f6006ef67d65859ab56c132
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127004
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-12-04 15:30:58 +00:00
Kirill Nikolaev eec49f34c4 Always truncate thread names on linux to 15 chars (16 with the null terminator). 
On Linux it is an error for a thread name to exceed 16 bytes. Thus also changing the VM thread pool to use the shorter "DartWorker" name.

Change-Id: I4c5cc2bfb831a5593a8652d6435631b9d3803720
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126163
Commit-Queue: Kirill Nikolaev <cyriln@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-12-04 14:26:48 +00:00
Sam Rawlins 28fc03709d NNBD preview: Improve details for overridden nullable parameter types 
Change-Id: Id7f85d2030f818f690f904050f0ec54c15b0d819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127066
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-04 14:20:48 +00:00
Vyacheslav Egorov 1c2ad7e2e1 [vm/aot] Remove assertion around committing object pool into GOP. 
Our inlining heuristics are not stable and can decide to inline
something on the second attempt, which was not inlined before
leading to generation of new allocation stubs which were not
generated before.

Fixes https://github.com/dart-lang/sdk/issues/39606

Change-Id: I49d6df35d6b0568429abc84a140469e0aae065de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127143
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-12-04 13:38:48 +00:00