Work towards https://github.com/dart-lang/dartdoc/issues/3761
Sibling CL to https://dart-review.googlesource.com/c/sdk/+/365204
The analyzer has never recognized `[this]` as a valid doc comment
reference (and the `comment_references` lint rule has similarly
reported such reference attempts). dartdoc has its own algorithms
for resolving comment references, which we are dismantling in favor
of a single resolution, provided by the analyzer.
We've also decided against adding support in the analyzer (see
https://github.com/dart-lang/linter/issues/2079), so these
reference attempts should be re-written.
Change-Id: I872c215a574dc3d04f0708387408d22fdfd14c14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366882
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
This package was moved to third_party but the URL here was not updated so the link on Pub is a 404.
This will need a new Pub release before it updates, but I'm not sure it's worth doing until there are some changes.
Change-Id: Ibd1e4ba0208f13f27e1e04ba141e8a78155bd2bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369700
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Helin Shiah <helinx@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Well, to be honest, remove all instances of Group. Instead, "groups"
are Strings. Because there was only one field left, a Group is just
a... name of a group.
Also, LintRule is no longer Comparable because that does not seem to
have served a purpose...
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I6e058139631dc1b06a4072a2549f156d1622c673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369782
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
* Remove unused LinterException, Reporter, PrintingReporter.
* Mark Hyperlink as visible-for-testing, and make 3 fields private.
* Make the LinterConstantEvaluationResult constructor private.
* Make LinterContextParsedImpl.package a getter
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Ib403fb7744e9454742d6555c8cdb8764ab4377be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369781
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Also update the coverage test so that it prints detailed results to
standard output, so that the repro instructions will produce a useful
result.
In my experiments, I've found that the number supplied for the
`--tasks` argument can have a small effect on coverage numbers (though
I'm not sure why), so I've included it in the repro instructions.
Change-Id: Ic347a9e5e3c2da0f73ceefbaa9322a60295735d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368920
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Index checks in debug mode are useful to catch bugs earlier.
Also remove stale declaration of PcDescriptors::PrintHeaderString.
TEST=ci
Change-Id: I4a149c3516a6627b3d4d254b9b7eed403f8aea1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369721
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
And rename it to TestLinter.
We also get to remove `LintRule._locationInfo`,which was _only_ used
for testing pubspec-oriented rules.
This DartLinter class is only used in tests and tools of the linter
package, so it's good to move it out of analyzer lib/.
In order to remove `LintRule._locationInfo`, we move the singular
package_names test case to be a reflective test.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I97b5e79daa07eb3942f5444502473a4ec1e9daf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369562
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
PatternAssignment is a strange expression that syntactcally can have
declared variables inside.
Bug: https://github.com/dart-lang/sdk/issues/52363
Change-Id: Id6132be26581112941b7b4828c8e232143ed59b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369505
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
As discussed, remove dedicated wildcard experiment test classes in favor of language versioning exceptions.
Change-Id: I415485b42b6c356d6beec9203dcb7d838e341399
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369509
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
TEST=verified that
pkg/vm_service/test/breakpoint_resolves_immediately_in_compiled_field_initializer_test.dart
fails without the changes in this CL and passes with them, verified that
none of the existing debugger tests got broken by this CL
Change-Id: I6acb5576a80e5d633b012c866fe90bf13d2c1ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369162
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Instead of hand-written assembly to instantiate various different kinds
of type constants, we simply lower type constants to `InstanceConstant`s
for which we already have code generation.
This lowering also means that types that are considered to be different
on the kernel `DartType` level may end up being lowered to the same
`InstanceConstant`.
=> We canonicalize them now where we didn't before
=> We reduce code size.
An example where this happens the `TypeParameterType`: On the kernel
level two such types are different if they refer to a different class.
But in the RTT data structure we do not care about what class they refer
to, only the index is important (as RTT knows which class it belongs
to).
Issue https://github.com/dart-lang/sdk/issues/55516
Change-Id: I7ebd68b2c48c752f6d074a7981da75fbbfbcf00f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369480
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
When checking against a destination type that isn't generic, we can
safely ignore the type arguments of the concrete class (as we only care
whether the object's class has the destination type in its transitive
super type hierarchy).
=> Avoid calling `Object._getTypeArguments(o)` if dst type is non-generic.
Issue https://github.com/dart-lang/sdk/issues/55516
Change-Id: Ie9c6a3ab2d99acc07546f9d28ca71ac740c4aad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369462
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This makes it more consistent with other listener calls.
Change-Id: Iae98ae4c37078c15ea785faef1cb21b2ea85bb48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
If we do a type check against a class that isn't generic, then we can
safely ignore all the type arguments - because irrespective of their
values - either the class we test against is in the transitive super
hierarchy of an object's class or not.
Issue https://github.com/dart-lang/sdk/issues/55516
Change-Id: Ibf6950492d4c33d7eaf55d6ce8389ebfac201b00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369461
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
This brings the soft static enforcement that we had before: a producer
that extends ParsedCorrectionProducer cannot access the
ResolvedUnitResult of a ParsedUnitResult.
Also we add some runtime enforcement that the producers used for parse-
only lint rules are ParsedCorrectionProducer.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: If77fa66ae6fc070de1c7e931eb992a4adc14b68a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369561
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
We talked about migrating these tests to using language version overrides but I lost the plot over the weekend :).
Can you suggest how I'd modify this? How would I opt into this feature with a language version override if there is not version in which we have it enabled?
Change-Id: Ie0411d8f24e7468692a99cc2bc645bdbd3d5a500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369420
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Add `NodeLintRegistry.afterLibrary` API which allows a lint rule to
register a callback to be called after the last CompilationUnit is
visited.
Change-Id: I77bf279412617e6f2c825b6dbeaf34849e515156
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368524
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
args (b3608bd..6a5a2e6):
6a5a2e6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/args#276)
async (f933ddf..4073129):
4073129 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/async#276)
bazel_worker (2ec90c0..c76d7c8):
c76d7c8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/bazel_worker#93)
benchmark_harness (6fa42b0..f6ef33d):
f6ef33d 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/benchmark_harness#107)
boolean_selector (84467e5..62f82f6):
62f82f6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/boolean_selector#62)
browser_launcher (0dcf224..7348cea):
7348cea 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/browser_launcher#60)
cli_util (9fe3eeb..c37d5e1):
c37d5e1 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/cli_util#104)
clock (80e70ac..7cbf08e):
7cbf08e 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/clock#65)
collection (fe2e800..586a5e8):
586a5e8 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/collection#346)
convert (056626e..302af1b):
302af1b 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/convert#106)
crypto (3f815ac..0a10171):
0a10171 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/crypto#171)
csslib (141dd65..23c314b):
23c314b 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/csslib#202)
dartdoc (ed97585..45627f9):
45627f92 2024-06-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/dartdoc#3777)
ecosystem (ad9da15..bc25c0c):
bc25c0c 2024-06-01 dependabot[bot] Bump the dependencies group with 4 updates (dart-lang/ecosystem#265)
file (8ce0d13..07cacae):
07cacae 2024-06-03 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (google/file.dart#240)
fixnum (ac892ad..a8157d8):
a8157d8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/fixnum#130)
glob (ee48ea8..eaec6a4):
eaec6a4 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/glob#94)
html (00d3461..3bc803d):
3bc803d 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/html#247)
http (6337ee3..7bfbeea):
7bfbeea 2024-06-01 Anikate De `ok_http`: Add BaseClient Implementation and make asynchronous requests. (dart-lang/http#1215)
http_multi_server (4a791af..25941e2):
25941e2 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/http_multi_server#70)
http_parser (702698a..551e0e4):
551e0e4 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/http_parser#93)
json_rpc_2 (3187f7b..5b1cbd6):
5b1cbd6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/json_rpc_2#115)
lints (b254c7e..baaaa56):
baaaa56 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/lints#191)
logging (7f722dc..73f043a):
73f043a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/logging#166)
markdown (c1013dc..3d8d7a8):
3d8d7a8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/markdown#614)
matcher (4ac4096..0abd405):
0abd405 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/matcher#249)
mime (b01c9a2..8d2d559):
8d2d559 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/mime#124)
package_config (3909676..903a0e5):
903a0e5 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/package_config#155)
path (aea50fa..8fc4c72):
8fc4c72 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/path#167)
pool (1a6f2df..88e4636):
88e4636 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/pool#87)
pub_semver (f57c9c3..a9025f3):
a9025f3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/pub_semver#104)
shelf (338962c..ea3c983):
ea3c983 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/shelf#434)
source_map_stack_trace (6834af5..96a8213):
96a8213 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_map_stack_trace#55)
source_maps (181a41c..caa79c2):
caa79c2 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_maps#94)
source_span (e80cb44..59a3903):
59a3903 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_span#113)
sse (1bb0a98..7dcde16):
7dcde16 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/sse#111)
stack_trace (4d346f7..ab09060):
ab09060 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/stack_trace#155)
stream_channel (61ad872..b41ff7a):
b41ff7a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/stream_channel#107)
string_scanner (32468bd..7b37c1b):
7b37c1b 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/string_scanner#75)
sync_http (82553db..7622bdd):
7622bdd 2024-06-03 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/sync_http#47)
term_glyph (a46b48b..c86e817):
c86e817 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/term_glyph#53)
test_descriptor (d61bf6c..b23d7cc):
b23d7cc 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_descriptor#67)
test_process (4ab3f1c..862eaf3):
862eaf3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_process#59)
test_reflective_loader (f8807e0..816942e):
816942e 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_reflective_loader#63)
typed_data (fb1958c..d14f965):
d14f965 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/typed_data#88)
vector_math (43f2a77..3c03ac3):
3c03ac3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.2 to 4.1.6 (google/vector_math.dart#325)
watcher (c182cd3..c00fc2a):
c00fc2a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/watcher#168)
yaml (8fb8147..7873b3f):
7873b3f 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/yaml#165)
Change-Id: I734de0d6c7013c49b879f927d5ecda4d675b19ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369520
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>