Commit graph

13809 commits

Author SHA1 Message Date
Florian Loitsch 7374ec71bd Remove support for mixin typedefs in dart2js.
Fixes #14410.
BUG= http://dartbug.com/14410
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2567943003 .
2016-12-13 14:04:06 +01:00
Florian Loitsch 36c5cea288 Update status file and test.
Fixes red status for dartium/drt.
Also makes one test more precise (and less likely to fail for the wrong
reasons).

Review-Url: https://codereview.chromium.org/2571583006 .
2016-12-13 14:02:25 +01:00
Johnni Winther 0937e2a2e4 Update status
Review-Url: https://codereview.chromium.org/2574723002 .
2016-12-13 12:21:32 +01:00
Johnni Winther a2483321a3 Even less reliance on Compiler.closedWorld
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2569733002 .
2016-12-13 10:38:04 +01:00
Johnni Winther d4c9dc92e1 Fix rti encoding of generic methods
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2565413002 .
2016-12-13 10:27:59 +01:00
Florian Schneider 1ca079a472 Reduce flakiness of http_client_stays_alive_test.
Give it more time before failing.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566263002 .
2016-12-12 13:50:33 -08:00
Florian Loitsch cc2eba8c2a Implement FutureOr<T> for dart2js.
In dart2js, FutureOr<T> should simply be treated as `dynamic`.

Fixes #28011
BUG= http://dartbug.com/28011
R=johnniwinther@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2559523006 .
2016-12-12 15:21:03 +01:00
Florian Loitsch 0c3deba6df Add tests for FutureOr<T>.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2564563003 .
2016-12-12 14:54:57 +01:00
Johnni Winther 7953afaee6 Remove Compiler.inferenceWorld
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2559373004 .
2016-12-12 10:48:18 +01:00
Zachary Anderson a0f4b3616c Mark io/socket_test Pass, Timeout on macos.
related #27453

Review-Url: https://codereview.chromium.org/2565133002 .
2016-12-09 22:27:48 -08:00
Bob Nystrom d5acd26b1d Restore line endings of files that should be CRLF. 2016-12-09 11:09:55 -08:00
Bob Nystrom 6c757957db Move the dev_compiler strong mode tests into sdk/tests/.
DDC's codegen test copies those files to a local "gen" directory so
that it can do stuff like splitting out the multitests before it
compiles them to JS.

I left all of that alone, so the rest of DDC's test infrastructure is
unchanged. The very first step that builds the "gen" directory just
copies from sdk/tests/..._strong/... instead and the rest is good to go.

I did not move not_yet_strong_tests.dart somewhere more accessible yet
because I'm not sure if kernel needs it or where it should go.

I did not create any status files because DDC doesn't need them and
there are no test suites for the new directories for the other
platforms.
2016-12-09 11:09:55 -08:00
Matthias Hausner 156fdef01d Revert "Add optional message argument to assert statements in the VM."
This reverts commit 67e83dd79d.

BUG=

Review-Url: https://codereview.chromium.org/2558993005 .
2016-12-09 09:50:27 -08:00
Matthias Hausner 67e83dd79d Add optional message argument to assert statements in the VM.
Add flag --assert-message to control the feature.

Fixes issue #24215
BUG= http://dartbug.com/24215

This replaces Lasse’s CL  1307363005

patch from issue 1307363005 at patchset 140001 (http://crrev.com/1307363005#ps140001)

R=lrn@google.com

Review-Url: https://codereview.chromium.org/2564623003 .
2016-12-09 09:25:58 -08:00
Lasse R.H. Nielsen 283bba0944 Revert "Let Isolate.errors close on isolate exit."
This reverts commit aeb544351e.

Wasn't ready for landing yet, and triggers bug in VM.

Review URL: https://codereview.chromium.org/2563723003 .
2016-12-09 13:02:20 +01:00
Lasse R.H. Nielsen aeb544351e Let Isolate.errors close on isolate exit.
It's not perfect because it won't catch an isolate exit that happens while nobody is listening.

Add test.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2555493003 .
2016-12-09 13:00:43 +01:00
Johnni Winther 925160e2d0 dartfmt dart2js and unittests
Using dartfmt version 0.2.13

R=sra@google.com

Review URL: https://codereview.chromium.org/2557313002 .
2016-12-09 10:59:50 +01:00
Martin Kustermann 6a30db5997 Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missing CTEs from dartk and from dart_bootstrap
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2563983002 .
2016-12-09 10:55:03 +01:00
Brian Wilkerson f61ffe3e07 Fix the kernel status files to fix the bots (TBR)
Review-Url: https://codereview.chromium.org/2562703004 .
2016-12-08 15:40:08 -08:00
Johnni Winther fa038d003b Remove Compiler.openWorld
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2556073002 .
2016-12-08 10:20:17 +01:00
Johnni Winther 709a355284 Move hasRuntimeTypeSupport, hasIsolateSupport, and hasFunctionApplySupport to JavaScriptBackend.
R=het@google.com

Review URL: https://codereview.chromium.org/2558763003 .
2016-12-08 10:08:24 +01:00
Johnni Winther 015ff75143 Move handling of regular static use from ResolutionEnqueuer to ResolutionWorldBuilderImpl
R=het@google.com

Review URL: https://codereview.chromium.org/2558013002 .
2016-12-08 10:01:16 +01:00
Johnni Winther 53eb4028d8 Change Enqueuer to use Entity instead of Element.
R=het@google.com

Review URL: https://codereview.chromium.org/2549423002 .
2016-12-08 09:51:17 +01:00
Brian Wilkerson e22a2b4626 Enable messages in asserts by default
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2557513008 .
2016-12-07 12:23:00 -08:00
Sigmund Cherem 2da72a832c fix status of jsshell tests
R=het@google.com

Review URL: https://codereview.chromium.org/2562483002 .
2016-12-07 10:32:20 -08:00
Emily Fortuna 2529184b9d Handle top level fields with Kernel.
BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2537553002 .
2016-12-07 10:08:53 -08:00
Regis Crelier 6da1083953 Disallow deprecated typedef syntax for mixin apps in the VM (fixes #14410).
Update status files (will reassign issue #14410 to dart2js, since it still
accepts the syntax).

R=floitsch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2556433004 .
2016-12-07 07:34:09 -08:00
Harry Terkelsen c78814326c Update jsshell to 50.0
R=sra@google.com

Review URL: https://codereview.chromium.org/2552123003 .
2016-12-06 16:58:15 -08:00
Florian Loitsch 80da37ed25 Fix csp mode on platforms that don't support __proto__.
Fixes #27290
BUG= http://dartbug.com/27290
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2550903002 .
2016-12-06 14:31:52 +01:00
Sigmund Cherem 0cb170488c Update failing chrome tests after chrome 55 roll (issue #27991), also update a
status comment.

Review URL: https://codereview.chromium.org/2557533002 .
2016-12-05 14:38:01 -08:00
Martin Kustermann 4d3af00382 Attempt to reduce flakiness rate of io test
BUG=https://github.com/dart-lang/sdk/issues/27951
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2546733002 .
2016-12-05 14:39:25 +01:00
Stephen Adams 3e7aaeebe4 Handle synthetic nodes use to throw exceptions
- Implement:
- - _genericNoSuchMethod
- - _unresolvedConstructorError
- - _malformedTypeError

- Temporarily change NoSuchMethod.toString to avoid a closure.
- Temporarily provide argument to StringBuffer to work around bug.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2545153002 .
2016-12-02 16:11:26 -08:00
Regis Crelier 3276a2ea26 Decorate mixin application class name with private keys of libraries of super
type and mixin types if they are imported from a different library than the
library defining the mixin application class (fixes #27957).

R=hausner@google.com

Review URL: https://codereview.chromium.org/2540323005 .
2016-12-02 08:46:29 -08:00
Brian Wilkerson f45f21ae42 Remove the now unnecessary flag from test files
R=asiva@google.com, eernst@google.com

Review URL: https://codereview.chromium.org/2540843002 .
2016-12-02 07:43:05 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
Martin Kustermann 117924ed15 Update kernel status files for precompilation after refactoring
The tests for which dartk is missing a compile-time error will run the precompiler on the result and will therefore have a different status entry (even though it is caused by dartk).

Review URL: https://codereview.chromium.org/2547523002 .
2016-12-01 14:48:24 +01:00
Martin Kustermann ff8951a515 VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate
If we generate too much surviving objects in Heap::kNew during program reading
time or flow graph construction time we trigger (very aggressive) growth of new
space.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2539173002 .
2016-12-01 13:51:29 +01:00
Martin Kustermann abd77cab64 Refactor kernel-related status files
To make it clear in the status file whether a crash (or other issues) are coming
from the dartk compiler or from the vm, this CL introduces new status file
markers which are the normal markers prefixed with Dartk (e.g. DartkCrash).

Furthermore this CL groups common failures
  * compiler: dartk & dartkp
  * runtime: vm & dart_precompiled
into shared status file blocks, thereby deduplicating failures (which removes around 500 lines).

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2543973002 .
2016-12-01 13:48:35 +01:00
Johnni Winther 489199eff1 Disallow null in spanFromSpannable.
Closes #27938

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2537303004 .
2016-12-01 10:53:56 +01:00
William Hesse 10e535a5ee Update status for dart_style package and dom/shadowroot co19 windows.
BUG=https://github.com/dart-lang/dart_style/issues/562
TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/2543463003 .
2016-11-30 16:52:17 +01:00
Johnni Winther 33303ffea5 Resolve type arguments to generic methods.
R=eernst@google.com

Review URL: https://codereview.chromium.org/2535373003 .
2016-11-30 12:44:29 +01:00
William Hesse de0c7acfd7 Update status for flaky Windows tests
BUG=https://github.com/dart-lang/sdk/issues/27935
R=eernst@google.com

Review URL: https://codereview.chromium.org/2539033002 .
2016-11-30 11:41:17 +01:00
Asger Feldthaus ecf9acd26c Update vm-kernel status file.
BUG=
R=jensj@google.com

Review URL: https://codereview.chromium.org/2538063002 .
2016-11-30 10:38:21 +01:00
Johnni Winther 40bf5d321e Handle 'dynamic' as type argument in generic calls.
R=eernst@google.com

Review URL: https://codereview.chromium.org/2541473002 .
2016-11-30 09:29:35 +01:00
Johnni Winther 44bdc75827 Support patched generic methods.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2535213003 .
2016-11-30 09:20:42 +01:00
Johnni Winther 3af747810f More refactoring of enqueuers
- refactor enqueuer/strategy/impact-visitor relations
- make helper methods/fields private

R=het@google.com

Review URL: https://codereview.chromium.org/2535143003 .
2016-11-30 09:12:08 +01:00
Ben Konyi d406779dd8 Changes to language.status to fix broken tests on vm-reload and analyzer.
R=zra@google.com

Review URL: https://codereview.chromium.org/2541513003 .
2016-11-29 16:07:56 -08:00
Ben Konyi 9428946b48 Fixed failing tests (for real this time hopefully) for build #2323
Updated language.status to address failure of regress_27201_test caused by lack of deferred loading support.

BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2542473002 .
2016-11-29 15:13:16 -08:00
Ben Konyi 061cbb170e Updated language.status to address failure of regress_27201_test caused by lack of deferred loading support.
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2542453002 .
2016-11-29 14:32:15 -08:00
Ben Konyi 7e918f5b48 Fixed the conditions of an assert causing the debug VM to crash when trying to load a library from an invalid path. Created copy of a previous deferred_import_t02.dart test from co19 as a regression test until deferred_import_t02.dart is reverted to the previous test.
Fixes #27201

R=zra@google.com

Review URL: https://codereview.chromium.org/2537253002 .
2016-11-29 14:07:19 -08:00