Florian Loitsch
7374ec71bd
Remove support for mixin typedefs in dart2js.
...
Fixes #14410 .
BUG= http://dartbug.com/14410
R=johnniwinther@google.com , sigmund@google.com
Review-Url: https://codereview.chromium.org/2567943003 .
2016-12-13 14:04:06 +01:00
Florian Loitsch
36c5cea288
Update status file and test.
...
Fixes red status for dartium/drt.
Also makes one test more precise (and less likely to fail for the wrong
reasons).
Review-Url: https://codereview.chromium.org/2571583006 .
2016-12-13 14:02:25 +01:00
Johnni Winther
0937e2a2e4
Update status
...
Review-Url: https://codereview.chromium.org/2574723002 .
2016-12-13 12:21:32 +01:00
Johnni Winther
a2483321a3
Even less reliance on Compiler.closedWorld
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2569733002 .
2016-12-13 10:38:04 +01:00
Johnni Winther
d4c9dc92e1
Fix rti encoding of generic methods
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2565413002 .
2016-12-13 10:27:59 +01:00
Kasper Lund
53dd819a4c
Cleanup the kernel service implementation and avoid printing on the console when no tracing flags are provided.
...
R=kmillikin@google.com , hausner@google.com
BUG=
Review-Url: https://codereview.chromium.org/2570483003 .
2016-12-13 09:08:10 +01:00
Ben Konyi
a3ec04eb99
Fixed bad calculations for determining total allocated size of a zone.
...
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2570763002 .
2016-12-12 17:48:59 -08:00
Ben Konyi
9f8a85c19b
Added task kind field to thread JSON output.
...
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2565253004 .
2016-12-12 17:08:45 -08:00
Ryan Macnak
66182e5881
Treat dispatchers and implicit accessors the same for inlining decisions.
...
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2572543003 .
2016-12-12 15:36:43 -08:00
Ben Konyi
7eef11a0e8
Added method to IsolateVisitor to check for special isolates (i.e., service / vm isolates) since this check is done frequently.
...
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2567193002 .
2016-12-12 14:54:05 -08:00
John McCutchan
f125cc7d0b
Improve the casing of Stackmap and Stacktrace.
...
- [x] Stackmap -> StackMap
- [x] Stacktrace -> StackTrace
This makes us consistent with the Dart language (StackTrace) and
corrects the casing of StackMap.
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2572563004 .
2016-12-12 14:51:30 -08:00
Mike Fairhurst
d8c9645c26
Reorganize InheritedRefenenceContributor to serve angular completion
...
Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.
Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.
Make opType a public member of DartCompletionRequest
Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.
Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.
Change to enable the angular analysis project to do autocomplete
We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.
So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2565633002 .
2016-12-12 14:29:53 -08:00
Regis Crelier
53e93e8b05
Use kFunctionCid instead of kIllegalCid to indicate that a generic function
...
type parameter does not parameterize a class, but a function.
Snapshot generation apparently trips on kIllegalCid.
R=johnmccutchan@google.com , rmacnak@google.com
Review-Url: https://codereview.chromium.org/2567163002 .
2016-12-12 14:13:17 -08:00
Brian Wilkerson
b62c5e466f
Remove invalid dependency on linter
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2570653002 .
2016-12-12 14:10:30 -08:00
Paul Berry
dea023d345
Upgrade "path" package to 1.4.1 and eliminate analyzer test workaround.
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2569043002 .
2016-12-12 14:08:59 -08:00
John McCutchan
8b6f610206
Fix hot reload test mode in simdbc by supporting forced slow paths on simdbc
...
- [x] Add new SIM DBC byte code: CheckStackAlwaysExit.
- [x] Emit CheckStackAlwaysExit instead of CheckStack when requested.
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2569013002 .
2016-12-12 14:07:22 -08:00
Brian Wilkerson
223513c81a
Fix bug when packages file changes in new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2570623002 .
2016-12-12 14:03:00 -08:00
Florian Schneider
1ca079a472
Reduce flakiness of http_client_stays_alive_test.
...
Give it more time before failing.
BUG=
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2566263002 .
2016-12-12 13:50:33 -08:00
Ryan Macnak
6051488ad9
Cleanup dead compiler and runtime aliases from the test framework.
...
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2570633002 .
2016-12-12 13:42:35 -08:00
Konstantin Shcheglov
a5b2e62bda
Fix for completion after the closing quote in a directive.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2572513003 .
2016-12-12 13:38:38 -08:00
Ben Konyi
0d16859d87
Updated SimpleManyTasksWithZones test to not use PrintJSONForVM
...
Fixed test to not use PrintJSONForVM to get isolate information since it only returns @Isolates. Also removed some unnecessary comments and checks for isolate ids.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2567153002 .
2016-12-12 13:35:43 -08:00
Konstantin Shcheglov
c4ed99acc9
Support for overlay only files in Analysis Server with the new driver.
...
Do we need this at all?
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2571593002 .
2016-12-12 13:16:04 -08:00
Zachary Anderson
b873e2b8e3
Revert "Make list_files.py and list_dart_files.py return absolute paths"
...
This reverts commit a858542c89
.
mac gyp build fails.
Review-Url: https://codereview.chromium.org/2574523002 .
2016-12-12 13:14:53 -08:00
Zachary Anderson
a858542c89
Make list_files.py and list_dart_files.py return absolute paths
...
This makes doing an SDK build in the Fuchsia tree easier
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2564413004 .
2016-12-12 13:09:26 -08:00
John McCutchan
cd116d861b
Fix service tests
...
BUG=
Review-Url: https://codereview.chromium.org/2568963002 .
2016-12-12 12:43:01 -08:00
Konstantin Shcheglov
d564b0aaab
Send errors notification without delay.
...
Update 'analysis.updateContent' integration test.
This might be OK from performance POV - errors are cheaper to send than
for example navigation. And this satisfies the goal of 'analyzing'
notification - that new errors are to be expected.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2567113003 .
2016-12-12 11:39:47 -08:00
Ben Konyi
fa25fdd72d
Fixed tests breaking build.
...
Merge branch 'master' of github.com:dart-lang/sdk into fix
Updated format string to reflect actual type.
BUG=
Review-Url: https://codereview.chromium.org/2562243003 .
2016-12-12 11:36:55 -08:00
Paul Berry
3a24020c23
Fix test of incorrect SDK path.
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2568253002 .
2016-12-12 11:30:57 -08:00
Ben Konyi
21192e0227
Updated format string to reflect actual type.
...
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org/2566283002 .
2016-12-12 11:13:22 -08:00
Paul Berry
0c81fbc411
Fix "unused import" warnings and sort declarations.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2562643006 .
2016-12-12 11:02:22 -08:00
Paul Berry
d70184abd8
Create a default error handler to avoid the need for null checks.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2568583002 .
2016-12-12 10:54:38 -08:00
Konstantin Shcheglov
f43db9ccfa
Update the integration test to make the file with subscription a priority one.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2566243002 .
2016-12-12 10:51:13 -08:00
Ben Konyi
69be515447
Fixed build issue introduced with last commit.
...
BUG=
R=johnmccutchan@google.com , zra@google.com
Review URL: https://codereview.chromium.org/2573483004 .
2016-12-12 10:32:01 -08:00
Paul Berry
02fe40c6f7
Simplify how patch files are specified to analyzer.
...
After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like. This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.
Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.
Note that we no longer include the patch configuration in
encodeCrossContextOptions. This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2560323002 .
2016-12-12 10:15:18 -08:00
Ben Konyi
d217b21ca6
Added conversion from thread id to intptr that fixes breaking build.
...
BUG=
R=johnmccutchan@google.com , zra@google.com
Review URL: https://codereview.chromium.org/2570583002 .
2016-12-12 10:13:44 -08:00
Konstantin Shcheglov
2a7612f103
Implement 'analysis.occurrences' for the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2566223002 .
2016-12-12 10:07:19 -08:00
Ben Konyi
35a49bc1ff
Created methods to surface zone memory information for each isolate and thread in JSON.
...
BUG=
R=asiva@google.com , johnmccutchan@google.com , zra@google.com
Review URL: https://codereview.chromium.org/2554983002 .
2016-12-12 09:56:49 -08:00
Paul Berry
fb2dbfce21
Fix analyzer's SDK detection so that during integration tests, we use the built SDK.
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2568743003 .
2016-12-12 09:49:50 -08:00
Konstantin Shcheglov
a7222ac09d
Implement 'analysis.outline' for the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2571513002 .
2016-12-12 09:09:45 -08:00
Brian Wilkerson
a2713a8be5
Disable a test that times out on the bots
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2568183002 .
2016-12-12 08:51:11 -08:00
Konstantin Shcheglov
1e59cc0b9f
Remove making added files as changed.
...
This is not done (in a way) during removing files.
We just forget everything about all files.
So, we don't need an additional complication here.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2566913002 .
2016-12-12 08:36:40 -08:00
Florian Loitsch
cc2eba8c2a
Implement FutureOr<T>
for dart2js.
...
In dart2js, FutureOr<T> should simply be treated as `dynamic`.
Fixes #28011
BUG= http://dartbug.com/28011
R=johnniwinther@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org/2559523006 .
2016-12-12 15:21:03 +01:00
Florian Loitsch
0c3deba6df
Add tests for FutureOr<T>
.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/2564563003 .
2016-12-12 14:54:57 +01:00
Florian Loitsch
6a966d2914
Add FutureOr<T>
class to dart:async
.
...
`FutureOr<T>` is a magical class, but having a concrete implementation
makes it easier for many tools (like dartdoc, code navigation, ...) to
deal with it.
Fixes #28029
BUG= http://dartbug.com/28029
R=lrn@google.com
Review URL: https://codereview.chromium.org/2562703002 .
2016-12-12 14:05:48 +01:00
Johnni Winther
e00732643f
Remove CodegenEnqueuer.compiler
...
R=het@google.com
Review-Url: https://codereview.chromium.org/2564823002 .
2016-12-12 10:59:48 +01:00
Johnni Winther
7953afaee6
Remove Compiler.inferenceWorld
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2559373004 .
2016-12-12 10:48:18 +01:00
Johnni Winther
415ba7948c
Reduce use of Compiler.closedWorld
...
- in preparation for passing ClosedWorld directly between phases.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2563443007 .
2016-12-12 10:35:23 +01:00
Brian Wilkerson
756cfc963d
Fix warnings
...
Review-Url: https://codereview.chromium.org/2564323002 .
2016-12-11 16:53:13 -08:00
Brian Wilkerson
b7f1a96ae5
Change the way tasks are registered
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2566893002 .
2016-12-11 15:59:46 -08:00
Konstantin Shcheglov
0728e4ee70
Implement 'analysis.getErrors' for the new driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2566013002 .
2016-12-11 15:27:57 -08:00