Commit graph

7475 commits

Author SHA1 Message Date
Terry Lucas 733c996535 Test sdk/lib regen for dart2js
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1755523002 .
2016-02-29 23:37:21 -08:00
John McCutchan e40a443bbf Fix Flutter Dart role
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/1744573002 .
2016-02-26 10:30:14 -08:00
Terry Lucas fe7e620a92 Fix InvocationMirror->Invocation in _ReturnedDictionary
BUG=

Review URL: https://codereview.chromium.org/1724133002 .
2016-02-24 07:54:12 -08:00
Alan Knight 78b0f6f353 Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1727003002 .
2016-02-23 16:33:31 -08:00
Terry Lucas 97861e3f22 Fixed a few problems with 45 roll merge
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1720823003 .
2016-02-22 12:02:43 -08:00
Terry Lucas a3350d9b06 Generation of sdk/lib files from 45 roll
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1720743005 .
2016-02-22 10:59:12 -08:00
Zachary Anderson 38786e9566 More SecurityContext calls accept a password.
Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.

R=whesse@google.com

Review URL: https://codereview.chromium.org/1699163002 .
2016-02-17 10:58:19 -08:00
Florian Loitsch a89ed4ad36 Add comment to linesplitter.bind.
Review URL: https://codereview.chromium.org/1695873002 .
2016-02-12 22:20:12 +01:00
Florian Loitsch bd2e5b8a75 Provide a better type for line-splitter's bind.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1698563002 .
2016-02-12 22:04:06 +01:00
Florian Loitsch 257272fd42 Use internal const-constructor.
BUG= http://dartbug.com/25760
R=lrn@google.com

Review URL: https://codereview.chromium.org/1696453002 .
2016-02-12 20:29:41 +01:00
John McCutchan 0c11088761 Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular
- rename sdk/lib/io/iolib_sources.gypi to sdk/lib/io/io_sources.gypi so that io is regular with respect to the other sdk libraries.
- Lint sdk/lib/*/*_sources.gypi
- Add dart_sdk_lib_copy gn template.

Related https://github.com/flutter/flutter/issues/1712

R=zra@google.com

Review URL: https://codereview.chromium.org/1692603002 .
2016-02-11 14:23:22 -08:00
Alan Knight f2fd68c362 Fix MessageEvent.data to convert using structured clone.
BUG=

Review URL: https://codereview.chromium.org/1683403005 .
2016-02-11 13:05:53 -08:00
Florian Loitsch 310385aeb2 More tests for async* functions.
An async* stream may only be canceled at yield-points.

R=hausner@google.com

Review URL: https://codereview.chromium.org/1677063003 .
2016-02-11 14:53:44 +01:00
Jacob Richman c0ddc73fce Switch broken console inspect method to call the _inspect method of the JS inspector host object.
BUG=

Review URL: https://codereview.chromium.org/1689033003 .
2016-02-10 18:49:25 -08:00
John McCutchan 657a3b759d Document ServiceExtensionResponse
Fixes #25758

R=nweiz@google.com

Review URL: https://codereview.chromium.org/1685703005 .
2016-02-10 14:47:36 -08:00
Zachary Anderson 89f414dc37 Adds support for PKCS12 containers to SecurityContext
Looking forward to using platform specific APIs, this container type is
more common on MacOS and Windows, and is the only container type
supported by the native iOS API.

R=whesse@google.com

Review URL: https://codereview.chromium.org/1687533002 .
2016-02-10 14:20:59 -08:00
John McCutchan b9b0649b9c dart:developer service extension fixes
Fixes #25724
Fixes Florian Loitsch's emailed request (get rid of k prefix on constants).

- Rename ServiceExtensionResponse constants to not have a 'k' prefix.
- Provide more explanation on how to invoke service extensions (they require an 'isolateId' parameter).
- Require extension method names to begin with "ext." and recommend the template: "ext.package.command" to avoid conflicts with other packages.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1680593004 .
2016-02-10 08:54:51 -08:00
Florian Loitsch 963f653b12 Make generic type of timeout-future the same as the one from the original.
R=lrn@google.com

Review URL: https://codereview.chromium.org//1299443002 .
2016-02-09 18:57:25 +01:00
Florian Loitsch 381c12df4a Documentation cleanups.
BUG= http://dartbug.com/25703
BUG= http://dartbug.com/25728
BUG= http://dartbug.com/25713
R=lrn@google.com

Review URL: https://codereview.chromium.org/1682013002 .
2016-02-09 18:27:14 +01:00
Sigmund Cherem c3e61f315c cpsir: triage remainder of html test suite, fix a couple.
R=asgerf@google.com, het@google.com

Review URL: https://codereview.chromium.org/1679603002 .
2016-02-08 10:37:52 -08:00
Zachary Anderson 2cf6405ca9 Adds SecurityContext.setTrustedCertificatesBytes
Implements SecurityContext.setTrustedCertificates in terms of the new
function. This requires setTrustedCertificates to return a Future,
and removing the `directory` named argument as it is not possible to
implement with BoringSSL without blocking IO.

R=whesse@google.com

Review URL: https://codereview.chromium.org/1665433002 .
2016-02-08 08:41:49 -08:00
Vijay Menon 89ccefe462 Add generic method info to ListMixin
These match those already in iterable.dart

Fixes #25408

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1665463002 .
2016-02-03 11:26:53 -08:00
Zachary Anderson 3319366489 Fix incomplete renaming
TBR

Review URL: https://codereview.chromium.org/1660023002 .
2016-02-02 12:38:54 -08:00
Zachary Anderson 8f356bf87e Adds SecurityContext.useCertificateChainBytes
Changes SecurityContext.useCertificateChain to call the new method and
return a Future.

R=whesse@google.com

Review URL: https://codereview.chromium.org/1648793005 .
2016-02-02 10:54:07 -08:00
Paul Berry fadca3983a Change sdk/bin/dart2js to find an available build.
This parallels the change to sdk/bin/dart made by commit
ac8a228d0b.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1650383002 .
2016-02-01 08:53:13 -08:00
Søren Gjesse ca7ee2b6cd Fix EOF detection when reading an entire file
Closes #25596

BUG= https://github.com/dart-lang/sdk/issues/25596
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1651023003 .
2016-02-01 10:08:57 +01:00
Zachary Anderson 98771a083f Adds SecurityContext.usePrivateKeyBytes
This is the first step toward removing blocking IO calls from
the implementation of the SecurityContext API.

Using a buffer rather than a file name API will probably be needed
for implementing SecurityContext and SecureSocket with platform
specific built-in APIs on iOS/Mac/Windows rather than BoringSSL.

related #8227

R=whesse@google.com

Review URL: https://codereview.chromium.org/1616073004 .
2016-01-29 08:52:18 -08:00
John McCutchan 87d8d3a719 Make it possible to share the embedder's dart sources for the service isolate.
- Cleanups to the embedder's Dart sources for the service isolate. This lets us stop keeping a local copy in the mojo and flutter trees.
- Let the VM know Observatory's server address.

R=zra@google.com

Review URL: https://codereview.chromium.org/1640773005 .
2016-01-29 07:43:21 -08:00
Lasse R.H. Nielsen d6b01b5028 Fix type-error in base64.dart
Fixes issue #25577.
BUG= http://dartbug.com/25577

Review URL: https://codereview.chromium.org/1630933004.
2016-01-28 13:15:01 +01:00
Kevin Moore 22961a8ee6 Small tweaks to isolate doc comments
R=iposva@google.com

Review URL: https://codereview.chromium.org/1642683002 .
2016-01-27 09:19:55 -08:00
Florian Loitsch 42f063e0a0 Improve stream-controller documentation.
R=lrn@google.com

Review URL: https://codereview.chromium.org/1635643002 .
2016-01-26 11:35:44 +01:00
Stephen Adams 4a01c6a1cf List constructor sentinel must not implement 'int' (extend JSInt).
Having a regular object that 'is' a number was causing horrible problems for type inference and generated code quality.

To get this to work required fixes in type inference and the collection of reified default argument values.

Fixes issue https://github.com/dart-lang/sdk/issues/25566

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1629553002 .
2016-01-25 20:40:39 -08:00
Lasse R.H. Nielsen 75d1366dbd Use WeakMap to support Expando if available.
Retains the existing code as fallback for settings without WeakMap for now.

Fixes issue #5144

BUG= http://dartbug.com/5144
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1599393003 .
2016-01-25 12:06:06 +01:00
Lasse R.H. Nielsen 3990be61d9 Update Stream.listen doc and use ?? in some places.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1606543005 .
2016-01-21 12:58:24 +01:00
Jacob Richman c66c110b75 Fix bug where multiple JSObject wrappers could be created for the same JsObject.
Factory constructors for JSObject now set the _dartHtmlWrapper of the JsObject
so that it will be hard to have future bugs related to preserving JSObject.

BUG=

Review URL: https://codereview.chromium.org/1605513005 .
2016-01-19 10:59:35 -08:00
Søren Gjesse 9240052ebb Optimize Websocket compression for no context takeover requests
Resolve issue with server applying context takeover when not enabled.

After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.

This patch resolves that issue and adds tests to validate in the future.

Ensure encoders/decoders are properly 'discarded' when client_no_context_takeover
and server_no_context_takeover flags are detected.

Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.

Add tests for client header values

BUG=25317

Patch by Matthew Butler <butler.matthew@gmail.com>

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1584653008 .
2016-01-18 08:51:44 +01:00
Jacob Richman cf7ae2e0cb Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html.
Support typed JS interop classes that extend the behavior of  dart:html types in Dartium.

This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1583773003 .
2016-01-15 10:40:32 -08:00
Lasse R.H. Nielsen b5d25f4b4c Merge pull request #25492 from sethladd/regexp-docs
add a short note about raw strings in the regexp class docs
2016-01-15 09:58:39 +01:00
Søren Gjesse 82aeb1997e Fix Websocket compression tests for Client side.
Client must use new encoding buffer when receiving clientNoContextTakeover
directive from server.

BUG=25317

Patch by Matthew Butler <butler.matthew@gmail.com>.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1583933007 .
2016-01-15 09:09:32 +01:00
Ivan Posva 28412d153e - Fix Isolate.spawn when running from snapshot.
- Avoid access to Isolate.resolvePackageUri when not needed. Fixes Dartium based test.

TBR

Review URL: https://codereview.chromium.org/1591573004 .
2016-01-14 23:24:07 -08:00
Seth Ladd 98722458bc add a short note about raw strings in the regexp class docs 2016-01-14 16:46:07 -08:00
Lasse R.H. Nielsen 0083cf8439 Change Platform.isiOS to isIOS.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1583763002 .
2016-01-14 11:14:59 +01:00
Søren Gjesse a72ddf3a9d Resolve issues with websocket compression.
Always reuse encoder/decoder otherwise we send partial frames before
all data is added properly. Also reduces redundant allocations.

Websocket: Only set compression flag if not a continuation frame

Continuation frames should inherit compression settings from
previous frame.

BUG=#25317

Patch by Matthew Butler <butler.matthew@gmail.com>.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1579343003 .
2016-01-14 10:44:37 +01:00
Alan Knight 87c1bb4b39 Add autofocus to the Html5NodeValidator list of standard attributes for <input>
BUG=

Review URL: https://codereview.chromium.org/1588773002 .
2016-01-13 17:19:00 -08:00
Stephen Adams 2bae30eb27 Initialize _BroadcastSubscription._eventState to permit inference of non-null value
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1576153005 .
2016-01-13 10:24:49 -08:00
Lasse R.H. Nielsen f70bef4a2c Support the same parameter key more than once in Uri query parameters.
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org/1520943002 .
2016-01-13 13:07:18 +01:00
Ivan Posva 6d066c7e53 Add package config support to dart:isolate
- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution: false" parameters to spawnUri.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1553233002 .
2016-01-12 18:19:04 -08:00
Alan Knight 7f80dbbbe1 Revert "Mark supportsPointConversions deprecated and always true rather than testing DOMPoint"
This reverts commit 2dfdfe554e.

BUG=

Review URL: https://codereview.chromium.org/1583673002 .
2016-01-12 16:24:12 -08:00
Alan Knight 2dfdfe554e Mark supportsPointConversions deprecated and always true rather than testing DOMPoint
BUG=

Review URL: https://codereview.chromium.org/1580203002 .
2016-01-12 13:52:38 -08:00
Alan Knight a5ba7a7db6 Add an Unstable comment/annotation on caretRangeFromPoint
BUG=

Review URL: https://codereview.chromium.org/1578103003 .
2016-01-12 11:12:47 -08:00