languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 03:13:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MessageEvent.data to convert using structured clone.

Browse source 
BUG=

Review URL: https://codereview.chromium.org/1683403005 .
This commit is contained in:
Alan Knight 2016-02-11 13:05:53 -08:00
parent c4602b0c8b
commit f2fd68c362
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sdk/lib/html/dartium/html_dartium.dart
View file

@ -26122,8 +26122,12 @@ class MessageEvent extends Event {
@DomName('MessageEvent.data')
@DocsEditable()
Object get data => wrap_jso(_blink.BlinkMessageEvent.instance.data_Getter_(unwrap_jso(this)));
// TODO(alanknight): This really should be generated by the
// _OutputConversion in the systemnative.py script, but that doesn't
// use those conversions right now, so do this as a one-off.
dynamic get data => convertNativeToDart_SerializedScriptValue(
_blink.BlinkMessageEvent.instance.data_Getter_(unwrap_jso(this)));
@DomName('MessageEvent.lastEventId')
@DocsEditable()
@Unstable()

13
tools/dom/templates/html/impl/impl_MessageEvent.darttemplate
View file

@ -21,11 +21,22 @@ $if DART2JS
type, canBubble, cancelable, data, origin, lastEventId, source,
messagePorts);
}
$endif
$endif
var event = document._createEvent("MessageEvent");
event._initMessageEvent(type, canBubble, cancelable, data, origin,
lastEventId, source, messagePorts);
return event;
}
$if DARTIUM
// TODO(alanknight): This really should be generated by the
// _OutputConversion in the systemnative.py script, but that doesn't
// use those conversions right now, so do this as a one-off.
@DomName('MessageEvent.data')
@DocsEditable()
dynamic get data => convertNativeToDart_SerializedScriptValue(
_blink.BlinkMessageEvent.instance.data_Getter_(unwrap_jso(this)));
$endif
$!MEMBERS
}