languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:39:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
36931 commits 11 branches 6011 tags 1.4 GiB
Commit graph

36931 commits

This branch
This branch
All branches
Author SHA1 Message Date
Siva Annamalai b6d01a8947 Fix thread test. 
Review URL: https://codereview.chromium.org/1754833002 .
 2016-03-01 13:26:30 -08:00
Paul Berry 9a983bcbda Add the ability to deprecate Flatbuffer fields. 
If an IDL field is marked as `@deprecated`, no setter will be
generated for it, and the getter generated for it will throw an
UnimplementedError.  This is similar to the behavior of standard
Flatbuffer tools (which generate neither setters nor getters for
deprecated fields) except that we have to generate a getter in order
to avoid warnings.

Once we have begun using summaries in the wild, we will need to make
use of this feature in order to avoid changing Id numbers and breaking
backwards compatibility.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1753883002 .
 2016-03-01 13:25:02 -08:00
pq d223676c7f Fix @override quick-fix to respect doc comments. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1751163002 .
 2016-03-01 13:01:57 -08:00
Siva Annamalai 376b60148c Fix windows build. 
Review URL: https://codereview.chromium.org/1748883004 .
 2016-03-01 12:56:46 -08:00
Brian Wilkerson 841f8e6cf2 Move shouldFileBeAnalyzed into ContextManager 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1748763002 .
 2016-03-01 12:40:56 -08:00
Siva Annamalai e83151cc77 - Add assertions in MutexLocker/MonitorLocker to ensure that the code enclosed 
in these blocks will not have a safepoint operation
- changed boxed_field_list_monitor_ to boxed_field_list_mutex_ as we only
  need a mutex for guarding access to boxed_field_list_ as changed the
  lock to use SafepointMutexLocker as the list addition code could potentially
  allocate and result in GC (safepoint operation)
- Added a SafepointMonitorLocker as we have a function Isolate::VisitIsolates
  which could potentially have safepoints in the enclosed block.
- Make the lock around MegamorphicCacheTable::Lookup a SafepointMutexLocker
  as the look up code seems to be allocating memory while the lock is held.
- Changed the ThreadPool and MessageHandler code to account for the new
  MonitorLocker usage standard
- Fixed PortMap::PrintPortsForMessageHandler to use SafepointMutexLocker as
  the code it encloses calls into Dart
- Removed profiler_ field in class Profiler as it doesn't seem to be used.

R=johnmccutchan@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1748953003 .
 2016-03-01 12:33:50 -08:00
Paul Berry 92176ad482 Add major and minor version numbers to summary files. 
Note: my expectation is that we won't start bumping the version
numbers until summaries begin being used in the wild.  While summary
support remains experimental, the version number will remain at 1.0.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1754793002 .
 2016-03-01 12:21:40 -08:00
Konstantin Shcheglov e225e619cd Issue 25827. Don't propose to remove the type of an incomplete variable declaration. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25827

Review URL: https://codereview.chromium.org/1753893002 .
 2016-03-01 12:20:24 -08:00
Srdjan Mitrovic 88acc8ab01 Make type canonicalization thread safe 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1747073002 .
 2016-03-01 12:12:16 -08:00
Paul Berry 5772408ed0 Clear static ElementFactory state at the start of all resolver tests. 
This prevents the ElementFactory's ClassElement for `Object` (which it
stores statically) from getting accidentally shared between separate
unit tests in a single test run, which could cause state to leak
between the tests.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1752023002 .
 2016-03-01 11:26:39 -08:00
Konstantin Shcheglov 93393bba3b Make 'generate_summaries' depend on the whole skd/lib folder. 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1749813003 .
 2016-03-01 11:17:06 -08:00
Konstantin Shcheglov 7d0fbd1b11 Separate 'isQualified' flags as List<bool>. 
It turned out that for used names we don't need any flags because we
want to store only qualified unresolved (potential) class member
usages. So, no flags for used names at all, at least for now.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1750163003 .
 2016-03-01 11:06:40 -08:00
Zachary Anderson e2729705ff Rolls back fix of SecurityContext method names. 
R=iposva@google.com

Review URL: https://codereview.chromium.org/1757453002 .
 2016-03-01 10:34:15 -08:00
Ryan Macnak 7b6463b708 Exception handlers may have null type arrays. 
Fixes crash introduced by e1cd55dc8f.

R=regis@google.com

Review URL: https://codereview.chromium.org/1755713002 .
 2016-03-01 10:14:03 -08:00
Ivan Posva 890c86251a - Add binary size analysis tool from Chromium. 
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1754443002 .
 2016-03-01 10:06:07 -08:00
Regis Crelier 699890db11 Introduce experimental flag --reify in the vm. 
Note that many tests will fail when using --no-reify, since expected type errors
are not reported.

R=iposva@google.com

Review URL: https://codereview.chromium.org/1517153004 .
 2016-03-01 10:03:18 -08:00
pq 6a75757e47 Updated hasFix(...). 
Follow-up to: https://codereview.chromium.org/1736383002/

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1741133002 .
 2016-03-01 08:32:48 -08:00
Brian Wilkerson eadf713dfd Add the @literal annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1747943002 .
 2016-03-01 07:57:26 -08:00
Brian Wilkerson 76d22fe363 Move DelegatingAstVisitor into the public API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1747093002 .
 2016-03-01 07:57:01 -08:00
Brian Wilkerson 55df03925a Clarify the semantics of the @required annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1744273002 .
 2016-03-01 07:56:36 -08:00
John McCutchan b2249f30fd Add persistent handles to service protocol and Observatory UI 
VM Changes:

- Add private _getPersistentHandles service RPC.
- Add service_test for _getPersistentHandles.

Observatory Changes:

- Add Persistent Handles page.
- Display persistent handles in a curly-block
- Display weak persistent handles in a sortable table.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1719313002 .
 2016-03-01 07:31:29 -08:00
Asger Feldthaus 396bf9ac15 dart2js cps: Reorder class definitions and run dartfmt. 
Subclasses of Primitive and Expression have been grouped into separate
sections of cps_ir_nodes.dart.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1748413002 .
 2016-03-01 15:34:19 +01:00
Asger Feldthaus dbaf47de5e dart2js cps: Remove receiverIsNotNull from CPS nodes. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1747213002 .
 2016-03-01 14:56:45 +01:00
Terry Lucas d2e1a2ce3c client* no longer handle manipulated the properties are back to ints 
TBR=alanknight@google.com,jacobr@google.com

Committed: 637ed1e3e1

Review URL: https://codereview.chromium.org/1754593004 .
 2016-03-01 04:50:40 -08:00
Asger Feldthaus e54c4c7003 dart2js cps: Use definitions by default, not references. 
Example of new client code:
  x.object => x.objectRef
  x.object.definition => x.object
  x.arguments[n].definition => x.argument(n)

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1743283002 .
 2016-03-01 13:25:31 +01:00
Terry Lucas 8cb5ef741f Fix more things with webgl so it works 
- dart.idl emitted currently supported operations in Chrome 45 so there were 9 duplicates.
- Support mapping a bunch of webgl types to Dart types.

TBR=jacobr@google.com,alanknight@google.com

Committed: 3a6e6cafea

Review URL: https://codereview.chromium.org/1748383002 .
 2016-03-01 03:34:19 -08:00
Terry Lucas 81d0e0f94f Revert "Test sdk/lib regen for dart2js" 
This reverts commit 733c996535.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1750283002 .
 2016-02-29 23:49:58 -08:00
Terry Lucas 733c996535 Test sdk/lib regen for dart2js 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1755523002 .
 2016-02-29 23:37:21 -08:00
Konstantin Shcheglov 4ca8d2d4a8 Support for boolean lists in FlatBuffer. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1747663002 .
 2016-02-29 18:08:43 -08:00
Konstantin Shcheglov 46aa21ac6c Remove indexing debug code. 
The bots are green, it seems that unwrapping Member(s) fixed the problem.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1751613002 .
 2016-02-29 17:50:36 -08:00
Konstantin Shcheglov 93e9a3c9a1 Record only qualified unresolved name usages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1755433002 .
 2016-02-29 17:46:47 -08:00
Brian Slesinsky 09a7387740 Clear stale elements in an unresolved TypeName 
BUG=https://github.com/dart-lang/sdk/issues/25855
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1745413002 .
 2016-02-29 17:16:28 -08:00
Ryan Macnak 7adcf94b75 Adjust expectations of library_env_test to take into account noopt, precompiled and product mode. 
R=iposva@google.com

Review URL: https://codereview.chromium.org/1748153003 .
 2016-02-29 17:11:07 -08:00
Srdjan Mitrovic cd1112a382 Factor out code that looks up a canonical type and adds it to the canonical_types_ array if necessary. 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org/1748913002 .
 2016-02-29 15:49:07 -08:00
Ryan Macnak e1cd55dc8f Precompilation: also trace types of exception handlers. 
Cf. 4b112c6d25

R=regis@google.com

Review URL: https://codereview.chromium.org/1746313002 .
 2016-02-29 15:34:59 -08:00
Regis Crelier e66d65f7b9 Change function source fingerprint calculation to rely on tokens exclusively and 
not on the signature type hash anymore. This makes fingerprints insensitive to
implementation details of the type system. The signature type hash was included
because, in the early days, the token stream of a function started at the
opening brace and did not include tokens representing the signature.

R=srdjan@google.com

Review URL: https://codereview.chromium.org/1752503002 .
 2016-02-29 14:59:21 -08:00
Brian Wilkerson 954d61f363 Partially revert notification of package map computation 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1750763002 .
 2016-02-29 14:37:00 -08:00
Konstantin Shcheglov 3a401c3d59 Follow ClassTypeAlias constructor redirections. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1746963002 .
 2016-02-29 14:13:30 -08:00
Brian Wilkerson c4d7f41650 Move folderMap from AnalysisContext to ContextManager 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1750683002 .
 2016-02-29 14:04:46 -08:00
Florian Schneider 248b70a40f Exclude deoptimization-related runtime functions from precompiled runtime. 
Deopt instructions and deferred object classes are not needed there.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1749973002 .
 2016-02-29 13:34:48 -08:00
Ryan Macnak ad01f0fb41 Don't expand inline frames in stacktraces under noopt to match full precompiled behavior. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1748793002 .
 2016-02-29 13:28:09 -08:00
Kevin Moore 6437886ef9 updated ordering of changelog items 
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1745223002 .
 2016-02-29 13:19:06 -08:00
Konstantin Shcheglov 2d94021a68 Record names references in index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1753433002 .
 2016-02-29 13:16:59 -08:00
Florian Loitsch 1d2a46e6b4 Update Changelog with conditional imports. 
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1749953002 .
 2016-02-29 22:14:42 +01:00
John McCutchan d08d4d8dba Dump functions on circular dependency parser error 
Help with: https://github.com/dart-lang/sdk/issues/25545

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1751523003 .
 2016-02-29 12:32:20 -08:00
Florian Loitsch 55630a5e90 Support 'dart.library.X' env variables in the VM. 
BUG= http://dartbug.com/24587
R=iposva@google.com, johnmccutchan@google.com

Committed: c2a06e22cb
Reverted: 5eb5b42989

Review URL: https://codereview.chromium.org/1640853004 .
 2016-02-29 20:58:32 +01:00
Matthias Hausner 11767827db Add comment to async* support code 
Addresses review comment.

Review URL: https://codereview.chromium.org/1751503002 .
 2016-02-29 11:22:04 -08:00
Konstantin Shcheglov b982e02a60 Attempt to fix build: unwrap Member(s). 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1748053002 .
 2016-02-29 11:18:13 -08:00
Konstantin Shcheglov db2fd1ef1e Rename some index fields and use single 'UnitIndex.unit' field. 
The added prefix 'usedElement' groups fields in UnitIndex.
In a next CL I will add also 'usedName' field set for indexing used
names, resolved and unresolved.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1746113002 .
 2016-02-29 10:50:19 -08:00
Brian Wilkerson 4d9aa3edf4 Remove more methods from context manager callbacks 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1741663003 .
 2016-02-29 10:43:55 -08:00