Commit graph

36931 commits

Author SHA1 Message Date
Konstantin Shcheglov
aa7bea0d6a New SearchEngine implementation - references only.
And only for the elements for which we have information in the index.
References to other kinds of elements - local variables, parameters,
etc can be implemented using AST visitors. To be implemented in next CLs.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1763133002 .
2016-03-04 12:08:04 -08:00
Konstantin Shcheglov
822fa6c912 Update codeOffset/codeLength during incremental resolution.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1768613002 .
2016-03-04 11:36:35 -08:00
pq
1f0a0b5a5c Quick fix to ignore a specific error (#25915).
See: https://github.com/dart-lang/sdk/issues/25915

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1764853002 .
2016-03-04 11:11:06 -08:00
Konstantin Shcheglov
40ebbcfb7c Don't index constructor element reference second time.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1761073004 .
2016-03-04 10:43:18 -08:00
John Messerly
764a067813 Fixes list/map literal to not infer bottom
R=leafp@google.com

Review URL: https://codereview.chromium.org/1759363002 .
2016-03-04 09:43:13 -08:00
Ryan Macnak
a78ed1c47a Tree-shake consts.
BUG=http://dartbug.com/25892
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1758153002 .
2016-03-04 09:42:53 -08:00
Florian Schneider
72a815c39f VM: Add smi fast path operations for precompiled code
The non-smi case is handled in a slow-path deferred code path.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1756403002 .
2016-03-04 09:33:09 -08:00
Konstantin Shcheglov
9c79752839 Resynthesize codeOffset/codeLength properties.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1762193002 .
2016-03-04 09:26:31 -08:00
Zachary Anderson
f6ddb4568f Regularize some errors thrown by SecureContext.
This is done by replacing a call to SSL_CTX_set_client_CA_list() with
calls to SSL_CTX_add_client_CA(), preserving the diagnostic status
return value discarded by the former.

R=iposva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/1761583002 .
2016-03-04 09:02:20 -08:00
Terry Lucas
984737f998 More passing tests with Dartium 45
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1766723002 .
2016-03-04 05:30:11 -08:00
Terry Lucas
e4a5eefe98 More tests that now work
TBR=alanknight@google.com,whesse@google.com

Review URL: https://codereview.chromium.org/1765913002 .
2016-03-04 05:18:31 -08:00
William Hesse
f425c82985 Add zlib dependency for dart_bootstrap build
The Dartium build does not include io components in the libraries, which
are what pull in zlib for the non-dartium builds of the SDK.  But it does
build dart_bootstrap, which needs zlib.  It actually should not need to
build dart_bootstrap, since it is useless without io capabilities.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org/1761233003 .
2016-03-04 13:15:40 +01:00
Kasper Lund
3f23d46ebb Try to fix redness on build bots by correcting the inline JS code.
TBR'ed.

R=jacobr@google.com
BUG=

Review URL: https://codereview.chromium.org/1761073003 .
2016-03-04 10:41:44 +01:00
Kasper Lund
96be0c49fb Revert "Change scripts to avoid generating things that bloat the compiled code"
This reverts commit 4f3abbd5ef.
2016-03-04 10:06:07 +01:00
Kevin Moore
edd6054d13 update changelog for Dartium roll
R=terry@google.com

Review URL: https://codereview.chromium.org/1760903004 .
2016-03-03 19:52:53 -08:00
Alan Knight
4f3abbd5ef Change scripts to avoid generating things that bloat the compiled code
BUG=

Review URL: https://codereview.chromium.org/1759303003 .
2016-03-03 17:39:50 -08:00
Regis Crelier
6219753e18 Use TRUNC.W instead of CVT.W on mips to convert from double to int as to not
depend on the current rounding mode (fixes issue 25900).
Add support for TRUNC.W in assembler, disassembler, and simulator.
Fix disassembler to understand CVT.S.
Remove unused instructions.
Update co19 status file.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1765623002 .
2016-03-03 17:05:09 -08:00
Ryan Macnak
3b16570e07 Also update the test harness for unification of dart_no_snapshot into dart_bootstrap.
Cf. d61ebd4ed2

R=iposva@google.com

Review URL: https://codereview.chromium.org/1760263003 .
2016-03-03 16:47:28 -08:00
Florian Schneider
69f39d0b83 VM: Don't do inline context allocation in precompiled code.
It saves almost 2% (dart2js) in generated snapshot size, and the performance
benefit is negligible in precompiled code.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1760153003 .
2016-03-03 16:22:13 -08:00
Terry Lucas
56b461c37c Few more tests for fix for 45 roll
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1767523002 .
2016-03-03 16:12:48 -08:00
Sigmund Cherem
cf78d296d7 Replace TypeMask.isEmpty by isEmptyOrNull, use isEmpty when it's really empty.
R=asgerf@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1755823003 .
2016-03-03 15:04:32 -08:00
Ivan Posva
d61ebd4ed2 - Unify dart_no_snapshot and dart_bootstrap into one binary.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1760063003 .
2016-03-03 14:53:59 -08:00
Zachary Anderson
7a2512540a Build for Android x64
This change adds standalone VM build targets for x64 Android.

Build with, e.g.:

./tools/build.py -m debug -a x64 --os=android runtime

R=iposva@google.com

Review URL: https://codereview.chromium.org/1762043002 .
2016-03-03 14:04:52 -08:00
John McCutchan
3d5b6017c1 Adjust offset before querying inline information for samples that begin at exit frames
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1762833002 .
2016-03-03 13:58:10 -08:00
Siva Annamalai
c51fcbf2b3 Turn off background compilation by default.
Review URL: https://codereview.chromium.org/1764823002 .
2016-03-03 13:48:48 -08:00
Jacob Richman
4aa00a94db Hand edited changes to dart:html to correct code size regressions.
BUG=

Review URL: https://codereview.chromium.org/1762073002 .
2016-03-03 13:45:38 -08:00
Jacob Richman
c66635cc9f Basline of dart2js w/ regen'd sdk/libs
BUG=

Review URL: https://codereview.chromium.org/1762063002 .
2016-03-03 13:42:10 -08:00
John McCutchan
f7aec4b5d2 Set last resume timestamp when isolate is made runnable
Fall out from https://codereview.chromium.org/1756393002/ caused a checked mode test failure: https://build.chromium.org/p/client.dart/builders/vm-linux-release-ia32-be/builds/11330/steps/checked%20vm%20tests/logs/stdio

Review URL: https://codereview.chromium.org/1759303002 .
2016-03-03 13:34:03 -08:00
Konstantin Shcheglov
6510065262 Check that target of a new constructor is a ClassDeclaration.
For an exception #10 from the list.

Cannot reproduce though.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1757393002 .
2016-03-03 13:19:40 -08:00
Srdjan Mitrovic
1cc5dab2f2 Clear fields sticky_error and pending_functions when unscheduling thread; enable background compilation
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1754703008 .
2016-03-03 12:32:54 -08:00
Terry Lucas
84365bc7c0 Skip 2 test for analysis API/IDLs have changed in 45 roll
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1760233002 .
2016-03-03 11:38:39 -08:00
John McCutchan
49dc7e557b Fix some service protocol isolate life cycle races that were discovered by the Flutter testing tool.
Fixes #25902

Issue #1

Assuming --pause-isolates-on-start, there is a window of time after an isolate is made runnable and before it pauses at the first message that we say the isolate is "resumed".

- Fix issue #1 by claiming the isolate is paused on start if it will eventually pause on start.
- Also, handle the resume command for this state by clearing the 'should pause on start' bit.

Issue #2

Before an isolate is made runnable we say the isolate is "resumed".

- Fix issue #2 by introducing a new pause event "None".

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1756393002 .
2016-03-03 11:30:41 -08:00
Konstantin Shcheglov
adcf43968f Ignore not ClassDeclaration target of an unknown method invocation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1764743002 .
2016-03-03 11:23:32 -08:00
Zachary Anderson
7c2c02d6a6 Fix x86-64 Android build.
R=iposva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1761953002 .
2016-03-03 11:11:31 -08:00
Terry Lucas
4f3b4097fd Fixed dart2js compilation problem
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1762763002 .
2016-03-03 11:08:24 -08:00
Paul Berry
c46f593b33 Add support for ConstructorElementImpl.isCycleFree to summaries.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1762663002 .
2016-03-03 11:00:27 -08:00
Terry Lucas
a29edf769f Updated status file changes for Dartium sdk/lib generated from 45 IDLs
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1761973002 .
2016-03-03 10:59:24 -08:00
Kevin Moore
06606b4c35 Cleanup/moving around config inputs sections for 1.15 changelog
TBR

Review URL: https://codereview.chromium.org/1764553003 .
2016-03-03 10:53:37 -08:00
pq
e0b327742d Bump meta pre-publish.
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1761933002 .
2016-03-03 10:53:08 -08:00
Brian Slesinsky
5831cfb1bb Fix issue where errors aren't reported for a new overlay
A new overlay was not being marked as an explicitly added
source, even if it's within the directory of an analysis
context. As a result, errors were not being reported.

I believe this only happens if there's no underlying file.
Therefore it seems difficult to reproduce in an IDE, but
it comes up in a stress test.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1753083003 .
2016-03-03 10:42:45 -08:00
Ryan Macnak
167616b83e Skip mirror tests more generally for $mode == product instead of $runtime == dart_product.
Reduces failures in tools/test.py -mproduct.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1760043002 .
2016-03-03 10:06:59 -08:00
pq
8cd8d219ca Handle incomplete rule options gracefully.
Net-net: this fixes the case where we get storms of UNDEFINED_LINT_WARNINGs when parsed yaml nodes have null values.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1752183003 .
2016-03-03 09:58:30 -08:00
pq
5f6b0eb6d4 Disable annotate_overrides pending bulk editor.
Until we can apply a bulk edit, the ~1800 occurences of this hint are too noisy.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1765543002 .
2016-03-03 09:56:32 -08:00
Todd Turnidge
5d83c5ec9b Print isolate properly in debug output for IsolateRunnable events.
Be a bit more verbose in test_helper to help us track down some test hangs.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1760963002 .
2016-03-03 09:53:44 -08:00
Terry Lucas
3f0bb621a8 Revert "Changes to tests and status file for the 45 roll w/ regenderated sdk/libs"
This reverts commit 8d12df1e77.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1763753002 .
2016-03-03 09:41:01 -08:00
Terry Lucas
23d5f671ae Revert "Fixed dart2js compilation and udpate obsolete analyzer for co19"
This reverts commit 439b59b1fc.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1753903005 .
2016-03-03 09:37:53 -08:00
Srdjan Mitrovic
5c0a18d3be fix status file
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1759203002 .
2016-03-03 09:35:19 -08:00
Konstantin Shcheglov
80531d974d Make SearchMatch usable for the new index - remove the element field.
The 'element' is still accessible, but as a computed property.

In many cases we don't need to know the containing element, and need
only the unit source, or the LibraryElement. So, by computing it on
demand we may save some time and make SearchMatch usable with the
new index - where we don't know the Element.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1764553002 .
2016-03-03 08:40:57 -08:00
William Hesse
15f8618c1c Update status for dart2js host-checked mode tests.
BUG=https://github.com/dart-lang/sdk/issues/25911

Review URL: https://codereview.chromium.org/1760173002 .
2016-03-03 17:29:25 +01:00
Konstantin Shcheglov
3fe1282f75 Don't use List caches for lists of primitive values.
Caching is useful for lists of objects, but lists of primitive values
it is wasteful to create copies when we can read directly from the
underlaying buffer.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1760523008 .
2016-03-03 08:04:52 -08:00