Commit graph

42934 commits

Author SHA1 Message Date
Zachary Anderson 63cb4565d7 Fuchsia: Adds a script to download the prebuild SDK
The Fuchsia world doesn't run gclient runhooks or use depot_tools so
the advice is to check in a custom script to pull the prebuilt SDK
from google storage.

R=asiva@google.com, phosek@chromium.org, rmacnak@google.com

Review URL: https://codereview.chromium.org/2541123006 .
2016-12-02 13:18:54 -08:00
Michael R Fairhurst 7e04b119aa Add a performance benchmark for the angular analyzer plugin (#27932) 2016-12-02 12:06:10 -08:00
Brian Wilkerson c75c14db54 Only generate summaries, in tests, when necessary
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2547953002 .
2016-12-02 12:01:51 -08:00
Konstantin Shcheglov 8524189ca0 Implement 'topLevelLibraryDeclarations' getter to return all libraries with exported top-level declarations.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2544883003 .
2016-12-02 11:20:33 -08:00
Brian Wilkerson b4820d6a63 Handle generic local functions without a return type (issue 27965)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2551533002 .
2016-12-02 10:50:21 -08:00
Florian Schneider 10e08360c7 VM: Fix DBC out-of-bounds load from Uint32List.
Fixes #27849.

R=zra@google.com

Review URL: https://codereview.chromium.org/2549743002 .
2016-12-02 10:43:24 -08:00
Kevin Moore b7be77cf92 update docs on dart:developer Service class
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2544153003 .
2016-12-02 10:28:42 -08:00
Seth Ladd 2e9064ae13 Update docs for Map values, keys (#27972)
Closes https://github.com/dart-lang/sdk/issues/27968
2016-12-02 10:01:23 -08:00
Brian Wilkerson 06bc6e5d33 Guard against missing token (issue 27963)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2547053002 .
2016-12-02 09:14:18 -08:00
Regis Crelier 3276a2ea26 Decorate mixin application class name with private keys of libraries of super
type and mixin types if they are imported from a different library than the
library defining the mixin application class (fixes #27957).

R=hausner@google.com

Review URL: https://codereview.chromium.org/2540323005 .
2016-12-02 08:46:29 -08:00
Konstantin Shcheglov d6e89bf3a2 Use Map(s) for top-level declarations.
This would help to implement 'get sources by name' that Paul pointed
out in a previous CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2543263002 .
2016-12-02 08:44:31 -08:00
Brian Wilkerson 8e2011aa21 Deserialize parameters before printing them
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2537863005 .
2016-12-02 08:28:37 -08:00
Brian Wilkerson f45f21ae42 Remove the now unnecessary flag from test files
R=asiva@google.com, eernst@google.com

Review URL: https://codereview.chromium.org/2540843002 .
2016-12-02 07:43:05 -08:00
Brian Wilkerson e17e359faa Create summary files in MockSdk classes
Review URL: https://codereview.chromium.org/2542853003 .
2016-12-02 07:32:39 -08:00
Asger Feldthaus 47bfb02f36 Fix a bug in kernel class hierarchy.
Abstract members would sometimes be seen at possible dispatch targets.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2542143003 .
2016-12-02 13:32:45 +01:00
William Hesse 191184ba3d Remove dead code with analyzer warning in test scripts
BUG=

Review URL: https://codereview.chromium.org/2548773002 .
2016-12-02 11:29:45 +01:00
Zachary Anderson bc661cf77b Fuchsia: Update VM test statuses
R=asiva@google.com

Review URL: https://codereview.chromium.org/2529293010 .
2016-12-01 20:28:14 -08:00
Jennifer Messerly 7a1b6e75b3 restrict generic function type subtyping
R=leafp@google.com

Review URL: https://codereview.chromium.org/2540903003 .
2016-12-01 19:24:15 -08:00
Florian Loitsch db8782f6e6 Update num.compareTo documentation.
Fixes #27924
BUG= http://dartbug.com/27924
R=lrn@google.com

Review URL: https://codereview.chromium.org/2537813002 .
2016-12-01 17:26:59 -08:00
Todd Turnidge e0d350aa27 Implement rewind on all platforms except for dbc.
BUG=

Review URL: https://codereview.chromium.org/2534413005 .
2016-12-01 17:19:31 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
Ryan Macnak 3126ade6d0 Fuchsia: Throttle epoll to prevent message queues from being overwhelmed with level-triggered events.
BUG=US-109
R=asiva@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2545833003 .
2016-12-01 16:39:22 -08:00
Vijay Menon 201c5b9297 Fix runtime strong mode error in ListMixin
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2544163002 .
2016-12-01 15:41:46 -08:00
Vijay Menon ec81359fc0 Fixes #27960
For "m.call(..)", the function is "m".

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2539033004 .
2016-12-01 15:38:46 -08:00
Ryan Macnak e5a16b1ca5 Remove exitCode setter from dart:io's Process.
Fixes #27950

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2542323002 .
2016-12-01 14:35:12 -08:00
Paul Berry 66bc760621 Analyze dev_compiler on the analyzer bot.
This would have allowed me to catch the failure that forced
1d028eed8d to be reverted.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2547683002 .
2016-12-01 13:51:01 -08:00
Konstantin Shcheglov 038cd32326 Compute exported top-level declarations.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2542883003 .
2016-12-01 13:49:00 -08:00
Alan Knight 1ff09b431f Keep only a single active stack trace, enables traces for thrown non-exceptions
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2545923002 .
2016-12-01 13:41:08 -08:00
Konstantin Shcheglov 4d7c536c2f Return only public top-level declarations.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2541793005 .
2016-12-01 13:32:48 -08:00
John McCutchan 6bf86eacd7 Add getIsolateID to Service class in dart:developer
Fixes https://github.com/dart-lang/sdk/issues/23924

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2542003002 .
2016-12-01 12:48:49 -08:00
Konstantin Shcheglov 1e5fc38884 Compute top-level declarations in a file.
This is the first step to implement 'Add Import' Quick Fix with the new
analysis driver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2545753003 .
2016-12-01 11:43:15 -08:00
Paul Berry c4f50f53cb Remove old AST factory constructors from analyzer.
This reapplies the remainder of
1d028eed8d (which was reverted due to
conflicts with dev_compiler), since dev_compiler has now been fixed to
use analyzer's new astFactory.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2549613002 .
2016-12-01 11:17:10 -08:00
Florian Loitsch 222d80ad9d Update documentation for num.clamp.
(partially) fixes #27923
BUG= http://dartbug.com/27923
R=lrn@google.com

Review URL: https://codereview.chromium.org/2541513002 .
2016-12-01 11:01:44 -08:00
Paul Berry 0c31815f1c Transition analyzer and analysis_server to new astFactory.
This is the same as 1d028eed8d (which
was reverted) except that it doesn't remove the old AST factory
constructors (which broke dev_compiler).  The removal of old AST
factory constructors will be done in a follow-up CL so that if it
unexpectedly breaks any other clients we will be able to revert it
without reverting this CL.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2536373008 .
2016-12-01 10:56:21 -08:00
Paul Berry 2d289c2df6 Modify dev_compiler to use analyzer's new AstFactory class.
The old mechanism for creating analyzer ASTs (factory constructors on
the interface classes) will be going away in analyzer 0.30.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2545843002 .
2016-12-01 10:37:22 -08:00
Konstantin Shcheglov 2368a59d60 Add libraries in corrections using SourceInfo instance of LibraryElement.
We are not going to have LibraryElement(s) for the new analysis driver.

The current approach: get known library sources, compute their elements,
import these elements does not work well when there is no analysis cache.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2532393008 .
2016-12-01 10:22:48 -08:00
Stephen Adams f62009a3aa dart2js-kernel: Handle some more 'is' cases
Adds type variables and function types.
Still missing parameterized interface types.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2542783002 .
2016-12-01 09:28:02 -08:00
Konstantin Shcheglov 53b04631bc Move running tasks for fixed time to the scheduler.
This improves recovery time for change/undo from 300 ms to 200 ms for
analyzer + analysis_server + front_end.

_FilesReferencingNameTask does not degrade in any noticeble way, it is
still about 0-1 ms for this code base, as compared to 60 ms without
fixing runing time in the task or the scheduler.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2540403002 .
2016-12-01 09:15:36 -08:00
Konstantin Shcheglov aaaeee5bc4 Make MemoryResourceProvider.convertPath() work with partially posix paths.
So that 'C:\some\path/to/file.dart' -> 'C:\some\path\to\file.dart'.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2542793003 .
2016-12-01 08:39:44 -08:00
Vijay Menon 106c623a9f Some fixes for lazy JS types
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2542833002 .
2016-12-01 07:44:38 -08:00
Jonas Termansen 3676af3168 Ensure consistent file ordering in observatory tarball
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/2545783002 .
2016-12-01 16:01:09 +01:00
Martin Kustermann 117924ed15 Update kernel status files for precompilation after refactoring
The tests for which dartk is missing a compile-time error will run the precompiler on the result and will therefore have a different status entry (even though it is caused by dartk).

Review URL: https://codereview.chromium.org/2547523002 .
2016-12-01 14:48:24 +01:00
Paul Berry cb2fef0c45 Add a front end perf test that computes unlinked summaries.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2544643002 .
2016-12-01 05:46:47 -08:00
Jonas Termansen c0172aba48 Don't store git commit in observatory version string
The observatory assets tarball would be different every time due to the
version string, which makes it compress to a different size. The size
changes would then move the program data around, making it much more
difficult to determine if dart builds of different revisions are
actually identical.

Google Analytics doesn't need to know the exact version numbers, it will
be fine to say they are bleeding edge builds of a particular version.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2540383003 .
2016-12-01 14:16:23 +01:00
Martin Kustermann 37dfdbdc97 VM: Remove unused (and incomplete) HashMap::Remove() function
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2542103002 .
2016-12-01 13:51:49 +01:00
Martin Kustermann ff8951a515 VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate
If we generate too much surviving objects in Heap::kNew during program reading
time or flow graph construction time we trigger (very aggressive) growth of new
space.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2539173002 .
2016-12-01 13:51:29 +01:00
Martin Kustermann abd77cab64 Refactor kernel-related status files
To make it clear in the status file whether a crash (or other issues) are coming
from the dartk compiler or from the vm, this CL introduces new status file
markers which are the normal markers prefixed with Dartk (e.g. DartkCrash).

Furthermore this CL groups common failures
  * compiler: dartk & dartkp
  * runtime: vm & dart_precompiled
into shared status file blocks, thereby deduplicating failures (which removes around 500 lines).

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2543973002 .
2016-12-01 13:48:35 +01:00
Johnni Winther 27afcc4296 Remove EnqueuerImpl.processInstantiatedClassMembers
R=het@google.com

Review URL: https://codereview.chromium.org/2539043002 .
2016-12-01 11:10:36 +01:00
Lasse R.H. Nielsen c6412af7bb Don't use [operator==] to refer to [==] in DartDoc. It doesn't work.
R=eernst@google.com

Review URL: https://codereview.chromium.org/2548433002 .
2016-12-01 11:00:33 +01:00
Johnni Winther 489199eff1 Disallow null in spanFromSpannable.
Closes #27938

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2537303004 .
2016-12-01 10:53:56 +01:00