languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:47:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
43970 commits 11 branches 6011 tags 1.4 GiB
Commit graph

43970 commits

This branch
This branch
All branches
Author SHA1 Message Date
Konstantin Shcheglov 4cd790abe3 Record isFinal for parameters into summaries. 
Found this out while running shared tests with the new analysis driver.

R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657583007 .
 2017-01-25 15:08:37 -08:00
Ben Konyi de72bf4991 Moved isolate high watermark calculations into the Observatory client. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2656723002 .
 2017-01-25 15:03:42 -08:00
Brian Wilkerson f6f2ecfe69 Improve performance of visiting large invalid compilation units 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2653343002 .
 2017-01-25 14:55:32 -08:00
Ben Konyi 0d9a7970f5 Removed usage of std::map and std::vector from kernel code. Issue #28064. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2658693002 .
 2017-01-25 14:53:33 -08:00
Matthias Hausner 197f141100 Allow debugger to stop when reading a static field 
Add a DebugStepCheck when the right-hand side of an expression is an access
to a static field or top-level variable.

BUG=#28453
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2650823007 .
 2017-01-25 14:39:24 -08:00
Ben Konyi 6c2e67e764 Revert "Switched from GrowableArray to MallocGrowableArray to fix crash caused" 
This reverts commit ac2b995a9296a100b0385fe7f262ebefa1da30d8.

BUG=

Review-Url: https://codereview.chromium.org/2656693006 .
 2017-01-25 13:59:46 -08:00
Ben Konyi 9956256223 Switched from GrowableArray to MallocGrowableArray to fix crash caused by no isolate/thread existing when called. Also created MallocMap for the same reason. 
BUG=
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2655463005 .
 2017-01-25 13:55:45 -08:00
Zachary Anderson 0c3d73967d VM eventhandler: Update epoll/kqueue even if the only event is an error 
Otherwise, we may try to add an fd to epoll/kqueue when it is already
there.

Also avoid sending multiple notifications on an error.

related #24417

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2655893002 .
 2017-01-25 13:50:00 -08:00
Siva Annamalai e07cc86697 Skip third_party/pkg/linter (Issue 27937) 
Review-Url: https://codereview.chromium.org/2649313007 .
 2017-01-25 13:37:47 -08:00
John McCutchan a47af8ea9e Fix memory leaks in cc/Log_* tests 
Fixes #28347

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2651013002 .
 2017-01-25 13:32:28 -08:00
Brian Wilkerson a27c9e4a0b Skip linter tests on the pkg bots 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2655963002 .
 2017-01-25 13:26:07 -08:00
P.Y. Laligand d0a9768377 Fix analyzer tests. 
This was failing on Windows.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2654183003 .
 2017-01-25 13:25:07 -08:00
Konstantin Shcheglov f1f5d490d7 Fix MockSdk.fromFileUri() implementations. 
This should fix the test failure on Windows bot.

TBR

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653753006 .
 2017-01-25 12:08:25 -08:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests" 
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
 2017-01-25 11:06:58 -08:00
Zachary Anderson d71c70d56d Update Dartium status for passing test 
Review-Url: https://codereview.chromium.org/2655913002 .
 2017-01-25 10:38:33 -08:00
Ryan Macnak ed00447138 Make the VM resilient to a confusion between a NULL instructions snapshot and instructions snapshot that is an empty array in the Flutter embedder. 
Related to issue #28504

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2648383006 .
 2017-01-25 09:58:14 -08:00
Kevin Moore 1e8558a3a6 fix spelling in core libraries 
Fixes https://github.com/dart-lang/sdk/issues/28490

R=dgrove@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2655883002 .
 2017-01-25 09:36:55 -08:00
P.Y. Laligand 66cda63fea Added support for GN workspaces. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2651613003 .
 2017-01-25 09:26:45 -08:00
Paul Berry 7d314c99bb Always pass "allocate: true" when converting URIs to paths. 
There's no need to special case the handling of "dart:" URIs.
Eventually we will need the "allocate:" behavior for all URIs anyhow,
because we won't have a pre-traversal of the import graph to populate
the FileRepository.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2651193002 .
 2017-01-25 09:21:59 -08:00
Brian Wilkerson ed40bd3eca Add failing test for sort issue 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2655803004 .
 2017-01-25 09:06:49 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests 
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
 2017-01-25 08:50:02 -08:00
Konstantin Shcheglov ebe04d131b Issue 28387. Test for search of classes defined in SDK. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28387

Review-Url: https://codereview.chromium.org/2651103004 .
 2017-01-25 08:39:42 -08:00
Konstantin Shcheglov 9264c1191a Implement LibraryElement.hasExtUri for resynthesized. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657743002 .
 2017-01-25 07:03:59 -08:00
Konstantin Shcheglov b8ab9b7e17 Fix tests to run with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656783002 .
 2017-01-25 06:58:24 -08:00
Konstantin Shcheglov 608cb122e3 Fix for dart:html query() type inference. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656673003 .
 2017-01-25 06:56:28 -08:00
Johnni Winther c885d809b6 Add inference test functionality based on code point id. 
The code point id is meant to be basis for AST/Kernel-IR equivalence and the test framework should thereby be portable to a Kernel based inference.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2656583003 .
 2017-01-25 14:44:28 +01:00
Paul Berry 07f2abb07b Fix summary type inference of async closures. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2655463004 .
 2017-01-25 05:39:49 -08:00
William Hesse d17af0420c Fix type error in analyzer test 
Follow-up to CL https://codereview.chromium.org/2653683004

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2647363005 .
 2017-01-25 12:59:33 +01:00
Johnni Winther e96d37e815 Revert "Optimizations to IC stub for unoptimized code performance on x64." 
This reverts commit f03f62ad09.

Review-Url: https://codereview.chromium.org/2658603002 .
 2017-01-25 12:09:19 +01:00
Johnni Winther fb75d52521 Introduce KernelWorldBuilder 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2651803003 .
 2017-01-25 10:16:32 +01:00
Erik Corry f03f62ad09 Optimizations to IC stub for unoptimized code performance on x64. 
Using two CMOVs for class ID load is not a win relative to a simple branch.
Unroll the loop that checks entries in the IC data to find correct call.
Don't check a counter for overflow on 64 bit, it's not going to happen and
even if it did it makes little difference.
Don't reload receiver and arg0 for every entry in the IC data in the
multidispatch case.
According to my measurements this IC stub is about 10% faster in the
single dispatch case, and about 15% faster in the less important double
dispatch case.  Unoptimzed code spends about 30% of its time in these
two stubs.
R=regis@google.com
BUG=

Review-Url: https://codereview.chromium.org/2647913002 .
 2017-01-25 10:15:01 +01:00
Zachary Anderson 82bddc3614 Fuchsia: Update vm and language status files 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2651803004 .
 2017-01-24 22:03:18 -08:00
Zachary Anderson 672aab3cd3 Fuchsia: Implement memory region protections 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2652873002 .
 2017-01-24 21:44:32 -08:00
Ben Konyi 57ff20f49e Revert "Revert "Revert "Removed usage of std::map and std::vector from kernel code. Issue #28064.""" 
This reverts commit e2bb8409ab.

BUG=

Review-Url: https://codereview.chromium.org/2654983002 .
 2017-01-24 19:29:06 -08:00
Konstantin Shcheglov fcd5f16d10 Stop using SDK summary bundle. Analyze dart:xxx as any other libraries. 
Unfortunately this makes runnings tests about 30% slower :-(

I suspect that's because we have to build unlinked and linked summaries
for SDK libraries again and again for every tiny test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653683004 .
 2017-01-24 18:32:26 -08:00
Stephen Adams 12300fa688 Fix crash when using type parameters on custom elements 
The fix ensures that the custom element '.created' constructor has 'receiver' as the first argument.

This prevents the crash reported in https://github.com/dart-lang/sdk/issues/28457
The type arguments will be seen as 'dynamic' because there is no way to specify them from document.createElement or HTML.

TBR=sigmund@google.com

BUG= https://github.com/dart-lang/sdk/issues/28457

Review-Url: https://codereview.chromium.org/2645283005 .
 2017-01-24 18:25:04 -08:00
Florian Schneider c1e4e8ef72 Fix Windows debug assertion when cancelling pending i/o 
When no pending i/o requests are found, CancelIoEx returns ERROR_NOT_FOUND.

This is ok, since there is nothing else to do before closing the handle.

Related to #22940.

TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2651033004 .
 2017-01-24 17:33:51 -08:00
Ben Konyi f2a097b9c8 Gardening: Updated status file to account for timeout in standalone/io/socket_close_test. Test times out on Linux release IA32. Issue: 28502. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2656703002 .
 2017-01-24 17:21:41 -08:00
Ben Konyi 0f92d38fbf Fix for vm.status file being updated incorrectly. 
BUG=

Committed: 529da7d291
Review-Url: https://codereview.chromium.org/2653103002 .
 2017-01-24 17:17:20 -08:00
Ben Konyi 529da7d291 Fix for vm.status file being updated incorrectly. 
BUG=

Review-Url: https://codereview.chromium.org/2653103002 .
 2017-01-24 17:14:12 -08:00
Brian Wilkerson f711a00e13 Revert "Clean up new errors and warnings" (TBR) 
Review-Url: https://codereview.chromium.org/2650063004 .
 2017-01-24 16:53:24 -08:00
Stephen Adams 7b70c720fb dart2js-kernel: Pass non-type arguments to constructor body 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2651503007 .
 2017-01-24 16:32:35 -08:00
Ben Konyi e2bb8409ab Revert "Revert "Removed usage of std::map and std::vector from kernel code. Issue #28064."" 
This reverts commit ddc24380b1.

BUG=

Review-Url: https://codereview.chromium.org/2648233005 .
 2017-01-24 15:58:59 -08:00
Vijay Menon f2b4114f08 Allow clang travis build to fail 
Probably need to switch this to use GN if we want to keep it.

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2653673008 .
 2017-01-24 15:56:41 -08:00
Ben Konyi ddc24380b1 Revert "Removed usage of std::map and std::vector from kernel code. Issue #28064." 
This reverts commit b9035d949f.

BUG=

Review-Url: https://codereview.chromium.org/2650333002 .
 2017-01-24 15:18:27 -08:00
Regis Crelier 23d57d28df Set correct type for enum values list (fixes #28341). 
Add regression test.
Update status file.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2651813006 .
 2017-01-24 15:07:01 -08:00
Jennifer Messerly 25b6e46154 fix #28141, fix super generic method bounds check 
R=leafp@google.com

Review-Url: https://codereview.chromium.org/2653873002 .
 2017-01-24 14:51:37 -08:00
Florian Schneider 2e1eeaf446 Cancel pending i/o when closing stdin on Windows 
When cancelling a subscription to stdin, there may be pending I/O operation
that need to be explicitly cancelled before closing the stdin handle.

Otherwise the program would sit waiting for input (until CR is pressed).

Fixes dart-lang/pub#1502
Fixes #22940

R=zra@google.com

Review-Url: https://codereview.chromium.org/2650063003 .
 2017-01-24 14:47:39 -08:00
Brian Wilkerson c25bd9403f Move driver creation into ContextBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2647293007 .
 2017-01-24 14:43:39 -08:00
Brian Wilkerson dd3b191add Clean up new errors and warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2653863003 .
 2017-01-24 14:32:32 -08:00