languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 12:58:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
34687 commits 11 branches 6011 tags 1.4 GiB
Commit graph

34687 commits

This branch
This branch
All branches
Author SHA1 Message Date
John McCutchan 33814bd507 Attempt to fix Windows build 
BUG=

Review URL: https://codereview.chromium.org/1419563005 .
 2015-10-27 08:56:02 -07:00
John McCutchan d1c5898ce0 Fix build 
BUG=

Review URL: https://codereview.chromium.org/1426713004 .
 2015-10-27 08:01:56 -07:00
John McCutchan f82058002c Fix dart_bootstrap build 
BUG=

Review URL: https://codereview.chromium.org/1413443007 .
 2015-10-27 07:54:18 -07:00
John McCutchan b9399cd964 Allow for FakeVMRpcExceptions when listening for streams 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/1406343004 .
 2015-10-27 07:44:10 -07:00
John McCutchan 30e77221bc Some cleanups to observatory BUILD.gn 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1416293003 .
 2015-10-27 07:42:27 -07:00
Asger Feldthaus 0c25cd27ac dart2js cps: Remove unneeded bailout on captured loop variables. 
The analysis of try-boxed variables reused some code from the old
dart2dart CPS backend, which had bailouts for code that is handled just
fine in the dart2js CPS backend.

R=karlklose@google.com, kmillikin@google.com

Committed: 695bdf4fa3

Review URL: https://codereview.chromium.org/1410123005 .
 2015-10-27 13:01:10 +01:00
Asger Feldthaus 11c7b77f63 Revert "dart2js cps: Remove unneeded bailout on captured loop variables." 
This reverts commit 695bdf4fa3.

BUG=

Review URL: https://codereview.chromium.org/1417773008 .
 2015-10-27 12:58:48 +01:00
Asger Feldthaus 11826bf9b7 dart2js cps: Do not inline static async methods. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org/1414333008 .
 2015-10-27 12:44:21 +01:00
Asger Feldthaus 695bdf4fa3 dart2js cps: Remove unneeded bailout on captured loop variables. 
The analysis of try-boxed variables reused some code from the old
dart2dart CPS backend, which had bailouts for code that is handled just
fine in the dart2js CPS backend.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1410123005 .
 2015-10-27 11:51:28 +01:00
Asger Feldthaus 3634c3998a dart2js: Bugfix for when 'await' occurs in an initializer list. 
If the JS ast contains an initializer list:

  var x = foo(), y = await x;

It would be retained as a single statement and generate invalid output
that awaits 'x' before it has been defined.

CLOSES=23997

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1427593003 .
 2015-10-27 11:36:57 +01:00
Johnni Winther 529bc75d81 Move codegen registration to transformImpact method. 
This prepares for only registering through WorldImpact.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1421463005.
 2015-10-27 10:10:01 +01:00
pq 808f32d61d Fix to give LineInfo to options error spans. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
 2015-10-26 21:09:48 -07:00
Ryan Macnak cf9c55735d Initialize VirtualMemory::embedder_allocated_. 
Review URL: https://codereview.chromium.org/1406023011 .
 2015-10-26 17:15:24 -07:00
Zachary Anderson 1fb050baa0 Fixes shutdown crashes. 
- Restores fix to debug message queue.
- Fixes for precompilation.

BUG=
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1406013004 .
 2015-10-26 15:43:27 -07:00
Chinmay Garde 52d8128b4e Avoid compilation errors when the dart_target_arch is TARGET_ARCH_ARM 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1424783002 .
 2015-10-26 15:39:14 -07:00
Srdjan Mitrovic cd98aff665 Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. 
BUG=
R=hausner@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1424703004 .
 2015-10-26 15:31:50 -07:00
Srdjan Mitrovic 772ee329c4 Make ICData changes thread safe (first compute array, then set it). Install code in the main thread instead of in the background compilation thread. 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1410363005 .
 2015-10-26 15:12:29 -07:00
John McCutchan 1b9f7bca1c Add Observatory BUILD.gn rules 
BUG=

Review URL: https://codereview.chromium.org/1419943003 .
 2015-10-26 14:18:50 -07:00
Siva Annamalai 82161396ee Fix arm build break. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1419173003 .
 2015-10-26 13:46:28 -07:00
Siva Annamalai 5e4a3d7a65 Add IsMutatorThread to the Thread class and use it instead of MutatorThreadIsCurrentThread 
Review URL: https://codereview.chromium.org/1408923005 .
 2015-10-26 13:12:10 -07:00
Alan Knight 6d47521590 Suppress tests on Dartium that access window.document cross-frame 
BUG=

Review URL: https://codereview.chromium.org/1424693003 .
 2015-10-26 12:40:58 -07:00
pq 52fb3b3bab Introducing a lint server plugin. 
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1410553005 .
 2015-10-26 12:11:38 -07:00
Konstantin Shcheglov cbea0dedf9 Issue 24714. Check other libraries that define unresolved class. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24714

Review URL: https://codereview.chromium.org/1413973007 .
 2015-10-26 11:32:59 -07:00
Alan Knight d85a45a717 Revert "Failure from a few days ago (returning null) on an exception masked error" 
This reverts commit e4a156785b.

BUG=

Review URL: https://codereview.chromium.org/1411303007 .
 2015-10-26 11:17:32 -07:00
Jacob Richman 314785869e DEPS AutoUpdate: webkit to 202690 (2015-10-26 11:05:57 -0700) johnmccutchan@chromium.org 
Fix Dartium to provide Observatory frontend resources on demand
http://src.chromium.org/viewvc/blink?view=rev&revision=202690
 2015-10-26 11:11:46 -07:00
John McCutchan b83e5a718e Fix ThreadIterator_AddFindRemove test 
- A pointer test was unsafe because the allocator could recycle the address for a new thread.

Fixes #24692

R=asiva@google.com

Review URL: https://codereview.chromium.org/1425463004 .
 2015-10-26 11:07:16 -07:00
Ryan Macnak dd7250323d Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). 
Also update descriptions of register availability in instrinsics.

1) Mechanical replacement in *arm.* files except the simulator and constants_arm.h (with sed).

R5 -> R9
R6 -> R8
R8 -> R10
R9 -> R5
R10 -> R6

2) Change register aliases.

CTX = R10 -> CTX = R6
PP = R9 -> PP = R5
ICREG = R5 -> ICREG = R9
CODE_REG = R10 -> CODE_REG = R6
THR = R8 -> THR = R10

3) Fixup users of ldrd/strd to have valid register pairs.

bigint_lsh
bigint_absadd
bigint_abssub
bigint_sqradd
TYPED_ARRAY_ALLOCATION
InlineArrayAllocation
AllocateArrayStub
AllocateContextStub

4) Fix PushList in MegamorphicMissStub to keep runtime call arguments in the right order.

BUG=http://dartbug.com/24683
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1419223003 .
 2015-10-26 11:05:32 -07:00
John McCutchan 533a6ecce7 Add new observatory resources cc file to libvmservice_io rule 
BUG=

Review URL: https://codereview.chromium.org/1427503002 .
 2015-10-26 10:52:43 -07:00
pq b32e2ce0db Analyzer dep bump. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1415693004 .
 2015-10-26 10:02:57 -07:00
pq ffccd9af76 Update options validation extension. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1424723002 .
 2015-10-26 09:54:41 -07:00
pq 15c9636924 Backed out validator registration. 
Net-net: this bakes in an (unsafe in tests) assumption that the options plugin has been contributed and registered.

Backing out pending a revisit.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1411313005 .
 2015-10-26 09:46:09 -07:00
Ryan Macnak 0eaf9c164d Add missing entry points called by the embedding API's implementation. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1421943002 .
 2015-10-26 09:26:50 -07:00
Ryan Macnak c483ba8451 Instrinsics on object pool architectures must preserve CODE_REG. 
This fixes c13b481aeb.

IA32 does not load a constant pool and does not use the CODE_REG to
create the pc marker, so it does not need to preserve CODE_REG in
instrinsics. Blocking another register from graph instrinsics caused some of
them to need to spill, which is asserted to never happen.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1418813005 .
 2015-10-26 09:13:12 -07:00
pq 68dc36a3e7 OptionsValidator plugin extension and linter service. 
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.

You'll notice that the warning code I added is NOT in `errors.dart`.  I did that in anticipation of plugin-specifc warnings living elsewhere.  If that's not the right angle, happy to un-do!

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1418333002 .
 2015-10-26 08:50:55 -07:00
John McCutchan 2844eb86ca Service isolate requests Observatory assets from embedder 
- Provide a new callback to Dart_Initialize that will be called when the service isolate needs the Observatory assets
- Move asset management code out of embedder and into common dart:_vmservice
- Use the tar format as the archive format
- Add build script to generate .cc file containing the archive
- Add a simple tar parser to service isolate

This makes it possible for embedders to not bake Observatory into their executable but instead load it off disk or over the network. The standalone embedder still links Observatory into the executable.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1411853003 .
 2015-10-26 07:21:23 -07:00
Johnni Winther db98c37dac Add CoreClasses 
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1421003004.
 2015-10-26 13:56:07 +01:00
Lasse R.H. Nielsen d9a4022ab9 Add documentation to typed-list .fromList constructors saying that values are truncated. 
Fixes issue #24708.
BUG= http://dartbug.com/24708
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1416243004 .
 2015-10-26 11:22:00 +01:00
Lasse R.H. Nielsen 289a22182e Add support for decoding URL-safe encoded base64. 
Also support "%3D" instead of "=" as padding, but no other percent escapes.

This is only for decoding, encoding is still as strict as possible.

R=nweiz@google.com

Review URL: https://codereview.chromium.org/1419983003 .
 2015-10-26 09:41:30 +01:00
pq 6e7c454037 Task graph re-gen. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1411243009 .
 2015-10-25 21:01:01 -07:00
pq bb431bbec4 Publish optionValidator extentsion API. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1420903003 .
 2015-10-25 20:49:49 -07:00
Konstantin Shcheglov 289bd0a056 [Atom] Issue 424. Fix for 'getNavigation' and index expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Review URL: https://codereview.chromium.org/1402353009 .
 2015-10-25 11:29:54 -07:00
Konstantin Shcheglov 2d8d0e1ed7 Clean up - remove unused inputs and tweak comments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1419363002 .
 2015-10-24 20:18:45 -07:00
John Messerly 396ed51cf0 fixes #24713, remove old generic substitution code in _getTypeOfProperty 
it looks like some old code was hanging around that tried to substitute generic type parameters by name. This is unnecessary because we already have a substituted type at this point, and the type variable we were substituting had no relationship at all with the parameter. After removing the code, all tests seem to be passing.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1409143009 .
 2015-10-24 12:48:53 -07:00
Konstantin Shcheglov c43f292dd9 Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results. 
This improves warm VM analysis time (i.e. 99% of all analyzis that happens in IDEs) from 7200 ms to 6600 ms.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1417143003 .
 2015-10-24 08:35:26 -07:00
Konstantin Shcheglov 4653d9bb76 Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx. 
This helps to improve analysis time from about 39100 to 37000 ms.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1406923006 .
 2015-10-23 14:56:25 -07:00
pq df580cf0ea WorkItem detail diagnostics. 
R=keertip@google.com

Review URL: https://codereview.chromium.org/1418323002 .
 2015-10-23 14:48:24 -07:00
keertip c133bf9467 add work item info to context status page 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1415503006 .
 2015-10-23 13:27:10 -07:00
Konstantin Shcheglov 041e61a0f6 Ensure that RESOLVED_UNITx ready once for every library. 
...instead of ensuring this separately for complete closures of every library.

This improves initial analysis performance from about 44 seconds to 39.
This also makes WorkOrder.moveNext less expensive - to about 5.6% during initial analysis.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1412273004 .
 2015-10-23 13:25:56 -07:00
danrubel 33e6b737e8 enable analysis server cmdline instrumentation log file option 
this change allows instrumentation to be logged to a file that is specified on the command line when analysis server is started for both internal and external builds of the analysis server

R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1413563009 .
 2015-10-23 15:47:09 -04:00
danrubel 5bd191ee12 fix import uri completion exception - fixes #24709 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1418123004 .
 2015-10-23 14:55:20 -04:00