Commit graph

34687 commits

Author SHA1 Message Date
Konstantin Shcheglov 851dc4ea97 Quick Fix for CAN_BE_NULL_AFTER_NULL_AWARE.
Also fix for false positive :-(

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1423993005 .
2015-10-29 13:47:17 -07:00
Srdjan Mitrovic 4efbbe06f4 Fixes bad C++ code generation by XCode 7
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1424733005 .
2015-10-29 13:26:05 -07:00
Paul Berry 06ef697a0b Rework codegen tools to avoid relying on CWD; integrate with task model graph.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1428673004 .
2015-10-29 13:12:44 -07:00
Ryan Macnak 41f3aaed40 Direct OS:Print[Err] to syslog on iOS.
R=chinmaygarde@google.com

Review URL: https://codereview.chromium.org/1415573004 .
2015-10-29 12:30:02 -07:00
Siva Annamalai 4f5a22726b Remove IsolateSpawnState::Cleanup as it is not used anywhere.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1422423002 .
2015-10-29 12:24:56 -07:00
John Messerly 36b471a638 fix type annotation in _lookUpMemberInInterfaces
Review URL: https://codereview.chromium.org/1426083002 .
2015-10-29 12:08:33 -07:00
Jacob Richman 4dcc4a603a DEPS AutoUpdate: webkit to 202692 (2015-10-29 11:31:18 -0700) jacobr@google.com
Fix crash in devtools when the prototype of a polymer element is incorrectly considered a dart:html object instead of a JsObject.
http://src.chromium.org/viewvc/blink?view=rev&revision=202692
2015-10-29 11:36:54 -07:00
Brian Wilkerson 8e80648c56 Compute propagated type for final instance fields (partially addresses issue 23001)
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1410493006 .
2015-10-29 11:36:11 -07:00
John Messerly 2503cb8eeb improve static type analysis for await for
This tries to do a full fix for https://github.com/dart-lang/sdk/issues/24191

The refactoring tries to unify how generic type substitutions are handled, so they always go through the (correct) mechanisms in the Element model.

This additionally should make it easier to add generic method type parameters in a future CL.

R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1405143006 .
2015-10-29 11:17:18 -07:00
Jacob Richman eab2ef5d82 Rev pkg js version
BUG=
R=ochafik@google.com

Review URL: https://codereview.chromium.org/1425823003 .
2015-10-29 10:33:16 -07:00
Siva Annamalai 47da86799d Minimize enter/exit isolate calls during startup and shutdown of service isolate.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1422753005 .
2015-10-29 09:57:27 -07:00
Søren Gjesse d1e01e205a Revert "Web Socket compression - take two"
This reverts commit 59bb84127b.

A number of observatory tests broke.

TBR=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1426043002 .
2015-10-29 14:13:24 +01:00
Asger Feldthaus b123d5393f dart2js: Bugfix in async rewriter preanalysis.
Name and StringConcatenation nodes would be classified as await/yield,
causing their surrounding expressions to be exploded into temporaries.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1418503009 .
2015-10-29 13:43:09 +01:00
Søren Gjesse 59bb84127b Web Socket compression - take two
Resolve issues with typed data tests and compression.
Uses HeaderValues to parse permessage_deflate option.

Includes changes from https://codereview.chromium.org/1208473005/

BUG=https://github.com/dart-lang/sdk/issues/14441
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1390353005 .
2015-10-29 13:36:40 +01:00
Sigurd Meldgaard f10470741a Rename Compiler.runCompiler -> runInternal.
Also renamed MockCompiler.runCompiler to MockCompiler.run

Change all tests to use Compiler.run.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1417323005 .
2015-10-29 13:30:29 +01:00
Sigurd Meldgaard e3b926849f Rename apiimpl.Compiler to CompilerImpl.
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1409803006 .
2015-10-29 13:23:55 +01:00
William Hesse 169b132a63 Add unique serial numbers to sample X509 certificates. Remove the "sendClientCertificate" parameter from SecureSocket.connect.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1420923006 .
2015-10-29 13:17:22 +01:00
Lasse R.H. Nielsen 0172094a50 Document truncating behavior of typed_data lists.
R=floitsch@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1422473003 .
2015-10-29 09:56:04 +01:00
Konstantin Shcheglov 2529e684f0 Report hint when target of an invocation uses '?.', so can be null.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1423623005 .
2015-10-28 16:45:19 -07:00
Konstantin Shcheglov 7b75a53fef Fix for regions reported with multiple targets.
We should merge them into single NavigationRegion(s) with multiple targets.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403373018 .
2015-10-28 16:38:12 -07:00
pq 5accd7a72e Error code validation for error filters.
Screenshots and background can be found on the tracking bug: https://github.com/dart-lang/sdk/issues/24618

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411053003 .
2015-10-28 16:37:34 -07:00
Matthias Hausner 59dce43dfe Shared token objects
Instead of one array for literal and identifier tokens for each TokenStream, share one array among all TokenStreams in an isolate.

The shared array and the token-to-index map is stored in the object store until the embedder is done loading. Then the map is thrown away (and the array remains shared, referred to by the TokenStreams).

When new files get loaded, a new shared array is created. For temporary scripts, e.g. when evaluating one-shot functions, the token arrays are not shared.

This eliminates many duplicate LiteralToken and identifier tokens. Looking at the core libraries:

Before: 30877 identifiers and 9618 literal tokens
After: 12899 identifiers and 6371 literal tokens

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1420103006 .
2015-10-28 16:02:58 -07:00
Jacob Richman 9075efbb43 Fix broken console evaluation in devtools when stopped at an async frame.
It appears that the Dart VM is now adding a local with invalid dart name :async_op
in some cases when the call stack is async.
This change filters out those variables from the list of locals.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1424133002 .
2015-10-28 15:00:34 -07:00
Harry Terkelsen 2c9af2a562 roll dart2js_info
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1415413011 .
2015-10-28 14:20:39 -07:00
John McCutchan 60f911944b Update create_archve.py to output a uint8_t array
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1419263004 .
2015-10-28 13:58:32 -07:00
Konstantin Shcheglov 8f94e36a74 Check for potential null operand in Not expressions.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1427783003 .
2015-10-28 13:09:30 -07:00
pq ff08fe58b6 Stop unwanted sharing between filter closures.
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1414863004 .
2015-10-28 13:02:28 -07:00
pq ffeacec73d Improved YAML doc exception handling.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1415153004 .
2015-10-28 11:24:42 -07:00
Srdjan Mitrovic 44ccbb5e29 Copy ICData descriptors when starting background compilation, so that they do not change while compiling
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1414933006 .
2015-10-28 10:19:35 -07:00
pq 2f9c4af993 Error Suppression FTW.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1420363005 .
2015-10-28 09:59:05 -07:00
Brian Wilkerson c687f29555 Add hint for use of ?. in conditions (issue 24649)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1422813003 .
2015-10-28 08:28:42 -07:00
Johnni Winther 8688d297c5 Move most codegen registrations into WorldImpact.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1410313005.
2015-10-28 13:54:28 +01:00
Johnni Winther 9628541c10 Move remaining helpers to BackendHelpers
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1413213004.
2015-10-28 13:23:57 +01:00
Asger Feldthaus f712e08e94 dart2js cps: More interceptor optimizations and fixes.
When the result of getInterceptor is either null or a known constant,
it is compiled to `x && const` or `x == null ? x : const` depending
on whether there are any other falsy values for that type.

This required some changes to share_interceptors so it can share/hoist
the constant subexpression separately from the whole expression.

The Interceptor root class is removed from the intercepted classes of
getInterceptor when it is "shadowed" by all the other intercepted classes.
E.g. if the input is a number or a string, there is no need
to intercept for {JSNumber, JSString, Interceptor}, because JSNumber
and JSString collectively shadow Interceptor.

R=sra@google.com

Review URL: https://codereview.chromium.org/1409803003 .
2015-10-28 12:56:21 +01:00
Sigurd Meldgaard b0a764c074 Make the computation of import chain to disallowed library use correct uri.
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1430603002 .
2015-10-28 10:19:12 +01:00
Jacob Richman 0a341e9790 DEPS AutoUpdate: webkit to 202691 (2015-10-27 08:11:15 -0700) johnmccutchan@chromium.org
Fix Dartium build
http://src.chromium.org/viewvc/blink?view=rev&revision=202691
2015-10-27 15:27:04 -07:00
Srdjan Mitrovic 975d8e863e Fix build: Too many friends
BUG=

Review URL: https://codereview.chromium.org/1426713005 .
2015-10-27 15:24:36 -07:00
Srdjan Mitrovic cea892f234 Cache initial (empty) ic_data arrays so that they are not repeatedly allocated. Factor out descriptor and data array allocation. Will be used later when we copy the descriptor for background compilation.
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1410573006 .
2015-10-27 15:05:14 -07:00
Chinmay Garde 2bf488f9e7 Disable integer division when generating precompiled snapshots for older ARMv7 devices
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1410683009 .
2015-10-27 14:38:35 -07:00
Ryan Macnak d422888b46 Use the iOS ABI when running SIMARM on Mac or targeting iOS.
Linux / iOS
R7   preserved / FP
R9   preserved / volatile
R11  FP / preserved

BUG=http://dartbug.com/24683
R=zra@google.com

Review URL: https://codereview.chromium.org/1421253004 .
2015-10-27 14:36:38 -07:00
Chinmay Garde dfd7c0b221 Fix CPU features detection and stack alignment assert on iOS
R=zra@google.com

Review URL: https://codereview.chromium.org/1413643004 .
2015-10-27 14:23:36 -07:00
Konstantin Shcheglov c095ba1f91 Extract 'computeLineStarts' utility.
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1411253007 .
2015-10-27 14:03:44 -07:00
keertip 395f255023 upgrade dartdoc to 0.7.4 in DEPS
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1411223004 .
2015-10-27 14:03:05 -07:00
Siva Annamalai 1a038d5030 Add lock owner information for class Monitor and add assertions for wait/notify/notifyall.
R=johnmccutchan@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1426743002 .
2015-10-27 13:47:10 -07:00
John McCutchan 25906f2144 Tweak create_archive.py to output the data as const char instead of const uint8_t
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1411543006 .
2015-10-27 13:22:50 -07:00
Jacob Richman 1ea666f401 Add documentation for allowInterop and allowInteropCaptureThis
BUG=
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1411173005 .
2015-10-27 13:05:38 -07:00
Konstantin Shcheglov cee3f13ae0 Fix for leaking AnalysisCache and AnalysisContext instances.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1426843002 .
2015-10-27 11:43:05 -07:00
Konstantin Shcheglov e2f905e11d Memory leak fix. Use correct analysis context for annotation constants.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410573005 .
2015-10-27 11:04:27 -07:00
Alan Knight 8831fb876e Deprecate new internal Dartium/JsInterop APIs that are public
BUG=

Review URL: https://codereview.chromium.org/1428593002 .
2015-10-27 10:55:12 -07:00
pq c4ccdb462a LineInfo line-end detection fixes.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
2015-10-27 09:39:30 -07:00