Brian Wilkerson
2ee2fe9b5c
[Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean
...
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2679553003 .
2017-02-06 13:26:39 -08:00
William Hesse
7a718e62c6
Suppress analyze_library tests on the new analyzer bots
...
BUG=https://github.com/dart-lang/sdk/issues/28620
Review-Url: https://codereview.chromium.org/2674793004 .
2017-02-03 08:24:21 +01:00
William Hesse
33e89e66be
Update status for analyze_libraries suite, and make it work with --use-sdk
...
BUG=https://github.com/dart-lang/sdk/issues/28620
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2671913002 .
2017-02-03 03:20:57 +01:00
Jacob Richman
410cde6023
Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status
...
Update pkg/js CHANGELOG.md to address comment from previous CL.
BUG=
Review URL: https://codereview.chromium.org/2179153002 .
2016-07-25 13:20:25 -07:00
Alan Knight
adf856186f
Change Dartium expectations from CompileTimeError to StaticWarning
...
BUG=
Review URL: https://codereview.chromium.org/1919733003 .
2016-04-25 13:11:39 -07:00
Jacob Richman
c1d669131b
TBR. Turns out these tests still fail just for a different reason.
...
BUG=
Review URL: https://codereview.chromium.org/1586133006 .
2016-01-15 14:05:29 -08:00
Jacob Richman
cf7ae2e0cb
Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html.
...
Support typed JS interop classes that extend the behavior of dart:html types in Dartium.
This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.
Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1583773003 .
2016-01-15 10:40:32 -08:00
Terry L. Lucas
7b322c246c
Dartium JS Enabled take 2
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas
09c804aa78
Revert "Dartium JS Interop enabled."
...
This reverts commit 403bd1698d
.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas
403bd1698d
Dartium JS Interop enabled.
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
terry@google.com
ec66fa460b
Updated to match 39 roll
...
Reviewers=paulberry@google.com ,asiva@google.com
BUG=22623
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44139 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 19:00:24 +00:00
paulberry@google.com
7398f49c3c
Update status file for bug 22623
...
TBR=terry@google.com
Review URL: https://codereview.chromium.org//972693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44129 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 14:54:47 +00:00
nweiz@google.com
c8de060c54
Revert "Revert "Use native async/await support in pub.""
...
The VM now fully supports all the weird async stuff pub is doing, and all the
tests pass with native async/await!
Previous CLs were r43484 and r43483.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//937243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43897 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:28:54 +00:00
paulberry@google.com
4a5680aec8
Visit async and core library dependencies when computing library cycles.
...
Previously, we would create the Library objects for the core and async
libraries before calling _computeLibraryDependencies(). As a result,
_computeLibraryDependencies() would skip those libraries when
computing dependencies. Normally this was not a problem, because the
dependencies surrounding the core and async libraries are so richly
intertwined that all of the necessary files got included in the cycle
anyhow. However if the starting point of analysis was the
"dart:async" library, some files would be missed entirely, leading to
bogus warnings.
The solution is to let _computeLibraryDependencies() create all the
Library objects, even for the core and async libraries; this way it
won't skip any dependencies.
BUG=dartbug.com/22415
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//921213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43772 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 18:52:39 +00:00
karlklose@google.com
308b2c4a68
Mark test as failing.
...
R=sigurdm@google.com
BUG= http://dartbug.com/22415
Review URL: https://codereview.chromium.org//924783004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43761 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 14:58:09 +00:00
nweiz@google.com
bbe0d9325c
Revert "Use native async/await support in pub."
...
This caused SDK compilation issues that may have obscured pub test failures as
well.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//887223007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43484 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:15:44 +00:00
nweiz@google.com
1835c63d0a
Use native async/await support in pub.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//896623005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43483 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 20:45:49 +00:00
nweiz@google.com
b8d1c3a8b7
Regenerate pub's sources and remove workarounds for fixed issues.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//868463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43057 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 01:07:38 +00:00
nweiz@google.com
c951660859
Don't analyze pub's command_runner library.
...
This works around https://github.com/dart-lang/async_await/issues/77 .
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//849053008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42893 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 01:28:02 +00:00
whesse@google.com
c61eb1fdb9
Update test status for analyzer error in DOM bindings code.
...
BUG=dartbug.com/21647
R=ricow@google.com
Review URL: https://codereview.chromium.org//733373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41799 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 12:52:30 +00:00
johnniwinther@google.com
09fbe78e71
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//694353007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:51:01 +00:00
johnniwinther@google.com
8637cfd322
Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
...
This reverts commit r41512.
BUG=
Review URL: https://codereview.chromium.org//693183006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
johnniwinther@google.com
2b336e17f0
Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
...
BUG=
Review URL: https://codereview.chromium.org//690103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00
nweiz@google.com
cb75ee00bc
Don't analyze async_await in the repo bots.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//687953004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41411 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 00:55:17 +00:00
nweiz@google.com
1db48a68c7
Mark all pub files as potentially failing in the analyzer.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//566983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40407 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 22:14:02 +00:00
scheglov@google.com
8b5ea1f3a1
Restore analyzing lib/_internal with Dart-based analyzer.
...
It adds 8+ minutes (to the current 4) to the analysis time, but does not timeout anymore.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//575573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40280 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 21:45:17 +00:00
ricow@google.com
33dbdeea9c
Remove analyzer suppression of analyze_library/lib/_internal/pub/lib/src/executable
...
This started passing after:
https://code.google.com/p/dart/source/detail?r=39787
Review URL: https://codereview.chromium.org//537493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39791 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 06:01:50 +00:00
rnystrom@google.com
f485ccfd7d
Make analyzer bot happy again.
...
Review URL: https://codereview.chromium.org//515373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39675 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 20:27:56 +00:00
rnystrom@google.com
9f052a7ef8
Fix two more analyzer bot failures.
...
Review URL: https://codereview.chromium.org//508323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39629 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 00:30:49 +00:00
rnystrom@google.com
46a888019d
Fix the analyzer bots.
...
Review URL: https://codereview.chromium.org//515783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39627 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 00:12:01 +00:00
floitsch@google.com
9cf4d2df03
Work around warning in darttags.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//284203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36225 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 15:46:04 +00:00
efortuna@google.com
2a9588d03d
Reapply "Fix analyzer errors in html Dartium."
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//281383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36195 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 23:09:04 +00:00
efortuna@google.com
462ca6ea1e
"Reverting 36191"
...
BUG=
Review URL: https://codereview.chromium.org//288873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36193 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 22:23:07 +00:00
efortuna@google.com
78a040990d
Fix analyzer errors in html Dartium.
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//285123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36191 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 21:54:38 +00:00
paulberry@google.com
252f56f9ca
Don't generate errors when failing to follow const constructor redirections.
...
In two cases (circular redirections and redirecting to a non-const
constructor), the error has already been reported. The third case
(external factory constructor) is not an error condition.
Fixes test lib/_internal/compiler/samples/jsonify/jsonify.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//273703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35877 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 00:24:30 +00:00
paulberry@google.com
099f24cf0e
In constant evaluation, properly handle redirecting factory constructors.
...
In order to unit test that this change doesn't regress the handling of
"const Symbol(...)", it was necessary to expand TestTypeProvider's
Symbol class to include the Symbol constructor.
Note: with this fix, analyzer detected a previously unknown flaw in
tests/language/switch_case_test.dart: class D didn't implement a
getter for x. Test updated accordingly.
This change breaks test lib/_internal/compiler/samples/jsonify/jsonify
by changing analyzer's handling of bool.fromEnvironment(). I plan to
address this in a future changelist.
BUG=dartbug.com/17209
R=brianwilkerson@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//261403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35853 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 16:27:03 +00:00
asiva@google.com
aff765fc98
Update status file to account for Issue 16564 being fixed.
...
R=keertip@google.com
Review URL: https://codereview.chromium.org//264923013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35821 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 19:28:50 +00:00
leafp@google.com
d1f0594840
Initial overloading implementation in _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//260893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
nweiz@google.com
623d3137a3
Use real "package:" imports in pub's plugin-loading code.
...
This works by providing the plugin-loading code to pub's barback instance as
assets for a pseudo-package named "$pub".
BUG=17506
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//198053009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34056 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 19:55:32 +00:00
nweiz@google.com
1cfd291f65
Load the transformer isolate code from pub's asset directory.
...
This renames "resources" to "asset" in the SDK, to better match the suggested
package layout guidelines.
BUG=17506
R=dgrove@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//200323008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33786 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 23:20:16 +00:00
karlklose@google.com
34faaf0161
Change expectations for passing tests.
...
R=johnniwhinter@google.com
BUG= http://dartbug.com/17264
Review URL: https://codereview.chromium.org//201713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33746 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:58:27 +00:00
jwren@google.com
567f754dce
Fix for 15001.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//179783007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33293 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 19:48:52 +00:00
karlklose@google.com
61ee600f61
Fix more analyzer test expectations.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//184613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33159 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 14:20:29 +00:00
karlklose@google.com
3110b630eb
Update analyzer test expectations.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//178193011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33158 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 13:16:28 +00:00
kustermann@google.com
1626736d2c
Remove flaky markers from status file for tests that are not flaky.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//135243005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32553 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 11:55:55 +00:00
dgrove@google.com
7bed1bc4e9
Remove dartdoc.
...
R=alanknight@google.com , efortuna@google.com
Review URL: https://codereview.chromium.org//140303009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32388 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 22:47:26 +00:00
ricow@google.com
18c7d04d90
Remove non existent paths from the analyze_library suite and add bugs for all other entries
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//138303005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32273 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 09:00:44 +00:00
floitsch@google.com
f54884a848
Update status file for analyzer.
...
Review URL: https://codereview.chromium.org//140033006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32224 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 23:30:10 +00:00
sra@google.com
9f09fcbaac
Redo "Make dart2js typed_data implementation classes private"
...
This time with analyzer suppression for new library/
BUG=
Review URL: https://codereview.chromium.org//141653003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31935 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 23:01:26 +00:00
nweiz@google.com
60660a5dff
Un-mark some pub tests as failing on the analyzer.
...
Removing SafeHttpServer caused these to start passing.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//137293004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31768 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 00:05:45 +00:00