Commit graph

7135 commits

Author SHA1 Message Date
Anis Alibegić 40e18905f2 Fixed various typos in a lot of files
Closes https://github.com/dart-lang/sdk/pull/49478

TEST=Manual

GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2022-07-25 12:21:59 +00:00
Brian Wilkerson 56dc3e360a Fix the convert_to_contains fix to remove the second argument
Change-Id: I2da6b71909dd5ecf725714fb51cd075498712c1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252522
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-23 14:58:07 +00:00
Ahmed Ashour eefbe1fd14 [analysis_server] add fix for ASSERT_IN_REDIRECTING_CONSTRUCTOR
Fixes #49486

Change-Id: Ic96d2b347578f574eb67b12ef3dbbddcd9c04d2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-21 22:16:06 +00:00
Ahmed Ashour a9ba31a5b2 [analysis_server] add fixes for ABSTRACT_FIELD_INITIALIZER
Fixes #49488

Change-Id: I48caabef2c038b95ef88cad903fdead47b91c615
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252081
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-21 21:30:26 +00:00
Danny Tuppeny 055774958d [anaysis_server] Cancel in-progress LSP completion requests if another arrives
Change-Id: Idf49b70750a3427529f71e952aa036fae4c7c6cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252422
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-21 17:40:06 +00:00
Danny Tuppeny 5741f11f7b [analysis_server] Remove unnecessary imports when organizing imports
Change-Id: I7a39a9b07adbacc7d3fd5abb3b165b47668e7938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-21 15:10:55 +00:00
Danny Tuppeny 71e2aee8a5 [analysis_server] Disallow extract method on all prefixes
Change-Id: I63ecfab4fad63797358dc2cfb7d5cf79ca444dc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-21 14:57:26 +00:00
Danny Tuppeny 0add39a68e [analysis_server] Skip analysis work when overlays are created if content matches previous content-
May prevent https://github.com/dart-lang/sdk/issues/48051 from occurring since we will no longer call driver.changeFile() for SDK libraries being opened, although it does not resolve the underlying issue.

Change-Id: I5ca53a04842348a584ccc824aaf90ba7f230c002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251980
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2022-07-20 22:45:15 +00:00
Danny Tuppeny 210af2940f [analysis_server] Fix loss of comments containing newlines when sorting imports
Change-Id: Ie264c16d4ec8254ba0394691625a161598e73f5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252180
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-20 21:23:55 +00:00
Danny Tuppeny 1d49366927 [analysis_server] Simplify ImportOrganizer to use a single range for each directive
This should be a no-op and existing tests pass. This is a step towards extracting code that computes a range for removing/sorting directives that could be used elsewhere such as the RemoveUnusedImport() fix.

Change-Id: Ib43b57bb1e34b817cb3771b60c65ad9ba2fe2919
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-20 19:44:35 +00:00
Danny Tuppeny 720f7bea37 [analysis_server] Fix assist test on Windows
Change-Id: I2a85c699140c2fd31ee03524fd2ecac6a0482540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-20 18:48:45 +00:00
Konstantin Shcheglov 21d0028643 Resolve augmentation import directives in libraries.
Change-Id: I900d262df4b32698e20907a3bb99e88fbee38d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2022-07-20 17:08:58 +00:00
Ahmed Ashour 157e407450 [analysis_server] don't offer fix when the error in "cannot-ignore"
Fixes #49464

Change-Id: I9f9f40e5a47604fa422a223f5c54fef3d045a074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-20 17:02:25 +00:00
Danny Tuppeny 019cfb998d [analysis_server] Handle errors from temporary watchers during rebuilds and restart rebuild
Fixes https://github.com/dart-lang/sdk/issues/49286.

Change-Id: Id60111e381f75aaf488dc4b80412242e113f3b59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-20 16:35:34 +00:00
Danny Tuppeny 2c6876aa47 [analysis_server] Fix CompletionBudget to start with the completion request
Change-Id: Iaa9f84394dce36b65a3f5e25dbb381449deb7ea5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-19 18:19:04 +00:00
Ahmed Ashour 5459fc133f [analysis_server] associate DEFAULT_VALUE_ON_REQUIRED_PARAMETER with RemoveDefaultValue
Fixes #47540

Change-Id: I8fa50933f2a7fadf6b11df2b6c385a759f36a8c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-19 17:58:22 +00:00
Konstantin Shcheglov 2f3269faa1 Deprecate 'Element.enclosingElement', switch to enclosingElement2.
We need this for:
1. CompilationUnitElement changes its enclosing element from LibraryElement to LibraryOrAugmentationElement
2. Similarly PrefixElement.

Change-Id: I5e3719b4ef59d03caab1b20c9172a8c0fd786bdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-19 15:44:14 +00:00
Ahmed Ashour 09680ec704 [analysis_server] associate INITIALIZING_FORMAL_FOR_NON_EXISTENT_FIELD with ChangeTo
Fixes #49058

Change-Id: Ie064f0155269282b6c8fa4208f9881ed307c0421
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251762
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-19 04:57:35 +00:00
Danny Tuppeny 89e9801103 [analysis_server] Fix isIncomplete flag for LSP completion when budget is exhausted
Change-Id: I1cc2ec9e3688383008d0eefc44ec7b94f858c5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251768
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-18 21:22:05 +00:00
Konstantin Shcheglov e23101a16f Rename to LibraryImportElement, LibraryExportElement.
Change-Id: I0928ca5522d9c67142111a8f3a7eb4d84f114f56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2022-07-18 20:01:18 +00:00
Konstantin Shcheglov eddd4f4427 Renames for FileState kinds / directives.
Change-Id: Ia024eb8922b06a0bdb37321f76a7527dc7e3c117
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251740
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-18 17:20:33 +00:00
Danny Tuppeny 6bbe04d40f [analysis_server] Set selection/selectionLength for Flutter "Wrap with X" widgets
Fixes https://github.com/Dart-Code/Dart-Code/issues/4061.

Change-Id: I41b54c2641a0eed29e500e1bcc90f9e3945f4f7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251766
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-18 16:28:27 +00:00
Ahmed Ashour e34c84a4fc [analysis_server] associate DEFAULT_VALUE_ON_REQUIRED_PARAMETER with RemoveRequired
Part of #47540

Change-Id: Iff1e81a2809ce045dc6dfb9b9567ad934400308e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251761
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-18 16:05:23 +00:00
Konstantin Shcheglov 2e86c1f018 Deprecate AnalysisDriver.dispose(), use dispose2() instead.
Change-Id: Icfb46bf83f3a1f5828efd76eab1014c4dee0e088
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-15 17:15:40 +00:00
Danny Tuppeny 0482fa6fb3 [analysis_server] Don't 'await' between calling function and using expect(throwsA)
This introduces a race where if the function throws before `expect(throwsA)` adds a handler, it becomes an unhandled exception.

Fixes https://github.com/dart-lang/sdk/issues/49455.

Change-Id: I81205f272c9ec211b99bf73af64dab8e4d774e84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251550
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-15 15:40:40 +00:00
Jaime Wren d61562d765 Extend the LSP Analysis Server support to include the DetachableFileSystemManager support
The DetachableFileSystemManager API also changes slightly with this change resolving a TODO.

Change-Id: I388b352c987e6c96f95fcabd9a532cbfcfa39e4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2022-07-14 21:10:39 +00:00
Danny Tuppeny 0213854523 [analysis_server] Don't provide commit characters on every completion item when enabled
Setting commit characters on the registration is now enough to apply to all items (see https://github.com/microsoft/vscode-languageserver-node/issues/673).

Change-Id: I1133005773e63f563d4e303af60f6c5bb56ec826
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251546
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-14 20:11:59 +00:00
Danny Tuppeny 57a3598b2b [analysis_server] Check Call Hierarchy target is still valid before returning calls
Change-Id: I7d915700dd323381adab4d3bd22d5fb384c6de00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251540
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-14 14:29:54 +00:00
Danny Tuppeny f34d4d5f93 [analysis_server] Add support for LSP Call Hierarchy
Fixes https://github.com/Dart-Code/Dart-Code/issues/612.

Change-Id: Ic51d4be2340317443b5a1cdae83e6eeaac4fa06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 18:45:03 +00:00
Danny Tuppeny f0d3e1dd90 [analysis_server] Enable unawaited_futures lint and fix remaining violations
Change-Id: I44b56ba8e1bd9ed5ba3d85006eb5d615e5a2c9d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 18:40:53 +00:00
Ahmed Ashour b3df7ce795 [analyzer] remove BulkFixProcessor.fixOfTypeInUnit
Fixes #49406

Change-Id: Ib755f918f91ceca1ac4c282e18a9eab9224882e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 16:05:13 +00:00
Danny Tuppeny 4bafe2233c [analysis_server] Has containerName to Call Hierarchy items
Change-Id: Ic39900ef0ef80b721eae645d1e7e1aa7b5b03661
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251266
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 14:22:53 +00:00
Ahmed Ashour 0813000fe4 [analysis_server] associate RemoveAbstract with ABSTRACT_FIELD_CONSTRUCTOR_INITIALIZER
Fixes #49365

Change-Id: Ibb0b2b3a0431e6c2770a214045fd94788c85f62b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 14:20:33 +00:00
Ahmed Ashour 565a52571d [analysis_server] associate RemoveInitializer with ABSTRACT_FIELD_CONSTRUCTOR_INITIALIZER
Part of #49365

Change-Id: Icf4ef0fb89cbc514587b39bbe10a4d394290499a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-13 04:50:42 +00:00
Konstantin Shcheglov 210536e46f Use ExportDirectiveState to build LibraryElement.exports2, add ExportElement2.
Change-Id: I29242bb6f9514eccc93b1bef207ecd5b1e558571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-13 01:48:34 +00:00
Konstantin Shcheglov e47a2f7705 Fix more unawaited_futures in DAS.
Change-Id: Icb1810a775282ad9c0095ddb35edff3fbcdd160c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251150
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-12 16:34:12 +00:00
Danny Tuppeny b331747f22 [analysis_server] Add codeRange to Call Hierarchy items
Change-Id: If78df6e9eadb3a22cb0334aab37fa53e50b70681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-12 14:54:44 +00:00
Konstantin Shcheglov 33295f8247 Add more await or unawaited() to DAS.
Change-Id: I45b2b988141c235b6fbe50e69fa018627e20e004
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251146
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-12 00:59:01 +00:00
Konstantin Shcheglov 4640782906 Fix UpdateContentTest integration test.
Change-Id: I82a1989df9f3cb1e551eb403c2099caff087ab01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251148
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-11 23:37:02 +00:00
Danny Tuppeny 2dd3080b37 [analysis_server] Add basic computer for Call Hierarchy
Change-Id: I2f6252596bcfe81fed619999986138cf59fb9f38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-11 22:50:31 +00:00
Danny Tuppeny d887dc8f2e [analysis_server] [lsp] Fix navigation for field/super formal params
Fixes https://github.com/Dart-Code/Dart-Code/issues/4031.

Change-Id: Ic1a6ec5407cf3599bb4b88d5be1ff8c3efe50066
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251108
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-11 21:27:31 +00:00
pq 3efd79b4b5 linter 1.26.0
Change-Id: I0a20fd9f26933908f6c40cb1019fca45b9a88299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-07-11 20:00:21 +00:00
Brian Wilkerson 94e3ddab39 Add documentation about creating an assist
This was copied from quick fixes and then modified, so please also look
for places that I missed updating the text.

Change-Id: Ib67865232e9af2194999553a8007911f1e691fae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251140
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2022-07-11 18:43:51 +00:00
Konstantin Shcheglov a943d2707b Use ImportDirectiveState to build LibraryElement.imports2, add ImportElement2.
Change-Id: I27a0e87a812eb3733ccfc7b98841c4169dc0a070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2022-07-11 16:54:32 +00:00
Danny Tuppeny e26de63f92 [analysis_server] Improve name of completion budget option
Change-Id: I866bbfa624eb63d5e9ecfaa3fe8e1d74e397bab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-11 14:43:31 +00:00
Danny Tuppeny 97fa3ca9fc [analysis_server] Don't extract methods as async if only a nested function expression is async
Fixes https://github.com/Dart-Code/Dart-Code/issues/4053.

Change-Id: I13a76fab9a2e6f9e08bbd736f997b37bf07ae78d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-07-11 14:42:22 +00:00
Lasse R.H. Nielsen 3fc0bf7e59 Retire the 2.17 language feature experiment flags.
Remove them from tests.
(They should have been removed from tests before launcing 2.17.)

Change-Id: I546f6cb90fdf9e6ed1bb560f3715f9db163b7c68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250384
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-07-11 13:02:22 +00:00
Konstantin Shcheglov c481790c50 Add a few await(s) in DAS integration tests.
Change-Id: Iee36f383a3b5b21eab1b6bbd9c59115a4e585567
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-07-09 14:39:09 +00:00
Brian Wilkerson 60a83b80d8 Update the documentation about creating fixes
Change-Id: Ia9f7d4f2b7008ee2684a0eee201c24ef28438857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250941
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2022-07-08 18:11:29 +00:00
Brian Wilkerson 0634e1fc47 Add priority constants for assists similar to those used for fixes
Change-Id: Id1b4b05b49e90db2fc1ffb6ea32229379152eda1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2022-07-08 18:11:13 +00:00