languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:19:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[analysis_server] Fix CompletionBudget to start with the completion request

Browse source 
Change-Id: Iaa9f84394dce36b65a3f5e25dbb381449deb7ea5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Danny Tuppeny 2022-07-19 18:19:04 +00:00 committed by Commit Bot
parent f7afab742a
commit 2c6876aa47
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/analysis_server/lib/src/lsp/handlers/handler_completion.dart
View file

@ -46,15 +46,15 @@ class CompletionHandler extends MessageHandler<CompletionParams, CompletionList>
/// This is usually the default value, but can be overridden via
/// initializationOptions (used for tests, but may also be useful for
/// debugging).
late final CompletionBudget completionBudget;
late final Duration completionBudgetDuration;
CompletionHandler(super.server, LspInitializationOptions options)
: suggestFromUnimportedLibraries = options.suggestFromUnimportedLibraries,
previewNotImportedCompletions = options.previewNotImportedCompletions {
final budgetMs = options.completionBudgetMilliseconds;
completionBudget = CompletionBudget(budgetMs != null
completionBudgetDuration = budgetMs != null
? Duration(milliseconds: budgetMs)
: CompletionBudget.defaultDuration);
: CompletionBudget.defaultDuration;
}
@override
@ -356,7 +356,7 @@ class CompletionHandler extends MessageHandler<CompletionParams, CompletionList>
final serverSuggestions2 =
await performance.runAsync('computeSuggestions', (performance) async {
var contributor = DartCompletionManager(
budget: completionBudget,
budget: CompletionBudget(completionBudgetDuration),
includedElementKinds: includedElementKinds,
includedElementNames: includedElementNames,
includedSuggestionRelevanceTags: includedSuggestionRelevanceTags,