Commit graph

3 commits

Author SHA1 Message Date
Ryan Macnak b9dc72f367 [infra] Give VM engineers OWNERS over double-conversion and binary_size.
Ownership used to be inherited from //runtime until 4d308f3911.

Change-Id: I252d7c3bfea20a5763ea432eedaf5a79d74c956b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337604
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-11-22 08:38:49 +00:00
Zach Anderson 8724025782 Adds a flag to run_binary_size_analysis.py to disable format checks
This change is needed for compatibility with the Flutter Engine's
use of a new Android NDK. The new Android NDK includes a new clang
toolchain which does a better job of classifying various
contributors to a binary's size, but which fails the compatibility
checks in the script. The intention of the compatibility checks is
to exclude versions of tooling that are too old not versions that
are too new. The compatibility check is also redundant with
failure modes later in the script. To avoid breaking any usage
of this script in the Dart tree, however, the check is retained
by this change, and instead a flag is added that skips it. This
is preferable to expanding on the questionable use of regular
expressions that implement the check to capture the strings
emitted by a continually updating toolchain.

Change-Id: If379e4aa86339a31eada0b6ce3fa90ddc9351804
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337602
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-11-21 18:46:57 +00:00
Alexander Thomas 4d308f3911 [build] Move runtime/third_party into third_party proper
* Add a chromium LICENSE file for binary_size.
* Update BUILD.gn files to still work.

Tested: CQ+flutter-linux-try
Cq-Include-Trybots: luci.dart.try:flutter-linux-try
Bug: b/286184681
Change-Id: Ia52839bc3edd9e42c2df27d0cb7d290851712249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332963
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2023-11-07 16:13:11 +00:00