Commit graph

35387 commits

Author SHA1 Message Date
William Hesse 3afd7025d6 Remove outdated support for chrome-only apis
These scripts, which are no longer used, generated support for Chrome
web app apis.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1526973002 .
2015-12-17 14:50:19 +01:00
William Hesse 73dfc7afe0 Change to X64 default build in tool scripts in sdk/bin
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1535553003 .
2015-12-17 14:49:19 +01:00
William Hesse 6485590527 Remove old java-based analyzer from test scripts and status files
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1537653002 .
2015-12-17 14:44:57 +01:00
William Hesse 07a5d7d814 Remove old versions of barback from checkout
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org/1533683003 .
2015-12-17 14:43:05 +01:00
William Hesse db90a9ff35 Revert "Remove third_party/pkg/petitparser and third_party/pkg/intl"
This reverts commit 58ea2fbce6.
See comments at https://codereview.chromium.org//1332963002

BUG=

Review URL: https://codereview.chromium.org/1523343007 .
2015-12-17 11:22:35 +01:00
Sigmund Cherem 2e90021cfb fix redness: it fails on some configurations and not others, still need to
investigate. For now marking as pass/fail.

BUG=

Review URL: https://codereview.chromium.org/1531203002 .
2015-12-16 21:10:37 -08:00
Sigmund Cherem 25e33b4a21 Suppress test that yields a stack overflow in the compiler
TBR=sra@google.com

Review URL: https://codereview.chromium.org/1537473004 .
2015-12-16 18:37:03 -08:00
Dan Rubel 0de484bb8b convert ImportedReferenceContributor to new API
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1526303003 .
2015-12-16 21:17:27 -05:00
Sigmund Cherem 913ca66834 Tweaks to improve performance of type-inference.
- short-circuit cases where join yields dynamic
- improve performance of some queries like `hasOnlySubclasses` and how `contains` is implemented in `flatten`. We could also add caching for `length`, but not sure if we want to just have a static map or precompute the data in the class-hierarchy nodes.

On my experiments this reduces inference times more than 50% on a large customer app, while small apps have almost no change.

R=johnniwinther@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1528953002 .
2015-12-16 17:03:46 -08:00
Ryan Macnak d71b98cfe7 Further triage --noopt failures.
- Explain slow bigint tests.
 - Note that deferred loading tests are failing for a valid reason.

BUG=http://dartbug.com/24676
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1531903002 .
2015-12-16 16:24:36 -08:00
Stephen Adams 444499020b More pkg.status tests from analyzer that are slow
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/1531973002 .
2015-12-16 16:15:47 -08:00
pq 0a32c6b290 Status page diagnostics for elements and docs.
Related to profiling the cost of storing element docs but the element counts themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1537503002 .
2015-12-16 15:47:51 -08:00
Paul Berry 493a03a0ed Add UnlinkedClass.hasNoSupertype property to summaries.
This is necessary in order to properly summarize the core type `Object`,
which lacks a supertype.

Note that there is no test for this functionality in
resynthesize_test.dart.  It will be covered as soon as the test
`fail_core` is enabled.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1531913002 .
2015-12-16 15:18:49 -08:00
Konstantin Shcheglov 9cb4fc5f1d Resolve comment references before function type aliases.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1535533002 .
2015-12-16 15:13:12 -08:00
Stephen Adams 042fcc9de0 Indexer one-shot fast path adjustment
If the index/key is not a number it is unlikely that the receiver is an Array-like JavaScript object.

This suggests that we should have a version of the one-shot with no fast-path to use at call sites where we can prove the (receiver, argument) combination does not benefit from the fast path.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1531453004 .
2015-12-16 15:07:21 -08:00
Ryan Macnak 0980c1af96 Further fix get_cpu_profile_timeline_rpc_test.
Review URL: https://codereview.chromium.org/1529093005 .
2015-12-16 14:59:33 -08:00
Konstantin Shcheglov 5eb20232e3 Skip comments code blocks indented with 4 spaces.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1536483002 .
2015-12-16 14:28:30 -08:00
Paul Berry 7adf62209d Fix summary resynthesis for operators ending in '='.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1530363002 .
2015-12-16 13:59:16 -08:00
John McCutchan f3ee772308 Provide list of service protocol extensions in isolate and emit an event when one is registered.
- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered (IsolateServiceExtensionRegistered).

Fixes https://dartbug.com/25208
Fixes https://dartbug.com/25257

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1527793004 .
2015-12-16 13:49:37 -08:00
Ryan Macnak 55a22037fb Fix get_cpu_profile_timeline_rpc_test.
AddProperty64 encodes as a JSON integer, not a JSON string.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1535513002 .
2015-12-16 13:42:06 -08:00
Paul Berry ac170168dd Add support for the "external" keyword to summaries.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1528983004 .
2015-12-16 13:32:19 -08:00
Dan Rubel 3bf298760f extract InheritedReferenceContributor from imported reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1533613004 .
2015-12-16 16:20:53 -05:00
Paul Berry 7e1abb6cbc Remove an unused import
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1531063002 .
2015-12-16 13:13:40 -08:00
Brian Wilkerson e5156862b2 Prepare to publish analyzer
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1527293003 .
2015-12-16 13:12:32 -08:00
John McCutchan 2db0ad84d0 Test that we can load Observatory frontend resources
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/1529153003 .
2015-12-16 13:03:01 -08:00
pq 8887cd69f0 Fix analyzer_cli error overrides (#24452).
Brings `analyzer_cli` inline with server wrt processing errors configured in `.analysis_options`.

Note some added complexity due to interactions with flags that globally escalate warnings/hints to errors.

https://github.com/dart-lang/sdk/issues/24452

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1529243002 .
2015-12-16 12:44:38 -08:00
Siva Annamalai e2f9217dc0 Remove and Add the mutator thread from the active thread list when unscheduling and scheduling the thread on an isolate, this ensures that we do not extra count the mutator thread even after it is unscheduled during safepoint operation.
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1532643003 .
2015-12-16 12:43:48 -08:00
John McCutchan e7358d1e51 Fix clang build error
BUG=

Review URL: https://codereview.chromium.org/1531863003 .
2015-12-16 12:42:36 -08:00
John McCutchan cc0f297703 Compress Observatory assets
- Gzip the Observatory assets tar file before encoding into the C++ source file.

Shrinks observatory_assets.cc from ~21MB to ~4MB.

Fixes #25276

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1534523002 .
2015-12-16 12:35:58 -08:00
Brian Slesinsky 4fad247dc6 remove obsolete cache size parameter
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1530103002 .
2015-12-16 12:35:20 -08:00
Paul Berry 98e8b0a118 Fix resynthesis of operator[]= from summary.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1533563003 .
2015-12-16 11:29:54 -08:00
Paul Berry 5ef4929ae2 Replace uses of setModifier with ElementImpl setters.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1524303004 .
2015-12-16 11:28:24 -08:00
Konstantin Shcheglov c19e958822 Don't produce [references] in GitHub-like code blocks in comments.
Mostly for the cases when we would like to demonstrate use or
lists or maps: `a[i] == b[i]`.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1527393002 .
2015-12-16 10:32:10 -08:00
Ryan Macnak a0e0ac78cb Observatory: Include profiler samples in the timeline view.
- Add pre-isolate service RPC that emits profiler samples in about:tracing format.
 - Make timeline UI automatically merge the event timeline with the sample timelines.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1525913002 .
2015-12-16 10:11:44 -08:00
Brian Wilkerson fa73d7e552 Restore auto-processing of plugins
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523343004 .
2015-12-16 09:19:16 -08:00
Dan Rubel f13460e235 rename InheritedContributor to OverrideContributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523163004 .
2015-12-16 12:15:34 -05:00
Dan Rubel 4cd376143f move functional argument check into manager
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1531473006 .
2015-12-16 12:11:36 -05:00
Konstantin Shcheglov ea922ef7f4 Fix for recording static elements of a prefixed comment reference.
I notied during reading idl.dart that I'd like to see highlighting and
search for type names in comment references like [PrelinkedLibrary.dependencies].

With this change we get highlighting, search and refactoring for both.
Navigation also works (*).

(*) does not work in IntelliJ - it does not parse Dart comments for reference expressions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1531613002 .
2015-12-16 09:03:25 -08:00
Paul Berry ea7e6b29ed Introduce code to resynthesize element models from summaries.
A lot of work remains to do (see TODO comments), but the basic
infrastructure is now in place.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1526243002 .
2015-12-16 08:39:56 -08:00
Brian Wilkerson 66e07636f4 Moved the tests for the element model into locations corresponding to the implementation
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1529923003 .
2015-12-16 07:49:15 -08:00
John McCutchan 7003c9686a Fix --print-metrics
Fixes #25037

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1531553002 .
2015-12-16 07:31:29 -08:00
John McCutchan 9f7440cde5 Bump observatory pub packages DEPS
Fixes #25262

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1524333003 .
2015-12-16 07:30:25 -08:00
Florian Schneider 61f190eebe Temporary workaround to make VM bots greener.
The reason are data races at isolate creation/shutdown. Further investigation
to fix the root cause needed.

TBR=johnmccutchan@google.com,

BUG=

Review URL: https://codereview.chromium.org/1531763002 .
2015-12-16 15:30:29 +01:00
Johnni Winther 5d53b30151 Handle malformed elements in onElementResolved.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1525423002.
2015-12-16 15:04:25 +01:00
William Hesse 58ea2fbce6 Remove third_party/pkg/petitparser and third_party/pkg/intl
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1332963002 .
2015-12-16 14:48:19 +01:00
Lasse R.H. Nielsen ba675bddf2 Update documentation on Stream.map
Fixes issue #25273
BUG= http://dartbug.com/25273
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1528363002 .
2015-12-16 14:46:35 +01:00
William Hesse d6fe4122ec Remove third_party/font-awesome and its use in site/try.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1528893002 .
2015-12-16 14:43:23 +01:00
William Hesse a74f54faf0 Remove fake_async from third_party/pkg.
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1330363002 .
2015-12-16 14:16:33 +01:00
Asger Feldthaus 488ffd8aac dart2js cps: Use oneshot interceptors and 'instanceof' expressions.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1525163002 .
2015-12-16 14:13:51 +01:00
Florian Schneider 4a037f0ccb VM: Use read-only handle Object::dynamic_type() where possible.
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1528873002 .
2015-12-16 11:31:53 +01:00