Commit graph

35222 commits

Author SHA1 Message Date
Dan Rubel 37d52a5d1c do not suggest completions for cascade on library prefix - fixes #25215
add CompletionRequest dotTarget
add CompletionTarget offset and isCascade

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1516883002 .
2015-12-10 11:57:26 -05:00
Brian Wilkerson f0d249e269 Clean up package imports and library names
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
2015-12-10 08:11:56 -08:00
William Hesse eab11aaac5 Split up list of package files in build process, to work around xcode limits.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org/1516803002 .
2015-12-10 13:29:10 +01:00
Kevin Millikin ff1c630edc dart2js: Do not eliminate calls whose receiver can be null.
In the CPS backend's type propagation, try to avoid eliminating calls
whose receiver can be null.

This fixes a bug in the constant folding of indexed access.  e0[e1]
would be folded away if e0 could be null but type inference told us
that the elements had a known (specifically null) type.

tests/language/inference_list_or_null_test triggers the bug.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org/1515833003 .
2015-12-10 13:02:47 +01:00
Johnni Winther 8e467be6b0 Add missing compile-time errors for async/await.
Closes #22324
Closes #23716

R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1504403005.
2015-12-10 11:24:09 +01:00
Lasse R.H. Nielsen fa025f3337 Make int_parse_radix_test run ~30% faster.
BUG= https://github.com/dart-lang/fletch/issues/46
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1510843002 .
2015-12-10 11:06:20 +01:00
Lasse R.H. Nielsen e038407e27 Simplify future-propagation for whenComplete.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1510053004.
2015-12-10 09:15:38 +01:00
Florian Loitsch a57abe83e2 Fix typo in streams.
Fixes issue 25195

Review URL: https://codereview.chromium.org/1502183009 .
2015-12-10 04:24:42 +01:00
Stephen Adams cfb97d053e Revert "Canonical output ordering for constants."
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/1511383002 .
2015-12-09 17:23:29 -08:00
Stephen Adams d15e5d5192 Canonical output ordering for constants.
Fix for: http://dartbug.com/24920

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1491413008 .
2015-12-09 17:05:51 -08:00
Florian Loitsch e802e26d7b Move messages out of dart2js.
The format of the shared messages is still valid Dart, but it is restricted, so that a JavaScript parser can easily parse it.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1503053004 .
2015-12-10 01:35:22 +01:00
Bob Nystrom 1d3d4049ce Add dartfmt to changelog.
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1504333008 .
2015-12-09 16:13:57 -08:00
Natalie Weizenbaum 5cfc7ab028 Update test and its dependencies.
Fixes dart-lang/pub#1365

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1506313003 .
2015-12-09 15:53:55 -08:00
John Messerly 0e09465f0c fix #25183, add support to ErrorVerifier for generic methods
R=brianwilkerson@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1514683002 .
2015-12-09 15:16:00 -08:00
Konstantin Shcheglov e48f962af1 Validate that root paths are absolute and normalized.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25203

Review URL: https://codereview.chromium.org/1511833004 .
2015-12-09 15:05:22 -08:00
Ivan Posva f887b03b5b - Assert that we do not hold the timeline lock while entering
potential safepoints.
- Enable timeline for existing test as a regression test.
- Fix allocation with timeline lock held during deoptimization to
  prevent deadlock.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1514653002 .
2015-12-09 13:41:42 -08:00
Stephen Adams e78c269603 Use annotations on confuse() in null_test
Verified no material code changes.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1511293003 .
2015-12-09 13:38:47 -08:00
keertip 0e61315d50 update dartdoc to 0.8.4 in DEPS
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1512993002 .
2015-12-09 13:17:09 -08:00
Dan Rubel 29a44c7b4c remove argument list suggestions - fixes #25197
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514613003 .
2015-12-09 16:06:53 -05:00
Stephen Adams 947d4db5fc Change confuse() for range_analysis3_test to return non-null int
The change was not material, but now main() is identical to before.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1504333005 .
2015-12-09 12:51:27 -08:00
Stephen Adams efba1086d7 Update confuse() on syncstar_less_than_test
Verified essential generated code is the same.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1516673002 .
2015-12-09 12:40:48 -08:00
Stephen Adams ec5e0c3d29 Use annotations on confuse() functions
TBR=-floitsch@google.com

Review URL: https://codereview.chromium.org/1518553002 .
2015-12-09 12:30:01 -08:00
Florian Loitsch 1a3853b128 Improve comment in UnmodifiableListView.
The class already states that the source must have efficient-length, but
the constructor didn't reiterate this requirement.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1510043002 .
2015-12-09 21:25:55 +01:00
Dan Rubel d54fb071a9 do not suggest import uri reaching out of lib
related to https://github.com/dart-lang/sdk/issues/22358

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509373005 .
2015-12-09 14:38:49 -05:00
Dan Rubel 824a012d8f do not suggest static methods from superclass - fixes #24258
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509723004 .
2015-12-09 14:37:03 -05:00
Dan Rubel 830a37afae suggest after import prefix in part files - fixes #25023
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1514603002 .
2015-12-09 14:35:30 -05:00
Konstantin Shcheglov 1f5973e24e Explicitly specify that FilePath is not just absolute, but also a normalized path.
It was implied, and every client I know of uses absolute and normalized paths.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1506323002 .
2015-12-09 11:30:54 -08:00
Florian Loitsch 581392cf17 Fix datetime test.
R=lrn@google.com

Review URL: https://codereview.chromium.org/1511773003 .
2015-12-09 20:24:40 +01:00
Alan Knight 44d82ebc43 Fix Chrome 47 test suppressions and invalid @DontInline directive
BUG=

Review URL: https://codereview.chromium.org/1509323003 .
2015-12-09 10:32:26 -08:00
Zachary Anderson bd20ef507f Load Observatory assets lazily
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/1500073003 .
2015-12-09 10:09:45 -08:00
Stephen Adams cfd1654293 Constant folding of indexers
- Constant fold indexers.
- Use inferred types of elements of containers and dictionaries.

R=asgerf@google.com

Review URL: https://codereview.chromium.org/1492233002 .
2015-12-09 09:42:29 -08:00
Kevin Millikin 42809b52b1 dart2js: Fix an issue with erroneous for-in.
In the CPS backend, when a for-in loop has an erroneous variable (interpreted
as an unresolved static setter), then we should call NoSuchMethod and not try
to call the setter.  This is what the SSA backend does.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1518473002 .
2015-12-09 18:33:27 +01:00
pq 2fdcb1bd74 Promote diagnostic.getDiagnostics() (#25061).
* removes rolling average support
* removes "experimental" tag
* bumps API version

Fixes #25061.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1509033003 .
2015-12-09 09:29:26 -08:00
Dan Rubel e9a77de7dd suggest yield and yeild* - fixes #24346
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1511553005 .
2015-12-09 12:03:12 -05:00
danrubel 87ac33a904 CombinatorContributor and LibraryMemberContributor - consolidate common behavior
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1516473002 .
2015-12-09 11:41:42 -05:00
Kevin Millikin deba5aaf7a Remove an unnecessary line in a test status file.
The syntax of the test status file expects the name of the test which will
be used to derive the filename.  If the filename is instead given, it
matches no test.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1508413002 .
2015-12-09 16:28:46 +01:00
Kevin Millikin 12d79f91a3 dart2js: Process arguments to direct invocations as if the target is known.
When a method is invoked directly the target is known.  Normalize the
arguments based on the known target at CPS-translation time.  If this is not
done, then the call may go indirectly through a stub which is not actually
generated.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org/1510193003 .
2015-12-09 16:27:13 +01:00
Paul Berry 1c3fa08ca6 Update pkg.status to account for dart_style roll.
The dart_style roll fixed the remaining tests that were broken by the
merge of analyzer-breaking-0.27.

Fixes #25173.

TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/1514553003 .
2015-12-09 07:10:14 -08:00
Johnni Winther 77b2f078af Make new of an ambiguous a warning.
Closes #21171

R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1508383002.
2015-12-09 15:54:41 +01:00
Johnni Winther 7716ef5da1 Report compile-time error on disallowed metadata values.
Closes #14548

R=karlklose@google.com

Review URL: https://codereview.chromium.org/1510863004.
2015-12-09 15:48:38 +01:00
danrubel e03c395a8c extract TypeMemberContributor from prefixed element contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1504223005 .
2015-12-09 07:38:20 -05:00
Kevin Millikin f4b80ff12e dart2js: Use correct call structures throughout the backend.
When translating to CPS, call arguments are normalized.  For known
targets, this means default values are passed for missing optional
arguments and named arguments are in a canonical order.  For unknown
targets, this means that passed named arguments are in a canonical
order.

However, the CallStructure recorded is one that describes the original
call.  This may have an incorrect number of passed argument or an
incorrect order for named arguments.  With this change, a new call
structure is created describing the call as it appears in the CPS IR.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1491973002 .
2015-12-09 12:57:04 +01:00
Johnni Winther a48dbfefd8 Static/instance getter/setter override is a warning.
Closes #11496

R=karlklose@google.com

Review URL: https://codereview.chromium.org/1508343002.
2015-12-09 11:57:20 +01:00
Florian Schneider 12b0aa1ba8 VM: Don't inline array allocation in precompiled code
This reduces generated code size by around 3-4% on ARM and x64.

Performance impact is mostly neutral because precompiled code is generally
dominated by other factors, and especially ARM often benefits from smaller
generated code.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1512513002 .
2015-12-09 11:40:32 +01:00
Johnni Winther 116a96bea5 Disallow const getters.
Closes #8750

R=karlklose@google.com

Review URL: https://codereview.chromium.org/1512573002.
2015-12-09 10:46:04 +01:00
William Hesse ed9bb160de Revert "Copy entire api-docs directory to release GCloud directory in promote script."
This reverts commit f03279a7eb.
When there is only one file in the directory, this does not move the
file into the target directory, but moves it to replace the target
directory with a file.

Reverting to the old behavior, with a changed filename, since we are
now only copying one file. tools/bots/bot_utils.py:124 is changed to
use dartdocs_zipfilename() instead of the deleted apidocs_zipfilename().

BUG=https://github.com/dart-lang/www.dartlang.org/issues/1528
R=ricow@google.com

Review URL: https://codereview.chromium.org/1502253002 .
2015-12-09 10:29:34 +01:00
Johnni Winther 0413883e0c Show import for import of parts.
Closes #24366

R=karlklose@google.com

Review URL: https://codereview.chromium.org/1511533002.
2015-12-09 10:04:44 +01:00
Florian Loitsch db643f5ae2 Fix datetime test.
Review URL: https://codereview.chromium.org/1514483003 .
2015-12-09 02:57:05 +01:00
Bob Nystrom c56910c930 Upgrade dart_style to 0.2.2.
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1508083004 .
2015-12-08 17:23:19 -08:00
Florian Loitsch 5b4e5a90fe Update status file.
Review URL: https://codereview.chromium.org/1507383003 .
2015-12-09 01:30:52 +01:00