Kevin Moore
36635d3c05
Bring in the latest pub
...
...2nd attempt
1st attempt: b3997dfc0c
reverted in 77ff7cf727
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2752963003 .
2017-03-15 16:31:58 -07:00
Siva Annamalai
4bc53826f7
Add test case to regress case where fields of a closure are accessed (reproduces the problem we encountered in b/36131545)
...
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2752803003 .
2017-03-15 13:41:47 -07:00
pq
f33d072d91
Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788)
...
* corrects insert target of `ADD_MISSING_REQUIRED_ARGUMENT` fixes
* updates `assertHasFix` to optionally verify fix target
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/788
Review-Url: https://codereview.chromium.org/2749373002 .
2017-03-15 13:27:27 -07:00
Konstantin Shcheglov
7986cc50bd
Fix also type inference for enum method invocation.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2745283007 .
2017-03-15 13:25:28 -07:00
Ryan Macnak
877284947b
Rename TARGET_OS_* to HOST_OS_*.
...
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.
Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.
R=zra@google.com
Review-Url: https://codereview.chromium.org/2750843003 .
2017-03-15 13:11:05 -07:00
Paul Berry
ef79634132
Re-land "Add support for metadata on type variables to Fasta parser." (with fixes).
...
Last time I landed this I left a crucial `pop()` out of BodyBuilder,
resulting in test failures.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2750503012 .
2017-03-15 12:42:23 -07:00
Konstantin Shcheglov
ae85bcf954
Parse for-loop statements with Fasta.
...
R=ahe@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2746333005 .
2017-03-15 11:40:32 -07:00
Konstantin Shcheglov
39dbb75c76
Parse constructor field initializers with Fasta.
...
R=paulberry@google.com , ahe@google.com
BUG=
Review-Url: https://codereview.chromium.org/2751913002 .
2017-03-15 11:32:53 -07:00
Brian Wilkerson
8afab37d55
Add PluginWatcher to watch for new plugins that need to be run
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2750483006 .
2017-03-15 11:26:14 -07:00
Brian Wilkerson
40ca7292fe
Improve printing of generic function types and add tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2752853002 .
2017-03-15 11:19:48 -07:00
Zach Anderson
8be1856589
Update CHANGELOG for Platform.ansiSupported
...
fixes #29079
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2756493002 .
2017-03-15 10:33:03 -07:00
Zach Anderson
607df1c822
[dart:io][windows] Reset the console on ctrl-c
...
fixes #28995
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2750833003 .
2017-03-15 10:17:53 -07:00
Siva Annamalai
f748465867
Fix for regression in content shell tests (see b/36131545)
...
Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).
R=regis@google.com , rmacnak@google.com
Review-Url: https://codereview.chromium.org/2751883002 .
2017-03-15 10:06:31 -07:00
Stephen Adams
6c76f592a6
Move TreeElementMixin to avoid out-of-library private overrides
...
This is one of two solutions for Issue 28809
https://codereview.chromium.org/2722923002
https://codereview.chromium.org/2722043002
We should pick one.
R=johnniwinther@google.com , sigmund@google.com
Review-Url: https://codereview.chromium.org/2722923002 .
2017-03-15 09:56:28 -07:00
Zach Anderson
9be35abd37
Fix dart2js test
...
Review-Url: https://codereview.chromium.org/2756483003 .
2017-03-15 09:49:48 -07:00
Vijay Menon
338304a6c7
Fix DDC patch
...
TBR'ing to get build green.
TBR=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2749703006 .
2017-03-15 09:23:49 -07:00
Zach Anderson
a8bf498e56
[dart:io] Adds Platform.ansiSupported
...
This is so that flutter_tool can determine whether it can print
ANSI codes to the terminal on windows.
fixes #28614,#28984
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2739683005 .
2017-03-15 08:51:50 -07:00
Erik Corry
ae8e6705c0
Allow dispatch to use a range of Class-ids in tests
...
Use polymorphic call for all multi-cid call sites
Remove special hashCode code
R=vegorov@google.com
BUG=
Review-Url: https://codereview.chromium.org/2737303003 .
2017-03-15 16:08:46 +01:00
William Hesse
3281587d84
Update DEPS to use chromium mirrors of more package repos
...
BUG=
R=sortie@google.com
Review-Url: https://codereview.chromium.org/2752783002 .
2017-03-15 16:02:51 +01:00
Peter von der Ahé
a228e0b2d7
Move deps file generation to fasta.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2742333006 .
2017-03-15 15:42:22 +01:00
Johnni Winther
cb8b56523c
Pending renames and cleanups after commits
...
Review-Url: https://codereview.chromium.org/2751983002 .
2017-03-15 15:33:42 +01:00
Johnni Winther
fa8a35f439
Add status_summary and current_summary to tools/gardening
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2753513005 .
2017-03-15 15:32:56 +01:00
Peter von der Ahé
06a6ba14a3
Swap two methods.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2748093005 .
2017-03-15 15:28:11 +01:00
Peter von der Ahé
11018241fe
Add here-be-dragons comments.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2749253003 .
2017-03-15 15:19:05 +01:00
Peter von der Ahé
99fa028982
Handle 'part of' declarations with URI correctly in Fasta.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2747173002 .
2017-03-15 15:11:36 +01:00
Johnni Winther
4414836936
Register type constants through ConstantUse
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2750503003 .
2017-03-15 14:52:09 +01:00
Johnni Winther
0924b17267
Create LookupMapAnalysis late.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2745133002 .
2017-03-15 14:46:02 +01:00
Johnni Winther
5ec55890fa
Add ConstantUse to WorldImpact
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2742283002 .
2017-03-15 14:34:40 +01:00
Johnni Winther
db7262d4ae
Extract CodegenImpactTransformer from ImpactTransformer
...
+ remove backend use from JavaScriptImpactTransformer
+ almost remove use of backend in CodegenImpactTransformer
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2728393005 .
2017-03-15 14:11:16 +01:00
Peter von der Ahé
626987ef5c
Add default type arguments on Supertype as well.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2746763003 .
2017-03-15 14:05:08 +01:00
Johnni Winther
69130277ef
Split NativeDataImpl
...
- into NativeClassDataImpl and NativeDataImpl
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2738513007 .
2017-03-15 13:54:40 +01:00
Jens Johansen
9fa510ea38
Revert "[kernel] offsets on direct property get/set"
...
This commit wanted stuff from anther CL that haven't landed yet.
This reverts commit 7577f6aaa0
.
BUG=
Review-Url: https://codereview.chromium.org/2751083002 .
2017-03-15 13:54:03 +01:00
Johnni Winther
4b9297caad
Create ResolutionEnqueuer after library loading.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2735763002 .
2017-03-15 13:46:48 +01:00
Johnni Winther
b08686ba67
Prepare for late creation of ResolutionEnqueuer
...
- late as in 'after library loading'
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2729383002 .
2017-03-15 13:33:19 +01:00
Jens Johansen
7577f6aaa0
[kernel] offsets on direct property get/set
...
BUG=
R=ahe@google.com , kmillikin@google.com
Review-Url: https://codereview.chromium.org/2748333002 .
2017-03-15 13:26:45 +01:00
Jens Johansen
5e1ba94af4
[kernel] debugging for in statement
...
BUG=
R=ahe@google.com , kmillikin@google.com
Review-Url: https://codereview.chromium.org/2747813003 .
2017-03-15 13:22:58 +01:00
Johnni Winther
8e1e08ce4a
Add ClassEntity.library, MemberEntity.library and FunctionEntity.isExternal
...
- and mostly use entities in native_data.dart
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2731173002 .
2017-03-15 13:18:31 +01:00
Johnni Winther
fbbf1e90ec
Split js interop registration into library/class/member elements
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2731163002 .
2017-03-15 12:58:55 +01:00
Zhivka Gucevska
bd3cfd6979
Implements support for variables and evaluation of logic expressions
...
BUG=
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2740433006 .
2017-03-15 12:50:16 +01:00
Johnni Winther
69b47ea010
Add NativeDataResolver
...
- to further align the NativeData computation towards separating builders from data.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2732793002 .
2017-03-15 11:54:48 +01:00
Johnni Winther
f7ec06f210
Add NativeClassData/NativeClassDataBuilder
...
- for information computed during loading (pre-resolution)
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2727253007 .
2017-03-15 11:24:13 +01:00
Johnni Winther
28f7099f17
Remove backend reference from ResolutionEnqueuerListener.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2729943004 .
2017-03-15 11:17:26 +01:00
Johnni Winther
452c380db1
Late creation of CodegenEnqueuerListener and CodegenWorldBuilder
...
- now with no reference to JavaScriptBackend!
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2727373003 .
2017-03-15 11:08:43 +01:00
Johnni Winther
3b89f84715
Register inlining as a StaticUse
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2724223005 .
2017-03-15 11:01:55 +01:00
William Hesse
d482ab3c30
Update status for a co19 test on Windows chrome.
...
BUG=
Review-Url: https://codereview.chromium.org/2749243002 .
2017-03-15 11:01:07 +01:00
William Hesse
77ff7cf727
Revert "Bring in the latest pub."
...
This reverts commit b3997dfc0c
.
Many pub tests are failing on Mac OS.
BUG=
R=sortie@google.com
Review-Url: https://codereview.chromium.org/2749643005 .
2017-03-15 11:00:23 +01:00
Johnni Winther
c7011e2d82
Late creation of CodegenEnqueuer
...
This is part of a general move towards creating codegen-specific object at codegen start instead of at resolution start. Many of the don't even make sense before, for instance, ClosedWorld has been computed.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2732663002 .
2017-03-15 10:52:52 +01:00
Dmitry Stefantsov
5526d5eeca
Don't create a closure class if it already exists
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2743363007 .
2017-03-15 10:04:05 +01:00
Johnni Winther
22d4992101
Remove Enqueuer.nativeEnqueuer
...
- moves logic into the backend instead.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2732633002 .
2017-03-15 10:02:37 +01:00
Erik Corry
4c05acd59b
Sign extend correctly in disassembler
...
R=vegorov@google.com
BUG=
Review-Url: https://codereview.chromium.org/2748023003 .
2017-03-15 09:20:00 +01:00