Fix test expectations.
Improve test (overly complex).
Mark tests/isolate as immutable to the presubmit script (like other migrated Dart 1 test directories).
(Gardening)
Change-Id: Iec59c59ca992b3dacafbf82176e4e8bd8c5bd3c5
Reviewed-on: https://dart-review.googlesource.com/42945
Reviewed-by: William Hesse <whesse@google.com>
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.
To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.
Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Only allow .status files in Dart 1.0 test directories to be changed.
R=rnystrom@google.com
Change-Id: Ic95b76eb53e7d5ab6b795425a7a97f0fded01a5b
Reviewed-on: https://dart-review.googlesource.com/14120
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
What is dead may never die.
Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
If the file has a syntax error, it can't be formatted. We don't want to
block submission on that since we do have lots of files in the repo
that deliberately contain syntax errors.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2987883002 .
PRESUBMIT will check:
1. a new test can NOT be added to Dart 1.0 the new test can only be added to DDC.
2. a existing Dart 1.0 test changed must have its corresponding DDC test updated too (if it exists).
Presubmit errors may appear as:
** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC test must change: tests/language_2/compiler_annotations.dart
R=jacobr@google.com, rnystrom@google.com
Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0 test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0 test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart
Review-Url: https://codereview.chromium.org/2982043002 .
