Commit graph

46204 commits

Author SHA1 Message Date
Peter von der Ahé 2d9956a93d Move kernel baseline tests to front_end.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2825063002 .
2017-04-19 10:57:58 +02:00
Paul Berry 84ef5ed2da Add the ability to select a subset of tests using "...".
For example, the following command:

    pkg/front_end/tool/fasta testing compile/type...

Now runs all tests in the "compile" suite whose name begins with
"type".

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2824373002 .
2017-04-19 01:45:34 -07:00
Johnni Winther 407645660c Remove Compiler and JavaScriptBackend from program_builder and collector.
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2824823004 .
2017-04-19 10:44:57 +02:00
Johnni Winther 230c1745cd Remove Compiler and JavaScriptBackend from class_stub_generator
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2820143004 .
2017-04-19 10:40:11 +02:00
Martin Kustermann a7e6da3a93 Add support for core dump archiving on macos
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2815553003 .
2017-04-19 10:36:23 +02:00
Johnni Winther 23684c221e Remove Compiler and JavaScriptBackend from field_visitor.
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2823003003 .
2017-04-19 10:30:55 +02:00
Peter von der Ahé 433575f618 Remove kernel baseline tests.
In CL 2824203002 the associated test cases are moved to pkg/front_end which uses pkg/testing to replace what's implemented in these tests.

R=asgerf@google.com

Review-Url: https://codereview.chromium.org/2824203002 .
2017-04-19 10:22:25 +02:00
jpaulsen 6a56c86c81 New Lint quick-fix: prefer_collection_literals (#29378) 2017-04-18 18:55:08 -07:00
Paul Berry 13941eaa03 Plumb TypeInferrer through KernelExpression._inferExpression.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2827793003 .
2017-04-18 18:40:46 -07:00
Régis Crelier 4dd686e9df More work on finalization of recursive types (fixes #29357).
Add regression test.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2822323002 .
2017-04-18 17:18:39 -07:00
Jacob Richman b7995140f8 Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)."
This reverts commit a84b6b7f7b.

BUG=

Review-Url: https://codereview.chromium.org/2824323002 .
2017-04-18 16:48:33 -07:00
Jacob Richman 0dbb32f406 Run formatter on dev_compiler.
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2830503002 .
2017-04-18 16:16:14 -07:00
Paul Berry ea0c1d8f35 Address nits from https://codereview.chromium.org/2823243002/
I thought I'd made these changes prior to landing the above CL, but I
accidentally made them to the wrong branch, so they didn't wind up
getting committed.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2821193004 .
2017-04-18 15:46:08 -07:00
Jacob Richman b67e83eea3 Format all remaining unformatted runtime files other than multitests.
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2829463003 .
2017-04-18 15:34:03 -07:00
Steve Messick 6a19d96ee2 Complete for-statement
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2824233002 .
2017-04-18 15:20:31 -07:00
Mike Fairhurst a84b6b7f7b Fix #28740 demangle constructors in stack traces (A.A becomes new A).
Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2818933003 .
2017-04-18 15:18:29 -07:00
P.Y. Laligand 36a7e49822 Updated build files for Fuchsia. (#29382) 2017-04-18 15:02:19 -07:00
Stephen Adams 2955ecc794 Increase tracing limit
Increasing from 16 to 32 has a lot of nice small improvements and does
not seem to affect compile time (within benchmark noise).

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2826623002 .
2017-04-18 15:00:20 -07:00
jpaulsen c386e41f25 New Lint quick-fix: avoid_init_to_null (#29367) 2017-04-18 14:13:53 -07:00
Mike Fairhurst 0aa8574a04 Fix failure using custom drivers with AnalysisDriverScheduler
Or alternatively, the AnalysisDriverGeneric interface could be extended?

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2815913006 .
2017-04-18 14:02:58 -07:00
Stephen Adams c65b3bee52 js_runtime: LinkedHashMap._makeEmpty may be removed
Since it has no effects and does not throw, it may be scheduled more freely.

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2825793002 .
2017-04-18 13:58:15 -07:00
Ryan Macnak b15cf1c490 Fix VM crash when encountering an assignment expression in a case expression.
Fixes #29370
Issue #29379

R=regis@google.com

Review-Url: https://codereview.chromium.org/2825843003 .
2017-04-18 13:48:06 -07:00
Ryan Macnak ff6a86f9eb Correct range in docs for signed accessors of ByteData.
Fixes #29375.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2823363002 .
2017-04-18 13:22:58 -07:00
P.Y. Laligand 043b8ebbf2 Fixed test failing on Windows. (#29380) 2017-04-18 12:50:50 -07:00
Konstantin Shcheglov 955d7cf037 Fix for instance fields inference when a setter has no parameter.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2828573002 .
2017-04-18 12:26:38 -07:00
Konstantin Shcheglov 19353f9e63 Issue 29358. Fix for reporting constant errors while evaluating constructor invocations.
We should not report errors in one file using offsets of node in
another file.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29358

Review-Url: https://codereview.chromium.org/2825813002 .
2017-04-18 12:13:23 -07:00
Siva Annamalai 96bbe512eb Fix for issue 29350 - VM Crashes when covariant is used incorrectly.
BUG=#29350
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2827453003 .
2017-04-18 11:10:28 -07:00
P.Y. Laligand bfdf42a8e0 GN workspaces now use packages files. (#29364)
The previous version would use a global cache of package locations which would hide missing dependencies.
Also fixed an issue in file tracking with non-existing sources that resolvers such as PackageMapUriResolver sometimes return.
2017-04-18 10:41:29 -07:00
Vyacheslav Egorov 8f563f2c32 VM: Prohibit reload when throwing or processing language errors.
This fixes flaky crashes on negative tests in stress reload mode: when
we attempt to reload an isolate while throwing/formatting compile time error.

Fixes https://github.com/dart-lang/sdk/issues/27835

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2825043002 .
2017-04-18 18:51:49 +02:00
Paul Berry 6d737cb684 Introduce initial plumbing for type inference in fasta.
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2823243002 .
2017-04-18 09:37:54 -07:00
Devon Carew 310d6d196b Fix an issue with restoring certain lint issues from summary files.
BUG=https://github.com/dart-lang/sdk/issues/29359
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2821943003 .
2017-04-18 08:50:22 -07:00
Zachary Anderson 63ffa88171 Update CHANGELOG.md for recent dart:io additions
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2819383003 .
2017-04-18 08:39:22 -07:00
Konstantin Shcheglov f3fd6d5e44 Add the missing space before 'in'.
R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2824113002 .
2017-04-18 08:32:12 -07:00
Florian Loitsch 9add06fe7f Remove changelog entry for part-of in 1.23.
Review-Url: https://codereview.chromium.org/2827433007 .
2017-04-18 16:12:47 +02:00
Paul Berry ed41766091 Simplify shadow class hierarchy.
Change the front_end's shadow class hierarchy so that instead of
containing implementation classes and mixin classes, it only contains
implementation classes.  The mixins proved to be unnecessary.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2819423004 .
2017-04-18 06:31:42 -07:00
Peter von der Ahé 0c9c069066 Add more diagnostics to UX watch list.
R=karlklose@google.com, lukechurch@google.com

Review-Url: https://codereview.chromium.org/2801253002 .
2017-04-18 14:51:00 +02:00
Johnni Winther 86b468a466 Remove Compiler and JavaScriptBackend from parameter_stub_generator
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2810223002 .
2017-04-18 10:43:52 +02:00
Johnni Winther d7f28df9e8 Remove Compiler and JavaScriptBackend from main_call_stub_generator and runtime_type_generator
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2815513007 .
2017-04-18 10:39:04 +02:00
Johnni Winther db048990bc Remove Compiler and JavaScriptBackend from interceptor_stub_generator.
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2818463002 .
2017-04-18 10:33:58 +02:00
Johnni Winther 635f2fc491 Less direct use of JavaScriptBackend in ProgramBuilder
This is a step towards passing data object directly instead of accessing
data on JavaScriptBackend. This is needed to support an element switch
between resolution and codegen.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2810183002 .
2017-04-18 10:25:15 +02:00
Johnni Winther e484e652e2 Remove Compiler/JavaScriptBackend from metadata_collector
- and Compiler from type_test_registry.

The CodeEmitterTask was removed from the TypeRepresentationGenerator to
break a dependency cycle between the two. An Emitter is now provided as
an argument to TypeRepresentationGenerator methods instead.

This is a step towards passing data object to the codegen/emitter
instead of pulling data directly from Compiler/JavaScriptBackend. This
is needed to support an element model switch between codegen and
resolution.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2809203003 .
2017-04-18 09:58:27 +02:00
Johnni Winther 9cff58233f Extract ClosedWorldRefiner implementation from ClosedWorldImpl to ClosedWorldBase
- to make it reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2814973003 .
2017-04-18 09:45:00 +02:00
Erik Corry 2a2de1aa23 Temporary fix to ameliorate severe dart2js regression on some workloads
R=vegorov@google.com
BUG=https://github.com/dart-lang/sdk/issues/29302

Review-Url: https://codereview.chromium.org/2798333004 .
2017-04-18 09:42:23 +02:00
Johnni Winther a65d195f72 Compute isSubtype and isSubclass using ClassSet/ClassHierarchyNode
This makes ClosedWorld.isSubtype and ClosedWorld.isSubclass reusable
for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2815513006 .
2017-04-18 09:34:32 +02:00
Johnni Winther 5ccf530f62 Extract OrderedTypeSetBuilderBase from OrderedTypeSetBuilder
- to make it reusable for kernel based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2808763005 .
2017-04-18 09:29:39 +02:00
Jacob Richman be6d22e015 Roll back files where the formatter made non-whitespace changes.
This is due to a bug in how the formatter handled generic functions.
BUG=

Review-Url: https://codereview.chromium.org/2822103002 .
2017-04-17 22:12:57 -07:00
Stephen Adams 0c83262a1e Use shorter names for some standard properties on closures.
BUG= https://github.com/dart-lang/sdk/issues/25003
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2820953002 .
2017-04-17 18:51:18 -07:00
Stephen Adams 835f06a488 dart2js: fast startup: cache common superclass in inheritance
- group classes by common superclass
- cache superclass in local to reduce property accesses

Shrinks minified large app by 0.2%

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2813743003 .
2017-04-17 14:57:50 -07:00
Jacob Richman b280a7803d Dev compiler debugger related tweaks.
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.

Fix bug formatting modules where we were incorrectly flagging them as JS.

BUG=
R=jmesserly@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2811343002 .
2017-04-17 14:57:31 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00