Commit graph

41477 commits

Author SHA1 Message Date
Zachary Anderson 27784381b2 Add tcmalloc to GN build
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2367723004 .
2016-09-23 15:24:54 -07:00
Siva Annamalai 12f86594ec Add --parse-all option in order to benchmark and measure the scanner/parser performance.
R=hausner@google.com

Review URL: https://codereview.chromium.org/2327693002 .
2016-09-23 15:20:39 -07:00
Siva Annamalai 85cb1b3bd8 Fix for issue 25954 (Adjust heap growth amount for the case when the amount of garbage collected in the previous round is 0).
out/ReleaseX64/dart ~/tmp/gc2.dart 1
permanent = 44739242  ephemeral = 671088620  21.875s

out/ReleaseX64/dart ~/tmp/gc2.dart 2
permanent = 89478485  ephemeral = 1342177280  45.3s

out/ReleaseX64/dart ~/tmp/gc2.dart 3
permanent = 134217728  ephemeral = 2013265920  79.41s

out/ReleaseX64/dart ~/tmp/gc2.dart 4
permanent = 178956970  ephemeral = 2684354540  101.525s

BUG=25954
R=zra@google.com

Review URL: https://codereview.chromium.org/2217833003 .
2016-09-23 14:37:38 -07:00
John McCutchan 74ee4ea047 Fix handling of co19 syntax error tests using the @compile-error tag and reload bots
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2369633002 .
2016-09-23 14:26:22 -07:00
pq bb4e0798df Pull linter 0.1.27 into the SDK.
* Fixed cast exception in `dart_type_utilities` (dart-lang/sdk#27405).
* New `parameter_assignments` lint.
* New `prefer_final_fields` lint.
* New `prefer_final_locals` lint.
* Markdown link fixes in docs (#306).
* Miscellaneous solo test running fixes and introduction of `solo_debug` (#304).

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2369463003 .
2016-09-23 14:00:01 -07:00
Bob Nystrom f8bca9b5bc Bump dart_style to 0.2.10.
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2365503004 .
2016-09-23 13:56:57 -07:00
Vijay Menon ead14fbd74 Update global_compile tool
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2363053003 .
2016-09-23 13:30:18 -07:00
Florian Schneider fac7314c4c Preserve canonical bit of static closures on reload.
BUG=#27364
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2362693005 .
2016-09-23 13:07:16 -07:00
John McCutchan bc119f28bb Relax zone allocation assertion
- [x] Allow allocation in any zone that is owned by the current thread not just the top zone.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2360963005 .
2016-09-23 13:06:14 -07:00
John McCutchan fb468e387d Fix vm/cc/Debug_StepInto test which relied on old defaults
BUG=

Review URL: https://codereview.chromium.org/2364923003 .
2016-09-23 12:25:30 -07:00
Terry Lucas 1faadecb97 Get latest WebKit - remove env DART_PACKAGE_ROOT
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2370503002 .
2016-09-23 11:26:32 -07:00
Zachary Anderson a76aa4e70c Throw an ArgumentError if the port is out of range
fixes #27416

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2361373003 .
2016-09-23 11:12:54 -07:00
John McCutchan 48c6f19600 Respect setLibraryDebuggable
- [x] Mark all libraries debuggable by default
- [x] Mark all dart:_* libraries as not debuggable by default
- [x] Respect setLibraryDebuggable
- [x] Add set library debuggable test case
- [x] Do not allow dart:_* libraries to be marked debuggable

Fixes https://github.com/dart-lang/sdk/issues/27370

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2361183002 .
2016-09-23 10:45:51 -07:00
Konstantin Shcheglov 0223b08a34 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Land again)
The pkg/analysis_server/test/integration/analysis/error_test was fixed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2366963002 .
2016-09-23 10:21:21 -07:00
Siva Annamalai da487a567c Fix for issue 27380 - VM stuck in deadlock with background finalization and background compiler thread
- fixed an inadvertant flip in the safepoint check in this cl
    https://github.com/dart-lang/sdk/commit/e72c1fb47

  -  return (IsMutatorThread() ||
  -          (isolate_ != NULL && !isolate_->thread_registry()->AtSafepoint()));
  +  return (IsMutatorThread() || IsAtSafepoint());

- increase the scope of CanCollectGarbage in Heap::AllocateOld to also
  account for the tasks lock as checking for tasks inside a safepoint
  scope can lead to deadlocks

- fix an aggressive assertion in compiler for expected errors being only
  LanguageErrors to allowing UnhandledExceptions (OOM, stack overflows etc.)

- fix an aggressive assert in exception handler (handler pc can be 0 even in the mutator thread.

- workaround issue 27413 in PageSpace::CanIncreaseCapacityInWords

BUG=27380
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2363823002 .
2016-09-23 10:14:12 -07:00
Konstantin Shcheglov 09b0bba932 Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27358

Review URL: https://codereview.chromium.org/2361203004 .
2016-09-23 09:44:47 -07:00
Vijay Menon d10d77aada Remove pubspec.lock
Otherwise we break whenever a dep gets updated.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2370433002 .
2016-09-23 08:45:10 -07:00
Vijay Menon 1305077353 Allow full builds to fail on travis for now
This may be related to ongoing VM build work.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2362213003 .
2016-09-23 08:42:26 -07:00
Brian Wilkerson dd9f017a21 Bump the version number in preparation for publishing
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2367833002 .
2016-09-23 08:16:48 -07:00
Zachary Anderson 7e1b7e54d7 Starting work on full GN build
This change:
- Sucks in gn binaries
- Sucks in a version of llvm that the GN build likes
- Adds tools/gn.py to invoke gn
- Adds a root BUILD.gn and .gn file
- Removes chrome boilerplate we don't need
- etc.

This lets us do a standalone build of the 'runtime'
target for x64, ia32, arm, arm64, mips, and the
simulators on Linux, and arm and arm64 on Android.

It does not include tcmalloc, and hasn't been tested
on Mac or Windows. That work and more cleanup of
chrome boilerplate will come in follow-up CLs.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2350583002 .
2016-09-23 07:47:36 -07:00
Brian Wilkerson f87e62ef14 Convert subclasses of Enum
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2365553004 .
2016-09-23 06:54:26 -07:00
Terry Lucas 5e6dc0e0d8 Updates to latest WebKit changes, run LayoutTests in Dartium again
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2364023002 .
2016-09-23 06:32:03 -07:00
Paul Berry fe2c152ee2 Revert "Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE."
This broke the analyzer bots.  See for example https://build.chromium.org/p/client.dart/builders/analyzer-mac10.11-release-be/builds/337/steps/analysis%20server%20unit%20tests/logs/stdio

This reverts commit 77ba5fd087.

TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/2361393002 .
2016-09-23 05:24:53 -07:00
Paul Berry 5d1dcde18c Revert "Issue 27375. Use ContextBuilder to find analysis options file in analyzer_cli."
This broke the analyzer bots.  See for example: https://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/9135/steps/tests%20--host-checked%20--checked/logs/stdio

This reverts commit 75a4f968be.

TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/2366913002 .
2016-09-23 05:12:42 -07:00
Johnni Winther 3d533a08f2 More kernel_impact.
R=het@google.com

Review URL: https://codereview.chromium.org/2360773003 .
2016-09-23 11:01:53 +02:00
Johnni Winther bad12f912b Move towards using WorldImpact for codegen
CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com, sra@google.com

Committed: 0a79576ed0

Review URL: https://codereview.chromium.org/2349163003 .

Reverted:  2a1ae8a3ce
2016-09-23 10:43:12 +02:00
Johnni Winther a52683ff9b Handle calls to redirecting factories.
R=het@google.com

Review URL: https://codereview.chromium.org/2361783002 .
2016-09-23 10:03:49 +02:00
Zachary Anderson 60ede13617 Filter tcmalloc out of Android link
R=asiva@google.com

Review URL: https://codereview.chromium.org/2364623002 .
2016-09-22 19:21:21 -07:00
Ryan Macnak 40e9cd5c76 Disassembler: use the register names we generally use with our assembler.
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2359313002 .
2016-09-22 16:49:08 -07:00
John Messerly adc71ab396 re-land fix #27110 with proper DDC side of changes
R=leafp@google.com

Review URL: https://codereview.chromium.org/2362563004 .
2016-09-22 15:47:55 -07:00
Konstantin Shcheglov 75a4f968be Issue 27375. Use ContextBuilder to find analysis options file in analyzer_cli.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27375

Review URL: https://codereview.chromium.org/2355413005 .
2016-09-22 15:11:15 -07:00
Konstantin Shcheglov 92ee0b2488 Fix for the new hint in super_mixin_example.dart in analyzer_cli.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364763002 .
2016-09-22 15:03:06 -07:00
Ryan Macnak b80dedeb27 AOT: When expanding the cid range of a single target call, only check the new portion of the range.
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2367533002 .
2016-09-22 14:30:29 -07:00
Konstantin Shcheglov 77ba5fd087 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE.
There are no positives in analyzer/server, dev_compiler or dart2js.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2364733002 .
2016-09-22 14:27:47 -07:00
Matthias Hausner 74e779d4fe Fix stepping over await statements
When async-stepping over an await statement that follows a previous
async-step command, ensure that the synthetic breakpoint at the
beginning of the async closure is not accidentally deleted.

Removing a test that depends on minute details of the internal
implementation of async-step commands.

Adding new test that checks for multiple consecutive async-step
commands.

Note that debugger.cc seems to contain a memory leak. Breakpoint
objects are not deleted (deallocated) when RemoveBreakpoint()
is called. Will address this in a separate CL.

BUG=#27238
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2366463002 .
2016-09-22 14:06:24 -07:00
Brian Wilkerson fd7bb76a4b Add some errors related to nnbd
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2362873002 .
2016-09-22 13:43:37 -07:00
John McCutchan decac71b70 Address Siva's DBCs on https://codereview.chromium.org/2350633003/
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2359283002 .
2016-09-22 13:27:50 -07:00
Ryan Macnak 326af5e9d7 Move Zone's destructor out of a header file.
This unburdens users of StackZone from needing to include handles_impl.h. A new use of StackZone was recently added to heap.cc without a include of handles_impl.h, and this caused link-time errors on some versions of gcc.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2362573002 .
2016-09-22 13:16:36 -07:00
Konstantin Shcheglov 65d2a2ce82 Issue 27392. Fix for invoking objects with function-bounds type parameter types.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27392

Review URL: https://codereview.chromium.org/2360303003 .
2016-09-22 11:50:24 -07:00
Stephen Adams 5cafe42577 Use indexing for type variable access when the receiver type constrains the substitution(s)
Often we are accessing Iterable.E from a precisely known class.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2352913003 .
2016-09-22 11:32:26 -07:00
Stephen Adams 127b419fc1 Add WhereIterable.map
This makes some nice code improvements for dart2js. dart2js can't
inline the MappedIterable factory constructor and specialize by
optimization, so specializing by hand removes the test "is
EfficientLength" for code like "x.where(f).map(g)".

R=lrn@google.com

Review URL: https://codereview.chromium.org/2354093002 .
2016-09-22 10:36:16 -07:00
Brian Wilkerson 74686371b3 Add support for getting the sessionId from instrumentation and sending it to the client
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2359233002 .
2016-09-22 10:26:13 -07:00
Konstantin Shcheglov 1e744f3dc2 Skip dev_compiler/gen while testing analyzer.
There are about 400 failures in them.

R=brianwilkerson@google.com, jmesserly@google.com
BUG=

Review URL: https://codereview.chromium.org/2358393003 .
2016-09-22 10:19:03 -07:00
Konstantin Shcheglov 5703f5adb1 Replace using reprecated 'package:analyzer/src/generated/error.dart'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364643002 .
2016-09-22 10:10:53 -07:00
Konstantin Shcheglov 163931ffdd Fix couple hints.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2362753002 .
2016-09-22 09:59:40 -07:00
Stephen Adams 3291ecfbc9 Add another test for initializing dispatchPropertyName that runs outside the browser
R=johnniwinther@google.com

BUG=

Review URL: https://codereview.chromium.org/2359023002 .
2016-09-22 09:45:19 -07:00
William Hesse 8dc3811050 Check in runtime/observatory/.packages
We won't remove it from the .gitignore file until we remove the
build steps that overwrite it.

BUG=https://github.com/dart-lang/sdk/issues/27412

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2359213002 .
2016-09-22 18:38:20 +02:00
William Hesse 92cd3e10f5 Fix test.py and tests to use an explicit --packages flag.
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2361813003 .
2016-09-22 17:51:09 +02:00
Johnni Winther 7a570f1b80 Roll kernel to latest and add baseline test.
The added visitor_test tests that the IR generated by the KernelVisitor
in dart2js matches the spec-mode IR.

R=asgerf@google.com, het@google.com

Review URL: https://codereview.chromium.org/2360603002 .
2016-09-22 10:16:11 +02:00
Zachary Anderson 94c96ac42c Added a target for a host version of the dart executable.
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2351743004 .
2016-09-21 19:05:06 -07:00