This includes the single commit:
```
4d8ecbd409d773fec47da33b7e6c8db0b51487fd Don't precompile on pub get/upgrade by default (#2277)
```
Change-Id: I1e72498487858cfc61f3af03e2eeb3397499d246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128070
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
It's pretty bare bones right now, but it helps automate some of the
steps.
Change-Id: I64280751870f1cb0d34ac464879c9c0edfc75d1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128280
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
The CFE recently changed the name of the top-level deferred load library method
from `__loadLibrary` to `_#loadLibrary` (see #39682)
We were properly escaping this name when generating the method itself, but we
didn't properly escape the name when creating tearoff closures derived from it.
This is why the issue was not detected earlier.
Change-Id: Ic1487a10f521a86a3466608b1825a2b632a191be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128260
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
It does not look that these are used anymore.
Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Clients can opt-in by passing "outline: true" in initializationOptions.
Fix outline name
Change-Id: I3a302178c685b49afe50370aef8360105b9676fc
Add test that outline comes through after change
Change-Id: If36344d485ea11c4b25d57e1e1fb43b575e8188f
Initial work on supplying Outline data over LSP
Change-Id: I74670b5c43a41af49195712bcc4be8e120e5b4ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128141
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: I018ddd6add8b8ff447019cc61bff579104084f00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128072
Commit-Queue: Victor Agnez Lima <victoragnez@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Note that when generating unstripped ELF snapshots with --obfuscate,
this means DWARF sections in the resulting snapshot will leak
otherwise obfuscated information. To avoid this, use both --strip
to strip the generated snapshot and --save-debugging-info=<...> to
save the unobfuscated DWARF information to a separate file.
Fixes https://github.com/dart-lang/sdk/issues/35563.
Change-Id: I8795e2a5623ad5fc5362257007f677e622a7700b
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-precomp-mac-release-simarm_x64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127166
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.
Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This will be used by the new approval workflow to mark a builder
as succeeded or failed (green or red) on the build console, depending
on approvals.
Change-Id: I47bddb1f964d5f5b7c06923660f86f6eb7a5e247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125667
Reviewed-by: Jonas Termansen <sortie@google.com>
This reverts commit 84a4bbcabc.
Reason for revert: Another try to land, to get more logging data.
Original change's description:
> Revert "Reland "[infra] Add failing test to test CI systems and approvals workflow""
>
> This reverts commit c716068538.
>
> Reason for revert: Trying again to diagnose failure to copy approvals.
>
> Original change's description:
> > Reland "[infra] Add failing test to test CI systems and approvals workflow"
> >
> > This reverts commit 25def20f5d.
> >
> > Reason for revert: Retrying, now that we are copying CQ approvals for all commits in the blamelist of a builder.
> >
> > Original change's description:
> > > Revert "[infra] Add failing test to test CI systems and approvals workflow"
> > >
> > > This reverts commit e578eeb235.
> > >
> > > Reason for revert: The reverted commit is a test of the new approvals UI for tryjobs and the CI. It includes an intentionally failing test, that we now remove again.
> > >
> > > Original change's description:
> > > > [infra] Add failing test to test CI systems and approvals workflow
> > > >
> > > > The failing test lib_2/collection/failing_list_test.dart is added,
> > > > which imports dart:io. So it will be a compile-time failure on
> > > > some dart2js platforms, and a run-time failure on dart:io.
> > > >
> > > > This commit is just to test the UI and backend for test failure
> > > > approvals on tryjobs and on CI results. It will be reverted after
> > > > the CI builders have run on it.
> > > >
> > > > Change-Id: Icc3d11e72511cb0dbd9a62cb4fa80e754c203c8c
> > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127883
> > > > Reviewed-by: Jonas Termansen <sortie@google.com>
> > >
> > > TBR=whesse@google.com,sortie@google.com
> > >
> > > Change-Id: I32b900e25dc562ac88f5cb496cdbca726fc70445
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127885
> > > Reviewed-by: William Hesse <whesse@google.com>
> >
> > TBR=whesse@google.com,sortie@google.com
> >
> > Change-Id: I64e528131c779c8d20c007ff715b57b599cd3f07
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127886
> > Reviewed-by: William Hesse <whesse@google.com>
> > Reviewed-by: Jonas Termansen <sortie@google.com>
>
> TBR=whesse@google.com,sortie@google.com,athom@google.com
>
> Change-Id: Icf68fd813d5f8f98d5ebf40c34e35811e8fffaf5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127892
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,sortie@google.com,athom@google.com
Change-Id: Ic63f74bf660e71e5e1853a391013368ce640bbc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127895
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
The flag can be used when creating AOT snapshots. The resulting file can be
used with package:vm/dwarf/convert.dart to convert DWARF-based stack traces
to stack traces with function, file, and line number information.
Currently the saved file will be an ELF file with DWARF debugging information,
but this is subject to change in the future. To avoid being affected by any
changes in format, read the DWARF information from the file using
Dwarf.fromFile() in package:vm/dwarf/dwarf.dart.
Also adds --dwarf-stack-traces to the VM global flag list, so its value at
compilation will be read out of snapshots by the precompiled runtime.
Fixes https://github.com/dart-lang/sdk/issues/39512, which was due to
a missing compiler::target:: prefix for Instructions::HeaderSize() in
BlobImageWriter::WriteText().
Exposes the information suggested in
https://github.com/dart-lang/sdk/issues/39490 so that package:vm/dwarf
can appropriately convert absolute PC addresses to the correct virtual
address for a given DWARF line number program.
Bug: https://github.com/dart-lang/sdk/issues/35851
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-precomp-mac-release-simarm_x64-try,vm-kernel-precomp-win-release-x64-try
Change-Id: I80d900fd9e5f1e2399ad3f2fd25c85131a7ea43c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121857
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This test was moved without updating its import. Convert the test
to a static error test (multitests can't have relative imports).
Change-Id: I075bf2f7d39f0958b8c625922c406cd5a7325836
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128068
Reviewed-by: Jonas Termansen <sortie@google.com>
Samples for managing native memory without finalizers.
Design: go/dart-ffi-resource-lifetime
Related issue: https://github.com/dart-lang/sdk/issues/35770
Change-Id: I2d0ac1acb65a78db9f57aea3dd5f25b4948ef6d6
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123662
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
This involved replacing PathMapper with the wrapper, PreviewPathMapper,
and MigrationInfo, with the wrapper, PreviewMigrationInfo.
Change-Id: Ie590c298bfa8c64c4765748b42ce3c9dc0dec3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
The RTI need computation is primarily focused on classes (as opposed to
types), so it's a poor choice for asserting that a type variable is
needed _in a type term_.
Change-Id: I593105cc092529ef6ac2dfc87f6d8d99ccd4ffb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128007
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Change-Id: Idbcc965a27e9ffeedf5e0a1068b019de4193070f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127745
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
